Found a bug while playing Ogre Encampment: click the Chest before clicking past the
intro screen and the game throws an error, when `updateSpellPalette` tries to access
call `spell.getSource()` but `spell` is undefined. This check keeps the same behavior
but handles the error.
Placing teachers and students in unknown districts and schools if we
have geoip countries and states/regions.
Placing teachers/students in unknown schools if there are 10+ students.
Attempting to use a react-component-like system, where the Surface simply emits everything that
happens through the shared GameUIState, and the parent (in this case the ThangsTabView, but theoretically
anything that uses the surface) handles the events manually, to enforce desired behavior for that particular
context.
It's nice that all the event handling is centralized, but it's still a bit of a mess, and not thoroughly
stateful. But it's a start. This is in preparation for allowing multi-thang selection and manipulation
in the level editor.
Update classroom and gameplay Ux to surface practice levels as 3a, 3b,
etc.
Update next level logic to leverage practice levels based on per level
completion playtime thresholds.
Patrol buster and patrol buster A are live for testing.
Fix a few classroom Ux progress hover bubble info bugs.
Closes#3767
* Initial pass adding new game-dev level type.
* Fix a failing test with updated LevelSystem required properties
* Bring back normal Angel worker timeout times
* Fix another failing LevelSystem test since removing propertyDocumentation
* Switch from auth.loginUser to User.loginPasswordUser with Promise
* Remove a cascade of unused views that were using auth.loginUser: StudentLogInModal, StudentSignupModal, HourOfCodeView
* Also remove auth.createUser
Was only happening when HeroPlaceholder had HasPet component.
Presumably because the collection was loaded by HasPet, but the thang node
for the inventory node needed to populate its autocomplete array.
This was a race condition where the view would trigger a render
before courses loaded, and the template required them when it had
some of its other resources.
Use selected hero in Course mode play
Show selected hero on Courses (in progress)
Add hero select modal
Use short names, only show warriors
Use box-shadow instead of borders
Add tests for HeroSelectModal
Refactor modal opening test
Address code review feedback
* Do not cache campaign
* Instead have an on leave message if there are unsaved changes
* Propagate campaignIndex values to campaign and levels so that they signal a change in order
The save modal seems to have a lot of issues with identifying what models have
changed. I tried using different methods, but none were consistent. Moving on
to other bugs.
On Windows/Chrome, the first click of the g+ button shows a popup
blocked warning, because the action is deferred while loading the
gplus library. Have the modals load the library first, and enable the
buttons when they're ready.
Hide TeachersContactModal after sending message
Fix GET /db/level/:handle/session, more extensively test
Fix EnrollmentView number of students input to stop losing focus on input
Fix EnrollmentsView syntax
Fix ActivateLicensesModal "Get Enrollments" button when already in the enrollments page
Update EnrollmentsView with new credit numbers when ActivateLicensesModal closes
Hide search box in TeacherClassView "Enrollment Status" tab
Tweak EnrollmentsView styling
Fix EnrollmentsView tests
Fix AnalyticsView
Make EnrollmentsView more explicitly handle undefined and empty array prepaid groups
Remove log
CoursesView handles JoinClassModal cancel
Re-enable EditStudentModal set password button when the form changes
Fix course instance tests, next level endpoint bug
Fix EditStudentModal tests
Fix link to /teachers/classes (fixes bugquest#20)
Fix edit button color/icon (bugquest#23)
Fix bugquest#34
Fix password input width (bugquest#33)
Center new pasword text
Fix teacher password reset endpoint (bugquest#4)
Refactor+use NewHomeView logic for user page button (Fixes bugquest#2)
Refactor teacher-password-reset endpoint
This makes it much easier to prevent collisions with other logic when PUTing new User attributes.
Add regression test for converting to teacher account
Fix email verified links, require login (fix bugquest#16)
Fix me having stale emailVerified value (Fixes bugquest#40)
Don't show JoinClassModal to students
Add paragraph to JoinClassModal (fixes bugquest#14)
Update change-password label text (fixes bugquest#30)
Fix prompting for login on Account Settings page (bugquest #10)
Show validation errors for teacher password reset (bugquest#36)
Show yellow progress dot in My Classes if anyone has started (bugquest#55)
Remove confusing text (bugquest#100)
* Refactor several related endpoints and views
* Redesign EnrollmentView, add TeacherContactModal
* Add "Enrollment Status" tab to TeacherClassView
* Delete PurchaseCoursesView and related files
* Style-flatten RemoveStudentModal
* Fix error handling in ActivateLicensesModal
* TeacherCoursesView loads faster by only loading course campaigns, and not load prepaids
This adds the ability to verify email addresses of a user, so we know they have access to the email address on their account.
Until a user has verified their email address, any teacher of a class they're in can reset their password for them via the Teacher Dashboard. When a user's email address is verified, a teacher may trigger a password recovery email to be sent to the student.
Verification links are valid forever, until the user changes the email address they have on file. They are created using a timestamp, with a sha256 of timestamp+salt+userID+email. Currently the hash value is rather long, could be shorter.
Squashed commit messages:
Add server endpoints for verifying email address
Add server endpoints for verifying email address (pt 2)
Add Server+Client endpoint for sending verification email
Add client view for verification links
Add Edit Student Modal for resetting passwords
Add specs for EditStudentModal
Tweak method name in EditStudentModal
Add edit student button to TeacherClassView
Fix up frontend for teacher password resetting
Add middleware for teacher password resetting
Improve button UX in EditStudentModal
Add JoinClassModal
Add welcome emails, use broad name
Use email without domain as fallback instead of full email
Fetch user on edit student modal open
Don't allow password reset if student email is verified
Set role to student on user signup with classCode
Tweak interface for joinClassModal
Add button to request verification email for yourself
Fix verify email template ID
Move text to en.coffee
Minor tweaks
Fix code review comments
Fix some tests, disable a broken one
Fix misc tests
Fix more tests
Refactor recovery email sending to auth
Fix overbroad sass
Add options to refactored recovery email function
Rename getByCode to fetchByCode
Fix error message
Fix up error handling in users middleware
Use .get instead of .toObject
Use findById
Fix more code review comments
Disable still-broken test
This updates TeacherClassView and ActivateLicensesModal to use the
new state-based rendering system, making it much snappier and less clunky
feeling, and improving data consistency.
Features also included in this:
- Hover details for progress dots in TeacherClassView
- ActivateLicensesModal has an "All Students" option and better handling
when you switch classrooms in the dropdown
- Unenrolled/Unassigned students are shown separately in Course Progress and
can be enrolled/assigned from there.
Add Back to Classes button on demo-request submitted view
Delete temporary patch file
Show unenrolled students separately in Course Progress (incomplete)
Migrate TeacherClassView to use orchestrator-style events, add unassigned students section, replace bootstrap tabs with state-based tabs
Convert missed instance variables to be in @state
Fix merge errors
(in progress) Convert a bunch of stuff to use state and events (removing student needs fixing)
Fix up modal interactions, some bugs
Switch state to be a Model, sync up course dropdowns
Convert student sorting to use state model
Add hover tooltips to TeacherClassView Students tab
Don't keep tooltip open when you mouse into it
Add dateFirstCompleted and Course Progress tooltips
Course Overview progress tooltips
Refactor ActivateLicensesModal
Refactors:
Uses state object for view state
Passes back the updated users in 'redeem-users' event instead of modifying given collection
Features:
Add 'All Students' dropdown option
Don't forget checked students if you change classroom from dropdown,
but only enroll the ones visible when you click "Enroll (n) Students"
Separate enrolled students; improve style
Rearrange error text
Disable enroll-students button when none are selected
Remove console.logs
Move style-flat variables to another file
This prevents .style-flat from being copied in multiple times to the resulting CSS.
Show Unarchive button when on the page for an archived class
Move text to en.coffee
Only sort students on first classroom sync
Fix merge error
Handle sessions missing completion date in view logic instead of migration script
Listen to classroom sync more than once in case it gets unarchived
TeacherClassView loaded course instances by owner rather than by classroom,
so the student would be removed from course instances in unrelated
but commonly owned classrooms.
Fix typo
Fix race condition with loading next level
Return an empty object for next level instead of an error;
Supermodel has a race condition when some of the models fail to load,
when we override an error response as "success".
Fix next level spec
Remove comment per Scott's request
* Updates spade.js vendor file, adds a sublime-project for developers to use
* Moves server logic away from handlers
* Moves session update logic to middleware, sets up server schema to autorender IDs as ObjectIDs
* Modernizes the supermodel loading scheme and switches from constructor to initalize
* Tweak wording, options
* Instead of storing changes in local storage, warn when users may lose changes by navigating away
* Fix CreateTeacherAccountView so that if you connect to an existing account, the redirect is triggered
* Fix users.coffee weird race condition
Partially fix ActivateLicensesModal.spec
[IN PROGRESS] Don't display deleted users
Move userID to classroom.deletedMembers on user delete (not retroactive)
Fix PDF links for course guides, remove old PDFs from repo
Remove deprecated SalesView
Remove underline for not-yet-linked student names
Only show class select when there's more than one
Ignore case when sorting student names
Use student.broadName instead of name for display and sorting
Fix initial load not showing progress after joining a course (hacky)
Fix text entry for enrollment number input
Fix enrollment statistics
Fix enrollment stats completely (and add back in per-class unenrolled count)
Add deletedMembers to classroom schema
More fixes to enrollment stats (don't count nonmember prepaids)
Don't use 0 as implicit false for openSpots
Update suggested number of credit to buy automatically
Fix classroom edit form ignoring cleared values
Add alert text when more users selected than enrollments available
Alert user when trying to assign course to unenrolled students
Alert user when assigning course to nobody
Add some tests for TeacherClassView bulk assign alerts
Fix TeacherClassView tests failing without demos
Use model/collection.fakeRequests :D
Remove unused comment
Fix handling of improperly sorted deleted users on clientside
Add test for moving deleted users to deletedMembers
Add script for moving all deleted classroom members to classroom.deletedMembers
Completely rewrite tallying up enrollment statistics
Fix some tests to not be dependent on logged-in user
Address PR comments
Fix default number of enrollments to buy
Fix i18n for not enough enrollments
Use custom error message for classroom name length
As JavaScript is the only language supported by the beautifier, and [CodeCombat is in the process of converting things to while (true)](https://github.com/codecombat/codecombat/issues/3510#issuecomment-201965310), I guess adding this quick hack to the view's code should suffice for now. Hopefully, the non-standard `loop` construct will be removed from other languages before they receive beautifier support.
If this doesn't seem good, I can move this hack to `aether.beautify`, where it is possible to perform this substitution in a language-aware way (i.e. inside Aether's JavaScript implementation's [`beautify` method](418ccf2414/src/languages/javascript.coffee (L137))). Seeing as the `loop` construct is specific to CodeCombat, I'm not sure if that would be a good idea. Passing an options object with a flag to support the `loop` construct seems a bit overkill.
Let me know what works best for you.
This is due to "flying-focus" taking up space at the bottom of the page. This solution is a bandaid. Ideally we have view-swapping logic that contains this type of thing and we just swap out views using one function.
