mirror of
https://github.com/codeninjasllc/codecombat.git
synced 2025-03-31 07:12:49 -04:00
Fix code review feedback
Fix code review feedback (2) Fix code review feedback (3)
This commit is contained in:
parent
66f99dd834
commit
7c1059bffa
4 changed files with 4 additions and 39 deletions
app
locale
templates/play/level/tome
views/play/level/tome
|
@ -213,32 +213,6 @@
|
|||
self: "self"
|
||||
hero: "hero"
|
||||
this: "this"
|
||||
Date: "Date" # Globals
|
||||
Vector: "Vector"
|
||||
Array: "Array"
|
||||
Function: "Function"
|
||||
Math: "Math"
|
||||
Number: "Number"
|
||||
Object: "Object"
|
||||
RegExp: "RegExp"
|
||||
String: "String"
|
||||
isFinite: "isFinite" # Built-ins
|
||||
isNaN: "isNaN"
|
||||
parseFloat: "parseFloat"
|
||||
parseInt: "parseInt"
|
||||
decodeURI: "decodeURI"
|
||||
decodeURIComponent: "decodeURIComponent"
|
||||
encodeURI: "encodeURI"
|
||||
encodeURIComponent: "encodeURIComponent"
|
||||
escape: "escape"
|
||||
unescape: "unescape"
|
||||
Infinity: "Infinity"
|
||||
NaN: "NaN"
|
||||
undefined: "undefined"
|
||||
null: "null"
|
||||
Boolean: "Boolean"
|
||||
Error: "Error"
|
||||
arguments: "arguments"
|
||||
|
||||
share_progress_modal:
|
||||
blurb: "You’re making great progress! Tell your parent how much you've learned with CodeCombat."
|
||||
|
|
|
@ -1,9 +1,10 @@
|
|||
h4
|
||||
span.prop-name= doc.shortName
|
||||
| -
|
||||
code.prop-type(data-i18n='skill_docs.'+(doc.type == 'function' && doc.owner == 'this' ? 'method' : doc.type))
|
||||
- var skillType = (doc.type == 'function' && doc.owner == 'this' ? 'method' : doc.type)
|
||||
code.prop-type(data-i18n='skill_docs.' + skillType)
|
||||
// In case there's no translation in en.coffee because we missed one
|
||||
= (doc.type == 'function' && doc.owner == 'this') ? 'method' : doc.type
|
||||
= skillType
|
||||
if doc.type != 'function'
|
||||
| (
|
||||
if writable
|
||||
|
|
|
@ -3,12 +3,6 @@ LevelComponent = require 'models/LevelComponent'
|
|||
template = require 'templates/play/level/tome/spell_translation'
|
||||
Range = ace.require('ace/range').Range
|
||||
TokenIterator = ace.require('ace/token_iterator').TokenIterator
|
||||
serializedClasses =
|
||||
Thang: require 'lib/world/thang'
|
||||
Vector: require 'lib/world/vector'
|
||||
Rectangle: require 'lib/world/rectangle'
|
||||
Ellipse: require 'lib/world/ellipse'
|
||||
LineSegment: require 'lib/world/line_segment'
|
||||
utils = require 'core/utils'
|
||||
|
||||
module.exports = class SpellTranslationView extends CocoView
|
||||
|
@ -22,11 +16,8 @@ module.exports = class SpellTranslationView extends CocoView
|
|||
constructor: (options) ->
|
||||
super options
|
||||
@ace = options.ace
|
||||
@thang = options.thang
|
||||
@spell = options.spell
|
||||
@supermodel = options.supermodel
|
||||
|
||||
|
||||
levelComponents = @supermodel.getModels LevelComponent
|
||||
@componentTranslations = levelComponents.reduce((acc, lc) ->
|
||||
for doc in (lc.get('propertyDocumentation') ? [])
|
||||
|
|
|
@ -642,7 +642,7 @@ module.exports = class SpellView extends CocoView
|
|||
@$el.append @debugView.render().$el.hide()
|
||||
|
||||
createTranslationView: ->
|
||||
@translationView = new SpellTranslationView { @ace, @thang, @spell, @supermodel }
|
||||
@translationView = new SpellTranslationView { @ace, @supermodel }
|
||||
@$el.append @translationView.render().$el.hide()
|
||||
|
||||
createToolbarView: ->
|
||||
|
@ -668,7 +668,6 @@ module.exports = class SpellView extends CocoView
|
|||
@createDebugView() unless @debugView
|
||||
@debugView?.thang = @thang
|
||||
@createTranslationView() unless @translationView
|
||||
@translationView?.thang = @thang
|
||||
@toolbarView?.toggleFlow false
|
||||
@updateAether false, false
|
||||
# @addZatannaSnippets()
|
||||
|
|
Loading…
Add table
Reference in a new issue