Karishma Chadha
5b2667556c
Comment cleanup
2018-11-14 13:15:36 -05:00
Karishma Chadha
dccb41e3c4
Comment and test cleanup.
2018-11-14 10:42:52 -05:00
DD
679ddf9fb7
Comment fixes and instantiate textImageElement only as necessary
2018-11-13 15:31:00 -05:00
DD
0b72608624
Remove swp file
2018-11-13 15:09:47 -05:00
Karishma Chadha
14bee14d8c
Update extensions to load when deserializing monitors. This is necessary when the monitor is the only part of the project that uses the extension. Update extension monitor color category.
2018-11-09 23:45:49 -05:00
Karishma Chadha
df24ca7b46
Refactor sb3 monitor deserialization. Create monitor blocks with the relevant info if they don't exist.
2018-11-09 23:45:49 -05:00
Karishma Chadha
1b9b3ac909
Revert changes that were made to leverage the monitor blocks getting created when the toolbox is loaded. This approach does not work when viewing the project detached from scratch-blocks (e.g. player mode).
2018-11-09 23:45:48 -05:00
Karishma Chadha
d690c76a34
Update sb2 deserialization of monitors.
2018-11-09 23:45:48 -05:00
Karishma Chadha
1a4f0a75f2
Serialize and deserialize monitors. Obtain monitor block information from runtime. Fix issue where stage monitors weren't getting loaded correctly.
2018-11-09 23:45:48 -05:00
Karishma Chadha
cfa71723eb
Ignore video sensing monitor and import music tempo monitor unless it is hidden. Load extensions for visible monitors. Add tests for new functionality.
2018-11-09 00:09:54 -05:00
Karishma Chadha
fe186913ac
Merge pull request #1742 from kchadha/multi-monitors
...
Multi monitors
2018-11-08 14:44:22 -05:00
Karishma Chadha
87244b4110
Normalize capitalization of sensing_current block fields during sb2 import and during monitor id generation. Update monitors integration test to include sensing_current block monitors.
2018-11-08 14:11:30 -05:00
Ray Schamp
4f5aba4fe6
Merge pull request #1727 from paulkaplan/add-ext-on-share
...
Add unloaded extensions on block sharing
2018-11-08 10:15:58 +00:00
Karishma Chadha
5db3db3a92
monitor id getter should use block fields instead of a list of strings
2018-11-08 01:33:26 -05:00
Karishma Chadha
7d1226458f
Fix import of current day of week block from sb2.
2018-11-08 00:37:49 -05:00
Karishma Chadha
0e7eae98d5
Separate out monitors for blocks reporter blocks that have parameters.
2018-11-08 00:37:28 -05:00
Karishma Chadha
8aa0fa11aa
Merge pull request #1649 from mzgoddard/get-attribute-stage-alt-name
...
Get attribute stage alt name
2018-11-07 17:47:44 -05:00
Paul Kaplan
ce94144051
Fixup from comments
2018-11-07 10:11:16 -05:00
DD
2bd468950f
Why do our lint rules require such weird formatting
2018-11-06 16:54:41 -05:00
DD
e538800293
Merge branch 'pull915' into textLayer
2018-11-06 10:39:43 -05:00
DD
876139847a
Merge branch 'develop' into pull915
2018-11-06 10:39:27 -05:00
DD
88b6bdd06c
Get text assets from zip
2018-11-05 18:07:56 -05:00
DD
86149325b1
Try to make loadCostume more readable, and revert deserializeCostume to changing the costume object directly
2018-11-05 17:11:07 -05:00
Paul Kaplan
bc1da9fa44
Move extension ID parsing into a helper and add test
2018-11-05 12:57:09 -05:00
Karishma Chadha
d64322a110
Merge pull request #1719 from rschamp/hotfix/sprite-upload-from-image
...
Handle images uploaded as sprites
2018-11-01 18:18:52 -04:00
Ray Schamp
3d06f0e633
Handle images uploaded as sprites
...
The sprite upload code in GUI serializes asset data, flattening it. We need to rehydrate the asset.
2018-11-01 18:28:54 +00:00
Michael "Z" Goddard
bca01a9ed2
rename Stage to _stage_ when its the OBJECT input for getAttributeOf
2018-11-01 12:33:56 -04:00
Valerie R Young
26c928d10b
Handle unknown opcode in input
2018-10-31 17:40:08 -04:00
Karishma Chadha
1df6743a5f
Refactor cloud data manager to break out cloud data limit check vs. limit update.
2018-10-31 13:40:05 -04:00
Karishma Chadha
848deaff30
Track whether a project has cloud data and enforce a cloud data limit on projects being loaded into the runtime.
2018-10-30 18:53:57 -04:00
Ray Schamp
de86eb3f19
Merge pull request #1691 from rschamp/storage-no-cache
...
Store asset objects on costumes and sounds
2018-10-25 10:15:47 +01:00
Katie Broida
18c83dcc67
Prevent non-core extensions from adding monitors ( #1688 )
2018-10-24 16:43:01 -04:00
Ray Schamp
902aee48ee
Merge branch 'develop' of https://github.com/LLK/scratch-vm into storage-no-cache
...
# Conflicts:
# package-lock.json
2018-10-24 12:09:06 +01:00
Ray Schamp
b47912dce4
Store asset objects on costumes and sounds
...
Stop using storage for in-memory storage, and keep these on the vm objects. Towards https://github.com/LLK/scratch-vm/issues/1577
2018-10-23 11:10:50 +01:00
DD
91e2f3a935
Revert 1643 Confirm extension in use in sb2 serialization
2018-10-18 11:06:13 -04:00
Eric Rosenbaum
891f696570
Save and load the language setting for Text to Speech ( #1670 )
...
* Use scratch locales internally, with adapter for polly
* Save and load text2pseech language
* Only localize default input to “speak” if in a supported language
2018-10-17 17:34:12 -04:00
Katie Broida
899ce56214
Confirm extension in use in sb2 serialization ( #1643 )
...
Add a check when serializing sb2 projects to see whether an extension is actually in use in a block or a visible monitor.
2018-10-17 10:49:08 -04:00
Andrew Sliwinski
7a28d5e41d
Merge pull request #1586 from mzgoddard/variable-id-type
...
conflict workaround for variables and lists of the same name
2018-10-01 18:27:59 -04:00
Florrie
744b01174b
Add support for "midiInstrument:" block ( #1329 )
...
* Add midiInstrument: block
* Don't show midiInstrument block in palette
* Lint
* More lint
2018-09-25 17:33:09 -04:00
Karishma Chadha
0ad59d3859
Merge pull request #1563 from mzgoddard/get-param-condition-input
...
Get param condition input
2018-09-18 15:29:43 -04:00
Michael "Z" Goddard
a5151a0446
generate sb2 variable ids with variable type
...
Make variables and lists with the same name have unique IDs so they
don't clobber the other in the variables map on the target.
2018-09-14 16:53:48 -04:00
Michael "Z" Goddard
ea55b3ed55
add inputOp to every input arg in the sb2 specmap
...
Add missing meta information in the inputOp value for some arguments.
`boolean` and `substack`, the new inputOp values, are not considered to
be shadowed values.
2018-09-13 12:42:54 -04:00
Michael "Z" Goddard
34b77d2024
ensure argument_reporter_boolean is used in CONDITION input
2018-09-07 17:26:24 -04:00
Michael "Z" Goddard
db7b356825
rename stage monitors along with stage
...
Rename Stage object and monitors together then use the set name to name
the sprite.
2018-09-07 14:36:44 -04:00
Michael "Z" Goddard
609350a7fc
pass parseState info in sb2 deserializer
...
Pass state information beyond the current block.
2018-09-07 14:00:23 -04:00
Ray Schamp
9c556219ce
Merge pull request #1528 from kchadha/fix-comment-import
...
Fix Comment import/save/load issue
2018-08-28 16:04:53 -04:00
Karishma Chadha
2c24ef37a0
Fix issue where block comments converted to workspace comments import correctly when there are no scripts on the workspace.
2018-08-24 14:29:10 -04:00
Karishma Chadha
0532f9a80a
Fix issue where a c-block that contained only blocks with unknown opcodes, was causing an import error.
2018-08-23 18:20:45 -04:00
Karishma Chadha
5e1dd8a7cf
Fix issue with importing projects from 2.0 where block comments were converted to workspace comments and the corresponding block was deleted.
2018-08-22 18:41:47 -04:00
Karishma Chadha
6f9367a8e2
Merge pull request #1468 from gnarf/serialization-util
...
export deserializeBlocks method
2018-08-20 19:58:19 -04:00
Corey Frang
ae219e361a
Add comments for deserialization and add tests
2018-08-20 13:25:24 -04:00
Eric Rosenbaum
825035f503
Fix importing WeDo 2.0 blocks from SB2 ( #1487 )
...
* Fix wedo2 import from sb2
* Hide wedo play note block
2018-08-16 14:24:19 -04:00
Corey Frang
896e62d2c4
Also export serializeBlocks for round-tripping
2018-08-15 17:06:30 -04:00
Corey Frang
df9dbd112a
Make importing with deserialized stuff okay
2018-08-15 17:04:49 -04:00
Corey Frang
fe46a81cc9
export deserializeBlocks method
2018-08-14 11:17:47 -04:00
Ray Schamp
4b5cf6505a
Merge pull request #1398 from paulkaplan/publish-docs
...
Publish jsdoc to gh-pages
2018-08-08 16:46:48 -04:00
Paul Kaplan
98e45ecdfe
Import current block menu as field not input
2018-08-02 13:45:00 -04:00
Paul Kaplan
138d7136af
Fix various jsdoc issues preventing the docs from building
2018-07-31 11:22:42 -04:00
Karishma Chadha
53ccb8d709
Don't serialize layerOrder when exporting a sprite.
2018-07-24 16:11:18 -04:00
Karishma Chadha
812e7a3772
Preserve sprite layer order information across saving and loading an sb3.
2018-07-24 11:00:48 -04:00
Karishma Chadha
b3ee2c439d
Remove layerOrder property, sprites are rendered in the order the targets are listed in in the .sb2 file.
2018-07-23 15:48:27 -04:00
Karishma Chadha
2508dc46ca
Order sprites in 2.0 projects based on the serailzied indexInLibrary property. Store original ordering (e.g. layer order of sprites on the stage) to use when installing targets.
2018-07-23 15:25:05 -04:00
Paul Kaplan
0e3413e6bd
Fix comment
2018-06-27 14:17:33 -04:00
Paul Kaplan
4967155285
Fix nits
2018-06-27 10:44:28 -04:00
Paul Kaplan
9f517bd483
Deal with comments attached to undefined blocks
...
Also fix an issue where you couldn't save/load projects that had multiple comments linked to a single block.
2018-06-26 16:41:10 -04:00
Paul Kaplan
e7e300caeb
Skip unknown opcode blocks while parsing
2018-06-26 15:58:43 -04:00
Connor Hudson
0bed25e01b
Merge develop into feature/extension-serialization
2018-06-26 08:56:42 -04:00
kchadha
d187517d85
Merge pull request #1256 from kchadha/sprite-save-load
...
Sprite save load
2018-06-25 11:21:01 -04:00
Corey Frang
4431b43e45
A few leftover loadSound that werent updated
2018-06-22 09:45:23 -04:00
Michael "Z" Goddard
c268bbae47
add decoded SoundPlayer's to a Sprite's SoundBank ( #1260 )
2018-06-21 17:23:33 -04:00
Connor Hudson
befcbec393
Create extensions list in serialize function
...
Removed runtime argument from serializeTarget call because it wasn't used
2018-06-21 15:01:00 -04:00
Connor Hudson
026dd96491
Modify serializeTarget function to take an extension set as an argument
...
This allows the serialize function to build a list of all extensions used
2018-06-21 15:00:17 -04:00
Connor Hudson
17679340f9
Return extension ids from serializeBlocks instead of modifying Set passed to it
2018-06-20 15:42:56 -04:00
Connor Hudson
15de2eaa68
Remove extension deserialization
2018-06-20 14:33:01 -04:00
Karishma Chadha
b40ac54fdd
Remove stray newline.
2018-06-20 13:37:31 -04:00
Karishma Chadha
b75a779540
Call fixUpVariableReferences in installTargets, before emitting the workspace update.
2018-06-20 12:12:33 -04:00
Karishma Chadha
9646e3d11e
Refactor and move variable reference fixup function into target.
2018-06-19 15:31:08 -04:00
Karishma Chadha
f2aacbc79c
Fix up variable references after deserializing a .sprite2 or .sprite3 to avoid conflicts with pre-existing variables.
2018-06-19 14:02:54 -04:00
Karishma Chadha
5cc48b6ef3
Provide global vars to sb2 import when deserializing a single sprite.
2018-06-19 08:52:22 -04:00
Karishma Chadha
86a8d93eb6
Sprite3 Export/Import.
2018-06-19 08:51:16 -04:00
Connor Hudson
aa16930e34
Add initial implementation of extension serialization/deserialization
2018-06-18 15:00:33 -04:00
Karishma Chadha
f3d49f75c8
Clean up comment serialization, add tests for new and old serialization (old is still valid, just more verbose).
2018-06-15 14:57:49 -04:00
Karishma Chadha
e2eadbf603
Comment save and load.
2018-06-14 14:11:20 -04:00
Florrie
24c6338302
Map costumeName -> costumenumbername [name]
...
...instead of mapping to a new obsolete/hidden block 'costumename'.
Thanks to @kchadha for helping with this!
2018-06-12 19:27:36 -03:00
Florrie
404834018b
Implement costume name block
2018-06-09 21:34:21 -03:00
Karishma Chadha
537dc9bcd5
Addressing PR comments.
2018-05-31 16:33:42 -04:00
Karishma Chadha
f079eb4bbd
Don't serialize x and y for sb2 comments so that they can be auto positioned.
2018-05-30 21:18:45 -04:00
Karishma Chadha
1401d54add
Parse SB2 comments and attach block comments to the blocks they belong to. Send comment xml on workspace update so they can be rendered.
2018-05-30 21:15:14 -04:00
kchadha
a85f641d25
Merge pull request #1148 from kchadha/stage-layering
...
Layer group ordering.
2018-05-25 09:10:05 -04:00
DD Liu
10aa6979ed
Multiply by bitmap resolution
2018-05-23 14:18:22 -04:00
DD Liu
85689201ed
Always give backdrops a certain rotation center
2018-05-23 14:06:23 -04:00
Karishma Chadha
64c8484066
Refactor so that layer group is optionally passed into createClone (and initDrawable) instead of isStage property getting stored on a sprite.
2018-05-18 10:11:59 -04:00
Karishma Chadha
67b114b9c9
Layer group ordering.
2018-05-15 22:22:44 -04:00
DD Liu
5c003641f9
Merge pull request #1126 from fsih/fixQuirksOnLoadCostume
...
Run quirks mode fixes on costumes loaded from sb2s
2018-05-10 13:42:48 -04:00
DD
aae1e083bc
Switched textEncoder to costumeAsset.encodeTextData, and pass in version as an argument instead of in costume
2018-05-09 15:48:49 -04:00
Paul Kaplan
f01558b74e
Address comments from @kchada review
2018-05-09 11:08:49 -04:00
Paul Kaplan
26cfbfe588
Fix stage checking
2018-05-08 17:15:54 -04:00
Paul Kaplan
4713f47fb7
Import monitors from sb2 files.
...
Paired with @kchadha on all of this.
2018-05-08 17:06:19 -04:00
DD
296af1a079
Run quirks mode fixes on costumes loaded from sb2s
2018-05-08 12:03:34 -04:00
Karishma Chadha
55352e88b1
Tests and cleanup of addSprite3 so that .sprite3 format does not need to be nested inside an extra {targets: ...}
2018-05-04 11:00:45 -04:00