scratchfoundation/scratch-vm
1
0
Fork 0
mirror of https://github.com/scratchfoundation/scratch-vm.git synced 2024-12-23 14:32:59 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Fix issue with importing projects from 2.0 where block comments were converted to workspace comments and the corresponding block was deleted.

Browse source
This commit is contained in:
Karishma Chadha 2018-08-22 18:41:47 -04:00
parent 5320dfb676
commit 5e1dd8a7cf
1 changed files with 17 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
src/serialization/sb2.js
View file

@ -183,6 +183,23 @@ const parseScripts = function (scripts, blocks, addBroadcastMsg, getVariableId,
blocks.createBlock(convertedBlocks[j]);
}
}
// scriptIndexForComment is now greater than the index of the 'last' block in the flattened block array.
// If there are any comments referring to this index or any indices after it, they are comments that
// were originally created as block comments, detached from the block, and then had the associated block deleted.
// These comments should be imported as workspace comments
// by making their blockIDs (which currently refer to non-existing blocks)
// null (See #1452).
const blockCommentIndicesToFix = Object.keys(comments).filter(k => k >= scriptIndexForComment);
for (let i = 0; i < blockCommentIndicesToFix.length; i++) {
const currCommentIndex = blockCommentIndicesToFix[i];
const currBlockComments = comments[currCommentIndex];
currBlockComments.forEach(c => {
if (typeof c.blockId === 'number') {
c.blockId = null;
}
});
}
};
/**