Jürg Lehni
cc7e60e51a
Revert db1ecdddd5
and fix issue properly this time.
...
Hopefully?
2015-09-23 12:44:00 -04:00
Jürg Lehni
20f950ac65
Implement #isFirst() / #isLast() tests on Segment and Curve.
2015-09-23 12:26:44 -04:00
Jürg Lehni
db1ecdddd5
Fix filtering of locations at ends of curves in addCurveLineIntersections()
...
Only occured when the line / curve had to be flipped.
2015-09-21 16:56:08 -04:00
Jürg Lehni
84bcc537e1
Simplify addCurveLineIntersections() and exclude end points.
2015-09-21 12:13:53 -04:00
Jürg Lehni
e36319b71a
Give PathItem#getIntersections() a way to filter found intersections right away.
...
And use it in #getCrossings()
2015-09-21 10:41:59 -04:00
Jürg Lehni
b5af47a7b1
Implement a better approach to calculate Path#clockwise...
...
...merging code with Path#area.
Closes #788
2015-09-18 21:41:54 +02:00
Jürg Lehni
10eafccd1a
Implement 0.75 * handle scaling in curve bounds checks.
2015-09-18 21:09:57 +02:00
Jürg Lehni
17dc5eb51a
Allow gettings of unstyled bounds on curves without paths.
2015-09-18 20:15:18 +02:00
Jürg Lehni
ae93652b56
Clean up getIntersection() methods.
...
Now that they filter the results on the fly.
2015-09-18 17:31:23 +02:00
Jürg Lehni
9c812335e5
Curve._filterIntersections() is now without a job.
2015-09-17 09:39:22 +02:00
Jürg Lehni
2750c34090
Improve the way intersections are sorted and merged.
...
Use a binary search to determine insertion index and compare with neighbours to eliminate doubles.
2015-09-17 01:03:13 +02:00
Jürg Lehni
30f1441c26
Various boolean code clean-ups.
2015-09-16 18:34:35 +02:00
Jürg Lehni
d0332f843f
Renamed Curve#reverse() and Segment#reverse() to #reversed()
...
Since they don't modify the object. Also introduce new Segment#reverse(), which does.
2015-09-16 18:16:48 +02:00
Jürg Lehni
e548391276
Use the zero-epsilon when checking beginnings and ends of curves for overlaps.
...
Relates to #786 and #777
2015-09-16 02:33:56 +02:00
Jürg Lehni
7aef20ae6b
Compare intersection points instead of curve time when deciding to merge.
...
Use same precision indepenent of curve length.
2015-09-14 15:18:44 +02:00
Jürg Lehni
e2d2c836e5
Some boolean code clean-up.
2015-09-13 14:19:56 +02:00
Jürg Lehni
ea2ff5ec28
Increase precision in Curve.getParameterOf()
...
Usually only requires 0-1 more iteration.
2015-09-13 13:45:20 +02:00
Jürg Lehni
d84a84c67f
Change the way winding contributions are propagated
...
The new approach preserves segment sequence.
Relates to #777
2015-09-13 13:06:01 +02:00
Jürg Lehni
19c9a0e722
Use the correct points on curve2 when checking intersections at beginnings and ends.
2015-09-13 11:52:17 +02:00
Jürg Lehni
d62caf6faa
Introduce CURVETIME_EPSILON, to be used when handling curve time parameters.
...
Relates to #777
2015-09-12 22:55:58 +02:00
Jürg Lehni
4f04dae20f
Use the correct GEOMETRIC_EPSILON when matching beginnings and ends of curve in Curve.getParameterOf()
...
Relates to #777
2015-09-12 22:26:16 +02:00
Jürg Lehni
a0730756c1
Use correct term for curve parameter renormalization.
2015-09-12 22:13:18 +02:00
Jürg Lehni
085cdd74a2
Use GEOMETRIC_EPSILON when comparing curve start / end points.
...
Relates to #777
2015-09-12 21:56:53 +02:00
Jürg Lehni
3da921a0b0
Improve CompoundPath#reduce() to properly reduce suppaths.
...
Relates to #779
2015-09-12 11:43:41 +02:00
Jürg Lehni
fb5f8c0115
Introduce GEOMETRIC_EPSILON, for isOrthogonal(), isCollinear() and overlap checks.
...
Relates to #777
2015-09-12 10:35:47 +02:00
Jürg Lehni
35f3ac87bf
Change checks for startConnected / endConnected to support compound-paths.
...
Closes #778
2015-09-12 10:12:17 +02:00
Jürg Lehni
86f404123e
Minor code tweaks.
2015-09-11 12:07:27 +02:00
Jürg Lehni
04452730dd
Simplify CurveLocation data structures.
...
Directly creating and linking intersections simplifies things a lot.
2015-09-09 17:17:49 +02:00
Jürg Lehni
abf70378fe
Some more code fixes.
...
One was breaking unit tests.
2015-09-09 08:15:43 +02:00
Jürg Lehni
70f8f1912f
Some code clean-up.
2015-09-09 08:06:59 +02:00
Jürg Lehni
332b09c534
More curve interesection optimizations.
...
Only evaluate points if locations are actually added.
2015-09-09 07:46:48 +02:00
Jürg Lehni
dae8bb630b
Avoid checking curves if completely out of control bounds.
...
This leads to a huge speed increase! Relates to #765
2015-09-09 07:34:28 +02:00
Jürg Lehni
1c1e19614e
Avoid matching connected start- and end points when self-intersecting curves.
...
Partial fix for #765 .
2015-09-09 07:28:08 +02:00
Jürg Lehni
3f53aa78ce
Do not access curve objects for geometry since they might be subdivided.
...
Partial fix for #765
2015-09-09 07:26:39 +02:00
Jürg Lehni
b96036fb03
Fix strange curve check.
...
Something went wrong in prior refactoring here. Also, no need to check curve beginnings and ends again, just handles.
2015-09-09 06:25:37 +02:00
Jürg Lehni
98d7703b5c
Finish implementing Curve#isStraight and #isLinear()
...
Closes #652
2015-09-06 18:02:15 +02:00
Jürg Lehni
31d9e1cd6e
Implement Curve#isLinear() to check for parametrical linearity.
...
Along with some unit tests for it.
2015-09-06 17:56:12 +02:00
Jürg Lehni
9d12a0a82c
Rename Curve#isLinear() to #isStraight()
...
Relates to #652
2015-09-06 17:35:27 +02:00
Jürg Lehni
9dab662a1f
Clean-up various Segment and Curve tests.
...
Moving functionality back to Path#toShape() since it was too specific, and missleading as part of the exposed Segment API.
2015-09-06 17:27:33 +02:00
Jürg Lehni
b52d343527
Use same notation for all injection scopes.
2015-09-06 16:48:23 +02:00
Jürg Lehni
cf813faa75
Remove all mention of points and square points as units.
...
And some other doc clean-ups.
2015-09-06 16:37:10 +02:00
Jürg Lehni
3d89cd71bd
Some clean-up work on documentation.
2015-09-06 15:54:11 +02:00
Jürg Lehni
66717868cd
Address failing #isLinear() tests.
2015-09-06 14:10:15 +02:00
Jürg Lehni
26e35322a4
Some reworking of code and comments.
2015-09-06 13:20:57 +02:00
Jürg Lehni
8b67d8a1dc
Remove #isStraight() in favor of #hasHandles() and implement #clearHandles()
...
Relates to #652
2015-09-06 12:47:35 +02:00
Jürg Lehni
3fa385ac7c
Fix typo in previous commit.
2015-09-05 09:56:37 +02:00
Jürg Lehni
af355dc82c
Fix false positives in Curve#isLinear() and Segment#isLinear().
2015-09-03 09:01:07 +02:00
Jürg Lehni
041c31a88a
Prevent variable leackage.
2015-09-02 15:54:14 +02:00
Jürg Lehni
b9a07ca538
Address code comments by @iconexperience in #762 .
2015-08-31 22:01:18 +02:00
Jürg Lehni
20222be5c6
Minor clean-up in fat-line code.
2015-08-30 19:59:13 +02:00
Jürg Lehni
bd61390f9d
improve break-off condition in curve interesection code.
...
To prevent arbitrary incorrect solutions occuring when tDiff is very close to zero.
Closes #762 .
2015-08-30 14:37:21 +02:00
Jürg Lehni
27aae8b261
Add support for values array and toString object format to Curve constructor.
2015-08-30 14:14:52 +02:00
Jürg Lehni
0cbce044aa
Define Curve#_serialize()
2015-08-28 16:18:28 +02:00
Jürg Lehni
d85b4f0c80
Fix issues with wrong sorting of CurveLocation in Curve.filterIntersections()
2015-08-26 16:56:28 +02:00
Jürg Lehni
815991d556
Some minor adjustments and fixes.
2015-08-26 11:43:39 +02:00
Jürg Lehni
2c4dcb96c2
Streamline addOverlap() code a bit.
2015-08-26 11:26:55 +02:00
Jürg Lehni
3946bcb04e
Remove unnecessary segments between two collinear curves in Path#reduce()
2015-08-24 12:49:33 +02:00
Jürg Lehni
75f669d839
Implement proper method to determine which segment to choose when encountering overlaps.
2015-08-24 04:36:49 +02:00
Jürg Lehni
85d21c84b8
Start implementing support for touching and overlapping shapes in boolean operations.
...
Relates to #449 , #450 , #648 , #719
2015-08-23 21:19:19 +02:00
Jürg Lehni
9bd399b5b8
Introduce Curve#isStraight() and use it in splitPath() and divide() to keep the result of splitting straight curves straight.
...
Do not use Curve#isLinear(), as that would include curves with collinear handles, and we don't want to set these straight.
2015-08-22 22:06:42 +02:00
Jürg Lehni
bddff95fe3
Remove workarounds in splitPath() thanks to improved precision of Numerical.solveCubic().
2015-08-22 14:24:31 +02:00
Jürg Lehni
716d21e369
Always use fat-line clipping since fallback doesn't behave the same way.
2015-08-21 16:39:41 +02:00
Jürg Lehni
0436b2749a
Fix some comments.
2015-08-19 17:28:41 +02:00
Jürg Lehni
84b202fd79
Expose and reuse Curve evaluation method names.
2015-08-19 17:26:52 +02:00
Jürg Lehni
9fe93d1434
Move Curve evaluate() method to private scope.
2015-08-19 17:19:42 +02:00
Jürg Lehni
da82116501
Rework handling of weighted and normalized curve tangents and normals.
...
Relates to #563
2015-08-19 17:15:41 +02:00
Jürg Lehni
59eec1f27b
Implement Curve#isLinear(), #isCollinear() & co without depending on the segments being part of a path.
2015-08-19 11:43:37 +02:00
Jürg Lehni
e476672748
Use better epsilon values in Numerical.solveQuadratic() and solveCubic()
...
To finally satisfy both #541 and #708 .
With this change in place, https://github.com/paperjs/boolean-test is also finally back to run with 0 errors. Woop!
2015-08-18 23:47:28 +02:00
Jürg Lehni
4ee68e5782
Various changes to #isCollinear(), #isOrthogonal(), #isArc()
...
- Rename #isArc() - > #isOrthogonalArc()
- Implement versions for Curve
- Write proper documentation
2015-08-17 14:33:48 +02:00
Jürg Lehni
f8314f927e
Various changes on #isLinear(), #hasHandles() & co
...
Relates to #652
- Implement #hasHandles() on Path, Segment and Curve
- Remove Path#isPolygon()
- Define #isLinear() consistently across Path, Segment and Curve.
- Introduce new Segment#isStraight()
2015-08-17 14:31:23 +02:00
Jürg Lehni
19bcd19b49
Implement path versioning for segment changes.
...
And use it to keep CurveLocation objects up to date. Closes #682
2015-06-16 19:36:22 +02:00
Jürg Lehni
c1485e7068
Use < instead of <= when comparing against TOLERANCE
2015-06-16 19:33:21 +02:00
Jürg Lehni
b541088c6f
A whole lot of documentation clean-up.
2015-06-16 17:50:37 +02:00
Jürg Lehni
e3f04478d9
Clean up Curve.getParameterOf() code.
2015-06-16 12:29:27 +02:00
Jürg Lehni
7749641e66
Handle out-of-bounds offsets/parameters correctly.
...
Closes #660
2015-04-04 17:05:39 +02:00
Jürg Lehni
22be259167
Deal with edge cases in Curve.solveCubic() where small cubics are very close to lines.
...
Also reduce Numerical.EPSILON again, as required by some rare edge cases.
Relates to #541 .
2015-01-10 22:05:42 +01:00
Jürg Lehni
1c758a415a
Switch to new and improved Line.getSignedDistance() in fat-line clipping code as well.
2015-01-05 16:20:33 +01:00
Jürg Lehni
1239eb55ec
Minor clean up in Curve.filterIntersections().
2015-01-04 17:47:41 +01:00
Jürg Lehni
afc14b9634
Reduce Numerical.TOLERANCE to 1e-6, and use the same value across the boolean code.
...
Yields very good results now, across all tests.
2015-01-04 15:54:50 +01:00
Jürg Lehni
3564dafa93
Do not keep iterating if the curve was reduced to a point.
2015-01-04 13:23:59 +01:00
Jürg Lehni
d33d65fcc2
Revert change in recursion threshold as the new code reaches the desired precision earlier.
2015-01-04 13:21:12 +01:00
hkrish
3781aedb22
Small but critical fix on getSignedDistance method
...
when the line is perfectly vertical, return the difference between x values depending on the side. The earlier "l1y" is a silly mistake.
2015-01-03 23:41:47 +01:00
Jürg Lehni
b6a4815d03
Remove Curve#isHorizontal() as its implementation and precision is specific to boolean operations.
2015-01-03 21:02:12 +01:00
Jürg Lehni
a854c55914
Split off code from Path.Clockwise() into Curve.getEdgeSum()
2015-01-03 01:46:22 +01:00
Jürg Lehni
538eac6dc7
Use smaller tolerances in winding code, to address edge cases.
...
Closes #559
2015-01-02 23:47:26 +01:00
Jürg Lehni
477527f8ec
Implement more intuitive version of clipConvexHull(), outlined in #570 by @iconexperience
...
Code further shortened using a sub-routine.
2015-01-02 22:36:04 +01:00
Jürg Lehni
232739fae9
Add comments to fat-line clipping code linking to issues #568 and #571 .
2015-01-02 22:34:09 +01:00
Jürg Lehni
4ed9ef54f2
Fix bug in Curve.filterIntersections() and clean up code a bit.
2015-01-02 21:19:18 +01:00
Jürg Lehni
b2261fd512
Introduce Curve.filterIntersections() and use it both in PathItems#getIntersections() and Curve#getIntersections()
2015-01-02 21:00:05 +01:00
Jürg Lehni
3302a7dff5
Increase recursion threshold to 4 when checking for fatline convergence.
2015-01-02 20:49:09 +01:00
Jürg Lehni
fbd026ea0d
Bring back code removed by @hkrish in commit 5fb75593c2
...
Relates to issue #570 , still required to figure out why it is still needed.
2015-01-02 20:02:45 +01:00
Jürg Lehni
e3e3d13fa5
Add comment regarding issue #565
2015-01-02 16:33:15 +01:00
Jürg Lehni
b75def3f3a
Implement optimal values in fat line clipping code for maximum recursion and curve time difference, as determined by @iconexperience.
...
Closes #565
2015-01-02 16:29:12 +01:00
Jürg Lehni
45c86a3035
Switch to suggested new implementation of Line.getSignedDistance() by @iconexperience
...
Closes #554
2015-01-02 16:17:19 +01:00
Jürg Lehni
318209e9e9
Replace compareNumbers() with equals() and improve numerical tolerance handling in test helpers.
2014-11-30 11:27:14 -08:00
Jürg Lehni
ebdc63fbfa
Use correct formula in Curve#getTangentAt() for end-points when there is no handle.
...
Closes #553 .
2014-11-08 17:16:22 -08:00
Jürg Lehni
e5714584ff
Fix return type of #getCurvatureAt() methods.
...
Closes #535 properly this time.
2014-10-15 12:02:21 +02:00
Jürg Lehni
b71e2c69d6
Fix documentation of Curve#getCurvatureAt(), as well as Path#getCurvatureAt() & co.
...
Closes #535
2014-10-14 13:52:57 +02:00
Jürg Lehni
6a11532322
Clean up and simplify code a bit further.
2014-09-28 11:49:46 +02:00
Jürg Lehni
7462fe0b70
Fix Curve.getParameterAt() for negative values of offset, and implement unit test.
...
Closes #524 .
2014-09-28 11:44:38 +02:00