Commit graph

351 commits

Author SHA1 Message Date
Régis Hanol
72e7271687 FIX: '.intersect?' isn't available in older version of ruby 2015-12-02 17:25:01 +01:00
Régis Hanol
f4184aea33 FIX: properly re-compute # of voters in multiple-choice polls 2015-12-02 12:33:34 +01:00
Andy Waite
3e50313fdc Prepare for separation of RSpec helper files
Since rspec-rails 3, the default installation creates two helper files:
* `spec_helper.rb`
* `rails_helper.rb`

`spec_helper.rb` is intended as a way of running specs that do not
require Rails, whereas `rails_helper.rb` loads Rails (as Discourse's
current `spec_helper.rb` does).

For more information:

https://www.relishapp.com/rspec/rspec-rails/docs/upgrade#default-helper-files

In this commit, I've simply replaced all instances of `spec_helper` with
`rails_helper`, and renamed the original `spec_helper.rb`.

This brings the Discourse project closer to the standard usage of RSpec
in a Rails app.

At present, every spec relies on loading Rails, but there are likely
many that don't need to. In a future pull request, I hope to introduce a
separate, minimal `spec_helper.rb` which can be used in tests which
don't rely on Rails.
2015-12-01 20:39:42 +00:00
Arpit Jalan
04593b8fef Update Translations 2015-12-01 01:09:45 +05:30
Régis Hanol
478062ba71 remove README 2015-11-30 11:32:48 +01:00
Régis Hanol
f36ba0b5bf add discourse-details plugin 2015-11-30 11:32:01 +01:00
Régis Hanol
08ae5f89bd FIX: rounding issue might appear when summing up all the decimals 2015-11-30 11:24:25 +01:00
Régis Hanol
96cd36e86d FIX: properly compute the number of voters using only valid options 2015-11-30 11:23:38 +01:00
Régis Hanol
68a44a1d59 FIX: use an algorithm that doesn't re-order percentages when rounding them up to 100% in single choice polls 2015-11-25 00:14:24 +01:00
Régis Hanol
4f25278b39 FIX: round down percentages when using multiple choices polls 2015-11-23 15:28:24 +01:00
Arpit Jalan
bde05fd334 Update Translations 2015-11-23 19:25:06 +05:30
Régis Hanol
9d2128dad3 FIX: don't round up to 100% when using multiple choices poll 2015-11-23 11:34:24 +01:00
Arpit Jalan
6ec336e56f Update Translations 2015-11-20 23:26:48 +05:30
Régis Hanol
32b6ccd622 FIX: properly round % so they add up to 100 in polls 2015-11-19 18:23:38 +01:00
Arpit Jalan
951bfb6186 Update Translations 2015-11-09 21:14:02 +05:30
Arpit Jalan
a44c2f6ea3 Update Translations 2015-11-02 17:49:57 +05:30
Arpit Jalan
574805b682 Update Translations 2015-10-30 18:16:52 +05:30
Arpit Jalan
c3cadbb4d8 Update Translations 2015-10-26 22:38:34 +05:30
Régis Hanol
515fc49727 FIX: replace polls with a link in emails 2015-10-22 19:10:07 +02:00
Arpit Jalan
717be06f17 Update Translations 2015-10-20 23:11:42 +05:30
Neil Lalonde
131e7ed445 fix MergePollsVotes migration 2015-10-16 13:54:41 -04:00
Régis Hanol
8f2b002203 FIX: a poll option cannot be voted more than 100% of the time 2015-10-16 17:18:22 +02:00
Arpit Jalan
06f616792d Update Translations 2015-10-15 18:19:04 +05:30
Arpit Jalan
43cd0912e6 Update Translations 2015-10-11 02:11:28 +11:00
Neil Lalonde
1e5ad6f219 Update translations 2015-10-02 10:40:28 -04:00
Arpit Jalan
a2e8e5f90b Update Translations 2015-09-29 12:30:01 +05:30
Gerhard Schlager
bb52042b46 FIX: Add missing pluralization keys to poll plugin locale 2015-09-27 21:36:57 +02:00
Régis Hanol
2e76c9165a FIX: polls are always editable until the first vote 2015-09-25 18:54:15 +02:00
Régis Hanol
cc75890cd4 UX: disable 'Hide results' button when poll is closed 2015-09-16 13:01:08 +02:00
Régis Hanol
26c743a962 FIX: disable poll dialect when poll plugin is disabled 2015-09-14 20:11:03 +02:00
Régis Hanol
60bbd81607 FIX: polls with votes were preventing users from updating the post 2015-09-14 19:27:54 +02:00
Arpit Jalan
b8c3187a94 Update Translations 2015-08-31 22:19:30 +05:30
Arpit Jalan
e1575746f2 Update Translations 2015-08-20 17:33:13 +05:30
Arpit Jalan
ecd1bfe4cb FIX: onebox youtube channels and handle deleted video links 2015-08-18 14:48:53 +05:30
Arpit Jalan
73f547b019 Update Translations 2015-08-10 23:41:05 +05:30
Sam
d16de4a0a1 correct polls spec 2015-08-05 12:39:38 +10:00
Arpit Jalan
e53bf294ef Update Translations 2015-08-04 13:17:39 +05:30
Régis Hanol
969f6ad1d0 Revert "make polls unselectable"
This reverts commit 9b819d9245.
2015-07-31 12:46:30 +02:00
Jeff Atwood
9b819d9245 make polls unselectable
https://meta.discourse.org/t/disabling-text-selection-in-polls/31586
2015-07-31 03:43:07 -07:00
Régis Hanol
233cdc011d FIX: disable text selection in polls 2015-07-31 12:42:53 +02:00
Arpit Jalan
62a59ef7c0 Update Translations 2015-07-30 22:41:12 +05:30
Arpit Jalan
e01d196bda Update Translations 2015-07-22 22:57:18 +05:30
Luke GB
9f31c3d235 Expose poll_maximum_options to client
At present this doesn't actually seem to be exposed to the client.

I discovered this by accident whilst trying to write my own plugin:

7b6d6b76eb/app/models/site_setting.rb (L17-L18)
2015-07-19 21:41:14 +01:00
Arpit Jalan
fc977771a3 Update Translations 2015-07-16 19:18:02 +05:30
Sam
00aaa692ac Merge pull request #3574 from gschlager/patch-2
FIX: Remove invalid translation keys from polls plugin
2015-07-15 16:53:37 +10:00
Arpit Jalan
63b5a6c4e0 Update Translations 2015-07-09 18:57:52 +05:30
Robin Ward
8be37193ee Trivial changes to poll plugin, including a small typo fix. 2015-07-07 10:51:51 -04:00
Kane York
af042ffe5e FEATURE: Per-plugin settings buttons, "Enabled" column
Also, added enabled_site_setting to the Poll plugin so it shows up properly.
2015-07-02 10:59:06 -07:00
Neil Lalonde
9a0e4bb96e Update translations 2015-07-01 17:09:37 -04:00
Gerhard Schlager
5eaf95b328 FIX: Remove invalid translation keys from polls plugin
And it changes the file header since it was wrong.
2015-06-28 01:31:03 +02:00
Arpit Jalan
db02dbb0da Update Translations 2015-06-26 20:30:13 +05:30
Régis Hanol
b25a16ee3e FEATURE: 2 new reports: time to first response, topics with no response
FIX: relativeAgeMediumSpan was off by 1
REFACTOR: extracted decimalAdjust & round functions from the poll plugin
2015-06-22 19:46:51 +02:00
Neil Lalonde
4b6cf528ce update translations 2015-06-19 11:29:13 -04:00
Arpit Jalan
6148ae8775 Update Translations 2015-06-17 22:05:22 +05:30
Arpit Jalan
436e84c6c1 Update Translations 2015-06-15 20:25:53 +05:30
Neil Lalonde
d9efb37ec7 Update translations 2015-06-11 15:35:01 -04:00
Arpit Jalan
45a7c314c2 Update Translations 2015-06-03 20:39:08 +05:30
Régis Hanol
7afe78eec0 FIX: don't use a table for poll results 2015-06-03 16:49:20 +02:00
Régis Hanol
50a39f7e98 use bigger bottom padding instead of line-height to vertical center 2015-06-03 12:35:49 +02:00
Régis Hanol
0013a94692 FIX: use pastel color for background of the selected poll options 2015-06-03 12:28:03 +02:00
Jeff Atwood
1a9da9133e switch back to line-height based centering on polls 2015-06-03 02:58:52 -07:00
Régis Hanol
c240a8bd80 FIX: make sure we can't vote on deleted polls 2015-06-01 22:31:47 +02:00
Arpit Jalan
1ac4e60c90 Update Translations 2015-06-01 23:33:27 +05:30
Régis Hanol
f736b6face FIX: validate poll parameters when type=multiple 2015-06-01 19:28:05 +02:00
Jeff Atwood
9ce6603864 better poll option alignment for multi-line 2015-05-29 16:32:44 -07:00
Arpit Jalan
5880313e84 Update Translations 2015-05-26 20:08:20 +05:30
Arpit Jalan
7608409fdb UX: allow youtube embed width and height to be passed as param 2015-05-26 18:03:50 +05:30
Robin Ward
78abf85087 FIX: IE9 issues with latest discourse 2015-05-25 12:32:42 -04:00
Arpit Jalan
56544f2048 Update Translations 2015-05-21 00:24:12 +05:30
Régis Hanol
3859273ff7 FIX: prevent span abuse in polls 2015-05-20 15:55:27 +02:00
Régis Hanol
d889f05480 changed default 'poll maximum options' to 20 2015-05-19 14:33:27 +02:00
Régis Hanol
764f9b42fe Merge pull request #3458 from Qasem-h/Bosnian
Add Bosnian langage for discourse
2015-05-15 14:34:16 +02:00
Régis Hanol
42be2b431f ooops, we actually need that :fired: 2015-05-15 11:51:10 +02:00
Régis Hanol
a3fb2c002c FIX: remove dangerous support for style/background attributes in polls 2015-05-15 11:08:51 +02:00
riking
9d232dac9a FIX: Properly whitelist li styles 2015-05-14 16:43:01 -07:00
Régis Hanol
635b31af7b FIX: editing a post with a poll breaks sometimes 2015-05-14 17:18:45 +02:00
Régis Hanol
7c545537a6 FIX: prevent pollception 2015-05-13 23:12:53 +02:00
Régis Hanol
43755a6fab keep closed status when migrating poll to new style 2015-05-13 22:30:27 +02:00
Régis Hanol
06643fb625 add support for all types of unordered lists in migrate_old_polls 2015-05-13 22:10:02 +02:00
Régis Hanol
4df868a420 FIX: update 'migrate_old_polls' rake task to support more cases
FIX: support list that uses double newlines
FIX: support list that uses spaces before the '-'
FIX: don't break lamentably when a poll wasn't created
2015-05-13 19:56:09 +02:00
Régis Hanol
b8005f0b1b FIX: link starting with '[poll' should not break polls 2015-05-13 17:50:25 +02:00
Neil Lalonde
1c5ea5d8ef Update translations 2015-05-12 17:38:49 -04:00
Qasem Hajizadeh
a4c69d450e Create server.bs_BA.yml 2015-05-12 16:22:06 +04:30
Qasem Hajizadeh
2ad958b796 Create client.bs_BA.yml 2015-05-12 16:21:49 +04:30
Régis Hanol
3a9907f392 FIX: prevent self-xss in poll attributes 2015-05-11 20:09:17 +02:00
Robin Ward
585583d38c Upgrade polls to Ember 1.11 2015-05-11 11:20:45 -04:00
Robin Ward
aee12fd6ef Ember Deprecations for Topics 2015-05-11 11:18:37 -04:00
riking
7238c43018 SECURITY: XSS in poll errors dialog 2015-05-08 19:28:04 -07:00
Arpit Jalan
c2312a427a UX: no need to show protocol in youtube link 2015-05-09 01:18:42 +05:30
Régis Hanol
f20f9d76a5 Merge pull request #3438 from techAPJ/patch-2
FIX: show youtube URL if title is undefined
2015-05-08 19:23:33 +02:00
Arpit Jalan
597dc2f0b6 FIX: show youtube URL if title is undefined 2015-05-08 22:51:45 +05:30
Régis Hanol
0ded6434df FIX: migrate_old_polls should properly identify olds polls at the end of the post 2015-05-08 19:17:09 +02:00
Arpit Jalan
88135e5b22 FIX: fetch YouTube video title via oEmbed 2015-05-08 18:03:36 +05:30
Régis Hanol
c2ffe255c3 FIX: add borders on polls on mobile 2015-05-08 11:13:32 +02:00
Régis Hanol
875a013ec7 FIX: poll design on mobile 2015-05-07 19:49:06 +02:00
Régis Hanol
c1bb7bc7cc clarify copy when editing a poll after the first 5 minutes 2015-05-07 17:24:35 +02:00
Régis Hanol
9b0ca60f52 FIX: support quotes for poll parameters 2015-05-07 16:40:14 +02:00
Régis Hanol
78cff468bc FIX: poll options display issues 2015-05-07 15:19:23 +02:00
Régis Hanol
033761d2f6 FIX: reset all votes when the # of options changes 2015-05-06 18:52:09 +02:00
Arpit Jalan
ee960899df Update Translations 2015-05-06 21:32:11 +05:30