Commit graph

2716 commits

Author SHA1 Message Date
adroitwhiz
a434bc5a34 Remove calls to updateDrawableSkinIdRotationCenter 2020-01-30 00:53:16 -05:00
Karishma Chadha
8faad67439
Merge pull request #2302 from ErikMejerHansen/develop
Fix custom field types
2019-12-27 11:44:00 -05:00
DD Liu
d47ea58bc3
Merge pull request #2203 from mzgoddard/render-update-drawable
Use new updateDrawable* methods
2019-11-19 15:33:21 -05:00
Eric Rosenbaum
24116e5514
Merge pull request #2289 from ericrosenbaum/bugfix/localize-tts-languages
Localize the Text to Speech extension "set language" menu
2019-11-18 16:22:15 -05:00
Erik Mejer Hansen
a6d8f6cbf2 Fix indents 2019-11-13 15:00:38 +01:00
Erik Mejer Hansen
700e163abe Fix handling of custom field types 2019-11-13 14:58:44 +01:00
Michael "Z" Goddard
52b6d76d35 use updateDrawable* methods from renderer
- replace updateDrawableProperties with updateDrawablePosition and other methods
- use all of the updateDrawable* methods in updateAllDrawableProperties
2019-11-12 13:19:53 -05:00
Ikuo Terado
fbbccacd74 Allow extension to force to write without response as well as with response 2019-11-03 22:07:16 +09:00
Eric Rosenbaum
27c424532f Add explanatory comment 2019-10-31 16:03:50 -04:00
Eric Rosenbaum
83781fd380 Check for spokenLanguages object 2019-10-29 11:39:14 -04:00
Karishma Chadha
0a5673d5d3
Merge pull request #2280 from kchadha/inline-images-in-extensions
Inline Images in Extensions
2019-10-18 10:20:16 -04:00
Chris Willis-Ford
da53d61e05
Merge pull request #2286 from dlech/patch-1
Fix mod operator comment
2019-10-17 13:16:58 -07:00
Karishma Chadha
3859013606 Move inline image specific code into separate helper function. Remove unnecessary todo. 2019-10-17 15:29:04 -04:00
Paul Kaplan
b13a40fb2e
Update src/extensions/scratch3_video_sensing/library.js
Co-Authored-By: Karishma Chadha <kchadha@media.mit.edu>
2019-10-17 11:01:22 -04:00
Paul Kaplan
3cf45f4e07 Fix video sensing by calling updateMatrix manually before using isTouching 2019-10-15 12:10:14 -04:00
Paul Kaplan
94188fc075 Fix tests by more carefully checking for the skin 2019-10-14 12:03:48 -04:00
Paul Kaplan
5913cae969 Use bitmap skin for video preview 2019-10-11 12:32:03 -04:00
Eric Rosenbaum
8971ee4668 use lowercase language codes
this ensures that when editor is set to ja-Hira, the default text loads and the language is set to ja
2019-10-03 13:22:53 -04:00
Eric Rosenbaum
dad1ced3d4 Use lowercase lang code for editor lang (to match ja-Hira) 2019-10-03 12:42:50 -04:00
Eric Rosenbaum
03e6d73cc6 update comment 2019-10-02 14:46:12 -04:00
Karishma Chadha
8bba60aaf3
Merge pull request #2196 from mzgoddard/develop-profiler
add Profiler.increment and Profiler.frame
2019-10-01 09:46:59 -05:00
David Lechner
3070e30241
Fix mod operator comment
The remainder of mod in Scratch is not always positive.

According to the wiki, Scratch uses floored division like Smalltalk instead of truncated division like JavaScript.

With floored division, the sign of the remainder matches the sign of the divisor - it is not always positive.
2019-09-30 17:08:43 -05:00
Karishma Chadha
a9e081859e Remove todo comment about flip_rtl default based on discussion from PR. 2019-09-27 11:48:31 -05:00
Karishma Chadha
470fdb761d Remove 'alt' from field_image descriptor since it seems to only be used for 'collapsed blocks' from blockly. This is not a feature being used in scratch. Update docs. 2019-09-27 11:46:48 -05:00
Karishma Chadha
b1392572ca Update tests and fix bug causing type error. 2019-09-27 11:39:15 -05:00
Karishma Chadha
c5879633d5 Make ArgumentTypeMap clearer now that there is an image field which is not technically an argument. Make the color picker consistent with the other arguments so that an extension developer can specify a default color if they wish. Add docs to document this. 2019-09-27 11:04:03 -05:00
Karishma Chadha
6afbe192d8 Log a warning if dataURI property is missing from image argument specification in extension info. Default to empty string if dataURI or alt are not provided. 2019-09-20 16:56:02 -07:00
Karishma Chadha
167f502edc Add comment for flipRTL property. 2019-09-20 16:02:18 -07:00
Karishma Chadha
7129f8c4a9 Add support for specifying that whether or not the image should be flipped in an RTL language. 2019-09-20 15:47:33 -07:00
Karishma Chadha
21430a5366 Add support for image argument type in extensions. Add example in core example extension. 2019-09-20 15:19:14 -07:00
Kevin Nørby Andersen
23d94b3820
Merge pull request #2231 from knandersen/bugfix/2230
Implements BLE manufacturer data-feature in LEGO BOOST extension
2019-09-19 17:44:03 -04:00
Karishma Chadha
5be322c1d5
Merge pull request #2192 from apple502j/list-cast-safely
Fix Cast.LIST_ALL casting case
2019-09-17 17:53:00 -07:00
Karishma Chadha
30ee33c50a
Merge pull request #2146 from adroitwhiz/no-ie-hacks
Remove Internet Explorer-specific Number.isNaN polyfill
2019-09-17 09:29:40 -07:00
Eric Rosenbaum
b540b2107a Remove mock data 2019-09-16 18:23:55 -04:00
DD Liu
cbb668a7ec
Update src/import/load-costume.js
Thanks!

Co-Authored-By: Karishma Chadha <kchadha@media.mit.edu>
2019-09-16 13:59:45 -04:00
Eric Rosenbaum
7011084517 Check for empty menuMap 2019-09-15 12:05:20 -04:00
DD Liu
82e0f71643 Move error log to right place 2019-09-13 16:15:36 -04:00
Eric Rosenbaum
5e84441542 Support dropped language names 2019-09-10 21:35:34 -04:00
Eric Rosenbaum
5ba476c833 Working localized Text to Speech language menu with dummy data 2019-09-10 18:37:21 -04:00
DD Liu
e447f003a1 Fix variable name 2019-09-04 11:26:23 -04:00
DD Liu
d3f687a6a7 use template 2019-08-23 17:31:11 -04:00
DD Liu
89db44bc6a Give some indication of why asset load failed 2019-08-23 17:28:13 -04:00
Eric Rosenbaum
0052383657
Merge pull request #2247 from spl237/keyboard
Add enter key to list of keyboard events detected.
2019-08-15 14:47:41 -04:00
chrisgarrity
5adf5ba8fc
Merge pull request #2252 from chrisgarrity/custom-mimetype
Add custom mime-type to exported sb3 and sprite
2019-08-13 15:22:10 -04:00
Chris Garrity
40be416c9f Add custom mime-type to exported sb3 and sprite 2019-08-07 13:52:30 +01:00
Kevin Nørby Andersen
d379dc1bc6
Merge pull request #2229 from knandersen/bugfix/2215
Fix 2215 by properly remapping ports to fit new firmware changes
2019-07-31 11:02:06 -04:00
Simon Long
7783deecf6 Add enter key to list of keyboard events detected. 2019-07-31 07:23:35 +01:00
Kevin Andersen
7d7ce2db13 Fixed issue where port A motor position was not being reported because the port number was false-y 2019-07-30 10:20:34 -04:00
Kevin Andersen
4523597a04 Corrected old port mapping! Thanks for catching that @ericr. 2019-07-29 17:59:16 -04:00
Kevin Andersen
842a8e9778 Adjusted portmapping variables to match firmware versions correctly 2019-07-26 15:34:26 -04:00
Kevin Andersen
fcbac7516e This commit addresses a discussion in #2229 around backward compatibility.
This change creates two different port mappings for the Move Hub. By default the extension will use the newer mapping introduced in firmware version 1.0.00.0224. When connected to the hub, the extension will request the hub's firmware version. If it's older than 1.0.00.0224 it will use the older mapping.
2019-07-26 15:31:37 -04:00
Kevin Andersen
e7634d50fa Add port mappings to support older firmware version 2.0.00.0016 and later as well as newer firmware version 2.0.00.0017 or newer 2019-07-26 14:12:05 -04:00
Kevin Andersen
fd0944e505 Changed manufacturerData-filter to fit the changes in https://github.com/LLK/scratch-link/pull/139 2019-07-23 13:11:17 -04:00
adroitwhiz
4e34f1735a replaceItemOfList by assigning array index 2019-07-20 01:11:35 -04:00
Karishma Chadha
9ba9732e8a
Merge pull request #2145 from mzgoddard/raise-params
Raise params to the next frame when pushing
2019-07-17 16:12:37 -04:00
Michael "Z" Goddard
d3ae00292f
add Profiler.increment and Profiler.frame
Let profiled code track frames and arguments called by incrementing a
counter for a frame id or frame id and argument. This replaces the same
counting by recording the call as part of a history of calls and
returns. Updating the array for all calls counted takes enough time to
bias the profiled run towards less overall executions.
2019-07-17 15:06:47 -04:00
Michael "Z" Goddard
50b55a489b
fix stopThisScript inside procedures 2019-07-17 15:02:44 -04:00
Kevin Andersen
c89add4de9 Added START_POWER enum to BoostOutputSubCommand which allows the extension to use unregulated motor commands with the Move Hub. Changed BoostMotor.turnOff() to use unregulated motor commands since it seems like a more reliable way of turning the motor off 2019-07-15 09:48:12 -04:00
Kevin Andersen
f4e34131e3 Implements BLE manufacturer data-feature to only scan for properly initialised LEGO BOOST Move Hubs 2019-07-11 17:23:59 -04:00
Kevin Andersen
dcccae9656 Add case to onMessage to catch responses from the LED 2019-07-11 16:23:07 -04:00
Kevin Andersen
4041fbadc3 Changed port-mapping to reflect firmware update. 2019-07-11 16:10:23 -04:00
Evelyn Eastmond
cc04fb0994
Merge pull request #2211 from evhan55/ergonomics/1568
EV3 documentation and small refactors
2019-06-28 12:09:24 -04:00
Eric Rosenbaum
4bf5f85d9a Lint (remove logs, add spaces) 2019-06-27 15:48:30 -04:00
Evelyn Eastmond
d7af8457e1 Making constants decimals. 2019-06-23 22:58:40 -04:00
Evelyn Eastmond
6520f3bd7c Fixing enum var name again. 2019-06-23 22:54:28 -04:00
Evelyn Eastmond
87590202cc Adding 'byte to follow' comments back. 2019-06-23 22:42:42 -04:00
Evelyn Eastmond
c5a954fb56 Testing some new variable names. 2019-06-23 22:20:50 -04:00
Evelyn Eastmond
471a22dbdc Clarifying input_device_list args and return types. 2019-06-23 21:58:05 -04:00
Evelyn Eastmond
98deb1bebe Removing test Ev3Args values. 2019-06-23 21:29:24 -04:00
Evelyn Eastmond
54633e1a97 Adding some comments. 2019-06-23 21:27:20 -04:00
Evelyn Eastmond
7ce8314437 Fixing comment. 2019-06-23 21:23:28 -04:00
Evelyn Eastmond
cbb99e2ee6 Comment clarifying mistake in LEGO docs. 2019-06-23 21:23:28 -04:00
Evelyn Eastmond
ca408dfb04 Trying to figure out the input_device_list args. 2019-06-23 21:23:28 -04:00
Evelyn Eastmond
abe5fa62e4 Remove stale comment. 2019-06-23 21:23:28 -04:00
Evelyn Eastmond
728e5e2d12 Renaming LONG_RAMP to RAMP and adding comment. 2019-06-23 21:23:28 -04:00
Evelyn Eastmond
f45539280a Trying some different enum values and reorganizing the enums at top of file. 2019-06-23 21:23:28 -04:00
Evelyn Eastmond
fe43ecfa73 Renaming byte allocation enum values. 2019-06-23 21:23:28 -04:00
Evelyn Eastmond
1e124657e5 Fix comments and formatting. 2019-06-23 21:23:27 -04:00
Evelyn Eastmond
ca28b4ff1b Fix device type return parsing to be clearer when it tries to avoid null values and convert them to 'none'. 2019-06-23 21:23:27 -04:00
Evelyn Eastmond
20b0d4da78 Remove some stale comments and add reminder to rename some byte value enums. 2019-06-23 21:23:27 -04:00
Evelyn Eastmond
f3d50dbe5a Add global var index 0 value to enum. 2019-06-23 21:23:27 -04:00
Evelyn Eastmond
63d9b0249a Removed a TODO and clarified with a better comment. 2019-06-23 21:23:27 -04:00
Evelyn Eastmond
5314be8310 More byte value updates, and change global index comments. 2019-06-23 21:23:27 -04:00
Evelyn Eastmond
50c80a8abc Adding comment to explain byte value enum values. 2019-06-23 21:23:27 -04:00
Evelyn Eastmond
14e8a93ac6 Add global var 1-byte-to-follow to enum. 2019-06-23 21:23:27 -04:00
Evelyn Eastmond
f8d9f687ec Move Ev3 byte values into their own enum, separate from parameter values. 2019-06-23 21:23:27 -04:00
Evelyn Eastmond
c237f1326d Clean up some null checks. 2019-06-23 21:23:27 -04:00
Evelyn Eastmond
6b9c3d12ef Shorten a comment. 2019-06-23 21:23:27 -04:00
Evelyn Eastmond
b476169f84 Change variable name to be shorter / more legible. 2019-06-23 21:23:27 -04:00
Evelyn Eastmond
6284cbdd85 Removing todo, decided not to rename. 2019-06-23 21:23:27 -04:00
Evelyn Eastmond
6c706b410f Removing label. 2019-06-23 21:23:27 -04:00
Evelyn Eastmond
3712b6fe72 Fixing GDX_FOR disconnect to new ble variable, fixing an error from a recent merge. 2019-06-23 18:42:32 -04:00
Eric Rosenbaum
a115f6dde5
Merge branch 'develop' into enhancement/1929 2019-06-19 11:09:14 -04:00
Karishma Chadha
aae7607e10 fix extension dropdown menu item conversion 2019-06-18 21:03:17 -07:00
Chris Willis-Ford
eba89d57d8 Merge branch 'develop' into non-droppable-extension-menus 2019-06-18 16:52:47 -07:00
Karishma Chadha
9af2e4c086
Merge pull request #2161 from LLK/e16n
Supporting VM changes for extensionification
2019-06-18 18:53:20 -04:00
Christopher Willis-Ford
fd776025e5 refactor _refreshExtensionPrimitives for clarity
The previous form made it harder to see that at most one extension
category is handled per call.
2019-06-18 15:08:03 -07:00
Chris Willis-Ford
edd6aafed0 call out capitalization change since it's important but easy to miss
Co-Authored-By: Karishma Chadha <kchadha@media.mit.edu>
2019-06-18 15:07:58 -07:00
Christopher Willis-Ford
3c28f714bb respond to code review 2019-06-17 21:14:21 -07:00
Chris Willis-Ford
18b1551cdb
remove redundant check
Co-Authored-By: Karishma Chadha <kchadha@media.mit.edu>
2019-06-17 13:22:52 -07:00
Evelyn Eastmond
f3f307b59c
Merge pull request #2207 from evhan55/ergonomics/2017
Removing comment in WeDo2 extension
2019-06-17 12:19:42 -04:00
Christopher Willis-Ford
33a6071466 for compatibility, make all existing extension menus accept reporters 2019-06-14 12:29:32 -07:00
Christopher Willis-Ford
cfee656306 fix tests: empty menus shouldn't be an array 2019-06-14 12:29:32 -07:00
Christopher Willis-Ford
3fbed88a95 switch from rejectReporters flag to acceptReporters
Also add more extensive documentation around extension menu definitions,
including some considerations to think about before making a menu accept
reporters.
2019-06-14 12:29:32 -07:00
Christopher Willis-Ford
e7bf49c8df support non-droppable menus in extensions 2019-06-14 12:29:32 -07:00
Evelyn Eastmond
418cd0a0f4 Removing comment after decision that this function name is accurate and distinct from coastAfter. 2019-06-12 10:20:21 -04:00
Evelyn Eastmond
704774d6d1 Fixing debug statements and also adding a safety check for timeoutIDs. 2019-06-12 09:02:12 -04:00
Evelyn Eastmond
0e250aef37 Fixing a comment. 2019-06-12 09:02:12 -04:00
Evelyn Eastmond
37fe83c057 Adding disconnect/state resetting behavior to rest of hardware extensions. 2019-06-12 09:02:12 -04:00
Evelyn Eastmond
f8a0ea281f Adding/fixing debug statements throughout. 2019-06-12 09:02:12 -04:00
Evelyn Eastmond
a1243fd897 Change cleanup/disconnect behavior for BT and EV3. 2019-06-12 09:02:12 -04:00
Evelyn Eastmond
6a032087ce Fixing up BOOST reset and disconnect behavior splitting. 2019-06-12 09:02:12 -04:00
Evelyn Eastmond
56fdd45242 Adding reset and resetCallback to BLE and Boost extension only for now. 2019-06-12 09:02:12 -04:00
Evelyn Eastmond
f192c181bd Rename scratchLinkSocket variables to 'socket' and 'ble' to avoid confusion with upcoming ScratchLinkWebSocket class. 2019-06-12 09:01:49 -04:00
picklesrus
b88d5d05b0
Merge pull request #2084 from picklesrus/update-languages-in-translate-list
Fixing some translate language menu bugs.
2019-06-10 11:13:52 -04:00
Eric Rosenbaum
8243d0f53a Update sound sampleCount and rate 2019-06-05 17:06:27 -04:00
Eric Rosenbaum
b6a33cc3ed
Merge branch 'develop' into extensions/ev3-rate-limiting 2019-06-04 11:37:43 -04:00
Evelyn Eastmond
6e80c92703
Merge pull request #2191 from evhan55/bt-pairing-changes
Add optional 'pin' parameter to BT connections
2019-06-04 11:26:47 -04:00
Michael "Z" Goddard
e1254bd8c7
elevate stack block id and frame info into thread
- Add pointer member to thread. This is the current executing block.
- Add stackFrame member to thread. This is the current frame
  information like procedure parameters.

This is a step potentially towards stack-less threads. With further
modifications we could have stack and stackFrames be null if a script
does not call a procedure.
2019-06-03 18:13:01 -04:00
Michael "Z" Goddard
ffcd0e6518
remove empty procedure_definetion block
The engine supports blocks that do not have defined functions.
2019-06-03 15:49:11 -04:00
apple502j
558f43a3d6 Fix Cast.LIST_ALL casting case 2019-06-01 14:43:53 +09:00
Evelyn Eastmond
ae791b3f26 Don't send null pin. 2019-05-31 11:27:20 -04:00
Evelyn Eastmond
b6913b7828 Move EV3 pin to a static var. 2019-05-31 11:14:32 -04:00
Evelyn Eastmond
8e302ac90c Add optional pin parameter to peripheral connection. 2019-05-31 11:10:13 -04:00
Paul Kaplan
615f60252d Set connected to false before closing to prevent infinite loop
There is an implicit assumption that socket.close is async, but if it is sync, it may go into an infinite loop of close callbacks if the connected flag is not set to false before trying to close

Co-Authored-By: chrisgarrity <chrisg@media.mit.edu>
2019-05-31 09:42:00 -04:00
Paul Kaplan
706354d2f0 Update documentation about required methods on ScratchLinkSocket
Co-Authored-By: chrisgarrity <chrisg@media.mit.edu>
2019-05-31 08:55:20 -04:00
Paul Kaplan
64cff3d161 Fix documentation on what methods to implement for ScratchLinkSocket
Co-Authored-By: chrisgarrity <chrisg@media.mit.edu>
2019-05-31 08:41:20 -04:00
Paul Kaplan
94afd58b2f Require handleMessage to be set before opening scratch-link-socket 2019-05-31 08:35:27 -04:00
Paul Kaplan
5e626eb7e9 Initial prototype of configurable scratch link socket 2019-05-24 12:51:58 -04:00
Karishma Chadha
dbcbe8b94f Revert "synth extension"
This reverts commit dbd513d85b.
2019-05-24 11:27:20 -04:00
Karishma Chadha
d1b261d56e Revert "lightplay extension stub"
This reverts commit 36de7517bd.
2019-05-24 11:27:08 -04:00
Karishma Chadha
7501af4c6b Revert "lightplay extension stub"
This reverts commit 1ee3cea144.
2019-05-24 11:26:54 -04:00
Carmelo Presicce
1ee3cea144 lightplay extension stub 2019-05-23 21:27:10 -04:00
Carmelo Presicce
36de7517bd lightplay extension stub 2019-05-23 21:26:57 -04:00
Carmelo Presicce
dbd513d85b synth extension 2019-05-23 20:22:03 -04:00
Evelyn Eastmond
565f11d4fc
Merge pull request #2168 from evhan55/ergonomics/2153
Change BOOST variable names regarding duration and rotation blocks
2019-05-22 16:23:35 -04:00
Eric Rosenbaum
79c8a815a3 Do not load speech2text extension 2019-05-20 12:53:16 -04:00
Evelyn Eastmond
58908bb1a4 Changing BTSendRateMax to help with key-down scenarios. 2019-05-17 11:43:06 -04:00
Evelyn Eastmond
d76756f5f6 Removing BTSendInterval, not needed. 2019-05-17 11:28:51 -04:00
Evelyn Eastmond
62a8f2d0f2 Fix typo. 2019-05-17 11:28:51 -04:00
Evelyn Eastmond
52519ae1e0 Add comment. 2019-05-17 11:28:51 -04:00
Evelyn Eastmond
9d231b7887 Adding RateLimiter and useLimiter rate limiting approach to EV3. 2019-05-17 11:28:51 -04:00
Karishma Chadha
14d2820460
Merge pull request #1648 from mzgoddard/stop-all-next-tick
Stop all next tick
2019-05-15 11:25:15 -04:00
Evelyn Eastmond
6e6d6140cc Rename duration timeout setter/getter. 2019-05-11 11:21:07 -04:00
Evelyn Eastmond
b7e0edcabc Fixing linting. 2019-05-11 11:08:00 -04:00
Evelyn Eastmond
6e0b4351d8 Clarify comment. 2019-05-11 10:55:51 -04:00
Evelyn Eastmond
693038972e Clarify comment. 2019-05-11 10:54:45 -04:00
Evelyn Eastmond
bdda6f7fc6 Fix inaccurate comment. 2019-05-11 10:52:00 -04:00
Evelyn Eastmond
048598aef8 Fix inaccurate comment. 2019-05-11 10:50:25 -04:00
Evelyn Eastmond
14ffae04f8 Fix inaccurate comment. 2019-05-11 10:48:35 -04:00