scratchfoundation/scratch-vm
1
0
Fork 0
mirror of https://github.com/scratchfoundation/scratch-vm.git synced 2024-12-23 14:32:59 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Remove some stale comments and add reminder to rename some byte value enums.

Browse source
This commit is contained in:
Evelyn Eastmond 2019-06-14 12:20:55 -04:00
parent f3d50dbe5a
commit 20b0d4da78
1 changed files with 4 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
src/extensions/scratch3_ev3/index.js
View file

@ -76,9 +76,9 @@ const Ev3Opcode = {
* @enum {number}
*/
const Ev3ByteValue = {
NUM8: 0x81, // = 0b1000-001 = 1 byte to follow
NUM16: 0x82, // = 0b1000-010 = 2 bytes to follow
NUM32: 0x83, // = 0b1000-011 = 4 bytes to follow
NUM8: 0x81, // = 0b1000-001 = 1 byte to follow // TODO: rename
NUM16: 0x82, // = 0b1000-010 = 2 bytes to follow // TODO: rename
NUM32: 0x83, // = 0b1000-011 = 4 bytes to follow // TODO: rename
GLOBAL8: 0xE1, // = 0b1110-001 = size of global var - 1 byte to follow
GLOBAL_INDEX_0: 0x20 // = 0b00100000 = global var index "0"
};
@ -735,7 +735,7 @@ class EV3 {
if (this._pollingCounter % 20 === 0) {
// GET DEVICE LIST
cmds[0] = Ev3Opcode.OPINPUT_DEVICE_LIST;
cmds[1] = Ev3ByteValue.NUM8; // 1 byte to follow
cmds[1] = Ev3ByteValue.NUM8;
cmds[2] = 33; // 0x21 ARRAY // TODO: document
cmds[3] = 96; // 0x60 CHANGED // TODO: document
cmds[4] = Ev3ByteValue.GLOBAL8;
@ -818,9 +818,7 @@ class EV3 {
_onMessage (params) {
const message = params.message;
const data = Base64Util.base64ToUint8Array(message);
// log.info(`received array: ${array}`);
// TODO: Is this the correct check?
if (data[4] !== Ev3Command.DIRECT_REPLY) {
return;
}