Christopher Willis-Ford
3649c15f2a
Fix monitor tests to count only monitor threads
...
The monitor tests no longer fail if the last step happens to have run a
non-monitor thread in addition to the monitor threads.
2018-11-19 16:34:33 -08:00
Chris Willis-Ford
e071cf3c0c
Merge pull request #1768 from cwillisf/node11-fix-unit-tests
...
Fix unit tests on Travis CI
2018-11-19 14:06:10 -08:00
Christopher Willis-Ford
812455db7c
Explicitly specify Node versions for Travis
2018-11-19 12:09:38 -08:00
Christopher Willis-Ford
30a1ba52e3
Use absolute path for worker shim in dispatch test
...
Node 11 causes TinyWorker to resolve its start script path differently,
compared to Node 8. Using an absolute path works for both.
2018-11-19 11:57:43 -08:00
Katie Broida
bb82c46f8a
Handle coordinate precision the same as Scratch 2 ( #1722 )
2018-11-15 15:50:56 -05:00
Valerie Young
2ca735eab4
Merge pull request #1716 from bocoup/unknown-block-input-fix
...
Handle unknown opcode in input
2018-11-15 10:09:46 -05:00
Ray Schamp
f2550d582c
Merge pull request #1750 from rschamp/feature/sb3-json-assets
...
Add method for collecting all targets' assets
2018-11-15 10:31:58 +00:00
Ray Schamp
bcd1c5b13a
Consolidate collectAssets into getter
2018-11-15 10:26:05 +00:00
Karishma Chadha
0c9da5d963
Merge pull request #1755 from kchadha/cloud-var-create
...
Create cloud variables
2018-11-14 21:39:29 -05:00
Karishma Chadha
e2e6509a4a
Fix lint error
2018-11-14 19:22:41 -05:00
Karishma Chadha
fad4d381bb
Add and update unit tests for new create cloud variable functionality.
2018-11-14 15:46:51 -05:00
Eric Rosenbaum
26ced0dd58
Use note picker in imported play note blocks ( #1757 )
...
* Use note picker in imported play note blocks
* Set default for obscured note shadows to 60
2018-11-14 14:55:12 -05:00
Valerie R Young
ebd3b46cc2
Address feedback
2018-11-14 14:24:09 -05:00
Paul Kaplan
8aa88fa2a2
Merge pull request #1723 from mzgoddard/blocks-monitored-cache
...
Cache the set of actively monitored blocks
2018-11-14 14:16:36 -05:00
Karishma Chadha
3dd0d0a657
Merge pull request #1686 from kchadha/monitor-save-load
...
Monitor save & load
2018-11-14 13:23:10 -05:00
Karishma Chadha
5b2667556c
Comment cleanup
2018-11-14 13:15:36 -05:00
Karishma Chadha
56ee6ba575
Merge pull request #1747 from kchadha/load-visible-extension-monitors
...
Always ignore video sensing monitor when importing from 2.0 and import visible extension monitors.
2018-11-14 10:54:25 -05:00
Karishma Chadha
dccb41e3c4
Comment and test cleanup.
2018-11-14 10:42:52 -05:00
Karishma Chadha
3fc1b89b30
Add ability to create cloud variables, and have cloud provider wait for confirmation from server.
2018-11-13 16:43:51 -05:00
Paul Kaplan
0a68722b80
Merge pull request #1748 from joker314/feat/point-random
...
Implement "point towards random direction"
2018-11-13 12:35:14 -05:00
Ray Schamp
df56e615ec
Add method for collecting all targets' assets
...
Resolves #1601 . Does not include the project JSON since that would require knowledge of a project ID, which the VM has not been responsible for so far.
For now, it is the responsibility of the consumer to determine if these assets should be saved or not. Otherwise the VM would need to be responsible for saving, which has been out of its scope.
2018-11-12 15:13:02 +00:00
jokebookservice1
306996e54c
feat: Implement "point towards random direction"
...
We subtract 180 even though the value will be clamped, for clarity. We round so that
using the "direction" getter will yield a sensible result. Note that this
implements 'point towards random direction', not 'point towards random
position' -- they have slightly different behaviours.
2018-11-11 01:51:37 +00:00
Karishma Chadha
6dfc0b678e
Add integration test for monitor save/load.
2018-11-09 23:45:49 -05:00
Karishma Chadha
14bee14d8c
Update extensions to load when deserializing monitors. This is necessary when the monitor is the only part of the project that uses the extension. Update extension monitor color category.
2018-11-09 23:45:49 -05:00
Karishma Chadha
df24ca7b46
Refactor sb3 monitor deserialization. Create monitor blocks with the relevant info if they don't exist.
2018-11-09 23:45:49 -05:00
Karishma Chadha
1b9b3ac909
Revert changes that were made to leverage the monitor blocks getting created when the toolbox is loaded. This approach does not work when viewing the project detached from scratch-blocks (e.g. player mode).
2018-11-09 23:45:48 -05:00
Karishma Chadha
ebdd548c8f
Update for auto-positioning monitors so that having just one of x or y be 0 (e.g. a monitor placed in the top right corner of the stage) does not result in the monitor being treated as a new monitor and get auto-positioned.
2018-11-09 23:45:48 -05:00
Karishma Chadha
d690c76a34
Update sb2 deserialization of monitors.
2018-11-09 23:45:48 -05:00
Karishma Chadha
1a4f0a75f2
Serialize and deserialize monitors. Obtain monitor block information from runtime. Fix issue where stage monitors weren't getting loaded correctly.
2018-11-09 23:45:48 -05:00
Karishma Chadha
cfa71723eb
Ignore video sensing monitor and import music tempo monitor unless it is hidden. Load extensions for visible monitors. Add tests for new functionality.
2018-11-09 00:09:54 -05:00
Evelyn Eastmond
3050f496b2
Resolves #1687 . Clears discover timeout when needed. ( #1697 )
2018-11-08 15:31:15 -05:00
Evelyn Eastmond
53c165c2f6
Close Scratch Link web socket on every new peripheral scan attempt ( #1696 )
...
* Progress towards: #1671 : Close web socket before making a new one for hardware extensions.
* Always disconnect before scanning for new peripheral. Removing console logs.
* Removing unused test code.
2018-11-08 15:21:28 -05:00
Karishma Chadha
fe186913ac
Merge pull request #1742 from kchadha/multi-monitors
...
Multi monitors
2018-11-08 14:44:22 -05:00
Karishma Chadha
7ea310a194
Fix typo in comment
2018-11-08 14:43:07 -05:00
Karishma Chadha
87244b4110
Normalize capitalization of sensing_current block fields during sb2 import and during monitor id generation. Update monitors integration test to include sensing_current block monitors.
2018-11-08 14:11:30 -05:00
Ray Schamp
4f5aba4fe6
Merge pull request #1727 from paulkaplan/add-ext-on-share
...
Add unloaded extensions on block sharing
2018-11-08 10:15:58 +00:00
Karishma Chadha
5db3db3a92
monitor id getter should use block fields instead of a list of strings
2018-11-08 01:33:26 -05:00
Karishma Chadha
7d1226458f
Fix import of current day of week block from sb2.
2018-11-08 00:37:49 -05:00
Karishma Chadha
0e7eae98d5
Separate out monitors for blocks reporter blocks that have parameters.
2018-11-08 00:37:28 -05:00
Karishma Chadha
8aa0fa11aa
Merge pull request #1649 from mzgoddard/get-attribute-stage-alt-name
...
Get attribute stage alt name
2018-11-07 17:47:44 -05:00
Karishma Chadha
4bb2d19584
Merge pull request #1683 from mzgoddard/sequencer-thread-cleanup
...
Sequencer thread cleanup
2018-11-07 17:15:11 -05:00
Eric Rosenbaum
2cff4159bb
Use the new note picker field in music and EV3 extensions ( #1720 )
...
* Add note field type
* Note picker in music extension plays notes
* Use note picker in EV3 beep block
2018-11-07 11:50:15 -05:00
Eric Rosenbaum
eef1885fad
On websocket error, use sendRequestError instead of disconnect ( #1736 )
2018-11-07 10:25:09 -05:00
Paul Kaplan
ce94144051
Fixup from comments
2018-11-07 10:11:16 -05:00
Eric Rosenbaum
3bd0797810
Make volume a sprite-specific monitor ( #1730 )
2018-11-06 10:52:40 -05:00
Valerie R Young
b64d18b627
Satisfy linter
2018-11-05 15:16:57 -05:00
Valerie R Young
2c76d3bf71
Add unit test for unknown opcode inputs
2018-11-05 13:23:31 -05:00
Paul Kaplan
979ed66594
Add a unit test to ensure extensions are loaded on shareBlocksToTarget
2018-11-05 13:01:00 -05:00
Paul Kaplan
c8ad1955d4
Load extensions before sharing blocks.
...
This commit fixes the unit tests so the assertions are made after the promise resolves
2018-11-05 13:00:35 -05:00
Paul Kaplan
bc1da9fa44
Move extension ID parsing into a helper and add test
2018-11-05 12:57:09 -05:00
