Andrew Sliwinski
326d1c491a
Merge pull request #1086 from mortendybdal/feature/add-sprite-3
...
Included a function to add sprite 3 to vm
2018-05-01 08:38:08 -04:00
Morten Dybdal
41be65ba4d
Fixing js linting issues
2018-05-01 13:23:21 +02:00
Paul Kaplan
8a9818d0d4
Merge pull request #1098 from paulkaplan/fix-say-bounds
...
Use renderer bounds instead of stage bounds for positioning bubbles.
2018-04-30 15:14:08 -04:00
Paul Kaplan
19d71f5c85
Merge pull request #1089 from paulkaplan/fix-say-flickering
...
Fix say flickering
2018-04-30 14:35:31 -04:00
Paul Kaplan
6c59ccbe1b
Use renderer bounds instead of stage bounds for positioning bubbles.
...
Instead of using the rendered bounds of the stage (which can be larger than the actual rendering area of the stage due to large costumes), use the `nativeSize` which is the size in scratch coords of the rendering area. Note that `nativeSize` is not the size of the canvas element or anything like that, it is the "logical size", i.e. the [width, height] in scratch coords.
2018-04-30 14:26:25 -04:00
Paul Kaplan
3f97ccc8ce
Remove the "optimization" for
2018-04-30 13:40:36 -04:00
Paul Kaplan
e4c109c0c8
Merge branch 'develop' into fix-say-flickering
2018-04-30 13:25:35 -04:00
Ray Schamp
23e72525bf
Merge pull request #1065 from mzgoddard/push-reported-again
...
Push reported again. Now with empty boolean support!
2018-04-30 09:36:32 -04:00
kchadha
8e65b3d80f
Merge pull request #1092 from kchadha/refactor-video-io
...
Refactor Video IO
2018-04-30 09:27:10 -04:00
Karishma Chadha
857f77c511
Addressing PR comments.
2018-04-29 19:52:21 -04:00
Paul Kaplan
ad4f5652e4
Merge pull request #1088 from paulkaplan/fix-say-timing
...
Track say/thinks per target so they can maintain correct timing.
2018-04-27 11:10:12 -04:00
Paul Kaplan
c2bb1e3123
Add comment to jsdoc typedef where it belongs.
2018-04-27 09:21:38 -04:00
Karishma Chadha
271a19c05d
Add runtime/render related functionality back to VM.
2018-04-26 19:17:41 -04:00
Andrew Sliwinski
1ed5d57c98
Merge pull request #1087 from thisandagain/bugfix/974
...
Cast 'create clone' argument to string
2018-04-26 14:57:32 -04:00
DD Liu
5f20609dc1
Merge pull request #1090 from fsih/renameGetCostume
...
Rename getCostumeSvg to getCostume
2018-04-26 13:51:31 -04:00
DD
fc36ea5208
Rename getCostumeSvg to getCostume
2018-04-26 13:36:51 -04:00
Karishma Chadha
5f4139cbe4
Use video provider instead of making call to getUserMedia directly.
2018-04-26 13:24:31 -04:00
Paul Kaplan
3019d05181
Fix issue where say bubble flickers during conversation.
...
The fix for this involves something of hack where we decide whether to use the optimization that prevents "typewriter" style projects (say for 0.05s in a loop) based on the amount of time the block is going to run for. A full fix of this can only be achieved if the text bubble renders synchronously.
2018-04-26 13:03:57 -04:00
Paul Kaplan
50708c15e4
Track say/thinks per target so they can maintain correct timing.
2018-04-26 11:29:24 -04:00
Andrew Sliwinski
218725d771
Cast 'create clone' argument to string. Resolves GH-974
2018-04-26 10:29:29 -04:00
Morten Dybdal
d033271a1f
Included a function to add sprite 3 to vm
2018-04-26 10:59:53 +02:00
Michael "Z" Goddard
1c68b543df
Comment execute's BlocksExecuteCache usage
...
Explain how BlocksExecuteCache helps speed up execute by storing values from
Blocks and one-time derived values on an object that is released when Blocks is
edited in the editor. The one time created cache object for a block then
simplifies the complexity of later javascript operations to use these stored
values.
2018-04-24 19:05:44 -04:00
Michael "Z" Goddard
02dd9a8c22
Unset justReported after reading its value
...
Avoid justReported values leaking to other argValues by setting back to the
default null value.
2018-04-24 19:05:20 -04:00
kchadha
cde801bc17
Merge pull request #1075 from kchadha/load-costume-no-metadata
...
Load costume without metadata
2018-04-23 17:52:04 -04:00
Andrew Sliwinski
eeab0695d6
Merge pull request #1079 from thisandagain/bugfix/1072
...
Various refinements to Video Motion extension
2018-04-23 17:04:17 -04:00
Paul Kaplan
f118e912bf
Merge pull request #1081 from paulkaplan/fix-stage-clicks
...
Activate stage click hats if no other sprites are clicked
2018-04-23 14:47:26 -04:00
Paul Kaplan
978906d926
Activate stage click hats if no other clicks are hit.
...
Also check the bounds before to make sure clicks are inside the stage bounds.
2018-04-23 14:25:58 -04:00
Andrew Sliwinski
add879ab0a
Enable video layer when loading extension. Resolves GH-1072
2018-04-23 13:03:56 -04:00
Andrew Sliwinski
ced4de8995
Flip sort order of sensing object menu in video motion extension. Resolves GH-1074
2018-04-23 13:00:20 -04:00
Andrew Sliwinski
717ac46bbd
Reorder video motion blocks. Resolves GH-1073
2018-04-23 12:57:14 -04:00
Karishma Chadha
af7ed61016
Fix bitmap support. In Scratch 3.0, we are defaulting to bitmapResolution = 2 for all costumes.
2018-04-22 21:22:03 -04:00
Karishma Chadha
e1d9df3b1b
Undo an unnecessary change from the last commit.
2018-04-20 18:11:14 -04:00
Paul Kaplan
c9f30ed6ef
Merge pull request #1071 from kchadha/fix-mp3-edit-bug
...
Fix issue with sound upload and save/load
2018-04-20 16:01:04 -04:00
Karishma Chadha
dfa3408add
Update sound dataFormat after editing
2018-04-20 14:13:57 -04:00
Andrew Sliwinski
968643ed16
Merge pull request #1069 from thisandagain/bugfix/underscore
...
Replace extension delimiter with '_'
2018-04-20 11:46:25 -04:00
Paul Kaplan
0f16e2fe65
Merge pull request #1070 from paulkaplan/fix-bubbles
...
Fix drag and empty costume bugs with say bubbles
2018-04-20 11:43:15 -04:00
Andrew Sliwinski
192084e0e7
Do not load extension if prefix is undefined
2018-04-20 11:36:16 -04:00
Andrew Sliwinski
fd97892eb1
Remove console log
2018-04-20 10:58:35 -04:00
Andrew Sliwinski
57b7e9916d
Resolve issue with SB2 import
2018-04-20 10:58:03 -04:00
Andrew Sliwinski
645a42b843
Address feedback from review
2018-04-20 10:49:06 -04:00
Paul Kaplan
393b5d54df
Handle positioning bubbles for empty costumes
2018-04-20 10:45:54 -04:00
Paul Kaplan
54d5be8bba
Do not bother repositioning bubbles for invisible sprites
2018-04-20 10:45:34 -04:00
Paul Kaplan
9782c137bb
Use the new general target visual change for updating bubbles.
2018-04-20 10:44:55 -04:00
Paul Kaplan
c36ff056a2
Add new event for all visual target changes, not just moving.
2018-04-20 10:43:45 -04:00
Andrew Sliwinski
9ec3d41ea1
Clarify 'core' list for SB2 import
2018-04-20 10:34:17 -04:00
Andrew Sliwinski
4a78e9c4af
All tests passing
2018-04-20 10:29:29 -04:00
Andrew Sliwinski
f86cad3305
Replace extension delimeter with '_'
2018-04-20 07:54:02 -04:00
Karishma Chadha
54b52ba96c
Use calculated rotation center from renderer when rotation center is not provided with the costume being loaded.
2018-04-20 00:04:08 -04:00
Karishma Chadha
d6f28f2266
Correct what is being passed into scratch-render if some metadata (rotationCenter, bitmapResolution) is missing.
2018-04-18 14:21:29 -04:00
kchadha
47a2d76a14
Merge pull request #1060 from kchadha/fix-sound-metadata
...
Update sound metadata and retrieve mp3 correctly from storage
2018-04-17 11:02:56 -04:00