Jürg Lehni
bd4874d73e
Improve debug logging of windings.
2015-10-05 04:57:12 +02:00
Jürg Lehni
ba76ed8671
Consider the winding contribution at the intersection of the next segment as well.
...
Fixes both example 20 and example 21 in #784
2015-10-05 04:24:04 +02:00
Jürg Lehni
d2c762997f
Address improvements mentioned by @hkrish in #794
2015-10-04 18:36:18 +02:00
Jürg Lehni
5601e21996
Make sure the two locations are actually part of the same path before comparing index / parameter values.
2015-10-04 10:14:04 +02:00
Jürg Lehni
035a3a1b8c
Remove unnecessary _visited check.
2015-10-04 02:27:56 +02:00
Jürg Lehni
ebc956353f
Move code to adjust segments after split to CurveLocation.
2015-10-04 02:25:33 +02:00
Jürg Lehni
be2f98d91a
Optimize various isCollinear() and isOrthogonal() methods.
2015-10-03 17:42:52 -04:00
Jürg Lehni
8073183010
Use getIntersections() with right filter instead of getCrossings() for boolean operations.
2015-10-03 17:17:12 -04:00
Jürg Lehni
79cb216684
Define CurveLocation#isOverlap() and improve documentation of various related methods.
2015-10-03 17:15:45 -04:00
Jürg Lehni
5af8515d1a
Commit some useful debug code, deactivated for now.
2015-10-03 16:18:00 -04:00
Jürg Lehni
86b1b74869
Prevent detection of tiny overlaps and streamline addOverlap() code.
2015-10-03 12:55:32 -05:00
Jürg Lehni
2bed611648
Improve Curve#getPart() to directly handle reversed curves and write docs for it.
2015-10-03 12:55:05 -05:00
Jürg Lehni
6fb4b7e3c4
Change the way overlaps are detected in lines.
...
We don't really care weather they are actually fully collinear, we only really care about the distances from the beginnings- and end-points of one line from the other, since that proximity will affect results elsewhere.
2015-10-03 11:46:50 -05:00
Jürg Lehni
5d7a596026
Fix wrong upper bounds check in Line.intersect()
...
1 as a solution was accidentally excluded.
2015-10-03 11:44:43 -05:00
Jürg Lehni
61fc75ace3
Some code clean-up.
2015-10-03 10:40:33 -05:00
Jürg Lehni
50c7473337
Improve CurveLocation#add() and #equals() to better merge locations.
...
Before, very close locations over curve boundaries where not merged.
2015-10-03 10:40:13 -05:00
Jürg Lehni
2167e458ae
Since we're using sorting now, we can add all start- / end-point intersections before finding the ones within the curves.
2015-10-03 10:38:45 -05:00
Jürg Lehni
7496a7c9e2
Try linked up intersections first before switching to the other intersecetion.
2015-10-02 19:00:32 -05:00
Jürg Lehni
632eb25f19
Bring back code removed in 11611c8fe2 again.
...
But add a _visited check, to get best of both approaches.
2015-10-02 18:57:45 -05:00
Jürg Lehni
00f1d5089f
Clean up Numerical code a bit.
2015-10-02 18:56:41 -05:00
Jürg Lehni
f6f9d963eb
Shorten Numerical.solveQuadratic() a bit.
2015-10-02 15:46:15 -05:00
sapics
c6de2f7f23
Fix to minimize floating point noise
2015-10-02 15:39:51 -05:00
Jürg Lehni
11611c8fe2
Remove isValid() check for current segment before attempting the switch.
...
This properly fixes example 14 in #784 .
2015-10-02 01:06:36 -05:00
Jürg Lehni
7f7d35a38a
Clean-up epsilon definitions.
2015-10-02 01:05:45 -05:00
Jürg Lehni
8dfa721e5a
Adjust debug rendering.
2015-10-01 21:12:15 -05:00
Jürg Lehni
a808aaf0fa
Remove unnecessary check for other === start.
2015-10-01 21:11:51 -05:00
Jürg Lehni
de57a7fbc8
Simplify tracePaths() code.
2015-10-01 21:09:30 -05:00
Jürg Lehni
c0bb6890bd
Switch back to CURVETIME_EPSILON now that overlap edge-case appears to be handled.
2015-10-01 20:47:56 -05:00
Jürg Lehni
4b4ccbac09
Make GEOMETRIC_EPSILON so that overlap edge-cases are correctly matched.
...
Relates to #784
2015-10-01 20:45:08 -05:00
Jürg Lehni
9b883e5fb6
Introduce new TRIGONOMETRIC_EPSILON with higher precision than GEOMETRIC_EPSILON.
2015-10-01 20:44:27 -05:00
Jürg Lehni
f5012a78e9
Reformat nested ternary operators again.
...
This got messed up in a recent refactoring.
2015-10-01 20:24:47 -05:00
Jürg Lehni
8aca088bf6
Clean-up splitPath() code a bit.
2015-10-01 09:41:57 -05:00
Jürg Lehni
72f9705615
Fix overeager refactoring in c77165be3a
2015-10-01 08:49:26 -05:00
Jürg Lehni
fee3a90329
Fixed leaked globals.
2015-10-01 07:05:00 -05:00
Jürg Lehni
b8c6eb46ad
Fix weirdness of Curve#divide() modifying the wrong Curve object.
2015-10-01 06:52:08 -05:00
Jürg Lehni
c77165be3a
Fix issue in Curve#divide() that lead to intersection segments being linked up wrongly.
...
Relates to #784
2015-10-01 06:21:17 -05:00
Jürg Lehni
53dd726057
Rename ignoreStraight argument to _setHandles
2015-10-01 05:55:22 -05:00
Jürg Lehni
0ca5a106de
Improve Line.intersect() comments.
2015-10-01 04:50:41 -05:00
Jürg Lehni
75a004187e
Improve Line.intersect() to more reliably find interesctions at the beginnings / ends.
...
Relates to #784
2015-10-01 04:38:48 -05:00
Jürg Lehni
53ff973f06
Perform the faster check first.
2015-10-01 03:38:35 -05:00
Jürg Lehni
5f706a4a5d
Use lower tolerance in bezier clipping code.
...
This really should be Numerical.CURVETIME_EPSILON, but I get better results using Numerical.GEOMETRIC_EPSILON. Perhaps Numerical.CURVETIME_EPSILON / 2 is the right value to use though.
2015-09-30 14:19:40 -05:00
Jürg Lehni
d385d25a51
Include comment regarding CurveLocation#equals() modification.
2015-09-30 13:48:28 -05:00
Jürg Lehni
9bcf369e6a
Ony split potentially self-intersecting curves if there are actual canditates.
2015-09-30 13:44:51 -05:00
Jürg Lehni
45040abc53
More clean-ups for #773
...
- Use local variables instead of array lookups for values used repeatetly, and merge with pre-existing variables.
- Add some more comments and reference to long explaining post in issue.
2015-09-30 13:40:01 -05:00
Jürg Lehni
1231153553
Start cleaning up code from #773
...
- Use Line object isntead of static methods
- Do not rely on Math.sign() as it's not supported on all browsers
- Wrap lines at 80 char width.
2015-09-30 13:07:55 -05:00
Jürg Lehni
2a7d1c5728
Improve CurveLocation#equals()
...
Relates to #784 , described in https://github.com/paperjs/paper.js/issues/784#issuecomment-143161586
2015-09-30 12:47:02 -05:00
Jürg Lehni
4e9bac1ca5
Fix code brokean in commit a869add90d
2015-09-30 12:39:59 -05:00
Jürg Lehni
07874034e9
Merge pull request #793 from iconexperience/Fix-for-#773
...
Fix for #773
2015-09-30 11:51:37 -05:00
Jan
ec70fa1806
Fix for #773
...
Indroduced more reliable method for finding self intersection on curves.
2015-09-30 12:19:09 +02:00
Jürg Lehni
a869add90d
Rename variables in Line.intersect()
2015-09-26 12:09:44 -05:00
