71 commits

Author	SHA1	Message	Date
DD Liu	bb9c318561	Rename variables to be not homonyms	2021-03-16 16:36:14 -04:00
DD Liu	627e62a339	Remove v2SvgAdapter	2021-03-04 15:32:14 -05:00
adroitwhiz	c30fcd23b5	grammar	2020-03-28 01:07:14 -04:00
adroitwhiz	5387f3a729	Clarify loadBitmap_ comments	2020-03-26 23:12:10 -04:00
adroitwhiz	a434bc5a34	Remove calls to updateDrawableSkinIdRotationCenter	2020-01-30 00:53:16 -05:00
DD Liu	cbb668a7ec	Update src/import/load-costume.js ... Thanks! Co-Authored-By: Karishma Chadha <kchadha@media.mit.edu>	2019-09-16 13:59:45 -04:00
DD Liu	82e0f71643	Move error log to right place	2019-09-13 16:15:36 -04:00
DD Liu	e447f003a1	Fix variable name	2019-09-04 11:26:23 -04:00
DD Liu	d3f687a6a7	use template	2019-08-23 17:31:11 -04:00
DD Liu	89db44bc6a	Give some indication of why asset load failed	2019-08-23 17:28:13 -04:00
Michael "Z" Goddard	d05a414439	turn getCanvas into a class CanvasPool	2019-03-06 10:53:15 -05:00
Michael "Z" Goddard	c01175613b	load-costume: idiomatic promise and createImageBitmap	2019-03-06 10:49:27 -05:00
Michael "Z" Goddard	9bd1bc5915	load-costume: use one canvas pool	2019-03-06 10:49:27 -05:00
Karishma Chadha	ed21af577c	Let errors from loadCostume bubble up so that we do not attempt to call installTargets on an invalid target (e.g. one that has no costumes).	2018-12-26 14:15:57 -05:00
Karishma Chadha	23298bd18f	Fix issue where uploading an sb with jpg images wasn't saving and loading properly.	2018-12-21 16:04:39 -05:00
Karishma Chadha	c38a054d4a	Fix issue where uploading the default vector image in place of a broken image was not correctly setting the costume's md5.	2018-12-20 19:29:37 -05:00
Katie Broida	5941b9173e	Use default builtin SVG asset for SVGs that can't be loaded for some reason	2018-12-19 14:34:18 -05:00
Karishma Chadha	c1b697b575	Compare asset type runtime formats instead of AssetType objects because costume assets can get flattened (e.g. while uploading a sprite from file).	2018-12-07 21:46:28 -05:00
Paul Kaplan	821dbb88d3	Remove promise finally because we are having trouble with polyfills	2018-12-03 16:47:46 -05:00
DD Liu	94227c00fa	Remove catches that do nothing	2018-11-21 12:01:48 -05:00
DD	c68da6605b	Move reject earlier and add loadedOne comment	2018-11-20 15:08:25 -05:00
DD	679ddf9fb7	Comment fixes and instantiate textImageElement only as necessary	2018-11-13 15:31:00 -05:00
DD	5ad193b96e	Better comment	2018-11-06 17:51:39 -05:00
DD	3c95b32da0	Rearrange so that if we already have the asset, there's no need to go through promise.all	2018-11-06 17:39:26 -05:00
DD	2a032be1a9	Remove todo	2018-11-06 17:34:07 -05:00
DD	6763355d00	Fix scaling to perform nearest neighbor	2018-11-06 17:22:25 -05:00
DD	2bd468950f	Why do our lint rules require such weird formatting	2018-11-06 16:54:41 -05:00
DD	998c5a186e	Merge images as part of fetch bitmap	2018-11-06 16:44:17 -05:00
DD	e538800293	Merge branch 'pull915' into textLayer	2018-11-06 10:39:43 -05:00
DD	876139847a	Merge branch 'develop' into pull915	2018-11-06 10:39:27 -05:00
DD	b6b3ca21d7	Load text layer asset	2018-11-06 10:36:52 -05:00
DD	86149325b1	Try to make loadCostume more readable, and revert deserializeCostume to changing the costume object directly	2018-11-05 17:11:07 -05:00
Ray Schamp	b47912dce4	Store asset objects on costumes and sounds ... Stop using storage for in-memory storage, and keep these on the vm objects. Towards https://github.com/LLK/scratch-vm/issues/1577	2018-10-23 11:10:50 +01:00
DD	06cb8e4b8a	Consistently return promises from functions that say they return promises	2018-10-03 14:58:36 -04:00
DD Liu	46918f266e	Add bitmap resolution so that required proptype warning stops	2018-07-12 17:25:53 -04:00
DD Liu	1c74c9028c	Better error handling	2018-07-12 17:18:38 -04:00
DD Liu	0258a7390f	Convert to node style callback and convert to bitmap resolution 2 always	2018-07-12 14:33:38 -04:00
DD Liu	747b4d1aed	Add bitmap resolution	2018-07-10 11:59:10 -04:00
DD Liu	6aefd13af6	Break load costume into more functions, and update how bitmaps are loaded	2018-07-10 10:30:38 -04:00
DD	7874ea9b1a	Allow rotation centers with zeros	2018-05-25 16:54:54 -04:00
DD	78e17b4842	Pass in argument to indicate compat mode	2018-05-11 14:24:07 -04:00
DD	589dd7d5e0	Attach the svg renderer instead of providing it in order to fix VM tests	2018-05-10 12:03:38 -04:00
DD	aae1e083bc	Switched textEncoder to costumeAsset.encodeTextData, and pass in version as an argument instead of in costume	2018-05-09 15:48:49 -04:00
DD	b9ce26918d	Fix review comments	2018-05-08 18:30:52 -04:00
DD	928245d5c9	Fix Edge	2018-05-08 14:25:32 -04:00
DD	296af1a079	Run quirks mode fixes on costumes loaded from sb2s	2018-05-08 12:03:34 -04:00
Karishma Chadha	af7ed61016	Fix bitmap support. In Scratch 3.0, we are defaulting to bitmapResolution = 2 for all costumes.	2018-04-22 21:22:03 -04:00
Karishma Chadha	54b52ba96c	Use calculated rotation center from renderer when rotation center is not provided with the costume being loaded.	2018-04-20 00:04:08 -04:00
Karishma Chadha	d6f28f2266	Correct what is being passed into scratch-render if some metadata (rotationCenter, bitmapResolution) is missing.	2018-04-18 14:21:29 -04:00
Paul Kaplan	89eb1ce39b	Set the costume asset size when a costume is loaded or modified.	2018-04-10 09:51:29 -04:00