Evelyn Eastmond
728e5e2d12
Renaming LONG_RAMP to RAMP and adding comment.
2019-06-23 21:23:28 -04:00
Evelyn Eastmond
f45539280a
Trying some different enum values and reorganizing the enums at top of file.
2019-06-23 21:23:28 -04:00
Evelyn Eastmond
fe43ecfa73
Renaming byte allocation enum values.
2019-06-23 21:23:28 -04:00
Evelyn Eastmond
1e124657e5
Fix comments and formatting.
2019-06-23 21:23:27 -04:00
Evelyn Eastmond
ca28b4ff1b
Fix device type return parsing to be clearer when it tries to avoid null values and convert them to 'none'.
2019-06-23 21:23:27 -04:00
Evelyn Eastmond
20b0d4da78
Remove some stale comments and add reminder to rename some byte value enums.
2019-06-23 21:23:27 -04:00
Evelyn Eastmond
f3d50dbe5a
Add global var index 0 value to enum.
2019-06-23 21:23:27 -04:00
Evelyn Eastmond
63d9b0249a
Removed a TODO and clarified with a better comment.
2019-06-23 21:23:27 -04:00
Evelyn Eastmond
5314be8310
More byte value updates, and change global index comments.
2019-06-23 21:23:27 -04:00
Evelyn Eastmond
50c80a8abc
Adding comment to explain byte value enum values.
2019-06-23 21:23:27 -04:00
Evelyn Eastmond
14e8a93ac6
Add global var 1-byte-to-follow to enum.
2019-06-23 21:23:27 -04:00
Evelyn Eastmond
f8d9f687ec
Move Ev3 byte values into their own enum, separate from parameter values.
2019-06-23 21:23:27 -04:00
Evelyn Eastmond
c237f1326d
Clean up some null checks.
2019-06-23 21:23:27 -04:00
Evelyn Eastmond
6b9c3d12ef
Shorten a comment.
2019-06-23 21:23:27 -04:00
Evelyn Eastmond
b476169f84
Change variable name to be shorter / more legible.
2019-06-23 21:23:27 -04:00
Evelyn Eastmond
6284cbdd85
Removing todo, decided not to rename.
2019-06-23 21:23:27 -04:00
Evelyn Eastmond
6c706b410f
Removing label.
2019-06-23 21:23:27 -04:00
Chris Willis-Ford
c6b63a8f09
Merge pull request #2143 from cwillisf/non-droppable-extension-menus
...
support non-droppable menus in extensions
2019-06-18 21:18:10 -07:00
Karishma Chadha
aae7607e10
fix extension dropdown menu item conversion
2019-06-18 21:03:17 -07:00
Chris Willis-Ford
eba89d57d8
Merge branch 'develop' into non-droppable-extension-menus
2019-06-18 16:52:47 -07:00
Karishma Chadha
9af2e4c086
Merge pull request #2161 from LLK/e16n
...
Supporting VM changes for extensionification
2019-06-18 18:53:20 -04:00
Christopher Willis-Ford
fd776025e5
refactor _refreshExtensionPrimitives for clarity
...
The previous form made it harder to see that at most one extension
category is handled per call.
2019-06-18 15:08:03 -07:00
Chris Willis-Ford
edd6aafed0
call out capitalization change since it's important but easy to miss
...
Co-Authored-By: Karishma Chadha <kchadha@media.mit.edu>
2019-06-18 15:07:58 -07:00
Christopher Willis-Ford
3c28f714bb
respond to code review
2019-06-17 21:14:21 -07:00
Chris Willis-Ford
18b1551cdb
remove redundant check
...
Co-Authored-By: Karishma Chadha <kchadha@media.mit.edu>
2019-06-17 13:22:52 -07:00
Evelyn Eastmond
f3f307b59c
Merge pull request #2207 from evhan55/ergonomics/2017
...
Removing comment in WeDo2 extension
2019-06-17 12:19:42 -04:00
Evelyn Eastmond
e732d9f3b6
Merge pull request #2194 from evhan55/ergonomics/1974
...
GDXFOR: Rename scratchLinkSocket variables to 'socket' and 'ble'
2019-06-17 11:59:25 -04:00
Christopher Willis-Ford
33a6071466
for compatibility, make all existing extension menus accept reporters
2019-06-14 12:29:32 -07:00
Christopher Willis-Ford
cfee656306
fix tests: empty menus
shouldn't be an array
2019-06-14 12:29:32 -07:00
Christopher Willis-Ford
3fbed88a95
switch from rejectReporters
flag to acceptReporters
...
Also add more extensive documentation around extension menu definitions,
including some considerations to think about before making a menu accept
reporters.
2019-06-14 12:29:32 -07:00
Christopher Willis-Ford
e7bf49c8df
support non-droppable menus in extensions
2019-06-14 12:29:32 -07:00
Christopher Willis-Ford
ab715901a6
add tests for new e16n support features
2019-06-12 13:01:28 -07:00
Evelyn Eastmond
418cd0a0f4
Removing comment after decision that this function name is accurate and distinct from coastAfter.
2019-06-12 10:20:21 -04:00
Evelyn Eastmond
f192c181bd
Rename scratchLinkSocket variables to 'socket' and 'ble' to avoid confusion with upcoming ScratchLinkWebSocket class.
2019-06-12 09:01:49 -04:00
picklesrus
b88d5d05b0
Merge pull request #2084 from picklesrus/update-languages-in-translate-list
...
Fixing some translate language menu bugs.
2019-06-10 11:13:52 -04:00
picklesrus
2ea04091e4
package-lock changes to go along with package.json update
2019-06-10 11:05:23 -04:00
Paul Kaplan
f74bf88ce3
Merge pull request #2197 from ericrosenbaum/bugfix/update-sound-duration
...
Update sound duration
2019-06-06 14:05:44 -04:00
Eric Rosenbaum
8243d0f53a
Update sound sampleCount and rate
2019-06-05 17:06:27 -04:00
Evelyn Eastmond
6c2d5b8a83
Merge pull request #2070 from evhan55/extensions/ev3-rate-limiting
...
Add RateLimiter to EV3
2019-06-04 17:12:59 -04:00
Eric Rosenbaum
b6a33cc3ed
Merge branch 'develop' into extensions/ev3-rate-limiting
2019-06-04 11:37:43 -04:00
Evelyn Eastmond
6e80c92703
Merge pull request #2191 from evhan55/bt-pairing-changes
...
Add optional 'pin' parameter to BT connections
2019-06-04 11:26:47 -04:00
Paul Kaplan
6b04f62863
Merge pull request #2182 from paulkaplan/scratch-link-socket
...
Initial prototype of configurable scratch link socket
2019-06-04 10:11:22 -04:00
Evelyn Eastmond
ae791b3f26
Don't send null pin.
2019-05-31 11:27:20 -04:00
Evelyn Eastmond
b6913b7828
Move EV3 pin to a static var.
2019-05-31 11:14:32 -04:00
Evelyn Eastmond
8e302ac90c
Add optional pin parameter to peripheral connection.
2019-05-31 11:10:13 -04:00
Paul Kaplan
615f60252d
Set connected to false before closing to prevent infinite loop
...
There is an implicit assumption that socket.close is async, but if it is sync, it may go into an infinite loop of close callbacks if the connected flag is not set to false before trying to close
Co-Authored-By: chrisgarrity <chrisg@media.mit.edu>
2019-05-31 09:42:00 -04:00
Paul Kaplan
706354d2f0
Update documentation about required methods on ScratchLinkSocket
...
Co-Authored-By: chrisgarrity <chrisg@media.mit.edu>
2019-05-31 08:55:20 -04:00
Paul Kaplan
64cff3d161
Fix documentation on what methods to implement for ScratchLinkSocket
...
Co-Authored-By: chrisgarrity <chrisg@media.mit.edu>
2019-05-31 08:41:20 -04:00
Paul Kaplan
94afd58b2f
Require handleMessage to be set before opening scratch-link-socket
2019-05-31 08:35:27 -04:00
Paul Kaplan
5e626eb7e9
Initial prototype of configurable scratch link socket
2019-05-24 12:51:58 -04:00