Commit graph

1269 commits

Author SHA1 Message Date
Jonathan Puckey
8f5f5ee43c Tests: add cloneAndCompare and compareItems helper functions. 2011-05-20 19:39:12 +02:00
Jonathan Puckey
013fe56ea4 Item#_clone: check if the item has a _pathStyle property before copying it. 2011-05-20 19:35:26 +02:00
Jürg Lehni
777cc95dc3 Rename proj -> project in all tests. 2011-05-20 14:08:17 +01:00
Jürg Lehni
84b1d865c1 Remove unused variable. 2011-05-20 14:08:04 +01:00
Jürg Lehni
be63d2cf07 Remove empty line. 2011-05-20 14:04:35 +01:00
Jürg Lehni
631923669a Eliminate some of the TODOs. 2011-05-20 14:00:27 +01:00
Jürg Lehni
0a87eef244 Add comment about PointText#matrix and #point being exposed. 2011-05-20 08:56:14 +01:00
Jürg Lehni
ec0484e798 Define Symbol#clone(), needs testing. 2011-05-20 08:55:44 +01:00
Jürg Lehni
5713bc07f2 Define PlacedSymbol#clone(), needs testing. 2011-05-20 08:55:35 +01:00
Jürg Lehni
b15eecc34d Use new internal Item#_clone() to improve Path#clone() and PointText#clone(). 2011-05-20 08:54:44 +01:00
Jürg Lehni
87d340e525 Introduce private Item#_clone(copy), so subclasses can override the way the copy is actually produced, e.g. providing parameters to the constructor. 2011-05-20 08:50:09 +01:00
Jürg Lehni
fd8ceb9641 Implement PointText#clone(), untested. 2011-05-20 08:47:13 +01:00
Jürg Lehni
4ceaca00f4 Initialise content to empty string, so content += 'something' would not produce odd results. 2011-05-20 08:46:58 +01:00
Jürg Lehni
e7cad9b134 Use local point in translate, as it is not a LinkedPoint and won't require beans access. 2011-05-20 08:46:17 +01:00
Jürg Lehni
01f26c4be0 Restructure line break. 2011-05-20 08:40:35 +01:00
Jürg Lehni
131425a12f Rely on #_transform() in #setPoint() as it already handles updating of #_point for us and all. 2011-05-20 08:33:19 +01:00
Jürg Lehni
2e82ac97d8 Convert PointText#point to a LinkedPoint so direct changes to it get noticed too. 2011-05-20 08:32:36 +01:00
Jürg Lehni
d6a49e2eb4 No need to check result of Point.read(), as it will always be a Point (_readNull is only defined for Color). 2011-05-20 08:28:49 +01:00
Jürg Lehni
4153bc0fbf Fix bug in PointText#_transform(), where wrong version of matrix._transformPoint() was applied to _point, resulting in no transformation. 2011-05-20 08:27:11 +01:00
Jürg Lehni
eb2dc011f4 Merge with conflicting commit which addressed same optimisation. 2011-05-20 08:12:40 +01:00
Jürg Lehni
10dadb80f2 Move isHue check outside of setter. 2011-05-20 08:08:26 +01:00
Jonathan Puckey
d25ca35b37 Optimize comparison, by precalculating string comparison. 2011-05-19 23:56:29 +02:00
Jürg Lehni
1c479f315e Add some comments to Item#clone(). 2011-05-19 22:09:51 +01:00
Jürg Lehni
8a8c68b3d6 Define #clone() for various Gradient classes. Needs testing. 2011-05-19 22:02:26 +01:00
Jürg Lehni
38ddd34589 Replace beans access with internal property. 2011-05-19 22:00:03 +01:00
Jürg Lehni
276eb3301e Define scafold #clone() function for the classes that still required a proper definition. 2011-05-19 21:56:49 +01:00
Jürg Lehni
7401e42316 Implement #clone() for Item, Group and Path. Needs testing. 2011-05-19 21:56:23 +01:00
Jürg Lehni
b52abbfbc1 Replace removed 'hidden' property with 'visible'. 2011-05-19 21:55:51 +01:00
Jürg Lehni
2dcb09a662 Define Path#clone(). 2011-05-19 21:34:19 +01:00
Jürg Lehni
6348f94362 Optimise Gradient constructor. 2011-05-19 20:54:52 +01:00
Jürg Lehni
8eea7e15d4 Give GradientStop a proper #initialize() function and use GradientStop.readAll() in Gradient#setStops() with some added magic to automatically assign rampPoints if they were not specified. 2011-05-19 20:51:09 +01:00
Jürg Lehni
fcb8242da8 Restructure #initialize() in basic types to use direct arguments checking more than arguments.length. 2011-05-19 20:37:04 +01:00
Jürg Lehni
404e61ebff Remove deleted files from load.js and paper.js. 2011-05-19 20:28:45 +01:00
Jürg Lehni
6685d09801 Add missing semicolon. 2011-05-19 20:21:42 +01:00
Jürg Lehni
ef4e80ecef Replace getter calls with direct access of internal properties. 2011-05-19 20:21:22 +01:00
Jürg Lehni
a035f645fc Replace unneeded beans access with local variable. 2011-05-19 20:20:32 +01:00
Jürg Lehni
1473d82456 Variable chaining. 2011-05-19 20:20:01 +01:00
Jürg Lehni
32fb1b065e No need to check for colorType since #convert() already performs this optimisation. 2011-05-19 20:19:36 +01:00
Jürg Lehni
3b9369fafb Handle special setter for hue in Color.extend() as well, and move defintion of various Color classes to Color file since they are one-liners now. 2011-05-19 19:00:36 +01:00
Jürg Lehni
57b194e047 Add explaining comments to Raster#getAverageColor() code. 2011-05-19 18:51:13 +01:00
Jürg Lehni
e8d4a16ab2 Shorten Raster#getAverageColor(). 2011-05-19 18:47:49 +01:00
Jürg Lehni
b103af4216 Merge remote-tracking branch 'origin/master' 2011-05-19 18:35:45 +01:00
Jürg Lehni
09612c4623 Remove the versions of #clone() that follow the scheme provided by Base#clone() now. 2011-05-19 18:35:38 +01:00
Jürg Lehni
b37ba3d858 Add a generic clone() method to all classes through Base which creates a new item using the constructor and passing 'this'. 2011-05-19 18:34:22 +01:00
Jürg Lehni
6854f7d026 Update comments in bootstrap.js. 2011-05-19 18:33:34 +01:00
Jonathan Puckey
a7fc55c998 Small update to Phyllotaxis Raster. 2011-05-19 18:42:03 +02:00
Jonathan Puckey
9c9b498e4a Simplify Extruded example. 2011-05-19 17:16:19 +02:00
Jonathan Puckey
958c19c572 Update Chain example. 2011-05-19 17:15:42 +02:00
Jonathan Puckey
1e18c38d35 Optimize the PhyllotaxisRaster example and use an image of a sunflower. 2011-05-19 17:00:08 +02:00
Jonathan Puckey
f965e53a06 Optimize Path#getAverageColor 2011-05-19 15:43:23 +02:00