72 commits

Author	SHA1	Message	Date
Jürg Lehni	7e7944e6f4	Fix recently introduced error in Color, by setting internal properties directly.	2011-05-21 00:40:20 +01:00
Jürg Lehni	631923669a	Eliminate some of the TODOs.	2011-05-20 14:00:27 +01:00
Jürg Lehni	10dadb80f2	Move isHue check outside of setter.	2011-05-20 08:08:26 +01:00
Jürg Lehni	6685d09801	Add missing semicolon.	2011-05-19 20:21:42 +01:00
Jürg Lehni	ef4e80ecef	Replace getter calls with direct access of internal properties.	2011-05-19 20:21:22 +01:00
Jürg Lehni	a035f645fc	Replace unneeded beans access with local variable.	2011-05-19 20:20:32 +01:00
Jürg Lehni	1473d82456	Variable chaining.	2011-05-19 20:20:01 +01:00
Jürg Lehni	32fb1b065e	No need to check for colorType since #convert() already performs this optimisation.	2011-05-19 20:19:36 +01:00
Jürg Lehni	3b9369fafb	Handle special setter for hue in Color.extend() as well, and move defintion of various Color classes to Color file since they are one-liners now.	2011-05-19 19:00:36 +01:00
Jürg Lehni	106719597b	Further simplify Color code by moving components definitions to one object.	2011-05-18 21:21:28 +01:00
Jürg Lehni	a17f7865a3	Simplify Color subclass construction by moving beans producing code into an extended Color.extend() function that handles it for us.	2011-05-18 21:11:59 +01:00
Jürg Lehni	dfc6a05969	Shorten some converters a bit.	2011-05-18 20:40:52 +01:00
Jürg Lehni	9b95ba095c	Don't capitalize twice.	2011-05-18 20:37:09 +01:00
Jürg Lehni	d643ac7626	Less cryptic code without Base.each() side-car makes more sense here.	2011-05-18 20:36:24 +01:00
Jürg Lehni	2367cfa6f2	Simplify Color code by merging all injection scopes to one.	2011-05-18 20:35:18 +01:00
Jürg Lehni	86ca1ed1e7	Add comment explaining color conversion code.	2011-05-18 15:37:01 +01:00
Jürg Lehni	6fc418b581	Fix accidentally reversed change and clean up code a bit.	2011-05-15 15:12:59 +01:00
Jürg Lehni	252a3635dc	Replace {@true} tags in documentation ({@true ([^}]*)} -> true $1, false otherwise.)	2011-05-15 15:06:10 +01:00
Jonathan Puckey	f8f6754068	Fix mistake in earlier commit.	2011-05-15 14:26:08 +02:00
Jonathan Puckey	2c36f3a62e	Fix bug in Color#read.	2011-05-15 14:11:35 +02:00
Jürg Lehni	b50b0f9e5a	Fix bug in Color#equals() resulting in it always returning true.	2011-05-05 13:19:36 +01:00
Jürg Lehni	5dfec35dc1	Allow colors to be compare to null.	2011-05-05 11:20:26 +01:00
Jürg Lehni	bc80c58558	Add Base.formatNumber() to format numbers in the same way as Scriptographer (precision of up to 5 fractional digits) and use it in the various #toString() functions.	2011-05-04 19:42:50 +01:00
Jürg Lehni	26b70309a8	Improve various #toString() functions.	2011-05-02 08:57:55 +01:00
Jürg Lehni	4d999d57e2	Replace all type converting string compares with ===, !==.	2011-04-28 13:23:17 +01:00
Jürg Lehni	ac5dca4fc0	Update various comments about TODOs.	2011-04-26 17:04:15 +01:00
Jürg Lehni	aae88d7568	Optimise chained return statements.	2011-03-14 22:13:01 +01:00
Jürg Lehni	f02b7031a9	Reintroduce accidentally removed definition of _readNull: true.	2011-03-14 22:08:07 +01:00
Jürg Lehni	a48c130965	Improve comments.	2011-03-14 22:07:21 +01:00
Jonathan Puckey	46ee4c517d	Optimize nameToRGBColor to also handle strings like rgb(0, 0, 0).	2011-03-14 13:54:57 +01:00
Jürg Lehni	bfd43b27fa	Improve commens and get rid of for loop to in nameToRGBColor().	2011-03-13 23:00:01 +01:00
Jürg Lehni	1c8c64c473	One more nameToRGBColor() simplification, by reversing return logic.	2011-03-13 22:57:01 +01:00
Jürg Lehni	a842b5faa6	Simplify nameToRGBColor() further: No need to create function in its own scope, simply use the inject scope to contain cache and context variables.	2011-03-13 22:55:20 +01:00
Jürg Lehni	21aa12271e	Simplify nameToRGBColor() code a little: Shorter variables names, no need to save and restore context, as all we do is fillRect().	2011-03-13 22:53:32 +01:00
Jonathan Puckey	e0753179e3	Clean up last commit a bit.	2011-03-13 20:16:04 +01:00
Jonathan Puckey	0d173e39bf	Merge remote branch 'origin/master'	2011-03-13 20:15:00 +01:00
Jonathan Puckey	b004a83361	Color: avoid huge named color lookup table by drawing the named color on a canvas and reading its components.	2011-03-13 20:14:16 +01:00
Jürg Lehni	cd80db14d8	Rearrange color converters to group by pairs.	2011-03-13 18:41:32 +01:00
Jürg Lehni	d5fa3d7ae6	Merge remote-tracking branch 'origin/master' ... Conflicts: src/item/Raster.js	2011-03-13 18:34:05 +01:00
Jürg Lehni	9d4af0ce9e	Clean up recently caused Base.read() mess by introducing _readNull property,m setting it to true on Color and reverting to previous behavior for Point, Size and Rectangle, where dimensions of 0 are read by default if nothing is provided.	2011-03-13 18:31:00 +01:00
Jonathan Puckey	5079259a8e	Small change to Color.	2011-03-12 15:16:17 +01:00
Jonathan Puckey	f57a7ba0d9	Use Math.min / Math.max to clamp component values in color classes.	2011-03-09 16:48:53 +01:00
Jonathan Puckey	08d66ae231	Color: small change.	2011-03-09 15:50:32 +01:00
Jonathan Puckey	87de9f4fa8	Further refactoring in Color.	2011-03-09 15:25:41 +01:00
Jonathan Puckey	30d2f16c8c	Color: save a var statement.	2011-03-09 15:00:13 +01:00
Jürg Lehni	41ce6279f1	Merge remote-tracking branch 'origin/master' ... Conflicts: src/color/Color.js	2011-03-09 13:34:13 +00:00
Jürg Lehni	9fd0381b82	Minor clean-ups.	2011-03-09 13:31:40 +00:00
Jonathan Puckey	b7902635bf	Color#setAlpha: comment out code using Math.min and Math.max, which was supposed to just be there to explain what is happening.	2011-03-09 14:31:30 +01:00
Jonathan Puckey	bda24fbd54	Color: simplify stringToRGB again.	2011-03-09 14:29:19 +01:00
Jonathan Puckey	eacf346aab	Color: reintroduce hexToRGB to be called from stringToRGB.	2011-03-09 14:23:18 +01:00