Previously, when diplomats submit translations, the system
would try to figure out whether it should be a 'patch' or a 'change',
and then would either create a patch for an admin or artisan to
review and accept or reject, or would apply the changes immediately
and they would be live. This was done as a compromise between
getting translations live quickly, but also preventing already-translated
text from getting overwritten without oversight.
But having the client handle this added logical complexity. So
this makes all diplomats submit patches, no matter what. The server
is then in charge of deciding if it should auto-accept the patch or not.
Either way, a patch is created.
There was also much refactoring. This commit includes:
* Update jsondiffpatch so changes within array items are handled correctly
* Refactor posting patches to use the new auto-accepting logic, and out of Patch model
* Refactor POST /db/patch/:handle/status so that it doesn't rely on handlers
* Refactor patch stat handling to ensure auto-accepted patches are counted
* Refactor User.incrementStat to use mongodb update commands, to avoid race conditions
* Refactor Patch tests
When a new version is created, the latest version is updated, then
the new one is made. If making a new one fails (most commonly due to
a name conflict), the latest version is left in a broken state. Set up
the new middleware to revert changes to latest version in this case,
and update the level handler to use the middleware. Also added
warning logs if models do not have editableProperties or postEditableProperties
set.
Address some code review feedback
Correct error code in test
Don't try to send emails to empty addresses
Add tests for subscriptions
Add tests for Next Steps email
Fix specs
Add reason for disabled test
Update classroom and gameplay Ux to surface practice levels as 3a, 3b,
etc.
Update next level logic to leverage practice levels based on per level
completion playtime thresholds.
Patrol buster and patrol buster A are live for testing.
Fix a few classroom Ux progress hover bubble info bugs.
Closes#3767
Hide TeachersContactModal after sending message
Fix GET /db/level/:handle/session, more extensively test
Fix EnrollmentView number of students input to stop losing focus on input
Fix EnrollmentsView syntax
Fix ActivateLicensesModal "Get Enrollments" button when already in the enrollments page
Update EnrollmentsView with new credit numbers when ActivateLicensesModal closes
Hide search box in TeacherClassView "Enrollment Status" tab
Tweak EnrollmentsView styling
Fix EnrollmentsView tests
Fix AnalyticsView
Make EnrollmentsView more explicitly handle undefined and empty array prepaid groups
Remove log
CoursesView handles JoinClassModal cancel
Re-enable EditStudentModal set password button when the form changes
Fix course instance tests, next level endpoint bug
Fix EditStudentModal tests
Fix link to /teachers/classes (fixes bugquest#20)
Fix edit button color/icon (bugquest#23)
Fix bugquest#34
Fix password input width (bugquest#33)
Center new pasword text
Fix teacher password reset endpoint (bugquest#4)
Refactor+use NewHomeView logic for user page button (Fixes bugquest#2)
Refactor teacher-password-reset endpoint
This makes it much easier to prevent collisions with other logic when PUTing new User attributes.
Add regression test for converting to teacher account
Fix email verified links, require login (fix bugquest#16)
Fix me having stale emailVerified value (Fixes bugquest#40)
Don't show JoinClassModal to students
Add paragraph to JoinClassModal (fixes bugquest#14)
Update change-password label text (fixes bugquest#30)
Fix prompting for login on Account Settings page (bugquest #10)
Show validation errors for teacher password reset (bugquest#36)
Show yellow progress dot in My Classes if anyone has started (bugquest#55)
Remove confusing text (bugquest#100)
* Refactor several related endpoints and views
* Redesign EnrollmentView, add TeacherContactModal
* Add "Enrollment Status" tab to TeacherClassView
* Delete PurchaseCoursesView and related files
* Style-flatten RemoveStudentModal
* Fix error handling in ActivateLicensesModal
* TeacherCoursesView loads faster by only loading course campaigns, and not load prepaids
This adds the ability to verify email addresses of a user, so we know they have access to the email address on their account.
Until a user has verified their email address, any teacher of a class they're in can reset their password for them via the Teacher Dashboard. When a user's email address is verified, a teacher may trigger a password recovery email to be sent to the student.
Verification links are valid forever, until the user changes the email address they have on file. They are created using a timestamp, with a sha256 of timestamp+salt+userID+email. Currently the hash value is rather long, could be shorter.
Squashed commit messages:
Add server endpoints for verifying email address
Add server endpoints for verifying email address (pt 2)
Add Server+Client endpoint for sending verification email
Add client view for verification links
Add Edit Student Modal for resetting passwords
Add specs for EditStudentModal
Tweak method name in EditStudentModal
Add edit student button to TeacherClassView
Fix up frontend for teacher password resetting
Add middleware for teacher password resetting
Improve button UX in EditStudentModal
Add JoinClassModal
Add welcome emails, use broad name
Use email without domain as fallback instead of full email
Fetch user on edit student modal open
Don't allow password reset if student email is verified
Set role to student on user signup with classCode
Tweak interface for joinClassModal
Add button to request verification email for yourself
Fix verify email template ID
Move text to en.coffee
Minor tweaks
Fix code review comments
Fix some tests, disable a broken one
Fix misc tests
Fix more tests
Refactor recovery email sending to auth
Fix overbroad sass
Add options to refactored recovery email function
Rename getByCode to fetchByCode
Fix error message
Fix up error handling in users middleware
Use .get instead of .toObject
Use findById
Fix more code review comments
Disable still-broken test
