Merge d86830028e into 01807fedc9

lets not forget to write docs for this..

.github/actions/build-debug-info-post/action.yml

@@ -1,4 +1,4 @@
-name: Prepare for Build Debug Info
+name: Prepare for Build Debug Info
 description: Provides debug info for the build process
 
 inputs:
@@ -16,7 +16,15 @@ runs:
         cd build
         sed 's/\\\\/\//g' compile_commands.json | sed 's/D:\//\/d\//' > uni_compile_commands.json
         pip install compile-commands --break-system-packages
-      compile-commands --file=uni_compile_commands.json --filter_files='.*info\.rc.*' --filter='(.*) -o (.*)((?:/|\\).*)\.(?:obj|o) -c (.*)' --replacement="$BASH"' --noprofile --norc -c "mkdir -p ../build-debug-info-preprocessed/\g<2> && \g<1> -o ../build-debug-info-preprocessed/\g<2>\g<3>.i -E \g<4>"' -o ../build-debug-info/preprocess_commands.json --run --verbose
+        compile-commands --file=uni_compile_commands.json \
+          --filter_files='.*info\.rc.*' \
+          --filter='(.*) -o (.*)((?:/|\\).*)\.(?:obj|o) -c (.*)' \
+          --replacement="$BASH" \
+          --noprofile --norc -c "\
+            mkdir -p ../build-debug-info-preprocessed/\g<2> && \
+            \g<1> -o ../build-debug-info-preprocessed/\g<2>\g<3>.i -E \g<4>"' \
+          -o ../build-debug-info/preprocess_commands.json \
+          --run --verbose
 
     - name: Upload Build Debug Info
       uses: actions/upload-artifact@v4

.github/actions/build-debug-info/action.yml

@@ -1,16 +1,18 @@
-name: Prepare for Build Debug Info
+name: Prepare for Build Debug Info
 description: Provides debug info for the build process
 
 inputs:
   has-sccache:
     description: 'Whether the build action has sccache'
     required: true
+
 outputs:
   extra-configure:
     description: 'Extra stuff for CMake configure step'
     value: |
       -DCMAKE_EXPORT_COMPILE_COMMANDS=ON
       cp ./build/compile_commands.json ./build-debug-info/
+
   extra-build:
     description: 'Extra stuff for CMake build step'
     value: |
@@ -28,7 +30,7 @@ runs:
         echo "SCCACHE_LOG=debug" >> $GITHUB_ENV
         echo "RUST_BACKTRACE=1" >> $GITHUB_ENV
 
-  - name: Checkout ninjatracing
+    - name: Checkout ninjatracing repository
       uses: actions/checkout@v4
       with:
         repository: 'nico/ninjatracing'

.github/workflows/build.yml

@@ -36,7 +36,7 @@ jobs:
     runs-on: ubuntu-24.04
 
     steps:
-    - name: Checkout
+      - name: Checkout repository
         uses: actions/checkout@v4
         with:
           submodules: recursive
@@ -64,7 +64,7 @@ jobs:
         uses: geode-sdk/cli/.github/actions/setup@main
 
       - name: Download xwin
-      uses: robinraju/release-downloader@v1.10
+        uses: robinraju/release-downloader@v1
         with:
           repository: Jake-Shadle/xwin
           latest: true
@@ -79,8 +79,6 @@ jobs:
           mv epic-xwin/xwin-*-x86_64-unknown-linux-musl/xwin ./xwin
           ./xwin --arch x86_64 --sdk-version 10.0.22621 --accept-license list
 
-    # this caches '.xwin-cache/**/*' but that's actually only gonna
-    # contain the manifest cuz we only ran `xwin list` so far
       - name: Setup xwin Cache
         id: xwin-cache
         uses: actions/cache@v4
@@ -111,18 +109,18 @@ jobs:
           ${{ env.base-build-command }}
           ${{ steps.build-debug-info.outputs.extra-build }}
 
-    - name: Upload Artifacts
+      - name: Upload artifacts
         uses: actions/upload-artifact@v4
         with:
           name: geode-win
           path: ./bin/nightly
 
-    - name: Package Installer
+      - name: Package installer
         run: |
           sudo apt install nsis
           makensis -WX -V3 ./installer/windows/installer.nsi
 
-    - name: Upload Installer
+      - name: Upload installer
         uses: actions/upload-artifact@v4
         with:
           name: geode-installer-win
@@ -142,7 +140,7 @@ jobs:
       SCCACHE_CACHE_MULTIARCH: 1
 
     steps:
-    - name: Checkout
+      - name: Checkout repository
         uses: actions/checkout@v4
         with:
           submodules: recursive
@@ -154,8 +152,7 @@ jobs:
           has-sccache: ${{ inputs.use-ccache }}
         if: inputs.build-debug-info
 
-    # due to very strange performance issues, sccache is currently disabled for macos. sorry
-
+      # macOS does not currently support sccache due to performance issues
       # - name: Setup caches
       #   uses: ./.github/actions/setup-cache
       #   with:
@@ -186,16 +183,16 @@ jobs:
           ${{ env.base-build-command }}
           ${{ steps.build-debug-info.outputs.extra-build }}
 
-    - name: Upload Artifacts
+      - name: Upload artifacts
         uses: actions/upload-artifact@v4
         with:
           name: geode-mac
           path: ./bin/nightly
 
-    - name: Package Installer
+      - name: Package installer
         run: ./installer/mac/package.sh ./bin/nightly ./installer/mac/geode-installer-mac.pkg
 
-    - name: Upload Installer
+      - name: Upload installer
         uses: actions/upload-artifact@v4
         with:
           name: geode-installer-mac
@@ -215,7 +212,6 @@ jobs:
           - name: Android (32-bit)
             id: android32
             extra-configure: -DANDROID_ABI=armeabi-v7a
-
           - name: Android (64-bit)
             id: android64
             extra-configure: -DANDROID_ABI=arm64-v8a
@@ -224,7 +220,7 @@ jobs:
     runs-on: ubuntu-latest
 
     steps:
-    - name: Checkout
+      - name: Checkout repository
         uses: actions/checkout@v4
         with:
           submodules: recursive
@@ -277,13 +273,12 @@ jobs:
           ${{ env.base-build-command }}
           ${{ steps.build-debug-info.outputs.extra-build }}
 
-    # hardcoding toolchain path :(
-    - name: Dump Symbols
+      - name: Dump symbols
         run: |
           ${{ steps.breakpad-tools.outputs.binary-path }} ./bin/nightly/Geode.${{ matrix.config.id }}.so -o ./bin/nightly/Geode.${{ matrix.config.id }}.so.sym
           $ANDROID_NDK_LATEST_HOME/toolchains/llvm/prebuilt/linux-x86_64/bin/llvm-strip ./bin/nightly/Geode.${{ matrix.config.id }}.so
 
-    - name: Upload Artifacts
+      - name: Upload artifacts
         uses: actions/upload-artifact@v4
         with:
           name: geode-${{ matrix.config.id }}
@@ -300,55 +295,56 @@ jobs:
     runs-on: ubuntu-latest
     needs: [ build-windows, build-mac, build-android ]
     if: github.ref == 'refs/heads/main'
+
     steps:
-      - name: Checkout
+      - name: Checkout repository
         uses: actions/checkout@v4
 
-      - name: Declare Version Variables
+      - name: Declare version variables
         id: ref
         run: |
           echo "version=$(cat VERSION | xargs)" >> $GITHUB_OUTPUT
           echo "hash=$(git rev-parse --short "$GITHUB_SHA")" >> $GITHUB_OUTPUT
 
-      - name: Download Artifacts
+      - name: Download artifacts
         uses: actions/download-artifact@v4
 
-      - name: Move Installers
+      - name: Move installers
         run: |
           mv geode-installer-mac/geode-installer-mac.pkg geode-installer-${{ steps.ref.outputs.hash }}-mac.pkg
           mv geode-installer-win/geode-installer-win.exe geode-installer-${{ steps.ref.outputs.hash }}-win.exe
 
-      - name: Zip MacOS Artifacts
+      - name: Zip MacOS artifacts
         uses: vimtor/action-zip@v1.2
         with:
           files: geode-mac/Geode.dylib geode-mac/GeodeBootstrapper.dylib
           dest: geode-${{ steps.ref.outputs.hash }}-mac.zip
 
-      - name: Zip Windows Artifacts
+      - name: Zip Windows artifacts
         uses: vimtor/action-zip@v1.2
         with:
           files: geode-win/XInput1_4.dll geode-win/Geode.dll geode-win/GeodeUpdater.exe geode-win/Geode.lib geode-win/Geode.pdb
           dest: geode-${{ steps.ref.outputs.hash }}-win.zip
 
-      - name: Zip Android32 Artifacts
+      - name: Zip Android32 artifacts
         uses: vimtor/action-zip@v1.2
         with:
           files: geode-android32/Geode.android32.so geode-android32/Geode.android32.so.sym
           dest: geode-${{ steps.ref.outputs.hash }}-android32.zip
 
-      - name: Zip Android64 Artifacts
+      - name: Zip Android64 artifacts
         uses: vimtor/action-zip@v1.2
         with:
           files: geode-android64/Geode.android64.so geode-android64/Geode.android64.so.sym
           dest: geode-${{ steps.ref.outputs.hash }}-android64.zip
 
-      - name: Zip Resources
+      - name: Zip resources
         uses: vimtor/action-zip@v1.2
         with:
           files: geode-android64/resources
           dest: resources.zip
 
-      - name: Update Development Release
+      - name: Update development release
         uses: andelf/nightly-release@main
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

.github/workflows/check-changelog.yml

@@ -1,5 +1,4 @@
-# check the changelog for non ascii characters
-name: Check CHANGELOG.md
+name: Check Changelog
 
 on:
   push:
@@ -11,16 +10,19 @@ on:
 
 jobs:
   check:
-    name: Check CHANGELOG.md
+    name: Check Changelog
     runs-on: ubuntu-latest
     steps:
-      - name: Checkout
+      - name: Checkout repository
         uses: actions/checkout@v4
         with:
           submodules: recursive
 
-      - run: |
-          if grep -q -P -n "[\x80-\xFF]" CHANGELOG.md
-          then
-              exit 1;
+      - name: Check for non-ASCII characters in changelog
+        run: |
+          if grep -q -P -n "[\x80-\xFF]" CHANGELOG.md; then
+            echo "Non-ASCII characters found in CHANGELOG.md"
+            exit 1
+          else
+            echo "No non-ASCII characters found in CHANGELOG.md"
           fi

.github/workflows/draft.yml

@@ -7,9 +7,10 @@ jobs:
   draft:
     name: Draft Release
     runs-on: ubuntu-latest
+
     steps:
-      - name: Download Development Release
-        uses: robinraju/release-downloader@v1.9
+      - name: Download development release
+        uses: robinraju/release-downloader@v1
         with:
           tag: nightly
           fileName: '*'
@@ -17,14 +18,14 @@ jobs:
           zipBall: true
           out-file-path: 'dev'
 
-      - name: Declare Version Variable
+      - name: Declare version variable
         id: ref
         shell: bash
         run: |
           VERSION=$(unzip -p ${{ github.workspace }}/dev/geode-nightly.zip geode-sdk-geode-*/VERSION | xargs)
           echo "version=$VERSION" >> $GITHUB_OUTPUT
 
-          # test if release already exists
+          # Test if release already exists
           set +e
           curl --fail "https://api.github.com/repos/geode-sdk/geode/releases/tags/v$VERSION" --silent --output /dev/null
           RESULT=$?
@@ -35,7 +36,7 @@ jobs:
             exit 1
           fi
 
-      - name: Move Files
+      - name: Move files
         run: |
           mv dev/geode-installer-*-win.exe geode-installer-v${{ steps.ref.outputs.version }}-win.exe
           mv dev/geode-installer-*-mac.pkg geode-installer-v${{ steps.ref.outputs.version }}-mac.pkg
@@ -45,8 +46,8 @@ jobs:
           mv dev/geode-*-android64.zip geode-v${{ steps.ref.outputs.version }}-android64.zip
           mv dev/resources.zip resources.zip
 
-      - name: Create Draft Release
-        uses: softprops/action-gh-release@v1
+      - name: Create draft release
+        uses: softprops/action-gh-release@v2
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
         with:
@@ -54,9 +55,9 @@ jobs:
           name: Geode v${{ steps.ref.outputs.version }}
           body: |
             TODO before publishing:
-             - mark if pre-release
-             - add changelog
-             - remove this
+             - Mark if pre-release
+             - Add changelog
+             - Remove this
           draft: true
           files: |
             ./geode-installer-v${{ steps.ref.outputs.version }}-win.exe

.github/workflows/update-site.yml

@@ -1,20 +1,16 @@
-# Update the install page on the geode-sdk/website repository
 name: Update Website
 
 on:
-  # # trigger when a new release is released
-  # release:
-  #   types:
-  #     - released
-
   workflow_dispatch:
 
 jobs:
   trigger:
     name: Trigger site build
     runs-on: ubuntu-latest
+
     steps:
-    - uses: actions/github-script@v7
+      - name: Trigger build workflow on geode-sdk/website repository
+        uses: actions/github-script@v7
         with:
           github-token: ${{ secrets.GEODE_BOT_PUSH_BIN_TOKEN }}
           script: |

CHANGELOG.md

@@ -10,10 +10,9 @@
    * Rewritten matjson library
    * Settings V2 completely removed, use V3 now
    * `JsonChecker` removed
- * Add new system for ordered hook priority (673317d, 6db3084)
-   * See docs: LINK HERE!!
+ * Add new system for ordered hook priority, [see docs](https://docs.geode-sdk.org/tutorials/hookpriority) (673317d, 6db3084)
  * C++20 coroutine support for `geode::Task`, [see docs](https://docs.geode-sdk.org/tutorials/tasks#coroutines) (e61b2c0, ab196b9)
- * Add `Task::chain`, [see docs](https://docs.geode-sdk.org/tutorials/tasks#chaining-tasks)
+ * Add `Task::chain`, [see docs](https://docs.geode-sdk.org/tutorials/tasks#chaining-tasks) (3248831)
  * Single page local mods list (efb1fbf)
  * Split mod problems into load and outdated (12e8bbb, 09fa872, df2528c)
    * This means mods made for outdated gd or geode versions no longer count as actual errors, resulting in less clutter in the ui

loader/include/Geode/utils/Task.hpp

@@ -817,7 +817,7 @@ namespace geode {
                                 // make the second event listener that waits for the mapper's task
                                 // and just forwards everything through
                                 static_cast<void*>(new EventListener<NewTask>(
-                                    [handle](Event* event) mutable {
+                                    [handle](typename NewTask::Event* event) mutable {
                                         if (auto v = event->getValue()) {
                                             NewTask::finish(handle.lock(), std::move(*v));
                                         }

loader/launcher/windows/proxyLoader.cpp

@@ -6,6 +6,7 @@
 
 struct XINPUT_STATE;
 struct XINPUT_CAPABILITIES;
+struct XINPUT_VIBRATION;
 
 constexpr static auto MAX_PATH_CHARS = 32768u;
 
@@ -41,6 +42,17 @@ extern "C" DWORD XInputGetState(DWORD dwUserIndex, XINPUT_STATE *pState) {
     return ERROR_DEVICE_NOT_CONNECTED;
 }
 
+#pragma comment(linker, "/export:XInputSetState,@3")
+extern "C" DWORD XInputSetState(DWORD dwUserIndex, XINPUT_VIBRATION* pVibration) {
+    static auto fp = getFP("XInputSetState");
+    if (fp) {
+        using FPType = decltype(&XInputSetState);
+        return reinterpret_cast<FPType>(fp)(dwUserIndex, pVibration);
+    }
+
+    return ERROR_DEVICE_NOT_CONNECTED;
+}
+
 #pragma comment(linker, "/export:XInputGetCapabilities,@4")
 extern "C" DWORD XInputGetCapabilities(DWORD dwUserIndex, DWORD dwFlags, XINPUT_CAPABILITIES *pCapabilities) {
     static auto fp = getFP("XInputGetCapabilities");

loader/src/hooks/DynamicCastFix.cpp

@@ -8,6 +8,10 @@ $execute {
     // this is needed because the transitions in cocos uses dynamic cast to check
     // layers, which fail on user layers due to typeinfo not matching
 
+    #if defined(GEODE_IS_MAC) && GEODE_COMP_GD_VERSION != 22074
+        #error "Unsupported version for macOS dynamic cast fix, please update the addresses"
+    #endif
+
     #if defined(GEODE_IS_INTEL_MAC)
         void* dynamicCastAddr = reinterpret_cast<void*>(base::get() + 0x7ba1d8);
         (void) Mod::get()->hook(dynamicCastAddr, &cast::typeinfoCastInternal, "__dynamic_cast");

loader/src/ui/mods/list/ModItem.cpp

@@ -330,9 +330,10 @@ void ModItem::updateState() {
     auto wantsRestart = m_source.wantsRestart();
 
     auto download = server::ModDownloadManager::get()->getDownload(m_source.getID());
+    bool isDownloading = download && download->isActive();
 
     // If there is an active download ongoing, show that in place of developer name 
-    if (download && download->isActive()) {
+    if (isDownloading) {
         m_updateBtn->setVisible(false);
         m_restartRequiredLabel->setVisible(false);
         m_developers->setVisible(false);
@@ -431,7 +432,7 @@ void ModItem::updateState() {
             m_bg->setColor("mod-list-errors-found"_cc3b);
             m_bg->setOpacity(isGeodeTheme() ? 25 : 90);
         }
-        if (!wantsRestart && targetsOutdated) {
+        if (!wantsRestart && targetsOutdated && !isDownloading) {
             LoadProblem problem = targetsOutdated.value();
             m_bg->setColor("mod-list-outdated-label"_cc3b);
             m_bg->setOpacity(isGeodeTheme() ? 25 : 90);

loader/src/ui/mods/sources/ModSource.cpp

@@ -5,6 +5,7 @@
 #include <Geode/ui/GeodeUI.hpp>
 #include <server/DownloadManager.hpp>
 #include <Geode/binding/GameObject.hpp>
+#include <unordered_set>
 
 LoadModSuggestionTask loadModSuggestion(LoadProblem const& problem) {
     // Recommended / suggested are essentially the same thing for the purposes of this
@@ -183,19 +184,22 @@ server::ServerRequest<std::unordered_set<std::string>> ModSource::fetchValidTags
     return std::visit(makeVisitor {
         [](Mod* mod) {
             return server::getTags().map(
-                [mod](auto* result) -> Result<std::unordered_set<std::string>, server::ServerError> {
-                    if (result->isOk()) {
-                        // Filter out invalid tags
+                [mod](Result<std::unordered_set<std::string>, server::ServerError>* result) 
+                    -> Result<std::unordered_set<std::string>, server::ServerError> {
+                    std::unordered_set<std::string> finalTags;
                     auto modTags = mod->getMetadata().getTags();
-                        auto finalTags = std::unordered_set<std::string>();
-                        for (auto& tag : modTags) {
-                            if (result->unwrap().contains(tag)) {
+
+                    if (result->isOk()) {
+                        std::unordered_set<std::string> fetched = result->unwrap();
+                        // Filter out invalid tags
+                        for (std::string const& tag : modTags) {
+                            if (fetched.contains(tag)) {
                                 finalTags.insert(tag);
                             }
                         }
-                        return Ok(finalTags);
                     }
-                    return Ok(result->unwrap());
+
+                    return Ok(finalTags);
                 },
                 [](server::ServerProgress* progress) {
                     return *progress;