scratchfoundation/scratchjr
1
0
Fork 0
mirror of https://github.com/scratchfoundation/scratchjr.git synced 2025-08-28 22:18:54 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix Firebase warnings

Browse source 
Don’t pass NSNulls to Firebase. Paramaters must be string or integer, so use ‘undefined’ to match current values.
This commit is contained in:
Chris Garrity 2020-09-04 08:51:32 -04:00
parent 45b06ee8a6
commit c5b57966b1
1 changed files with 5 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

6
ios/ScratchJr/src/JsBridge.m
View file

@ -169,9 +169,13 @@
} }
-(void) analyticsEvent: (JsRequest *) request { -(void) analyticsEvent: (JsRequest *) request {
NSString *label = @"undefined";
if (![request.params[2] isEqual:[NSNull null]]) {
label = request.params[2];
}
[FIRAnalytics logEventWithName:request.params[1] // action [FIRAnalytics logEventWithName:request.params[1] // action
parameters:@{ parameters:@{
kFIRParameterItemName:request.params[2], // label kFIRParameterItemName:label, // label
kFIRParameterItemCategory:request.params[0] // category kFIRParameterItemCategory:request.params[0] // category
}]; }];
[request callback:@"ok"]; [request callback:@"ok"];