scratchfoundation/scratch-www
1
0
Fork 0
mirror of https://github.com/scratchfoundation/scratch-www.git synced 2024-11-23 15:47:53 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

fix(studio): do not show mute error as if manager can edit info

Browse source
This commit is contained in:
Paul Kaplan 2021-07-06 10:42:02 -04:00
parent 6dbf8d1bd5
commit e719d25e3d
2 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/redux/studio-permissions.js
View file

@ -71,7 +71,9 @@ const selectCanRemoveProject = (state, creatorUsername, actorId) => {
}; };
// We should only show the mute errors to muted users who have any permissions related to the content // We should only show the mute errors to muted users who have any permissions related to the content
const selectShowEditMuteError = state => selectIsMuted(state) && (isManager(state) || selectIsAdmin(state)); // TODO these duplicate the behavior embedded in the non-muted parts of the selectors above, it would be good
// to extract this.
const selectShowEditMuteError = state => selectIsMuted(state) && (isCreator(state) || selectIsAdmin(state));
const selectShowProjectMuteError = state => selectIsMuted(state) && const selectShowProjectMuteError = state => selectIsMuted(state) &&
(selectIsAdmin(state) || (selectIsAdmin(state) ||
isManager(state) || isManager(state) ||

2
test/unit/redux/studio-permissions.test.js
View file

@ -503,7 +503,7 @@ describe('studio mute errors', () => {
['unconfirmed', false], ['unconfirmed', false],
['logged out', false], ['logged out', false],
// ['muted creator', true], // This one fails; not sure why // ['muted creator', true], // This one fails; not sure why
['muted manager', true], ['muted manager', false],
['muted curator', false], ['muted curator', false],
['muted logged in', false] ['muted logged in', false]
])('%s: %s', (role, expected) => { ])('%s: %s', (role, expected) => {