diff --git a/src/redux/studio-permissions.js b/src/redux/studio-permissions.js index 13c4d7130..6a00ffa08 100644 --- a/src/redux/studio-permissions.js +++ b/src/redux/studio-permissions.js @@ -71,7 +71,9 @@ const selectCanRemoveProject = (state, creatorUsername, actorId) => { }; // We should only show the mute errors to muted users who have any permissions related to the content -const selectShowEditMuteError = state => selectIsMuted(state) && (isManager(state) || selectIsAdmin(state)); +// TODO these duplicate the behavior embedded in the non-muted parts of the selectors above, it would be good +// to extract this. +const selectShowEditMuteError = state => selectIsMuted(state) && (isCreator(state) || selectIsAdmin(state)); const selectShowProjectMuteError = state => selectIsMuted(state) && (selectIsAdmin(state) || isManager(state) || diff --git a/test/unit/redux/studio-permissions.test.js b/test/unit/redux/studio-permissions.test.js index f1b138a34..5e68693ee 100644 --- a/test/unit/redux/studio-permissions.test.js +++ b/test/unit/redux/studio-permissions.test.js @@ -503,7 +503,7 @@ describe('studio mute errors', () => { ['unconfirmed', false], ['logged out', false], // ['muted creator', true], // This one fails; not sure why - ['muted manager', true], + ['muted manager', false], ['muted curator', false], ['muted logged in', false] ])('%s: %s', (role, expected) => {