Kevin Andersen
7d7ce2db13
Fixed issue where port A motor position was not being reported because the port number was false-y
2019-07-30 10:20:34 -04:00
Kevin Andersen
4523597a04
Corrected old port mapping! Thanks for catching that @ericr.
2019-07-29 17:59:16 -04:00
Kevin Andersen
842a8e9778
Adjusted portmapping variables to match firmware versions correctly
2019-07-26 15:34:26 -04:00
Kevin Andersen
fcbac7516e
This commit addresses a discussion in #2229 around backward compatibility.
...
This change creates two different port mappings for the Move Hub. By default the extension will use the newer mapping introduced in firmware version 1.0.00.0224. When connected to the hub, the extension will request the hub's firmware version. If it's older than 1.0.00.0224 it will use the older mapping.
2019-07-26 15:31:37 -04:00
Kevin Andersen
e7634d50fa
Add port mappings to support older firmware version 2.0.00.0016 and later as well as newer firmware version 2.0.00.0017 or newer
2019-07-26 14:12:05 -04:00
Kevin Andersen
dcccae9656
Add case to onMessage to catch responses from the LED
2019-07-11 16:23:07 -04:00
Kevin Andersen
4041fbadc3
Changed port-mapping to reflect firmware update.
2019-07-11 16:10:23 -04:00
Evelyn Eastmond
cc04fb0994
Merge pull request #2211 from evhan55/ergonomics/1568
...
EV3 documentation and small refactors
2019-06-28 12:09:24 -04:00
Evelyn Eastmond
1d880bca21
Merge pull request #2201 from evhan55/enhancement/1929
...
Clean up hardware disconnect behavior
2019-06-27 16:01:12 -04:00
Eric Rosenbaum
4bf5f85d9a
Lint (remove logs, add spaces)
2019-06-27 15:48:30 -04:00
Evelyn Eastmond
d7af8457e1
Making constants decimals.
2019-06-23 22:58:40 -04:00
Evelyn Eastmond
6520f3bd7c
Fixing enum var name again.
2019-06-23 22:54:28 -04:00
Evelyn Eastmond
87590202cc
Adding 'byte to follow' comments back.
2019-06-23 22:42:42 -04:00
Evelyn Eastmond
c5a954fb56
Testing some new variable names.
2019-06-23 22:20:50 -04:00
Evelyn Eastmond
471a22dbdc
Clarifying input_device_list args and return types.
2019-06-23 21:58:05 -04:00
Evelyn Eastmond
98deb1bebe
Removing test Ev3Args values.
2019-06-23 21:29:24 -04:00
Evelyn Eastmond
54633e1a97
Adding some comments.
2019-06-23 21:27:20 -04:00
Evelyn Eastmond
7ce8314437
Fixing comment.
2019-06-23 21:23:28 -04:00
Evelyn Eastmond
cbb99e2ee6
Comment clarifying mistake in LEGO docs.
2019-06-23 21:23:28 -04:00
Evelyn Eastmond
ca408dfb04
Trying to figure out the input_device_list args.
2019-06-23 21:23:28 -04:00
Evelyn Eastmond
abe5fa62e4
Remove stale comment.
2019-06-23 21:23:28 -04:00
Evelyn Eastmond
728e5e2d12
Renaming LONG_RAMP to RAMP and adding comment.
2019-06-23 21:23:28 -04:00
Evelyn Eastmond
f45539280a
Trying some different enum values and reorganizing the enums at top of file.
2019-06-23 21:23:28 -04:00
Evelyn Eastmond
fe43ecfa73
Renaming byte allocation enum values.
2019-06-23 21:23:28 -04:00
Evelyn Eastmond
1e124657e5
Fix comments and formatting.
2019-06-23 21:23:27 -04:00
Evelyn Eastmond
ca28b4ff1b
Fix device type return parsing to be clearer when it tries to avoid null values and convert them to 'none'.
2019-06-23 21:23:27 -04:00
Evelyn Eastmond
20b0d4da78
Remove some stale comments and add reminder to rename some byte value enums.
2019-06-23 21:23:27 -04:00
Evelyn Eastmond
f3d50dbe5a
Add global var index 0 value to enum.
2019-06-23 21:23:27 -04:00
Evelyn Eastmond
63d9b0249a
Removed a TODO and clarified with a better comment.
2019-06-23 21:23:27 -04:00
Evelyn Eastmond
5314be8310
More byte value updates, and change global index comments.
2019-06-23 21:23:27 -04:00
Evelyn Eastmond
50c80a8abc
Adding comment to explain byte value enum values.
2019-06-23 21:23:27 -04:00
Evelyn Eastmond
14e8a93ac6
Add global var 1-byte-to-follow to enum.
2019-06-23 21:23:27 -04:00
Evelyn Eastmond
f8d9f687ec
Move Ev3 byte values into their own enum, separate from parameter values.
2019-06-23 21:23:27 -04:00
Evelyn Eastmond
c237f1326d
Clean up some null checks.
2019-06-23 21:23:27 -04:00
Evelyn Eastmond
6b9c3d12ef
Shorten a comment.
2019-06-23 21:23:27 -04:00
Evelyn Eastmond
b476169f84
Change variable name to be shorter / more legible.
2019-06-23 21:23:27 -04:00
Evelyn Eastmond
6284cbdd85
Removing todo, decided not to rename.
2019-06-23 21:23:27 -04:00
Evelyn Eastmond
6c706b410f
Removing label.
2019-06-23 21:23:27 -04:00
Evelyn Eastmond
3712b6fe72
Fixing GDX_FOR disconnect to new ble variable, fixing an error from a recent merge.
2019-06-23 18:42:32 -04:00
Eric Rosenbaum
a115f6dde5
Merge branch 'develop' into enhancement/1929
2019-06-19 11:09:14 -04:00
Chris Willis-Ford
c6b63a8f09
Merge pull request #2143 from cwillisf/non-droppable-extension-menus
...
support non-droppable menus in extensions
2019-06-18 21:18:10 -07:00
Karishma Chadha
aae7607e10
fix extension dropdown menu item conversion
2019-06-18 21:03:17 -07:00
Chris Willis-Ford
eba89d57d8
Merge branch 'develop' into non-droppable-extension-menus
2019-06-18 16:52:47 -07:00
Karishma Chadha
9af2e4c086
Merge pull request #2161 from LLK/e16n
...
Supporting VM changes for extensionification
2019-06-18 18:53:20 -04:00
Christopher Willis-Ford
fd776025e5
refactor _refreshExtensionPrimitives for clarity
...
The previous form made it harder to see that at most one extension
category is handled per call.
2019-06-18 15:08:03 -07:00
Chris Willis-Ford
edd6aafed0
call out capitalization change since it's important but easy to miss
...
Co-Authored-By: Karishma Chadha <kchadha@media.mit.edu>
2019-06-18 15:07:58 -07:00
Christopher Willis-Ford
3c28f714bb
respond to code review
2019-06-17 21:14:21 -07:00
Chris Willis-Ford
18b1551cdb
remove redundant check
...
Co-Authored-By: Karishma Chadha <kchadha@media.mit.edu>
2019-06-17 13:22:52 -07:00
Evelyn Eastmond
f3f307b59c
Merge pull request #2207 from evhan55/ergonomics/2017
...
Removing comment in WeDo2 extension
2019-06-17 12:19:42 -04:00
Evelyn Eastmond
e732d9f3b6
Merge pull request #2194 from evhan55/ergonomics/1974
...
GDXFOR: Rename scratchLinkSocket variables to 'socket' and 'ble'
2019-06-17 11:59:25 -04:00
