Commit graph

1921 commits

Author SHA1 Message Date
DD Liu
5c003641f9
Merge pull request #1126 from fsih/fixQuirksOnLoadCostume
Run quirks mode fixes on costumes loaded from sb2s
2018-05-10 13:42:48 -04:00
DD
589dd7d5e0 Attach the svg renderer instead of providing it in order to fix VM tests 2018-05-10 12:03:38 -04:00
Ray Schamp
6ffc206d10
Merge pull request #1134 from LLK/do-deploy
Actually do the deploy
2018-05-09 16:47:32 -04:00
Ray Schamp
feb90f1f8c
Actually do the deploy
Now that the release stage is only created for master and develop, allow the deploy to run on any branch. This way we can control which branches get deployed from the stage condition alone.
2018-05-09 16:47:06 -04:00
DD
aae1e083bc Switched textEncoder to costumeAsset.encodeTextData, and pass in version as an argument instead of in costume 2018-05-09 15:48:49 -04:00
Paul Kaplan
f3404f4275
Merge pull request #1128 from paulkaplan/sb2-monitors
Import monitors from sb2 files.
2018-05-09 13:52:29 -04:00
Paul Kaplan
6c9ecd9065 Return a new copy of the list for monitors when changes occur 2018-05-09 13:42:53 -04:00
Paul Kaplan
7d0121bc44 Return lists as arrays if running for monitors.
This is a strange quirk of the way the list blocks work, they get joined into a string for interoperability within other other scratch blocks. But for monitors, we need it to stay an array.
2018-05-09 12:24:01 -04:00
Paul Kaplan
36a01cf0cb Fix clearing monitor state 2018-05-09 12:06:24 -04:00
Paul Kaplan
6793349898 Do not stringify reported monitor values.
Consulted @fsih, should be fine since formatting is being handled in the GUI anyway.
2018-05-09 11:39:14 -04:00
Paul Kaplan
cc1314d289 Clear out monitor state on vm.clear
Fixes https://github.com/LLK/scratch-gui/issues/1848
2018-05-09 11:34:01 -04:00
Paul Kaplan
f01558b74e Address comments from @kchada review 2018-05-09 11:08:49 -04:00
Paul Kaplan
aa24d118c8 Fix lint error 2018-05-09 10:55:47 -04:00
Paul Kaplan
9e372916a8 Add comment about sensing block id oddness 2018-05-09 10:52:00 -04:00
kchadha
13d1218876
Merge pull request #1127 from kchadha/update-scratch-parser
Update scratch-parser.
2018-05-09 10:15:26 -04:00
kchadha
cf8ad388de
Merge pull request #1122 from Kenny2github/develop
Handle random backdrop menu option
2018-05-09 10:12:05 -04:00
Karishma Chadha
3e2dd67fda Update scratch-parser version and pin to specific version. 2018-05-09 09:54:38 -04:00
Ray Schamp
5875476228
Merge pull request #1131 from rschamp/no-release-on-pr-builds
Don't run release stage for PR builds
2018-05-09 09:53:03 -04:00
Ray Schamp
968927511a Don't run release stage for PR builds 2018-05-09 09:49:30 -04:00
Paul Kaplan
e0db8529bf Add an sb2 import test for importing monitors.
Checks for
- monitor types set correctly (all 4)
- monitor visibility set correctly
- monitor threads not running if not visible
- monitor positioning imported
- monitor width/height for lists
- custom monitor slider range
- sprite specificity
2018-05-09 09:33:28 -04:00
Paul Kaplan
db646fd3c2 Remove monitors from sb2 fixtures that expect no threads to stay running 2018-05-09 08:44:03 -04:00
Ray Schamp
af174c5782
Merge pull request #1130 from rschamp/conditional-release
Make Travis release stage conditional by branch
2018-05-08 23:54:55 -04:00
Ray Schamp
756b7941af Make release stage conditional by branch
If the branch isn't a release branch, don't even try to do the release stage.  This should speed up PR tests.
2018-05-08 23:51:50 -04:00
Ray Schamp
ac6e73c947
Merge pull request #1129 from rschamp/node8
Clean up Travis config
2018-05-08 23:36:08 -04:00
Kenny2github
8e9f9e0a30 Add one to index if random costume is current costume 2018-05-09 08:13:04 +08:00
Ray Schamp
bfde3f476c Specify Node 8 in build stages 2018-05-08 19:38:05 -04:00
Ray Schamp
4dca1b29aa Don't use NODE_ENV=production for the matrix
This is something we want enabled for all builds, so it should be a global. This should simplify the matrix. The builds without an NPM_SCRIPT didn't do anything anyway.
2018-05-08 19:37:09 -04:00
Ray Schamp
a12e4dfbae Update Travis Node to 8
The peer dependency fix seemed to work, but we want to be up to 8 on all our repos anyway so do that.
2018-05-08 19:36:01 -04:00
Ray Schamp
aad5131f93 Update remaining peer dependency 2018-05-08 19:35:29 -04:00
Ray Schamp
c705be4cfa Update expose-loader dependency instead
It doesn't make sense that webpack 4 has made Node 6 builds. Maybe it's due to peer dependencies on the install step?
2018-05-08 19:27:26 -04:00
Ray Schamp
6da5da7c38 Bump Travis to Node 8
Tests fail otherwise, with the new version of webpack?
2018-05-08 18:53:36 -04:00
DD
b9ce26918d Fix review comments 2018-05-08 18:30:52 -04:00
Paul Kaplan
13dfef553e Fix default value for monitor record 2018-05-08 17:30:39 -04:00
Paul Kaplan
26cfbfe588 Fix stage checking 2018-05-08 17:15:54 -04:00
Paul Kaplan
4713f47fb7 Import monitors from sb2 files.
Paired with @kchadha on all of this.
2018-05-08 17:06:19 -04:00
DD
928245d5c9 Fix Edge 2018-05-08 14:25:32 -04:00
DD
296af1a079 Run quirks mode fixes on costumes loaded from sb2s 2018-05-08 12:03:34 -04:00
Ray Schamp
22852aeab4
Merge pull request #1119 from mzgoddard/recycle-args
Recycle block args
2018-05-08 12:00:29 -04:00
Ray Schamp
b657d6a50f
Merge pull request #1118 from mzgoddard/recycle-stack-frame
Add Thread.StackFrame class
2018-05-08 09:04:16 -04:00
Kenny2github
3f1c4aa2d8 thought I was being smart by using inline assignment, but noooooo 2018-05-08 08:27:51 +08:00
Kenny2github
e3b7f53319 Make sure switched costume is not current costume 2018-05-08 08:21:27 +08:00
Michael "Z" Goddard
8107349bec
Comment BlockCached 2018-05-07 15:32:31 -04:00
Michael "Z" Goddard
2db2287d12
BlockCached instances are always initialized 2018-05-07 15:32:30 -04:00
Michael "Z" Goddard
5fd749918f
Reuse argValues
Block args set by fields are static and never change. Inputs that do
change are always set onto args. With these two assumptions we can
reuse the same objects for each execution of the same block instead of
constantly creating them and letting them be garbage collected.
2018-05-07 15:32:30 -04:00
Michael "Z" Goddard
9b82530f51
Use a constructor to create the execute cache objects 2018-05-07 15:32:30 -04:00
Ray Schamp
784705d46e
Merge pull request #1105 from mzgoddard/dynamic-load-music
Dynamically load music extension manifest
2018-05-07 14:38:37 -04:00
Ray Schamp
a9a23ef589
Merge pull request #1104 from mzgoddard/webpack-4
Update to webpack 4
2018-05-07 11:28:51 -04:00
Michael "Z" Goddard
0634e962a8
Add Thread.StackFrame class
Use a private StackFrame class to help internally manage use of Stack
Frame values and memory. Create params, reported, and executionContext
on demand.
2018-05-07 11:20:26 -04:00
Ray Schamp
a3324c6a38 Major-pin webpack 2018-05-07 10:41:18 -04:00
Ray Schamp
9f33b593b3
Merge pull request #1112 from mzgoddard/babel-preset-env
Update babel-preset-es2015 to babel-preset-env
2018-05-07 10:34:34 -04:00