Karishma Chadha
b828444ea8
Update comments for addCloudVariable and removeCloudVariable.
2018-11-28 15:03:20 -05:00
Karishma Chadha
431e92aa54
Fix up tests and remove unused function.
2018-11-28 15:03:20 -05:00
Karishma Chadha
86d61a4c20
Emit event tracking when the project's hasCloudData status changes. Cloud var creation now happens regardless of connectivity to the provider.
2018-11-28 15:03:19 -05:00
picklesrus
90b627982c
fix todo
2018-11-28 12:34:49 -05:00
picklesrus
eefe021425
add todo and remove a newline
2018-11-28 12:33:04 -05:00
picklesrus
d19848b712
remove unused import
2018-11-28 11:55:02 -05:00
picklesrus
e64cd5f34b
stop mocking method in the test.
2018-11-28 10:36:22 -05:00
picklesrus
4a542b455d
fix code review comments
2018-11-28 10:36:22 -05:00
picklesrus
f214d3a191
VM changes for the sensing_of block. This handles lists properly (by ignoring them like Scratch2 and makes the attribute menu update based on what was chosen in the target menu.
2018-11-28 10:35:35 -05:00
Paul Kaplan
631d44a061
Merge pull request #1785 from paulkaplan/no-multi-starts
...
Prevent the runtime from spawning new stepping intervals
2018-11-28 08:52:18 -05:00
Paul Kaplan
421aac6340
Ensure setCompatibilityMode continues to restart if previously started.
...
This was previous behavior, but the previous commit which prevents restarts based on _steppingInterval truthiness broke it because clearInterval does not modify the value of _steppingInterval
2018-11-28 08:47:51 -05:00
Paul Kaplan
4378603d36
Prevent the runtime from spawning new stepping intervals
2018-11-28 08:34:22 -05:00
Chris Willis-Ford
05979e2e93
Merge pull request #1784 from cwillisf/setLocale-always-refreshBlocks
...
Make setLocale consistently refresh blocks
2018-11-27 19:19:41 -08:00
Valerie R Young
70f00e30c4
Revert changes to toNumber, fix comparison of infinity in cast.compare
2018-11-27 17:53:20 -05:00
Paul Kaplan
ffb02c607d
Merge pull request #1783 from paulkaplan/emit-start-event
...
Emit a RUNTIME_STARTED event to track if the vm has been started
2018-11-27 16:38:27 -05:00
Paul Kaplan
0c38c3cffe
Force exiting after tests finish
2018-11-27 16:06:56 -05:00
Evelyn Eastmond
acc2e6dba2
Merge pull request #1781 from evhan55/extensions/rpc-error
...
Adding check for open request before calling RPC reject/resolve.
2018-11-27 12:06:10 -08:00
Christopher Willis-Ford
4256f86ac3
Make setLocale consistently refresh blocks
...
This change makes the VM's `setLocale` method call `refreshBlocks` even
when not changing the language, though it still skips an unnecessary
call to `formatMessage.setup` in this case.
2018-11-27 10:26:04 -08:00
Paul Kaplan
cc4751228e
Emit a RUNTIME_STARTED event to track if the vm has been started
2018-11-27 11:37:01 -05:00
Evelyn Eastmond
9c3518ba6d
Adding check for open request before calling reject/resolve. Resolves #1764 .
2018-11-27 09:43:53 -05:00
Ray Schamp
dd2023e2f3
Merge pull request #1779 from rschamp/project-dirty-signal
...
Add "project changed" event
2018-11-27 08:54:30 -05:00
Ray Schamp
5022227c15
Add "project changed" event
...
And emit it whenever we think the project has changed. Try to not emit it when a change has happened internally that shouldn't affect the serialized project.
This iteration fires the event too frequently, e.g., when switching sprites. This is meant as a simple initial implementation that can be improved.
2018-11-26 17:10:43 -05:00
Eric Rosenbaum
045ebb5026
Apply sprite's volume to music extension notes and drums ( #1735 )
...
* Use a gain node for volume instead of effects chain
* Use a gain node for volume for drums too
2018-11-26 11:46:25 -05:00
DD Liu
5802723dc7
Merge pull request #1737 from fsih/textLayer
...
Support text layer in sb2 files
2018-11-21 13:18:47 -05:00
Karishma Chadha
aa7ac73aed
Merge pull request #1775 from kchadha/cloud-rename-delete
...
Cloud rename delete
2018-11-21 13:18:32 -05:00
DD Liu
17d0033f1c
Remove conditional because text layer file name always comes from sb2
2018-11-21 12:03:52 -05:00
DD Liu
94227c00fa
Remove catches that do nothing
2018-11-21 12:01:48 -05:00
Karishma Chadha
63c4b53b09
Replace reference to deleted variable with specific variable info needed.
2018-11-21 11:45:16 -05:00
Karishma Chadha
abbce00203
Add unit tests for new rename and delete cloud var functionality.
2018-11-20 19:56:45 -05:00
Karishma Chadha
25ce08131a
Add rename and delete functionality for cloud variables. Refactor function name for cloud variable creation API.
2018-11-20 15:11:12 -05:00
DD
c68da6605b
Move reject earlier and add loadedOne comment
2018-11-20 15:08:25 -05:00
Chris Willis-Ford
cb7a2c9a61
Merge pull request #1770 from cwillisf/node10-fix-monitors-unit-test
...
Fix monitor tests to count only monitor threads
2018-11-20 09:48:04 -08:00
Christopher Willis-Ford
3649c15f2a
Fix monitor tests to count only monitor threads
...
The monitor tests no longer fail if the last step happens to have run a
non-monitor thread in addition to the monitor threads.
2018-11-19 16:34:33 -08:00
Chris Willis-Ford
e071cf3c0c
Merge pull request #1768 from cwillisf/node11-fix-unit-tests
...
Fix unit tests on Travis CI
2018-11-19 14:06:10 -08:00
Christopher Willis-Ford
812455db7c
Explicitly specify Node versions for Travis
2018-11-19 12:09:38 -08:00
Christopher Willis-Ford
30a1ba52e3
Use absolute path for worker shim in dispatch test
...
Node 11 causes TinyWorker to resolve its start script path differently,
compared to Node 8. Using an absolute path works for both.
2018-11-19 11:57:43 -08:00
Valerie R Young
d8078c018d
Implement feedback, broadcast order
2018-11-16 17:24:28 -05:00
Valerie R Young
dd81a261df
Remove Cast import
2018-11-16 16:49:27 -05:00
Valerie R Young
73e157ba7c
Use Number instead of Cast.toNumber
2018-11-16 16:30:26 -05:00
Katie Broida
bb82c46f8a
Handle coordinate precision the same as Scratch 2 ( #1722 )
2018-11-15 15:50:56 -05:00
Valerie Young
2ca735eab4
Merge pull request #1716 from bocoup/unknown-block-input-fix
...
Handle unknown opcode in input
2018-11-15 10:09:46 -05:00
Ray Schamp
f2550d582c
Merge pull request #1750 from rschamp/feature/sb3-json-assets
...
Add method for collecting all targets' assets
2018-11-15 10:31:58 +00:00
Ray Schamp
bcd1c5b13a
Consolidate collectAssets into getter
2018-11-15 10:26:05 +00:00
Karishma Chadha
0c9da5d963
Merge pull request #1755 from kchadha/cloud-var-create
...
Create cloud variables
2018-11-14 21:39:29 -05:00
Karishma Chadha
e2e6509a4a
Fix lint error
2018-11-14 19:22:41 -05:00
Karishma Chadha
fad4d381bb
Add and update unit tests for new create cloud variable functionality.
2018-11-14 15:46:51 -05:00
Eric Rosenbaum
26ced0dd58
Use note picker in imported play note blocks ( #1757 )
...
* Use note picker in imported play note blocks
* Set default for obscured note shadows to 60
2018-11-14 14:55:12 -05:00
Valerie R Young
ebd3b46cc2
Address feedback
2018-11-14 14:24:09 -05:00
Paul Kaplan
8aa88fa2a2
Merge pull request #1723 from mzgoddard/blocks-monitored-cache
...
Cache the set of actively monitored blocks
2018-11-14 14:16:36 -05:00
Karishma Chadha
3dd0d0a657
Merge pull request #1686 from kchadha/monitor-save-load
...
Monitor save & load
2018-11-14 13:23:10 -05:00
