Commit graph

635 commits

Author SHA1 Message Date
Evelyn Eastmond
54633e1a97 Adding some comments. 2019-06-23 21:27:20 -04:00
Evelyn Eastmond
7ce8314437 Fixing comment. 2019-06-23 21:23:28 -04:00
Evelyn Eastmond
cbb99e2ee6 Comment clarifying mistake in LEGO docs. 2019-06-23 21:23:28 -04:00
Evelyn Eastmond
ca408dfb04 Trying to figure out the input_device_list args. 2019-06-23 21:23:28 -04:00
Evelyn Eastmond
abe5fa62e4 Remove stale comment. 2019-06-23 21:23:28 -04:00
Evelyn Eastmond
728e5e2d12 Renaming LONG_RAMP to RAMP and adding comment. 2019-06-23 21:23:28 -04:00
Evelyn Eastmond
f45539280a Trying some different enum values and reorganizing the enums at top of file. 2019-06-23 21:23:28 -04:00
Evelyn Eastmond
fe43ecfa73 Renaming byte allocation enum values. 2019-06-23 21:23:28 -04:00
Evelyn Eastmond
1e124657e5 Fix comments and formatting. 2019-06-23 21:23:27 -04:00
Evelyn Eastmond
ca28b4ff1b Fix device type return parsing to be clearer when it tries to avoid null values and convert them to 'none'. 2019-06-23 21:23:27 -04:00
Evelyn Eastmond
20b0d4da78 Remove some stale comments and add reminder to rename some byte value enums. 2019-06-23 21:23:27 -04:00
Evelyn Eastmond
f3d50dbe5a Add global var index 0 value to enum. 2019-06-23 21:23:27 -04:00
Evelyn Eastmond
63d9b0249a Removed a TODO and clarified with a better comment. 2019-06-23 21:23:27 -04:00
Evelyn Eastmond
5314be8310 More byte value updates, and change global index comments. 2019-06-23 21:23:27 -04:00
Evelyn Eastmond
50c80a8abc Adding comment to explain byte value enum values. 2019-06-23 21:23:27 -04:00
Evelyn Eastmond
14e8a93ac6 Add global var 1-byte-to-follow to enum. 2019-06-23 21:23:27 -04:00
Evelyn Eastmond
f8d9f687ec Move Ev3 byte values into their own enum, separate from parameter values. 2019-06-23 21:23:27 -04:00
Evelyn Eastmond
c237f1326d Clean up some null checks. 2019-06-23 21:23:27 -04:00
Evelyn Eastmond
6b9c3d12ef Shorten a comment. 2019-06-23 21:23:27 -04:00
Evelyn Eastmond
b476169f84 Change variable name to be shorter / more legible. 2019-06-23 21:23:27 -04:00
Evelyn Eastmond
6284cbdd85 Removing todo, decided not to rename. 2019-06-23 21:23:27 -04:00
Evelyn Eastmond
6c706b410f Removing label. 2019-06-23 21:23:27 -04:00
Evelyn Eastmond
3712b6fe72 Fixing GDX_FOR disconnect to new ble variable, fixing an error from a recent merge. 2019-06-23 18:42:32 -04:00
Eric Rosenbaum
a115f6dde5
Merge branch 'develop' into enhancement/1929 2019-06-19 11:09:14 -04:00
Chris Willis-Ford
eba89d57d8 Merge branch 'develop' into non-droppable-extension-menus 2019-06-18 16:52:47 -07:00
Evelyn Eastmond
f3f307b59c
Merge pull request #2207 from evhan55/ergonomics/2017
Removing comment in WeDo2 extension
2019-06-17 12:19:42 -04:00
Christopher Willis-Ford
33a6071466 for compatibility, make all existing extension menus accept reporters 2019-06-14 12:29:32 -07:00
Evelyn Eastmond
418cd0a0f4 Removing comment after decision that this function name is accurate and distinct from coastAfter. 2019-06-12 10:20:21 -04:00
Evelyn Eastmond
704774d6d1 Fixing debug statements and also adding a safety check for timeoutIDs. 2019-06-12 09:02:12 -04:00
Evelyn Eastmond
37fe83c057 Adding disconnect/state resetting behavior to rest of hardware extensions. 2019-06-12 09:02:12 -04:00
Evelyn Eastmond
f8a0ea281f Adding/fixing debug statements throughout. 2019-06-12 09:02:12 -04:00
Evelyn Eastmond
a1243fd897 Change cleanup/disconnect behavior for BT and EV3. 2019-06-12 09:02:12 -04:00
Evelyn Eastmond
6a032087ce Fixing up BOOST reset and disconnect behavior splitting. 2019-06-12 09:02:12 -04:00
Evelyn Eastmond
56fdd45242 Adding reset and resetCallback to BLE and Boost extension only for now. 2019-06-12 09:02:12 -04:00
Evelyn Eastmond
f192c181bd Rename scratchLinkSocket variables to 'socket' and 'ble' to avoid confusion with upcoming ScratchLinkWebSocket class. 2019-06-12 09:01:49 -04:00
picklesrus
b88d5d05b0
Merge pull request #2084 from picklesrus/update-languages-in-translate-list
Fixing some translate language menu bugs.
2019-06-10 11:13:52 -04:00
Eric Rosenbaum
b6a33cc3ed
Merge branch 'develop' into extensions/ev3-rate-limiting 2019-06-04 11:37:43 -04:00
Evelyn Eastmond
b6913b7828 Move EV3 pin to a static var. 2019-05-31 11:14:32 -04:00
Evelyn Eastmond
8e302ac90c Add optional pin parameter to peripheral connection. 2019-05-31 11:10:13 -04:00
Karishma Chadha
dbcbe8b94f Revert "synth extension"
This reverts commit dbd513d85b.
2019-05-24 11:27:20 -04:00
Karishma Chadha
7501af4c6b Revert "lightplay extension stub"
This reverts commit 1ee3cea144.
2019-05-24 11:26:54 -04:00
Carmelo Presicce
1ee3cea144 lightplay extension stub 2019-05-23 21:27:10 -04:00
Carmelo Presicce
dbd513d85b synth extension 2019-05-23 20:22:03 -04:00
Evelyn Eastmond
58908bb1a4 Changing BTSendRateMax to help with key-down scenarios. 2019-05-17 11:43:06 -04:00
Evelyn Eastmond
d76756f5f6 Removing BTSendInterval, not needed. 2019-05-17 11:28:51 -04:00
Evelyn Eastmond
62a8f2d0f2 Fix typo. 2019-05-17 11:28:51 -04:00
Evelyn Eastmond
52519ae1e0 Add comment. 2019-05-17 11:28:51 -04:00
Evelyn Eastmond
9d231b7887 Adding RateLimiter and useLimiter rate limiting approach to EV3. 2019-05-17 11:28:51 -04:00
Evelyn Eastmond
6e6d6140cc Rename duration timeout setter/getter. 2019-05-11 11:21:07 -04:00
Evelyn Eastmond
b7e0edcabc Fixing linting. 2019-05-11 11:08:00 -04:00
Evelyn Eastmond
6e0b4351d8 Clarify comment. 2019-05-11 10:55:51 -04:00
Evelyn Eastmond
693038972e Clarify comment. 2019-05-11 10:54:45 -04:00
Evelyn Eastmond
bdda6f7fc6 Fix inaccurate comment. 2019-05-11 10:52:00 -04:00
Evelyn Eastmond
048598aef8 Fix inaccurate comment. 2019-05-11 10:50:25 -04:00
Evelyn Eastmond
14ffae04f8 Fix inaccurate comment. 2019-05-11 10:48:35 -04:00
Evelyn Eastmond
0256fff8ce Update public getters to new variable names. 2019-05-11 10:46:45 -04:00
Evelyn Eastmond
9ae2c4b1f1 Adding a comment. 2019-05-11 10:40:27 -04:00
Evelyn Eastmond
eabff71461 Changing some variable names regarding duration and rotation blocks for clarity. 2019-05-11 10:37:42 -04:00
Eric Rosenbaum
86f4ca5806 Do not localize motor IDs 2019-05-02 16:21:08 -04:00
Eric Rosenbaum
b75b8027a1 Always clear motor promises when setting state 2019-04-30 11:37:10 -04:00
Eric Rosenbaum
8245b46d56 Change extension name to all-caps BOOST 2019-04-29 15:43:38 -04:00
Eric Rosenbaum
85f3a3c3c5
Merge branch 'develop' into bugfix/2125 2019-04-29 14:06:13 -04:00
Evelyn Eastmond
2a04e9c7f2 Don't set motor power or direction if in rotation state. 2019-04-29 11:58:34 -04:00
Evelyn Eastmond
8745c9b3ac Move false flag left because it will get fixed by PR 2140 instead. 2019-04-29 11:54:12 -04:00
Evelyn Eastmond
c1292f6a59 Don't set motor power if it's already equal to the input power. 2019-04-29 11:53:40 -04:00
Evelyn Eastmond
71c3b72892 Moving false flag from Math.abs to turnOnForDegrees, fixing typo. 2019-04-29 11:53:40 -04:00
Evelyn Eastmond
7e01326d71 Fixing linting. 2019-04-29 11:45:15 -04:00
Evelyn Eastmond
a67b303294 Remove console logs and change a comment. 2019-04-29 11:42:09 -04:00
Evelyn Eastmond
c37a41c352 Only clear pending duration timeout if not in _ON_FOR_TIME state. 2019-04-29 09:22:36 -04:00
Evelyn Eastmond
75eae9a58a Fixing motor status setter to not clear rotation if already in rotation state. 2019-04-29 09:22:36 -04:00
Evelyn Eastmond
5109cd474c Remove more power===0 checks. 2019-04-29 09:22:36 -04:00
Evelyn Eastmond
410e13b4e3 Remove resetState and all power===0 checks. 2019-04-29 09:22:36 -04:00
Evelyn Eastmond
d0ed16d47c Fixing Math.abs false arg? and moving it to turnOnForDegrees call. 2019-04-29 09:22:36 -04:00
Evelyn Eastmond
dd82079bad Fixing a comment style. 2019-04-29 09:22:36 -04:00
Evelyn Eastmond
bb6514f1d6 Removing some tabs. 2019-04-29 09:22:36 -04:00
Evelyn Eastmond
14162b9920 Adding an empty line back in. 2019-04-29 09:22:36 -04:00
Evelyn Eastmond
7ed8d376c5 Putting in a comment. 2019-04-29 09:22:36 -04:00
Evelyn Eastmond
99c7528a1e Removing some empty changed lines. 2019-04-29 09:22:36 -04:00
Evelyn Eastmond
12233b73dd Fixing comments to reflect original code. 2019-04-29 09:22:36 -04:00
Evelyn Eastmond
73fc5b8723 Fixing lint. 2019-04-29 09:22:36 -04:00
Evelyn Eastmond
83bf1be066 Comment out all the power = 0 checks that came over from WeDo. 2019-04-29 09:22:36 -04:00
Evelyn Eastmond
270a445703 Playing with power states while we figure out the design. 2019-04-29 09:22:36 -04:00
Evelyn Eastmond
597bd68c0d Remove commented line. 2019-04-29 09:21:06 -04:00
Evelyn Eastmond
f0edd10346 Change turnOnForever and turnOff behavior for power = 0 case. 2019-04-29 09:21:06 -04:00
unknown
a0f0a4092c Moving position reversal back to reporter to avoid conflicts. 2019-04-24 22:42:54 -04:00
Evelyn Eastmond
a61b01628e Putting back a line deleted by accident. 2019-04-24 11:28:29 -04:00
Evelyn Eastmond
e3ec614173 Move reversing of sign to _onMessage, before clamping. 2019-04-24 11:24:56 -04:00
Evelyn Eastmond
adb4c0482c Reversing the sign on Motor A reported position. 2019-04-23 19:05:12 -04:00
Eric Rosenbaum
b80b05ead7
Merge pull request #2131 from ericrosenbaum/feature/add-tts-arabic
Add Arabic to Text to Speech extension
2019-04-23 17:23:19 -04:00
Evelyn Eastmond
9a60d10190 Adding send interval delay to setMotorDirection opcode. 2019-04-22 12:17:47 -04:00
Evelyn Eastmond
26e6d25325 Make set motor speed opcode yield for send interval duration. 2019-04-22 11:59:02 -04:00
Eric Rosenbaum
f1c1883881 Add Arabic to Text to Speech 2019-04-21 21:18:56 -04:00
Eric Rosenbaum
ddd5bb2d7b
Merge pull request #2119 from ericrosenbaum/bugfix/boost-color-sensing-fixes
BOOST color sensing fixes
2019-04-16 15:44:13 -04:00
Eric Rosenbaum
8dc4832100 Reorganize color ids and indices 2019-04-16 15:24:39 -04:00
Kevin Nørby Andersen
1c8dfea382
Merge pull request #2115 from knandersen/bugfix/2108
Fix #2108 by making setMotorPower() and setMotorDirection() yield for a tick
2019-04-15 18:41:28 -04:00
Eric Rosenbaum
07768652f9 clean up whencolor is seeingcolor functions 2019-04-15 11:34:02 -04:00
Eric Rosenbaum
1381d2c4c0 Add boolean “seeing color brick?” 2019-04-15 09:59:03 -04:00
Eric Rosenbaum
bd5bc7947b rename hat to “when color brick seen” 2019-04-15 09:58:44 -04:00
Eric Rosenbaum
0cadf685b2 Remove color reporter 2019-04-12 17:14:34 -04:00
Eric Rosenbaum
d77944beff Clean up detection of color any 2019-04-12 17:09:10 -04:00