Commit graph

741 commits

Author SHA1 Message Date
Florrie
934b756032 Make mouse cursor react to what it's hovered over (#762) 2018-12-10 17:42:29 -05:00
Ashwin Ramaswami
01090ec098 Get proper paintMessages object properties 2018-12-09 10:34:59 -08:00
chrisgarrity
d2b05bf268 Update scratch-l10n dependency
- update to scratch-l10n that includes script for pushing new source file to transifex
- add new step to .travis.yml that will generate and push source strings if running a cron job
2018-11-30 13:57:33 -05:00
Florrie
a04f1276f8 Make circle (shift-oval) tool work for any direction dragged (#774) 2018-11-28 13:16:20 -05:00
DD Liu
badc549fdc
Revert "Revert "Wait for other callbacks before load SVG code"" (#772)
* Add back bitmap jumping fix

* Cancel previous async action if a new one is queued, and move zoomToFit call until after import

* Make bitmap load cancellable too
2018-11-20 14:10:25 -05:00
Paul Kaplan
382f1fe0ef
Merge pull request #760 from LLK/revert-755-bitmapMove
Revert "Wait for other callbacks before load SVG code"
2018-11-09 13:07:11 -05:00
Paul Kaplan
dd35871076 Revert "Wait for other callbacks before load SVG code (#755)"
This reverts commit 2d277581b1.
2018-11-09 13:01:58 -05:00
DD Liu
b3009320d1
Fix issues handling rasters in reshape (#756) 2018-11-05 15:58:42 -05:00
DD Liu
2d277581b1
Wait for other callbacks before load SVG code (#755) 2018-11-05 11:03:58 -05:00
DD Liu
4bc3b5b624
Cut off text2 (#744) 2018-10-29 11:01:53 -04:00
chrisgarrity
fa6f69ec45
Merge pull request #705 from chrisgarrity/issue/620-gd-toobig
Add Gaidhlig (gd) to the ‘hide-label’ locales
2018-09-26 15:05:32 -04:00
DD Liu
c6fb28a69c
Make stroke width 0 when transparent (#695) 2018-09-26 13:08:47 -04:00
chrisgarrity
e220ba1f54 Add Gaidhlig (gd) to the ‘hide-label’ locales 2018-09-26 11:41:44 -04:00
DD Liu
8daea46ad6
Use consistent hit testing (#689) 2018-09-26 11:19:46 -04:00
DD Liu
bcc3af4571
Save after adding points (#696) 2018-09-24 13:47:57 -04:00
DD Liu
c8a5db311b
Don't scale text outlines (#685) 2018-09-18 16:30:56 -04:00
DD Liu
a5baa14316
Don't navigate away when paint editor is open and delete/backspace are pressed' (#679) 2018-09-18 16:17:51 -04:00
DD Liu
b6ad997ea2
Switch fix aspect ratio to default when resizing by a corner (#681) 2018-09-17 13:43:51 -04:00
DD Liu
4b658c294f
Bitmap select state (#678) 2018-09-17 13:38:16 -04:00
DD Liu
ccd7f27268
Export bit text (#680) 2018-09-17 13:37:01 -04:00
DD Liu
02ea26efe7
Add safety checks to fill and stroke colors (#682) 2018-09-14 16:14:34 -04:00
DD Liu
ca04db7094
Export bit shapes (#662) 2018-09-12 18:17:45 -04:00
DD Liu
a105d967ba
Fence tools to make it less easy to lose work off the sides (#671) 2018-09-12 18:03:19 -04:00
DD Liu
e4883063fe
Handle transparency in bitmap tools (#660) 2018-09-12 13:21:54 -04:00
DD Liu
5b1d9ee9c4
Make scrollbars a smidgen larger (#674) 2018-09-12 12:25:28 -04:00
DD Liu
29e25cf4e9
Use RGBA instead of hex so Edge can understand the color (#673) 2018-09-12 12:19:38 -04:00
DD Liu
45018e4f64
Add component will unmount to deactivate to all tools (#657) 2018-09-11 10:35:08 -04:00
DD Liu
8658840ee7
Re-enable keyboard shortcuts (#654) 2018-09-05 18:02:39 -04:00
DD Liu
6f5c47686d
Rtl text tool (#651) 2018-09-05 17:19:40 -04:00
kyleplo
3701f99d93 Make gradient icons not selectable (#645) 2018-09-05 15:58:22 -04:00
DD Liu
4be60cae49
Copy and delete work on all objects when none are selected (#634) 2018-09-05 15:34:00 -04:00
DD Liu
97f55cde9e
Fix a bug where we never remove key listeners (#652) 2018-09-05 11:22:45 -04:00
DD Liu
d5741c2e02 Fix undefined exception 2018-08-31 13:43:15 -04:00
DD Liu
39051b8220
Disable keyboard shortcuts for now (#642) 2018-08-31 12:29:54 -04:00
DD Liu
516f6eb714
Zoom to fit (#629)
Note do not merge without GUI change
2018-08-31 12:07:17 -04:00
DD Liu
20a98db397
Break paint-editor.jsx code out into HOCs (#633) 2018-08-30 17:51:11 -04:00
DD Liu
c6458ddebc
Fix the pointer-events error in the console (#635) 2018-08-30 14:56:10 -04:00
DD Liu
07effb7fd8
Scroll containers shouldn't intercept pointer events (#630) 2018-08-29 17:09:45 -04:00
DD Liu
4474ec3aa1
Keyboard shortcuts (#623) 2018-08-29 15:29:13 -04:00
chrisgarrity
97f669423a
Make PaintEditor component rtl aware (#617)
* Make PaintEditor component rtl aware

Fixes the color-picker and any other popover elements.

Adds an RTL prop to the PaintEditor that initializes the `layout` state in redux. Any other components that need to know the layout refer to the state in redux.

I debated whether the state should just be a boolean (true for RTL), or ‘rtl’, ‘ltr’. I went with the latter, but could be convinced that boolean would be better.

I did not add `dir=“rtl”` to the font picker dropdown as all the names are in LTR languages.

Question: Should the sliders reverse direction, and if so, is it worth doing right now when the layout of the color picker may change.

Adding the rtl prop and the `dir=…` to the PaintEditorComponent fixes layout issues in the playground.

* Don’t reverse gradient swatches: the fill colors (and swatch preview) should represent the way the left-right colors will blend when filling a shape.
2018-08-23 19:08:56 -04:00
chrisgarrity
620dd6ae49
Mirror margins, borders and arrow icons for RTL (#616)
* Mirror margins, borders and arrow icons for RTL

This handles everything exception the color picker.

I verified that things like the paint brush and magnifying glass should not be mirrored (even people who read Hebrew are usually right-handed)

* Fix dropdown icon padding in RTL
2018-08-22 13:13:46 -04:00
DD Liu
50de05cee4
Scrollbars (#602) 2018-08-16 16:49:43 -04:00
DD Liu
2791866a9e
Reduce tolerance across the board. Don't accept hit results on helper items unless they are handles. (#597) 2018-08-16 13:09:26 -04:00
DD Liu
8267e11176
Double click in select modes switches to text tool (#583) 2018-08-09 10:55:44 -04:00
Jacco Kulman
8056a788e7 Loupe issues fixed #378 (#382) 2018-08-08 18:27:01 -04:00
apple502j
5c723e5f92 Localize tool tooltips (#573)
* Create messages.js for all tooltips as many are shared between the bitmap and vector editors:
  * Brush Translation
  * Eraser Translation
  * Fill Translation
  * Line Translation
  * Oval Translation
  * Rect Translation
  * Reshape Translation
  * RoundedRect Translation
  * Select Translation
  * Text Translation
2018-08-06 09:16:35 -04:00
DD Liu
6c84cbf76d
Selection limit (#572) 2018-08-03 13:10:45 -04:00
DD Liu
df88d56d1b
Save bitmap selection (#569) 2018-07-25 19:07:35 -04:00
DD Liu
f7ca2c7e43
Leftover selection boxes (#570) 2018-07-25 16:28:55 -04:00
chrisgarrity
28ad90c9fe
Merge pull request #560 from chrisgarrity/issue/543-localize
Adjust format for different locales
2018-07-18 14:31:09 -04:00
chrisgarrity
ec38552b32 Fix icon alignment when there are no labels 2018-07-18 14:21:39 -04:00
DD Liu
af3c6694d4
Bitmap gradient (#559) 2018-07-17 17:21:02 -04:00
DD Liu
4ba79cacbb
Vector gradient (#558) 2018-07-17 16:37:03 -04:00
chrisgarrity
0ed3aaf3db Adjust format for different locales
* increased fullsize editor width, English required 1272, adding a couple more pixels allowed a couple of other languages to keep labels
* hide flip vertical/horizonal labels for everything except English
* hide all labels for languages defined in `hideLabel`
2018-07-16 14:34:36 -04:00
DD Liu
21f3a5f30c
Add missing props validation (#556) 2018-07-13 10:55:36 -04:00
DD Liu
4e4bb396a6
Draw oval and rectangle outlines in bitmap (#550) 2018-07-12 15:48:30 -04:00
Paul Kaplan
11bab6ebe2
Merge pull request #553 from paulkaplan/fix-conversion-button-styles
Make the bitmap/vector conversion button look enabled
2018-07-12 10:38:47 -04:00
Paul Kaplan
1d63bafedd Make the bitmap conversion button enabled always 2018-07-12 10:27:14 -04:00
DD Liu
652a3ca89b
Update image when deleting points (#551) 2018-07-11 14:10:03 -04:00
DD Liu
7063d359eb
Correct the view bounds when the paper canvas is initialized. (#549) 2018-07-11 11:13:27 -04:00
Paul Kaplan
179c68378b
Merge pull request #545 from paulkaplan/delete-button
Delete button
2018-07-09 09:17:37 -04:00
Paul Kaplan
64b71703ce Simplify the logic for reshape delete 2018-07-09 09:17:15 -04:00
Paul Kaplan
501f9806e6 Make fill and outline labels go above color buttons 2018-07-06 15:32:31 -04:00
DD Liu
90bc640dbb Fix reshape 2018-07-06 11:29:06 -04:00
Paul Kaplan
20228dfe0a Check for curved points as well as selected items for reshape delete 2018-07-06 11:27:48 -04:00
Paul Kaplan
fb460e3eb3 Add delete button for reshape tool also
The delete code already handles the pointwise deletion correctly, just needed to add it to the tool row
2018-07-05 14:17:20 -04:00
Paul Kaplan
a837b9ced6 Add delete button to mode tools for select tool 2018-07-05 14:16:43 -04:00
Paul Kaplan
74196228f1
Merge pull request #542 from paulkaplan/increase-tool-visibility
Increase selected tool visibility by making the icon white and bg blue.
2018-07-05 08:55:29 -04:00
Paul Kaplan
e772907023 Increase selected tool visibility by making the icon white and bg blue.
Resolves #375
2018-06-29 08:30:47 -04:00
Paul Kaplan
06a3ab7390
Merge pull request #537 from fsih/bitSelectTool
Bitmap select tool
2018-06-29 07:50:44 -04:00
DD Liu
e215b8a9b8 Fix issue with pasting vector into bitmap 2018-06-28 17:52:15 -04:00
Paul Kaplan
400f31e7ab Use the tool description as the button title to improve accessibility. 2018-06-28 09:54:49 -04:00
DD Liu
e2cc5e46b0 Merge branch 'develop' into bitSelectTool 2018-06-28 02:18:01 -04:00
DD Liu
d7bd6280ed clean up 2018-06-28 02:04:24 -04:00
DD Liu
0483d65413 Fix paste and transform bugs 2018-06-28 01:54:05 -04:00
DD Liu
eed84d8cf2 Handle flip in bitmap 2018-06-28 00:21:01 -04:00
DD Liu
a04088898e keep reference to selection 2018-06-27 23:42:29 -04:00
DD
ddca91a567 Fix the undo bug, but this time it's more real 2018-06-27 15:29:13 -04:00
Florrie
0176dd7eed Fix scroll speed on Firefox (#532)
Copied from https://github.com/LLK/scratch-blocks/pull/1427/
2018-06-26 16:15:50 -04:00
DD
7aa74d7ffd wip 2018-06-26 16:04:38 -04:00
DD Liu
093c3d03bb
Redo fill logic (#525) 2018-06-26 14:53:03 -04:00
DD
8759a3306f Keep scaled down images from becoming blurry 2018-06-25 19:37:47 -04:00
DD
f4df0e07af Redo fill logic 2018-06-25 16:57:56 -04:00
DD
57e3f3c8cb Handle undo 2018-06-25 11:51:33 -04:00
DD
a0faa1418e Fix flipped resizing 2018-06-21 10:43:41 -04:00
DD Liu
9c73d1a7d9 Add files 2018-06-21 10:22:24 -04:00
DD
644655d25e Bitmap select tool 2018-06-20 21:26:40 -04:00
DD Liu
d7298c0c43
Bit text tool (#515) 2018-06-19 14:54:29 -04:00
DD Liu
a70f8e1f36
Bitmap Oval tool (#516) 2018-06-19 14:20:06 -04:00
Paul Kaplan
512d39e63b Better fix for bit brush on touch, including isEraser fix (#512) 2018-06-14 12:01:01 -04:00
DD Liu
c7e0caaca7
Fill tool (#504) 2018-06-14 11:44:11 -04:00
DD Liu
e9deddba05
reungroup (#499) 2018-06-14 11:38:06 -04:00
DD Liu
4cadcb3da3
Bitmap eraser tool (#507) 2018-06-14 10:35:02 -04:00
Paul Kaplan
f785ac0c42 Fix line tool for touch as well 2018-06-13 16:45:11 -04:00
Paul Kaplan
5f8bca6b08 Prevent color pickers from sliding the UI 2018-06-13 16:38:47 -04:00
Paul Kaplan
19a0061bdf Make sure tmpCanvas exists before drawing it 2018-06-13 16:29:54 -04:00
DD Liu
389eba6284
Bitmap rectangle tool (#494) 2018-06-11 11:48:35 -04:00
DD Liu
ebed37390d
Move convert to bitmap into bitmap helper (#490) 2018-06-07 11:26:26 -04:00
Paul Kaplan
a9ba5eac9b Protect against drawing zero sized images, fixing Firefox crashes (#495)
* Protect against drawing zero sized images, fixing Firefox crashes

* Remove removing raster

Let the layer.js helper manage the raster object
2018-06-07 10:19:06 -04:00
DD Liu
44f71d9f72
Fix drawing rectangle while holding shift (#493) 2018-06-07 10:01:23 -04:00
DD Liu
63198c05b4
Fix firefox wrap and opaque text selection (#474) 2018-05-24 14:16:00 -04:00
DD Liu
09babb15c5
Safety check cursor preview (#470) 2018-05-23 16:39:18 -04:00
DD Liu
df93408196
Ungroup layer groups generated by paper (#453) 2018-05-21 11:55:01 -04:00
Ray Schamp
3df9c0862d
Revert "Temporarily hide the font dropdown" 2018-05-21 10:05:43 -04:00
Ray Schamp
638602bb0d Temporarily hide the text tool
This is for the GUI release to master today and should be reverted after that merge.
2018-05-21 09:46:03 -04:00
DD Liu
f9e00afdc8
Dont translate fonts and increase default font size (#450)
* Remove internationalization from all font names
* Bump up the default font sizes
2018-05-17 15:34:36 -04:00
DD Liu
0240abcfe3
Font tool (#443)
Add font picker
2018-05-17 10:37:02 -04:00
DD Liu
7f216defd2
Add todo to add viewbox (#446) 2018-05-16 15:34:00 -04:00
Paul Kaplan
40ccb3c75c Fix linting 2018-05-14 14:28:36 -04:00
DD Liu
830dd3c9ee
Use font inlining method from scratch svg render (#427) 2018-05-10 13:46:23 -04:00
DD Liu
fd6268c940
Queue perform snapshot (#430) 2018-05-09 10:51:49 -04:00
DD
b638b2b9ca Listen to undo state in fixedTools 2018-05-04 13:35:19 -04:00
DD Liu
d71ca021f1
Hide top row buttons in bitmap mode (#423) 2018-05-03 14:23:00 -04:00
DD Liu
10d35d066c
Fix costume string description (#422) 2018-05-03 10:53:43 -04:00
Paul Kaplan
aef0a03b77
Merge pull request #416 from paulkaplan/fix-edge-button-text
Fix button text wrapping in Edge
2018-05-02 15:16:11 -04:00
DD Liu
c00234c1a7
Fix image conversion in firefox and add fallback (#417) 2018-05-02 15:09:05 -04:00
Paul Kaplan
4cf7349126 Fix button text wrapping in Edge 2018-05-02 14:57:38 -04:00
DD Liu
89133f42e5
Update import and export types (#412)
* Import/export bitmap
* Fix playground and readme
* Use constants instead of changing zoom level for every import/export
2018-05-01 16:18:24 -04:00
DD Liu
3d99044ccf
Import and export bitmaps (#404)
* Rename svg to image

* Import/export bitmap

* Fix playground and readme

* Fix lint

* Assume strings are svgs
2018-04-26 18:45:50 -04:00
DD Liu
af29e606d8
Merge pull request #405 from fsih/lineTool
Add line tool
2018-04-26 16:36:17 -04:00
DD
ed114bb073 Move getBrushMark to helper 2018-04-26 14:54:44 -04:00
DD
86bec30790 Remove ungroup on import 2018-04-26 11:00:28 -04:00
DD Liu
0755df9990 Add line tool 2018-04-25 15:26:48 -04:00
DD
f08c3e140f Fix merge 2018-04-20 11:27:09 -04:00
DD
bec01149ea Fix review comments 2018-04-20 11:20:38 -04:00
DD Liu
b93f902827 double defaults 2018-04-20 11:17:42 -04:00
DD Liu
8d55265de1 Double resolution on import and halve on export 2018-04-20 11:17:42 -04:00
DD Liu
57f3be36ec
Merge pull request #391 from fsih/tooltips
Tooltips
2018-04-20 11:14:26 -04:00
DD Liu
99534eb24c
Merge pull request #387 from fsih/raster
Bitmap brush
2018-04-20 11:05:44 -04:00
DD
88c9f17998 fix review comments 2018-04-20 10:57:10 -04:00
DD
bfb3948244 Add coming soon tooltips to other tools 2018-04-18 15:03:34 -04:00
DD
15c3f44388 Fix lint 2018-04-17 15:55:40 -04:00
DD
d6111ed031 Remove unused code 2018-04-17 15:01:10 -04:00
DD
bda357bca6 Delete extra tools 2018-04-17 14:57:50 -04:00
DD
87d9386906 Allow odd numbers for very small brush sizes for detail 2018-04-17 14:51:34 -04:00
DD
ca42dc7735 Double pixel brush drawin working 2018-04-13 11:33:47 -04:00
Jacco Kulman
507047e245 Fix whitespace 2018-04-13 11:33:04 +02:00
Jacco Kulman
71e01dd9c4 Escape end text edit mode 2018-04-13 08:16:43 +02:00
DD
420e1013cf Use a separate state to track the size of the bitmap brush tool from the brush tool 2018-04-12 16:56:54 -04:00
DD
2043ee4609 Merge branch 'develop' into raster 2018-04-12 14:33:26 -04:00
DD
64686feb8b review comments 2018-04-12 14:27:07 -04:00
DD
c9c04745bc Hide stroke indicators in bitmap mode 2018-04-12 14:23:19 -04:00
DD
9c84537a42 Switch tools when switching editors. Pipe through vector brush size for now. 2018-04-12 10:56:16 -04:00
DD
7855ae8893 Merge branch 'develop' into raster 2018-04-11 18:05:13 -04:00
DD
a868d29d82 Add tool to bitmap editor 2018-04-11 18:04:55 -04:00
DD
8622bfab69 Merge branch 'develop' into convertToBitmapShapeRendering 2018-04-11 15:50:39 -04:00
DD Liu
bf1d4ca82a
Merge pull request #370 from fsih/convertToBitmap
Convert to bitmap
2018-04-11 15:50:18 -04:00
DD Liu
6252366759
Merge pull request #360 from fsih/fillTransparentText
Add ability to fill transparent text
2018-04-11 14:45:56 -04:00
DD Liu
e14198faea
Merge pull request #369 from fsih/boundingBoxToolOnNoSelection
Make sure to remove the bounding box when no items are selected
2018-04-11 14:32:18 -04:00
DD
41a68b1aea Merge branch 'develop' into convertToBitmap 2018-04-11 10:36:14 -04:00