Karishma Chadha
d9b5dc09ce
Changing === to ==
2017-11-20 17:01:42 -05:00
Karishma Chadha
efc74609ac
Refactoring 'broadcast_msg' to be referenced via a constant in core/constants instead of being hard-coded everywhere.
2017-11-20 16:53:58 -05:00
kchadha
8c8b0d2cc2
Merge branch 'develop' into broadcast-message-functionality
2017-11-20 12:08:23 -05:00
Karishma Chadha
c1044047f0
Changing new message constant name to be more useful because Blockly.Msg.NEW_MESSAGE will probably get confusing.
2017-11-20 11:45:27 -05:00
Paul Kaplan
f9cd4fa833
Merge pull request #1246 from paulkaplan/too-much-input
...
Fix expanding field_textinput width for label editors
2017-11-17 15:42:12 -05:00
Karishma Chadha
cd5fe76811
Another comment clarification.
2017-11-17 13:59:27 -05:00
Karishma Chadha
ebd3978cde
Make one of the comments clearer.
2017-11-17 13:54:35 -05:00
Paul Kaplan
ee3aee18ee
Fix rendering for solitary fields
2017-11-17 13:45:10 -05:00
Rachel Fenichel
d015cc08c5
Merge pull request #1236 from rachel-fenichel/bugfix/double_init
...
Return early from field init if the field has already been initialized.
2017-11-17 10:20:04 -08:00
Rachel Fenichel
11a72e15e6
Merge pull request #1239 from rachel-fenichel/bugfix/label_editor_background
...
Tweak text input rendering when not on a shadow block
2017-11-17 10:19:01 -08:00
Paul Kaplan
fc42d581e6
Fix field_textinput width when not in a shadow
2017-11-17 11:33:27 -05:00
Karishma Chadha
6eafe6ed51
If a field dropdown is used to create a new message, the field then gets updated with the name of the newly created message. There are also some todo comments here for future work that has been documented in two github issues ( #1244 and #1245 )
...
.
2017-11-17 10:49:46 -05:00
Rachel Fenichel
ab788e21c1
Tweak text input rendering when not on a shadow block
2017-11-16 15:34:39 -08:00
Rachel Fenichel
ed072e258c
Return early from field init if the field has already been initialized.
2017-11-16 14:27:31 -08:00
Paul Kaplan
010668a082
Fix tests!
2017-11-16 17:05:47 -05:00
Paul Kaplan
08c975299a
Refactor create button code
2017-11-16 17:05:47 -05:00
Paul Kaplan
20aaefe810
Update blocks for the procedure flyout category
2017-11-16 17:05:45 -05:00
Rachel Fenichel
1c888617fe
Merge pull request #1225 from rachel-fenichel/feature/custom_procedure_editor
...
Custom procedure editing: renaming, adding, and deleting inputs and labels
2017-11-16 13:33:49 -08:00
Rachel Fenichel
c865f36837
Apply new names for procedure components
2017-11-16 13:18:53 -08:00
Karishma Chadha
9ddf8a79a9
Adding ability to create a new broadcast message using the dropdown option. Broadcast messages are now typed variables with the variable type as 'broadcast_msg'. Needed to do some extra work to translate variables from blocks to XML correctly because the default broadcast messages were getting added as new variables with the incorrect type upon trying to move any of the broadcast message related blocks from the toolbar into the workspace because it was trying to create a new variable with a different type than already existed. Currently, broadcast message names conflict with variable names, and I need to make it so that isn't so. Additionally, need to update the source block's message name after creation of a new message via the dropdown.
2017-11-16 11:45:59 -05:00
Paul Kaplan
b5714adc01
Merge pull request #1224 from paulkaplan/use-list-block
...
Use data_listcontents instead of data_variable for list getter block
2017-11-13 11:01:53 -05:00
Paul Kaplan
3838208bf7
Use data_listcontents instead of data_variable for list getter block
2017-11-10 09:36:32 -05:00
Rachel Fenichel
d014a7de6e
Make inputs own input shapes, and dispose of them correctly
2017-11-09 13:29:51 -08:00
Rachel Fenichel
e836137ebf
Merge pull request #1209 from LLK/rachel-fenichel-patch-1
...
Check workspace.isDragging() instead of Blockly.dragMode_
2017-11-07 13:32:36 -08:00
Paul Kaplan
fa42959241
Merge pull request #1212 from paulkaplan/bring-back-lists
...
Bring back the list data category
2017-11-06 15:37:55 -05:00
Paul Kaplan
86c5f3b3f2
Bring back the list data category
2017-11-06 13:42:45 -05:00
Paul Kaplan
807743d20f
Change variableType to variabletype in xml.
...
Scratch-blocks version of blockly pr #1422
2017-11-06 10:29:43 -05:00
Rachel Fenichel
df2e5c90bb
Check workspace.isDragging() instead of Blockly.dragMode_
...
Scratch-blocks version of https://github.com/google/blockly/pull/1418
2017-11-03 16:08:00 -07:00
DD Liu
317cb82581
Revert "Improve insertion markers"
2017-11-01 14:32:21 -04:00
DD Liu
b01dcafcf8
Revert "Improve insertion markers"
2017-11-01 14:30:13 -04:00
Eric Rosenbaum
6ae469cd0a
Merge pull request #1198 from ericrosenbaum/feature/category-menu-style
...
Tighten up the category menu
2017-11-01 11:53:17 -04:00
Eric Rosenbaum
8e2f353cff
Adjust toolbox width to use new category menu width
2017-11-01 11:43:03 -04:00
Eric Rosenbaum
619fb631e7
Set category menu width in px for clarity
2017-11-01 11:42:50 -04:00
Eric Rosenbaum
3f40225536
Tighten up the category menu
...
To make space for additional items
2017-10-31 18:30:24 -04:00
Paul Kaplan
31a3a13b79
Merge pull request #1197 from paulkaplan/default-change-by-value
...
Default change by value
2017-10-31 17:23:03 -04:00
Paul Kaplan
db865f24f4
Remove unused variable category code.
...
It had been moved to the data_category.js file. It is dead code now.
2017-10-31 09:34:19 -04:00
Paul Kaplan
d735d33351
Change "change by" default value to 1 instead of 0.
2017-10-31 09:30:35 -04:00
Paul Kaplan
2cf42d13db
Make XML creation for data category more explicit.
...
But no changes to defaults.
2017-10-31 09:29:58 -04:00
DD Liu
b0a3e80c65
fix insertion blocks that shouldnt be there
2017-10-30 20:17:14 -04:00
Rachel Fenichel
0eb4e2ee81
Merge pull request #1193 from rachel-fenichel/feature/eyes
...
Improve insertion markers
2017-10-30 13:08:15 -07:00
Rachel Fenichel
a2f2612f02
disable for C and E blocks
2017-10-30 13:02:24 -07:00
Rachel Fenichel
a02d69e09b
Make the 'ok' button apply a mutation in the custom procedure playground
2017-10-27 11:12:46 -07:00
picklesrus
b48b0dc67e
Add the new clearWorkspaceAndLoadFromXml to the set of globals so the compiler does not rename it. This should have been part of #1178 ( #1184 )
2017-10-26 11:16:45 -07:00
Paul Kaplan
e04cf81727
Merge pull request #1182 from paulkaplan/fix-flyout-var-ids
...
Re-fix the flyout variable block IDs
2017-10-25 14:43:53 -04:00
Paul Kaplan
4dc0e845b1
Add id to comment showing what it looks like
2017-10-25 14:36:55 -04:00
Paul Kaplan
9d03bf1511
Re-fix the flyout variable block IDs
2017-10-25 12:43:08 -04:00
Rachel Fenichel
6a0d58bb5d
Merge pull request #1179 from rachel-fenichel/bugfix/no_toolbox_ws
...
Don't parse the default toolbox if it doesn't exist
2017-10-25 09:13:16 -07:00
Rachel Fenichel
ce31ae9743
Don't parse the default toolbox if it doesn't exist
2017-10-24 18:03:17 -07:00
picklesrus
a54957c637
Add an xml utility to clear the workspace and then load xml into the dom. In it, use a new toolbox refresh mechanism that allows for batch updates. It mirrors the setResizesEnabled mechanism for managing batch updates to the workspace.
2017-10-24 14:33:53 -07:00
picklesrus
2996c86c53
Do not refresh the toolbox when a new variable is created on the work… ( #1166 )
...
* Do not refresh the toolbox when a new variable is created on the workspace but it already exists in the variable map. This gets rid of some calls to Toolbox.refreshSelection. e.g. when you drag a variable block out of the toolbox, we were refreshing the toolbox. It will also help with xml loading for workspaces using multiple of the same variable reporter. More needs to be done to solve #879 , but this helps a little.
* Fix typo
2017-10-24 12:40:22 -07:00
