Commit graph

3258 commits

Author SHA1 Message Date
Karishma Chadha
d9b5dc09ce Changing === to == 2017-11-20 17:01:42 -05:00
Karishma Chadha
efc74609ac Refactoring 'broadcast_msg' to be referenced via a constant in core/constants instead of being hard-coded everywhere. 2017-11-20 16:53:58 -05:00
kchadha
d65ac790a0
Merge branch 'develop' into broadcast-message-functionality 2017-11-20 12:09:03 -05:00
kchadha
8c8b0d2cc2
Merge branch 'develop' into broadcast-message-functionality 2017-11-20 12:08:23 -05:00
Karishma Chadha
2d0d9dba0b Making default name for broadcast messages amenable to translation. 2017-11-20 12:05:55 -05:00
Karishma Chadha
c1044047f0 Changing new message constant name to be more useful because Blockly.Msg.NEW_MESSAGE will probably get confusing. 2017-11-20 11:45:27 -05:00
Paul Kaplan
f9cd4fa833
Merge pull request #1246 from paulkaplan/too-much-input
Fix expanding field_textinput width for label editors
2017-11-17 15:42:12 -05:00
Karishma Chadha
cd5fe76811 Another comment clarification. 2017-11-17 13:59:27 -05:00
Karishma Chadha
ebd3978cde Make one of the comments clearer. 2017-11-17 13:54:35 -05:00
Paul Kaplan
ee3aee18ee Fix rendering for solitary fields 2017-11-17 13:45:10 -05:00
Rachel Fenichel
d015cc08c5
Merge pull request #1236 from rachel-fenichel/bugfix/double_init
Return early from field init if the field has already been initialized.
2017-11-17 10:20:04 -08:00
Rachel Fenichel
11a72e15e6
Merge pull request #1239 from rachel-fenichel/bugfix/label_editor_background
Tweak text input rendering when not on a shadow block
2017-11-17 10:19:01 -08:00
Paul Kaplan
fc42d581e6 Fix field_textinput width when not in a shadow 2017-11-17 11:33:27 -05:00
Karishma Chadha
6eafe6ed51 If a field dropdown is used to create a new message, the field then gets updated with the name of the newly created message. There are also some todo comments here for future work that has been documented in two github issues (#1244 and #1245)
.
2017-11-17 10:49:46 -05:00
Paul Kaplan
b90b315154
Merge pull request #1232 from paulkaplan/custom-procedure-flyout-category
Custom procedure flyout category
2017-11-17 10:21:57 -05:00
Rachel Fenichel
ab788e21c1 Tweak text input rendering when not on a shadow block 2017-11-16 15:34:39 -08:00
Rachel Fenichel
ed072e258c Return early from field init if the field has already been initialized. 2017-11-16 14:27:31 -08:00
Paul Kaplan
010668a082 Fix tests! 2017-11-16 17:05:47 -05:00
Paul Kaplan
08c975299a Refactor create button code 2017-11-16 17:05:47 -05:00
Paul Kaplan
20aaefe810 Update blocks for the procedure flyout category 2017-11-16 17:05:45 -05:00
Rachel Fenichel
1c888617fe
Merge pull request #1225 from rachel-fenichel/feature/custom_procedure_editor
Custom procedure editing: renaming, adding, and deleting inputs and labels
2017-11-16 13:33:49 -08:00
Rachel Fenichel
c865f36837 Apply new names for procedure components 2017-11-16 13:18:53 -08:00
Rachel Fenichel
12f2fda994 Use input.name and stop passing around the id 2017-11-16 13:18:53 -08:00
Rachel Fenichel
d241de93ca Get rid of the param map 2017-11-16 13:18:53 -08:00
Rachel Fenichel
3f170d8c40 procedures_mutator_root -> procedures_declaration_root 2017-11-16 13:18:53 -08:00
Rachel Fenichel
d35768bb5a argument names -> display names 2017-11-16 13:18:53 -08:00
Rachel Fenichel
2e614ea32a Remove procedures_param 2017-11-16 13:18:53 -08:00
Rachel Fenichel
ffb5c9e369 Extract shared code; general cleanup 2017-11-16 13:18:33 -08:00
Karishma Chadha
9ddf8a79a9 Adding ability to create a new broadcast message using the dropdown option. Broadcast messages are now typed variables with the variable type as 'broadcast_msg'. Needed to do some extra work to translate variables from blocks to XML correctly because the default broadcast messages were getting added as new variables with the incorrect type upon trying to move any of the broadcast message related blocks from the toolbar into the workspace because it was trying to create a new variable with a different type than already existed. Currently, broadcast message names conflict with variable names, and I need to make it so that isn't so. Additionally, need to update the source block's message name after creation of a new message via the dropdown. 2017-11-16 11:45:59 -05:00
Paul Kaplan
b5714adc01
Merge pull request #1224 from paulkaplan/use-list-block
Use data_listcontents instead of data_variable for list getter block
2017-11-13 11:01:53 -05:00
Rachel Fenichel
d0611a3027 Add back use of buildShadowDom, but only in the single case that needs it 2017-11-10 11:53:49 -08:00
Rachel Fenichel
aa00bcc6ff Get rid of reattachBlock 2017-11-10 11:53:49 -08:00
Rachel Fenichel
702def8c94 Cleanup 2017-11-10 11:53:49 -08:00
Rachel Fenichel
da17573fe4 'add random input' and 'remove random input' buttons 2017-11-10 11:53:49 -08:00
Rachel Fenichel
9854afeedb Add labels and inputs, rename them, and push changes to the right side playground 2017-11-10 11:53:13 -08:00
Rachel Fenichel
1113c5d4a7 Rename inputs based on an updated mutation string! 2017-11-10 11:53:13 -08:00
Rachel Fenichel
637fdb5722
Merge pull request #1219 from rachel-fenichel/feature/input_shapes
Make inputs own input shapes, and dispose of them correctly
2017-11-10 09:35:12 -08:00
Paul Kaplan
3838208bf7 Use data_listcontents instead of data_variable for list getter block 2017-11-10 09:36:32 -05:00
Rachel Fenichel
d014a7de6e Make inputs own input shapes, and dispose of them correctly 2017-11-09 13:29:51 -08:00
Rachel Fenichel
6cdf691860
Merge pull request #1214 from rachel-fenichel/bugfix/custom_procedure_multimutation
Fix applying multiple mutations to a single procedure_callnoreturn_internal block
2017-11-07 13:33:37 -08:00
Rachel Fenichel
e836137ebf
Merge pull request #1209 from LLK/rachel-fenichel-patch-1
Check workspace.isDragging() instead of Blockly.dragMode_
2017-11-07 13:32:36 -08:00
Rachel Fenichel
9d8a597490 Fix naming 2017-11-06 15:32:56 -08:00
Rachel Fenichel
181f9c6c39 Documentation, fixes for return values 2017-11-06 15:31:40 -08:00
Rachel Fenichel
5010a330af Handle repeated mutations on the internal procedure caller block 2017-11-06 15:12:34 -08:00
Paul Kaplan
fa42959241
Merge pull request #1212 from paulkaplan/bring-back-lists
Bring back the list data category
2017-11-06 15:37:55 -05:00
Paul Kaplan
86c5f3b3f2 Bring back the list data category 2017-11-06 13:42:45 -05:00
Paul Kaplan
cc410c1326
Merge pull request #1211 from paulkaplan/fix-camel-case-xml
Change variableType to variabletype in xml.
2017-11-06 13:42:08 -05:00
Paul Kaplan
807743d20f Change variableType to variabletype in xml.
Scratch-blocks version of blockly pr #1422
2017-11-06 10:29:43 -05:00
Rachel Fenichel
df2e5c90bb
Check workspace.isDragging() instead of Blockly.dragMode_
Scratch-blocks version of https://github.com/google/blockly/pull/1418
2017-11-03 16:08:00 -07:00
Rachel Fenichel
8008975a2d
Merge pull request #1203 from rachel-fenichel/bugfix/custom_procedure_multimutation
Handle mutating procedure calls multiple times
2017-11-03 15:47:29 -07:00