Neil Fraser
d906095698
Style improvements. No functional changes. ( #1367 )
2017-10-19 17:08:17 -04:00
Nick Allred
86a7b939cb
Subtract metrics.contentTop from metrics.viewTop so that the flyout does not begin to scroll down once the delta is smaller than the value of metrics.contentTop ( #1309 )
2017-10-19 16:57:54 -04:00
Rachel Fenichel
5e386d5bd0
Fix iOS toolbox flashing on tap ( #1351 )
2017-10-19 16:57:47 -04:00
Rachel Fenichel
e802fb921b
Unify code for positioning the widget div ( #1334 )
...
* New widget div functions, used in context menu code
* Make all widget div positioning functions use the same argument order
* Use new widget div functions for fields
* share code for measuring menu size
* Get rid of positionMenu
* Update copyright date
* Rebuild blockly_uncompressed because there's a new require in town
2017-10-19 14:58:41 -04:00
Rachel Fenichel
6868b9cccb
Code cleanup: widget creation ( #1332 )
2017-10-19 14:47:32 -04:00
Sam El-Husseini
c55824d619
Avoid IE and Edge re-rendering ( #1326 )
...
* Fix wrong width of field_dropdown with an image on Edge / IE
* Avoid re-rendering on IE and Edge by using getBBox().width to compute the text width on those browsers
2017-10-19 14:43:43 -04:00
Rachel Fenichel
c2e7f6dfe8
Make dropdowns update correctly when you switch between images. ( #1321 )
2017-10-19 14:32:12 -04:00
Rachel Fenichel
971c0c8316
Allow the toolbox to scroll ( #1319 )
...
* Allow the toolbox to scroll
* Switch from onMouseDown to onClick_ for toolbox category taps and clicks.
2017-10-19 14:13:34 -04:00
Neil Fraser
75f52db086
Strip licences from compiled code. ( #1318 )
2017-10-19 14:04:45 -04:00
Sam El-Husseini
9ce71d1099
Fix flyout labels causing flyout scrolling issues ( #1301 )
2017-10-19 13:04:21 -04:00
Rachel Fenichel
b033c8d3ab
Create WorkspaceViewport class ( #1291 )
...
* Create WorkspaceViewport class
* Update comments
* Move workspace viewport functions back to the workspace for now
* whitespace
2017-10-19 12:57:28 -04:00
Rachel Fenichel
504c458003
Add annotations for units to scrollbar.js ( #1290 )
...
* Add annotations for units to scrollbar.js
* Update comments
2017-10-19 12:38:37 -04:00
Rachel Fenichel
6fb59ccc78
Decompose the showEditor_ function in FieldTextInput ( #1285 )
...
* Explicit annotations
* Decompose the showEditor_ function in FieldTextInput
* Remove extra newline
2017-10-19 12:35:11 -04:00
Rachel Fenichel
e38411c07f
Clean up code in FieldTextInput ( #1284 )
...
* Clean up code in FieldTextInput
* Explicit annotations
* Remove extra newline
2017-10-19 12:29:10 -04:00
Evan W. Patton
910284856e
Implement Blockly.Events.filter in linear time ( #1205 )
...
* Implement Blockly.Events.filter in linear time
For large App Inventor projects (order 1k+ blocks, 100+ top-level
blocks), the O(n^2) behavior of Blockly.Event.filter was causing
performance issues when rearranging blocks or pasting from the
backpack. This commit provides a linear merge implementation using a
key that uniquely identifies a block so that multiple events targeting
the same block are merged. This change benefits from O(1) amortized
lookup using an object as a key-value store.
* Add event filter unit tests and fix logic bugs
* Update Blockly.Events.filter unit tests
2017-10-19 12:03:51 -04:00
Rachel Fenichel
5ec9195ff1
Bring the most recently edited stack to the front at the end of a drag. ( #1283 )
2017-10-19 12:03:20 -04:00
Rachel Fenichel
eed4e33f84
Escape variable names correctly when serializing to XML ( #1279 )
2017-10-19 12:02:42 -04:00
picklesrus
0c09d60ff7
Fix #1275 by adding a more specific rule for overflow:visible on the … ( #1280 )
...
* Fix #1275 by adding a more specific rule for overflow:visible on the drag surface svg. This wins out over a common bootstrap rule that says: svg:not(:root) {overflow:hidden} and helps avoid a difficult problem for Blockly users to diagnose.
* Update css.js
2017-10-19 11:59:21 -04:00
Rachel Fenichel
92e6d339f4
Code cleanup in BlockSvg.prototype.tab ( #1277 )
2017-10-19 11:56:44 -04:00
RoboErikG
348aba771e
Missed one use of string instead of .property in extensions.js ( #1262 )
2017-10-19 11:53:00 -04:00
RoboErikG
88e404732d
Update extensions.js to be compatible with ADVANCED_OPTIMIZATIONS ( #1253 )
...
* Update extensions.js to be compatible with ADVANCED_OPTIMIZATIONS
We were using strings to check for the existence of properties on
a mutator, which breaks if those properties were renamed by the
closure compiler. This updates all of the uses to direct function
references so that anyone building with advanced optimizations turned
on will get the correct method references in their mutators.
fixes #1251
* Update to extensions.js for advanced optimizations
Some minor updates to making extensions.js work with advanced
optimizations.
* use === undefined instead of typeof == 'undefined'
2017-10-19 11:52:50 -04:00
marisaleung
6a9617c77d
Fix type tags and todo placement.
2017-10-19 11:51:30 -04:00
Neil Fraser
a119cca83b
Compatibility for Closure Compiler. ( #1240 )
2017-10-19 11:47:04 -04:00
Paul Kaplan
145bbdbffa
Merge pull request #1148 from paulkaplan/fix-color-slider-stability
...
Fix unstable color sliders by tracking HSV internally
2017-10-18 13:17:28 -04:00
Paul Kaplan
6fd99e21a8
Fix the ranges on the sliders to go the entire range.
2017-10-18 12:36:54 -04:00
Paul Kaplan
33f994288a
Use hsv to track color value while in editor
2017-10-18 09:57:52 -04:00
Rachel Fenichel
d872c673c8
Fix findCallers
2017-10-17 16:58:41 -07:00
Rachel Fenichel
d6515e52bc
Find all scratch-blocks custom procedure calls
2017-10-17 16:58:41 -07:00
Rachel Fenichel
4783e7fd9d
Merge pull request #1144 from rachel-fenichel/bugfix/fix_tests
...
Fix tests
2017-10-17 09:40:15 -07:00
Rachel Fenichel
fe57056c2f
Merge pull request #1142 from rachel-fenichel/cleanup/ws_context_menu
...
Cleanup of workspace context menu code
2017-10-16 10:04:47 -07:00
Rachel Fenichel
685d293c8b
Check for the existence of a message before calling replace on it, to avoid a crash
2017-10-13 16:16:22 -07:00
Rachel Fenichel
9771120ab4
Cleanup of workspace context menu code
2017-10-13 13:36:37 -07:00
Paul Kaplan
3d4f237f08
Merge pull request #1141 from paulkaplan/block-rendering-performance
...
Block rendering performance
2017-10-13 16:28:41 -04:00
Paul Kaplan
360222d4ea
Allow className changes by field subclass to prevent layout thrashing
2017-10-13 16:00:37 -04:00
Paul Kaplan
2a6ff11202
Check for timeout pid before calling clearTimeout
2017-10-13 16:00:37 -04:00
Paul Kaplan
8eedd0b9f0
Remove initial updateTransform from flyout button
2017-10-13 16:00:37 -04:00
Paul Kaplan
0ac07db628
Use Blockly.Field.getCachedWidth instead of non-caching method
2017-10-13 16:00:37 -04:00
Rachel Fenichel
9636c5dcb7
Merge pull request #1137 from rachel-fenichel/bugfix/1135
...
Custom context menu for procedure calls
2017-10-13 12:27:07 -07:00
Rachel Fenichel
fda3880e78
Merge pull request #1140 from rachel-fenichel/bugfix/1129
...
Fix argument reporter rendering with short text
2017-10-13 10:41:44 -07:00
Rachel Fenichel
995222fb2e
Merge pull request #1138 from rachel-fenichel/bugfix/1133
...
Enable bulk updating during duplication
2017-10-13 10:07:28 -07:00
Rachel Fenichel
11a13b2eb3
Fix argument reporter rendering with short text
2017-10-12 17:28:13 -07:00
Rachel Fenichel
cbe4aec9e6
Make functions package instead of private
2017-10-12 15:22:49 -07:00
Rachel Fenichel
f34ac37f2f
Move context menu helpers to contextmenu.js
2017-10-12 15:20:57 -07:00
Rachel Fenichel
5f01772df6
Create helper functions for creating block context menu options
2017-10-12 15:07:18 -07:00
Rachel Fenichel
970db3cef9
Enable bulk updating during duplication
2017-10-12 14:17:26 -07:00
Rachel Fenichel
f928a7b9d6
Custom context menu for procedure calls
2017-10-12 13:39:24 -07:00
Rachel Fenichel
a856dee687
Remove dead code
2017-10-12 11:59:48 -07:00
Rachel Fenichel
d3e7bfb081
Tinker with constants for drawing the define block.
2017-10-12 11:41:48 -07:00
Rachel Fenichel
52dac2094e
Move connections at the end of render
2017-10-11 17:02:56 -07:00
Paul Kaplan
0e1bf835e8
Fix resizesEnabled flag from bulkUpdating change
2017-10-11 10:06:10 -04:00
