Commit graph

3132 commits

Author SHA1 Message Date
Neil Fraser
d906095698 Style improvements. No functional changes. (#1367) 2017-10-19 17:08:17 -04:00
Paul Kaplan
6fced52ef8 Add new test to the vertical and horizontal test runner files 2017-10-19 16:57:54 -04:00
Nick Allred
86a7b939cb Subtract metrics.contentTop from metrics.viewTop so that the flyout does not begin to scroll down once the delta is smaller than the value of metrics.contentTop (#1309) 2017-10-19 16:57:54 -04:00
Rachel Fenichel
5e386d5bd0 Fix iOS toolbox flashing on tap (#1351) 2017-10-19 16:57:47 -04:00
Rachel Fenichel
3d37a8ae9e Tests for widget div math. (#1338)
* New widget div functions, used in context menu code

* Make all widget div positioning functions use the same argument order

* Use new widget div functions for fields

* share code for measuring menu size

* Get rid of positionMenu

* Update copyright date

* Rebuild blockly_uncompressed because there's a new require in town

* Test for widget div math
2017-10-19 14:59:02 -04:00
Rachel Fenichel
e802fb921b Unify code for positioning the widget div (#1334)
* New widget div functions, used in context menu code

* Make all widget div positioning functions use the same argument order

* Use new widget div functions for fields

* share code for measuring menu size

* Get rid of positionMenu

* Update copyright date

* Rebuild blockly_uncompressed because there's a new require in town
2017-10-19 14:58:41 -04:00
Rachel Fenichel
6868b9cccb Code cleanup: widget creation (#1332) 2017-10-19 14:47:32 -04:00
Sam El-Husseini
c55824d619 Avoid IE and Edge re-rendering (#1326)
* Fix wrong width of field_dropdown with an image on Edge / IE

* Avoid re-rendering on IE and Edge by using getBBox().width to compute the text width on those browsers
2017-10-19 14:43:43 -04:00
Rachel Fenichel
c2e7f6dfe8 Make dropdowns update correctly when you switch between images. (#1321) 2017-10-19 14:32:12 -04:00
Rachel Fenichel
971c0c8316 Allow the toolbox to scroll (#1319)
* Allow the toolbox to scroll

* Switch from onMouseDown to onClick_ for toolbox category taps and clicks.
2017-10-19 14:13:34 -04:00
Neil Fraser
75f52db086 Strip licences from compiled code. (#1318) 2017-10-19 14:04:45 -04:00
Sam El-Husseini
9ce71d1099 Fix flyout labels causing flyout scrolling issues (#1301) 2017-10-19 13:04:21 -04:00
Rachel Fenichel
b033c8d3ab Create WorkspaceViewport class (#1291)
* Create WorkspaceViewport class

* Update comments

* Move workspace viewport functions back to the workspace for now

* whitespace
2017-10-19 12:57:28 -04:00
Rachel Fenichel
504c458003 Add annotations for units to scrollbar.js (#1290)
* Add annotations for units to scrollbar.js

* Update comments
2017-10-19 12:38:37 -04:00
Rachel Fenichel
6fb59ccc78 Decompose the showEditor_ function in FieldTextInput (#1285)
* Explicit annotations

* Decompose the showEditor_ function in FieldTextInput

* Remove extra newline
2017-10-19 12:35:11 -04:00
Rachel Fenichel
e38411c07f Clean up code in FieldTextInput (#1284)
* Clean up code in FieldTextInput

* Explicit annotations

* Remove extra newline
2017-10-19 12:29:10 -04:00
Evan W. Patton
910284856e Implement Blockly.Events.filter in linear time (#1205)
* Implement Blockly.Events.filter in linear time

For large App Inventor projects (order 1k+ blocks, 100+ top-level
blocks), the O(n^2) behavior of Blockly.Event.filter was causing
performance issues when rearranging blocks or pasting from the
backpack. This commit provides a linear merge implementation using a
key that uniquely identifies a block so that multiple events targeting
the same block are merged. This change benefits from O(1) amortized
lookup using an object as a key-value store.

* Add event filter unit tests and fix logic bugs

* Update Blockly.Events.filter unit tests
2017-10-19 12:03:51 -04:00
Rachel Fenichel
5ec9195ff1 Bring the most recently edited stack to the front at the end of a drag. (#1283) 2017-10-19 12:03:20 -04:00
Rachel Fenichel
eed4e33f84 Escape variable names correctly when serializing to XML (#1279) 2017-10-19 12:02:42 -04:00
picklesrus
0c09d60ff7 Fix #1275 by adding a more specific rule for overflow:visible on the … (#1280)
* Fix #1275 by adding a more specific rule for overflow:visible on the drag surface svg.  This wins out over a common bootstrap rule that says: svg:not(:root) {overflow:hidden} and helps avoid a difficult problem for Blockly users to diagnose.

* Update css.js
2017-10-19 11:59:21 -04:00
Rachel Fenichel
92e6d339f4 Code cleanup in BlockSvg.prototype.tab (#1277) 2017-10-19 11:56:44 -04:00
RoboErikG
348aba771e Missed one use of string instead of .property in extensions.js (#1262) 2017-10-19 11:53:00 -04:00
RoboErikG
88e404732d Update extensions.js to be compatible with ADVANCED_OPTIMIZATIONS (#1253)
* Update extensions.js to be compatible with ADVANCED_OPTIMIZATIONS

We were using strings to check for the existence of properties on
a mutator, which breaks if those properties were renamed by the
closure compiler. This updates all of the uses to direct function
references so that anyone building with advanced optimizations turned
on will get the correct method references in their mutators.

fixes #1251

* Update to extensions.js for advanced optimizations

Some minor updates to making extensions.js work with advanced
optimizations.

* use === undefined instead of typeof == 'undefined'
2017-10-19 11:52:50 -04:00
marisaleung
6a9617c77d Fix type tags and todo placement. 2017-10-19 11:51:30 -04:00
Neil Fraser
a119cca83b Compatibility for Closure Compiler. (#1240) 2017-10-19 11:47:04 -04:00
Paul Kaplan
5b4537a1e6 Merge pull request #1155 from LLK/revert-1149-randomize-pretty-colors
Revert "Only pick random colors with full saturation and brightness"
2017-10-19 10:32:40 -04:00
Paul Kaplan
d9d3a60631 Revert "Only pick random colors with full saturation and brightness" 2017-10-19 10:31:45 -04:00
Paul Kaplan
145bbdbffa Merge pull request #1148 from paulkaplan/fix-color-slider-stability
Fix unstable color sliders by tracking HSV internally
2017-10-18 13:17:28 -04:00
Paul Kaplan
cf35d8e7e9 Merge pull request #1147 from paulkaplan/run-tests-on-travis
Run tests on travis
2017-10-18 13:17:12 -04:00
Paul Kaplan
2c9d126ed6 Merge pull request #1149 from paulkaplan/randomize-pretty-colors
Only pick random colors with full saturation and brightness
2017-10-18 13:16:51 -04:00
Paul Kaplan
2cbed37ba5 Remove travis osx switch and pin webdriverio version 2017-10-18 12:47:20 -04:00
Paul Kaplan
b0aedbc2c4 Only pick random colors with full saturation and brightness 2017-10-18 12:37:57 -04:00
Paul Kaplan
6fd99e21a8 Fix the ranges on the sliders to go the entire range. 2017-10-18 12:36:54 -04:00
Paul Kaplan
a83cd2d9a8 Revert typo 2017-10-18 12:22:20 -04:00
Paul Kaplan
ee477fce57 Merge branch 'run-tests-on-travis' of github.com:paulkaplan/scratch-blocks into run-tests-on-travis 2017-10-18 11:55:53 -04:00
Paul Kaplan
d1ee51ee57 Move scripts folder into tests 2017-10-18 11:55:42 -04:00
Paul Kaplan
a28299d35d Merge branch 'develop' into run-tests-on-travis 2017-10-18 11:52:16 -04:00
Rachel Fenichel
1ce2e4ce4a Merge pull request #1146 from rachel-fenichel/feature/find_procedure_calls
Find all callers of a procedure by procCode
2017-10-18 08:27:59 -07:00
Paul Kaplan
33f994288a Use hsv to track color value while in editor 2017-10-18 09:57:52 -04:00
Paul Kaplan
9f7423efaf Setup selenium for travis 2017-10-18 09:45:34 -04:00
Paul Kaplan
0d7f26bd32 Update closure library and revert test runner change.
Closure library being out of date caused the test
runner as written in blockly/develop not to work.
2017-10-18 09:34:33 -04:00
Paul Kaplan
8d8cb075f5 Add webdriverio to dev deps 2017-10-18 09:29:35 -04:00
Paul Kaplan
8ec8a29e6a Fix horizontal tests 2017-10-18 09:26:49 -04:00
Paul Kaplan
660503193f Get unit tests running on travis 2017-10-18 09:06:33 -04:00
Rachel Fenichel
af6cbd8d13 reorder horizontal tests and add procedure_test.js 2017-10-17 17:02:59 -07:00
Rachel Fenichel
99fa91fb4f Include procedure tests in vertical_tests.html 2017-10-17 17:01:10 -07:00
Rachel Fenichel
46800eec34 Put tests in order 2017-10-17 17:00:30 -07:00
Rachel Fenichel
66d1383b59 tests for procedure.findCallers 2017-10-17 16:58:41 -07:00
Rachel Fenichel
d872c673c8 Fix findCallers 2017-10-17 16:58:41 -07:00
Rachel Fenichel
d6515e52bc Find all scratch-blocks custom procedure calls 2017-10-17 16:58:41 -07:00