Commit graph

3674 commits

Author SHA1 Message Date
Paul Kaplan
88383d0998 Use the main workspaces stack glow filter for both flyout and toolbox
This fixes the stack glow filter not existing for both the "simple" and "category" modes of the workspace.
2018-06-01 10:18:42 -04:00
Ray Schamp
df6b7208fb
Merge pull request #1508 from mzgoddard/dependents-no-boiler
Use shim/vertical as browser entry point
2018-05-31 18:21:31 -04:00
Paul Kaplan
f7be0a9ac7
Merge pull request #1551 from howettl/feature/field-highlighting-safari
Randomized id for svg filters
2018-05-31 16:54:16 -04:00
Lee Howett
d9c91d958d Randomized id for svg filters 2018-05-31 12:23:20 -07:00
kchadha
e38969831e
Merge pull request #1544 from kchadha/comments
Scratch Block Comments
2018-05-30 19:31:06 -04:00
Karishma Chadha
d33b884fab Make magic numbers slightly less magic... 2018-05-30 19:24:18 -04:00
Karishma Chadha
9d7c1df8b0 Swap comment top bar icons in RTL and make minimize arrow icon a little bigger. 2018-05-30 18:13:15 -04:00
Karishma Chadha
c603ef5bba Fix some RTL issues with comments. 2018-05-30 17:34:38 -04:00
Karishma Chadha
cbf148211b Block context menu still uses the 'Remove Comment' message. 2018-05-30 17:15:02 -04:00
Karishma Chadha
835a525e61 Fix the fix for RTL. 2018-05-30 16:23:07 -04:00
Karishma Chadha
0969a0dda5 Fix RTL issues. The category list/flyout can be empty when switching from LTR to RTL and vice-versa. 2018-05-30 16:15:19 -04:00
Karishma Chadha
f547cbff45 Fix comments. 2018-05-30 15:16:33 -04:00
Karishma Chadha
9a9e4c1053 Block comments and workspace comments should have the same delete option label in the context menu. Change this message to 'Delete' instead of 'Remove Comment'. 2018-05-30 15:03:04 -04:00
Karishma Chadha
1d13bca806 Minimized comments should get imported with minimize width instead of provided full size width. 2018-05-30 11:58:22 -04:00
Karishma Chadha
f55bc764d8 Breaking out scratch bubble rendering into helper functions for rendering subcomponents. 2018-05-30 11:57:41 -04:00
Karishma Chadha
1b5ce1354c Some code cleanup from PR comments. 2018-05-30 11:57:08 -04:00
Karishma Chadha
118f6bb7b4 Minimized state should use positioning (instead of ignoring) if provided. 2018-05-30 10:28:44 -04:00
Karishma Chadha
516ca3372b Use ScratchBlockComment everywhere and break out comment to dom translation into a helper function. 2018-05-30 10:28:14 -04:00
Karishma Chadha
4ac00a97a9 Fix functions referring to parent class instead of ScratchBlockComment. 2018-05-29 16:20:08 -04:00
Karishma Chadha
c9aa5dfac2 Add require for ScratchBlockComment. 2018-05-25 17:44:09 -04:00
Karishma Chadha
0141576808 Update message names and add 'Delete' option for comment context menu. 2018-05-25 17:32:29 -04:00
Karishma Chadha
4afc8e5085 Scratch block comments. 2018-05-25 17:21:31 -04:00
Paul Kaplan
6ea1343875
Merge pull request #1543 from paulkaplan/fix-unclickable-buttons
Fix unclickable flyout buttons
2018-05-25 15:40:09 -04:00
Rachel Fenichel
8bd2067dab
No trailing spaces, even on comments. 2018-05-25 11:20:51 -07:00
Rachel Fenichel
da93357d3f
Merge pull request #1533 from rachel-fenichel/ordered_children
Add ordered option to getDescendants and all uses.
2018-05-25 11:00:55 -07:00
Rachel Fenichel
5b76c6257e
Add comments to explain some subtle code. 2018-05-25 11:00:07 -07:00
Paul Kaplan
c115e6d998 Use transparent instead of none for the button fill.
Mouse up does not fire on the inside of a fill: none; path, but fill: transparent; does click
2018-05-25 13:40:33 -04:00
Ray Schamp
1708dc9bd5
Merge pull request #1537 from mzgoddard/npm-files-only
Publish only dist, TRADEMARK, README.md, package.json, and LICENSE to npm
2018-05-24 09:06:41 -04:00
kchadha
6b5665847d
Merge pull request #1539 from kchadha/require-wkspc-comment-render
Add the require for WorkspaceCommentSvg.render
2018-05-21 13:41:16 -04:00
Michael "Z" Goddard
18b1fb6785
files 2018-05-21 12:22:48 -04:00
Karishma Chadha
c33b1e35c3 Add the require for WorkspaceCommentSvg.rener 2018-05-21 11:35:31 -04:00
Rachel Fenichel
27ac3cb225
Merge pull request #1520 from rachel-fenichel/bugfix/copy_paste_flyout
Don't allow cut or paste in the flyout
2018-05-18 09:59:40 -07:00
kchadha
17f7a7e83b
Merge pull request #1521 from joshyrobot/develop
Use localeCompare for variable and procedure name comparison
2018-05-17 10:15:40 -04:00
joshyrobot
6a3b8077fb
Replace undefined locale with empty array 2018-05-16 21:46:26 -06:00
joshyrobot
b88d579611 Move compareStrings to scratchBlocksUtils 2018-05-16 16:57:05 -06:00
joshyrobot
854f4a047e Forgot a few semicolons 2018-05-16 16:52:14 -06:00
joshyrobot
965c76ec62 Move string comparison to Blockly global 2018-05-16 16:41:59 -06:00
Eric Rosenbaum
7b785595b1
Merge pull request #1524 from ericrosenbaum/feature/flyout-bottom-padding
Add padding to the bottom of the flyout
2018-05-16 17:51:27 -04:00
Rachel Fenichel
af4060c75b Add ordered option to getDescendants and all uses.
"
2018-05-16 12:51:41 -07:00
kchadha
e91e29c8d8
Merge pull request #1519 from rachel-fenichel/feature/merge_workspace_comments
Feature/merge workspace comments
2018-05-16 10:48:13 -04:00
Rachel Fenichel
bcb7c29b6d Update comment 2018-05-15 17:09:08 -07:00
Rachel Fenichel
91af54d85a Respond to review feedback 2018-05-15 17:02:35 -07:00
Eric Rosenbaum
4b50998bef Handle very long extension categories 2018-05-15 15:20:58 -04:00
Eric Rosenbaum
cc1f572a89 Add padding to bottom of flyout 2018-05-15 14:50:27 -04:00
Ray Schamp
2868b2bbf2
Merge pull request #1505 from gnarf/delay-ctm-update
update ctm logic to fit with upstream change
2018-05-15 09:44:37 -04:00
Eric Rosenbaum
8e72b20c27
Merge pull request #1517 from ericrosenbaum/feature/scroll-by-id
Scroll to category by id
2018-05-14 16:26:01 -04:00
Andrew Sliwinski
7d4a74cf29
Merge pull request #1522 from thisandagain/bugfix/1490
Add various missing translation strings
2018-05-14 16:25:21 -04:00
Eric Rosenbaum
2b04d61faf Update JSDoc 2018-05-14 11:02:54 -04:00
Eric Rosenbaum
056b76df95 Return null if no categories 2018-05-14 11:02:33 -04:00
Andrew Sliwinski
7e08190329 Add various missing translation strings. Resolves GH-1490 2018-05-13 13:34:33 -04:00