scratchfoundation/scratch-blocks
1
0
Fork 0
mirror of https://github.com/scratchfoundation/scratch-blocks.git synced 2025-07-10 03:36:13 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

Revert "Merge pull request from cwillisf/windows-fix-local-compile"

Browse source 
This reverts commit 4ffecde2bc, reversing
changes made to b63e5c62d3.

What I thought were spurious build failures on CI were apparently legit...
This commit is contained in:
Christopher Willis-Ford 2018-11-09 12:22:06 -08:00
parent 4ffecde2bc
commit 1465a9efe2
1 changed files with 2 additions and 2 deletions

4
build.py
View file

@ -323,7 +323,7 @@ class Gen_compressed(threading.Thread):
for group in [["google-closure-compiler"], dash_args]:
args.extend(filter(lambda item: item, group))
proc = subprocess.Popen(args, stdin=subprocess.PIPE, stdout=subprocess.PIPE, shell=True)
proc = subprocess.Popen(args, stdin=subprocess.PIPE, stdout=subprocess.PIPE)
(stdout, stderr) = proc.communicate()
# Build the JSON response.
@ -566,7 +566,7 @@ if __name__ == "__main__":
# Sanity check the local compiler
test_args = [closure_compiler, os.path.join("build", "test_input.js")]
test_proc = subprocess.Popen(test_args, stdin=subprocess.PIPE, stdout=subprocess.PIPE, shell=True)
test_proc = subprocess.Popen(test_args, stdin=subprocess.PIPE, stdout=subprocess.PIPE)
(stdout, _) = test_proc.communicate()
assert stdout == read(os.path.join("build", "test_expect.js"))