Merge pull request from cwillisf/windows-fix-local-compile

Fix local compile on Windows
This commit is contained in:
Chris Willis-Ford 2018-11-09 12:10:54 -08:00 committed by GitHub
commit 4ffecde2bc
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23

View file

@ -323,7 +323,7 @@ class Gen_compressed(threading.Thread):
for group in [["google-closure-compiler"], dash_args]:
args.extend(filter(lambda item: item, group))
proc = subprocess.Popen(args, stdin=subprocess.PIPE, stdout=subprocess.PIPE)
proc = subprocess.Popen(args, stdin=subprocess.PIPE, stdout=subprocess.PIPE, shell=True)
(stdout, stderr) = proc.communicate()
# Build the JSON response.
@ -566,7 +566,7 @@ if __name__ == "__main__":
# Sanity check the local compiler
test_args = [closure_compiler, os.path.join("build", "test_input.js")]
test_proc = subprocess.Popen(test_args, stdin=subprocess.PIPE, stdout=subprocess.PIPE)
test_proc = subprocess.Popen(test_args, stdin=subprocess.PIPE, stdout=subprocess.PIPE, shell=True)
(stdout, _) = test_proc.communicate()
assert stdout == read(os.path.join("build", "test_expect.js"))