Commit graph

130 commits

Author SHA1 Message Date
Jürg Lehni
ddf3670952 Fix / remove some comments. 2011-05-26 12:04:47 +01:00
Jürg Lehni
d2263b26db No need to check argument for _colorType since Color.read already performs an instanceof check for us. 2011-05-26 09:20:58 +01:00
Jürg Lehni
4fbc462a96 Shorten local 'colorType' variable to 'type'. 2011-05-26 08:40:07 +01:00
Jürg Lehni
300ea72261 Simplify Color#initialize() by relying on #convert() for performing _colorType check and delegate to #clone() instead of #convert() if it is the same. 2011-05-26 08:39:21 +01:00
Jürg Lehni
bfcfb23a9e Shorten Color#clone() further. 2011-05-26 08:36:56 +01:00
Jonathan Puckey
f2e01a8837 Color: Rename variable name due to conflict. 2011-05-21 17:56:54 +02:00
Jonathan Puckey
81558cb54f Avoid double lookup of component key. 2011-05-21 17:49:54 +02:00
Jonathan Puckey
f3deed81cd Optimize Color#initialize for minifying. 2011-05-21 17:40:29 +02:00
Jonathan Puckey
f83d16906c Clone the color when calling Color#convert with the same color type. 2011-05-21 17:37:36 +02:00
Jonathan Puckey
e5034a5a76 Color#clone: don't initialize when calling 'new this.constructor'. 2011-05-21 17:35:37 +02:00
Jonathan Puckey
024e8eb19b Fix Color cloning by adding clone function and using it in Color#initialize. 2011-05-21 17:13:25 +02:00
Jonathan Puckey
46b1311260 Gradient#equals: also check gradient type. 2011-05-21 12:06:37 +02:00
Jonathan Puckey
d8b73f3671 Fix GradientColor#clone(). 2011-05-21 12:06:01 +02:00
Jürg Lehni
f6e827cfd1 Allow Color#alpha to be set to null. 2011-05-21 00:41:04 +01:00
Jürg Lehni
7e7944e6f4 Fix recently introduced error in Color, by setting internal properties directly. 2011-05-21 00:40:20 +01:00
Jürg Lehni
631923669a Eliminate some of the TODOs. 2011-05-20 14:00:27 +01:00
Jürg Lehni
10dadb80f2 Move isHue check outside of setter. 2011-05-20 08:08:26 +01:00
Jürg Lehni
8a8c68b3d6 Define #clone() for various Gradient classes. Needs testing. 2011-05-19 22:02:26 +01:00
Jürg Lehni
38ddd34589 Replace beans access with internal property. 2011-05-19 22:00:03 +01:00
Jürg Lehni
6348f94362 Optimise Gradient constructor. 2011-05-19 20:54:52 +01:00
Jürg Lehni
8eea7e15d4 Give GradientStop a proper #initialize() function and use GradientStop.readAll() in Gradient#setStops() with some added magic to automatically assign rampPoints if they were not specified. 2011-05-19 20:51:09 +01:00
Jürg Lehni
6685d09801 Add missing semicolon. 2011-05-19 20:21:42 +01:00
Jürg Lehni
ef4e80ecef Replace getter calls with direct access of internal properties. 2011-05-19 20:21:22 +01:00
Jürg Lehni
a035f645fc Replace unneeded beans access with local variable. 2011-05-19 20:20:32 +01:00
Jürg Lehni
1473d82456 Variable chaining. 2011-05-19 20:20:01 +01:00
Jürg Lehni
32fb1b065e No need to check for colorType since #convert() already performs this optimisation. 2011-05-19 20:19:36 +01:00
Jürg Lehni
3b9369fafb Handle special setter for hue in Color.extend() as well, and move defintion of various Color classes to Color file since they are one-liners now. 2011-05-19 19:00:36 +01:00
Jürg Lehni
106719597b Further simplify Color code by moving components definitions to one object. 2011-05-18 21:21:28 +01:00
Jürg Lehni
a17f7865a3 Simplify Color subclass construction by moving beans producing code into an extended Color.extend() function that handles it for us. 2011-05-18 21:11:59 +01:00
Jürg Lehni
dfc6a05969 Shorten some converters a bit. 2011-05-18 20:40:52 +01:00
Jürg Lehni
9b95ba095c Don't capitalize twice. 2011-05-18 20:37:09 +01:00
Jürg Lehni
d643ac7626 Less cryptic code without Base.each() side-car makes more sense here. 2011-05-18 20:36:24 +01:00
Jürg Lehni
2367cfa6f2 Simplify Color code by merging all injection scopes to one. 2011-05-18 20:35:18 +01:00
Jürg Lehni
86ca1ed1e7 Add comment explaining color conversion code. 2011-05-18 15:37:01 +01:00
Jürg Lehni
93d3214a35 Fix porting error in GradientStop. 2011-05-18 10:04:46 +01:00
Jürg Lehni
db1a25933a Replace accidental beans access with direct access of internal property. 2011-05-18 09:43:32 +01:00
Jürg Lehni
88332d763d Simplify GradientColor#equals(). 2011-05-18 09:42:09 +01:00
Jürg Lehni
57eabed874 Simplify GradientStop#equals(). 2011-05-18 09:40:03 +01:00
Jürg Lehni
8b2709f5d8 Replace accidental beans access with direct access of internal property. 2011-05-18 09:38:45 +01:00
Jürg Lehni
eb6b838cf4 Simplify GradientStop#setRampPoint(). 2011-05-18 09:38:20 +01:00
Jonathan Puckey
2be70ae73f Gradient#setStops: improve checking for array. 2011-05-16 15:46:25 +02:00
Jürg Lehni
671d790068 Fix bug caused by recent commit. 2011-05-16 12:43:51 +01:00
Jürg Lehni
42e7fc910f Simplify GradientColor#transform(), using new _transformPoint() parameters. 2011-05-16 11:19:40 +01:00
Jürg Lehni
6fc418b581 Fix accidentally reversed change and clean up code a bit. 2011-05-15 15:12:59 +01:00
Jürg Lehni
252a3635dc Replace {@true} tags in documentation ({@true ([^}]*)} -> true $1, false otherwise.) 2011-05-15 15:06:10 +01:00
Jonathan Puckey
f8f6754068 Fix mistake in earlier commit. 2011-05-15 14:26:08 +02:00
Jonathan Puckey
2c36f3a62e Fix bug in Color#read. 2011-05-15 14:11:35 +02:00
Jonathan Puckey
94889148a4 GradientColor: clone origin / destination & hilite points. 2011-05-08 14:29:58 +01:00
Jonathan Puckey
bbccb25184 Transform gradient when path is transformed. 2011-05-08 14:05:47 +01:00
Jonathan Puckey
6fa993a2a5 Implement equals function for GradientColor, Gradient & GradientStop. 2011-05-05 20:28:28 +01:00