Commit graph

1083 commits

Author SHA1 Message Date
Jonathan Puckey
d8b73f3671 Fix GradientColor#clone(). 2011-05-21 12:06:01 +02:00
Jürg Lehni
b461368b18 Found a clean way for Layer#initialize() to call this.base() too, without implicitely calling paper.project.activeLayer.appendTop. 2011-05-21 01:05:22 +01:00
Jürg Lehni
9f1172f24a Merge remote-tracking branch 'origin/master' 2011-05-21 00:59:19 +01:00
Jürg Lehni
f6e827cfd1 Allow Color#alpha to be set to null. 2011-05-21 00:41:04 +01:00
Jürg Lehni
7e7944e6f4 Fix recently introduced error in Color, by setting internal properties directly. 2011-05-21 00:40:20 +01:00
Jonathan Puckey
8a1b1041cd Make PointText#matrix 'private' by renaming to _matrix. 2011-05-20 22:03:16 +02:00
Jonathan Puckey
f676cc026f Add TextItem#_clone to copy over characterStyle and paragraphStyle. 2011-05-20 21:33:25 +02:00
Jonathan Puckey
2c94b4270a Fix ParagraphStyle.create(item). 2011-05-20 21:29:47 +02:00
Jonathan Puckey
fc3833f150 Fix PlacedSymbol#clone(). 2011-05-20 19:41:53 +02:00
Jonathan Puckey
64a142436b Tests: add item cloning tests. 2011-05-20 19:40:07 +02:00
Jonathan Puckey
013fe56ea4 Item#_clone: check if the item has a _pathStyle property before copying it. 2011-05-20 19:35:26 +02:00
Jürg Lehni
84b1d865c1 Remove unused variable. 2011-05-20 14:08:04 +01:00
Jürg Lehni
be63d2cf07 Remove empty line. 2011-05-20 14:04:35 +01:00
Jürg Lehni
631923669a Eliminate some of the TODOs. 2011-05-20 14:00:27 +01:00
Jürg Lehni
0a87eef244 Add comment about PointText#matrix and #point being exposed. 2011-05-20 08:56:14 +01:00
Jürg Lehni
ec0484e798 Define Symbol#clone(), needs testing. 2011-05-20 08:55:44 +01:00
Jürg Lehni
5713bc07f2 Define PlacedSymbol#clone(), needs testing. 2011-05-20 08:55:35 +01:00
Jürg Lehni
b15eecc34d Use new internal Item#_clone() to improve Path#clone() and PointText#clone(). 2011-05-20 08:54:44 +01:00
Jürg Lehni
87d340e525 Introduce private Item#_clone(copy), so subclasses can override the way the copy is actually produced, e.g. providing parameters to the constructor. 2011-05-20 08:50:09 +01:00
Jürg Lehni
fd8ceb9641 Implement PointText#clone(), untested. 2011-05-20 08:47:13 +01:00
Jürg Lehni
4ceaca00f4 Initialise content to empty string, so content += 'something' would not produce odd results. 2011-05-20 08:46:58 +01:00
Jürg Lehni
e7cad9b134 Use local point in translate, as it is not a LinkedPoint and won't require beans access. 2011-05-20 08:46:17 +01:00
Jürg Lehni
01f26c4be0 Restructure line break. 2011-05-20 08:40:35 +01:00
Jürg Lehni
131425a12f Rely on #_transform() in #setPoint() as it already handles updating of #_point for us and all. 2011-05-20 08:33:19 +01:00
Jürg Lehni
2e82ac97d8 Convert PointText#point to a LinkedPoint so direct changes to it get noticed too. 2011-05-20 08:32:36 +01:00
Jürg Lehni
d6a49e2eb4 No need to check result of Point.read(), as it will always be a Point (_readNull is only defined for Color). 2011-05-20 08:28:49 +01:00
Jürg Lehni
4153bc0fbf Fix bug in PointText#_transform(), where wrong version of matrix._transformPoint() was applied to _point, resulting in no transformation. 2011-05-20 08:27:11 +01:00
Jürg Lehni
10dadb80f2 Move isHue check outside of setter. 2011-05-20 08:08:26 +01:00
Jürg Lehni
1c479f315e Add some comments to Item#clone(). 2011-05-19 22:09:51 +01:00
Jürg Lehni
8a8c68b3d6 Define #clone() for various Gradient classes. Needs testing. 2011-05-19 22:02:26 +01:00
Jürg Lehni
38ddd34589 Replace beans access with internal property. 2011-05-19 22:00:03 +01:00
Jürg Lehni
276eb3301e Define scafold #clone() function for the classes that still required a proper definition. 2011-05-19 21:56:49 +01:00
Jürg Lehni
7401e42316 Implement #clone() for Item, Group and Path. Needs testing. 2011-05-19 21:56:23 +01:00
Jürg Lehni
b52abbfbc1 Replace removed 'hidden' property with 'visible'. 2011-05-19 21:55:51 +01:00
Jürg Lehni
2dcb09a662 Define Path#clone(). 2011-05-19 21:34:19 +01:00
Jürg Lehni
6348f94362 Optimise Gradient constructor. 2011-05-19 20:54:52 +01:00
Jürg Lehni
8eea7e15d4 Give GradientStop a proper #initialize() function and use GradientStop.readAll() in Gradient#setStops() with some added magic to automatically assign rampPoints if they were not specified. 2011-05-19 20:51:09 +01:00
Jürg Lehni
fcb8242da8 Restructure #initialize() in basic types to use direct arguments checking more than arguments.length. 2011-05-19 20:37:04 +01:00
Jürg Lehni
404e61ebff Remove deleted files from load.js and paper.js. 2011-05-19 20:28:45 +01:00
Jürg Lehni
6685d09801 Add missing semicolon. 2011-05-19 20:21:42 +01:00
Jürg Lehni
ef4e80ecef Replace getter calls with direct access of internal properties. 2011-05-19 20:21:22 +01:00
Jürg Lehni
a035f645fc Replace unneeded beans access with local variable. 2011-05-19 20:20:32 +01:00
Jürg Lehni
1473d82456 Variable chaining. 2011-05-19 20:20:01 +01:00
Jürg Lehni
32fb1b065e No need to check for colorType since #convert() already performs this optimisation. 2011-05-19 20:19:36 +01:00
Jürg Lehni
3b9369fafb Handle special setter for hue in Color.extend() as well, and move defintion of various Color classes to Color file since they are one-liners now. 2011-05-19 19:00:36 +01:00
Jürg Lehni
57b194e047 Add explaining comments to Raster#getAverageColor() code. 2011-05-19 18:51:13 +01:00
Jürg Lehni
e8d4a16ab2 Shorten Raster#getAverageColor(). 2011-05-19 18:47:49 +01:00
Jürg Lehni
b103af4216 Merge remote-tracking branch 'origin/master' 2011-05-19 18:35:45 +01:00
Jürg Lehni
09612c4623 Remove the versions of #clone() that follow the scheme provided by Base#clone() now. 2011-05-19 18:35:38 +01:00
Jürg Lehni
b37ba3d858 Add a generic clone() method to all classes through Base which creates a new item using the constructor and passing 'this'. 2011-05-19 18:34:22 +01:00
Jonathan Puckey
f965e53a06 Optimize Path#getAverageColor 2011-05-19 15:43:23 +02:00
Jonathan Puckey
df15cf6970 Merge branch 'master' of github.com:scriptographer/paper.js 2011-05-19 15:41:34 +02:00
Jürg Lehni
ac213e94b4 Fix bug introduced in recent change to #getStrokeBounds(): We need to pass matrix as optional argument to #getBounds(). 2011-05-18 21:32:00 +01:00
Jürg Lehni
106719597b Further simplify Color code by moving components definitions to one object. 2011-05-18 21:21:28 +01:00
Jürg Lehni
a17f7865a3 Simplify Color subclass construction by moving beans producing code into an extended Color.extend() function that handles it for us. 2011-05-18 21:11:59 +01:00
Jürg Lehni
dfc6a05969 Shorten some converters a bit. 2011-05-18 20:40:52 +01:00
Jürg Lehni
9b95ba095c Don't capitalize twice. 2011-05-18 20:37:09 +01:00
Jürg Lehni
d643ac7626 Less cryptic code without Base.each() side-car makes more sense here. 2011-05-18 20:36:24 +01:00
Jürg Lehni
2367cfa6f2 Simplify Color code by merging all injection scopes to one. 2011-05-18 20:35:18 +01:00
Jonathan Puckey
e8cf29fd6c Size#min and Size#max: fix capitalization. 2011-05-18 21:31:02 +02:00
Jonathan Puckey
0a385d56a7 Replace accidental beans access with direct access of internal property. 2011-05-18 20:22:57 +02:00
Jonathan Puckey
b4807b9b7c Fix Path#getStrokeBounds: use Path#getBounds when no strokeColor or strokeWidth are set. 2011-05-18 20:08:10 +02:00
Jürg Lehni
cca4a44d03 Merge remote-tracking branch 'origin/master' 2011-05-18 15:44:33 +01:00
Jürg Lehni
86ca1ed1e7 Add comment explaining color conversion code. 2011-05-18 15:37:01 +01:00
Jonathan Puckey
241d98a1cf Merge remote branch 'origin/master' 2011-05-18 16:01:36 +02:00
Jonathan Puckey
8810563a8f Improve Raster#getAverageColor. 2011-05-18 16:00:55 +02:00
Jürg Lehni
93d3214a35 Fix porting error in GradientStop. 2011-05-18 10:04:46 +01:00
Jürg Lehni
db1a25933a Replace accidental beans access with direct access of internal property. 2011-05-18 09:43:32 +01:00
Jürg Lehni
88332d763d Simplify GradientColor#equals(). 2011-05-18 09:42:09 +01:00
Jürg Lehni
57eabed874 Simplify GradientStop#equals(). 2011-05-18 09:40:03 +01:00
Jürg Lehni
8b2709f5d8 Replace accidental beans access with direct access of internal property. 2011-05-18 09:38:45 +01:00
Jürg Lehni
eb6b838cf4 Simplify GradientStop#setRampPoint(). 2011-05-18 09:38:20 +01:00
Jürg Lehni
fc52944ee8 Change method sequence a bit. 2011-05-17 13:43:45 +01:00
Jürg Lehni
160f3d55c7 Make View#transform() private. 2011-05-17 13:43:10 +01:00
Jürg Lehni
f3f5515763 Add comment about potential renaming of artworkToView -> projectToView? 2011-05-17 13:42:45 +01:00
Jürg Lehni
ac364014da Actually use matrix when drawing view. 2011-05-17 13:42:20 +01:00
Jürg Lehni
2f63127b02 Simplify and fix View#setZoom(). 2011-05-17 13:41:42 +01:00
Jürg Lehni
26269d394a Rename project/ProjectView -> ui/View. 2011-05-17 13:29:07 +01:00
Jürg Lehni
7b4dd222ac Completely decouple ProjectView from Project. 2011-05-17 13:25:46 +01:00
Jürg Lehni
e5f8ee0464 Write comment about calling base() from Layer#initialize(). 2011-05-17 13:14:23 +01:00
Jürg Lehni
c07f9b438e Use same modification in static create() method of ParagraphStyle and CharacterStyle as was used in PathStyle. 2011-05-17 13:14:04 +01:00
Jürg Lehni
2c03cb1ccb Use Base.initialize() in both ParagraphStyle and CharacterStyle's #initialize(). 2011-05-17 13:13:24 +01:00
Jürg Lehni
6427bca46e No beans required in ParagraphStyle yet. 2011-05-17 13:12:44 +01:00
Jürg Lehni
7d1d6fa9da Define Base.initialize() as a general purpose way to initialize a newly created object with values from a provided object and default values from another, in case they are not provided. 2011-05-17 13:12:19 +01:00
Jürg Lehni
5369b251ae Move comment. 2011-05-17 13:11:09 +01:00
Jürg Lehni
41dd9eb131 Point.read() always returns an object even if nothing is provided, no need to have a default value. 2011-05-17 13:10:57 +01:00
Jürg Lehni
e5198fea40 Remove unused code that seems to stem from PointText. 2011-05-17 13:10:22 +01:00
Jürg Lehni
515dbbb151 Fix error in Item#removeChildren(). 2011-05-17 13:09:10 +01:00
Jürg Lehni
eafc0d202e Add comment about #clockwise magic happening in #append*() methods. 2011-05-16 20:17:14 +01:00
Jürg Lehni
889b1687f9 Use #setChildren() in Group constructor and allow passing of children both as arguments and inside an array. 2011-05-16 20:16:27 +01:00
Jürg Lehni
baf35ea18c Rename parameter. 2011-05-16 20:15:16 +01:00
Jürg Lehni
8a449b0e76 Remove deprecated Item#appendChild(). 2011-05-16 20:14:49 +01:00
Jürg Lehni
f12ed7234a Shorten code. 2011-05-16 19:44:46 +01:00
Jürg Lehni
97c4435d87 Fix typo. 2011-05-16 19:35:42 +01:00
Jürg Lehni
d535a1f6fc Clean up method sequence in Item. 2011-05-16 19:35:09 +01:00
Jürg Lehni
75b0fa3596 Add Item#removeChildren() and #setChildren(). 2011-05-16 19:34:57 +01:00
Jürg Lehni
c4203fe174 Change the way associated PathStyles are created and updated. 2011-05-16 19:21:36 +01:00
Jürg Lehni
05c0eb0e51 Simplify PathStyle#initialize(). 2011-05-16 19:20:32 +01:00
Jürg Lehni
34110fa82d Move #_setStyle() closer to the related styles hash. 2011-05-16 19:19:18 +01:00
Jürg Lehni
c8c47bf641 get styles directly from _style object rather than passing through getters on Item. 2011-05-16 18:57:47 +01:00