scratchfoundation/paper.js
1
0
Fork 0
mirror of https://github.com/scratchfoundation/paper.js.git synced 2025-01-01 02:38:43 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix ignoring of clip item matrix in group internal bounds

Browse source 
Closes #1427
This commit is contained in:
sasensi 2018-10-17 10:11:35 +02:00 committed by Jürg Lehni
parent 4aa1bebf26
commit e3c298d3f4
2 changed files with 14 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/item/Group.js
View file

@ -172,7 +172,7 @@ var Group = Item.extend(/** @lends Group# */{
var clipItem = this._getClipItem(); var clipItem = this._getClipItem();
return clipItem return clipItem
? clipItem._getCachedBounds( ? clipItem._getCachedBounds(
matrix && matrix.appended(clipItem._matrix), matrix && matrix.appended(clipItem._matrix) || clipItem._matrix,
Base.set({}, options, { stroke: false })) Base.set({}, options, { stroke: false }))
: _getBounds.base.call(this, matrix, options); : _getBounds.base.call(this, matrix, options);
}, },

13
test/tests/Group.js
View file

@ -166,3 +166,16 @@ test('Group#isEmpty(recursively)', function() {
equals(false, group.isEmpty()); equals(false, group.isEmpty());
equals(true, group.isEmpty(true)); equals(true, group.isEmpty(true));
}); });
test('group.getInternalBounds() with clip item without matrix applied', function() {
var point = new Point(100, 100);
var translation = new Point(100, 100);
var item = new Path.Circle({ center: point, radius: 50, fillColor: 'orange' });
var clip = new Path.Rectangle({ from: point.subtract(translation), to: point.add(translation) });
clip.applyMatrix = false;
clip.translate(translation);
var group = new Group(clip, item);
group.clipped = true;
equals(group.getInternalBounds(), new Rectangle(point, point.add(translation.multiply(2))));
});