scratchfoundation/paper.js
1
0
Fork 0
mirror of https://github.com/scratchfoundation/paper.js.git synced 2025-01-01 02:38:43 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix exported SVG missing viewBox attribute (#1576)

Browse source 
SVG viewBox attribute was not added when bounds rectangle point was 0,0.
This commit is contained in:
Samuel Asensi 2019-06-07 22:30:01 +02:00 committed by Jürg Lehni
parent 314390d789
commit de824e1846
2 changed files with 7 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/svg/SvgExport.js
View file

@ -427,7 +427,7 @@ new function() {
if (rect) { if (rect) {
attrs.width = rect.width; attrs.width = rect.width;
attrs.height = rect.height; attrs.height = rect.height;
if (rect.x || rect.y) if (rect.x || rect.x === 0 || rect.y || rect.y === 0)
attrs.viewBox = formatter.rectangle(rect); attrs.viewBox = formatter.rectangle(rect);
} }
var node = SvgElement.create('svg', attrs, formatter), var node = SvgElement.create('svg', attrs, formatter),

6
test/tests/SvgExport.js
View file

@ -113,6 +113,12 @@ test('Export SVG path at precision 0', function() {
equals(path.exportSVG({ precision: 0 }).getAttribute('d'), 'M0,2l1,1'); equals(path.exportSVG({ precision: 0 }).getAttribute('d'), 'M0,2l1,1');
}); });
test('Export SVG viewbox attribute with top left at origin', function() {
var path = new Path.Rectangle(new Point(10, 10), new Size(80));
var rectangle = new Rectangle(new Point(0, 0), new Size(100));
equals(project.exportSVG({ bounds: rectangle }).getAttribute('viewBox'), '0,0,100,100');
});
if (!isNode) { if (!isNode) {
// JSDom does not have SVG rendering, so we can't test there. // JSDom does not have SVG rendering, so we can't test there.
test('Export transformed shapes', function(assert) { test('Export transformed shapes', function(assert) {