scratchfoundation/paper.js
1
0
Fork 0
mirror of https://github.com/scratchfoundation/paper.js.git synced 2025-01-06 04:42:15 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix issue with Item#removeChildren(from, to) removing too many items.

Browse source
This commit is contained in:
Jürg Lehni 2011-12-26 02:39:54 +01:00
parent 7af06502bc
commit c552925426
1 changed files with 6 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/item/Item.js
View file

@ -1265,7 +1265,8 @@ function(name) {
this.setSelected(false); this.setSelected(false);
if (this._name) if (this._name)
this._removeFromNamed(); this._removeFromNamed();
Base.splice(this._parent._children, null, this._index, 1); if (this._index != null)
Base.splice(this._parent._children, null, this._index, 1);
// Notify parent of changed hierarchy // Notify parent of changed hierarchy
if (notify) if (notify)
this._parent._changed(Change.HIERARCHY); this._parent._changed(Change.HIERARCHY);
@ -1307,7 +1308,10 @@ function(name) {
return null; return null;
from = from || 0; from = from || 0;
to = Base.pick(to, this._children.length); to = Base.pick(to, this._children.length);
var removed = this._children.splice(from, to - from); // Use Base.splice(), wich adjusts #_index for the items above, and
// deletes it for the removed items. Calling #_remove() afterwards is
// fine, since it only calls Base.splice() if #_index is set.
var removed = Base.splice(this._children, null, from, to - from);
for (var i = removed.length - 1; i >= 0; i--) for (var i = removed.length - 1; i >= 0; i--)
removed[i]._remove(true, false); removed[i]._remove(true, false);
if (removed.length > 0) if (removed.length > 0)