scratchfoundation/paper.js
1
0
Fork 0
mirror of https://github.com/scratchfoundation/paper.js.git synced 2025-01-01 02:38:43 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix getInteriorPoint()

Browse source 
getInteriorPoint() could return a point outside the path as explained in #1064
This fix excludes curve's start points from intercept detection to prevent double counting, it ensures that all intercepts are collected and the intercepts are sorted by x-value.
This commit is contained in:
Jan 2016-06-07 16:11:37 +02:00
parent f19d0c8134
commit b735a3ec95
1 changed files with 4 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
src/path/PathItem.Boolean.js
View file

@ -1028,7 +1028,7 @@ Path.inject(/** @lends Path# */{
// Since there is no guarantee that a poly-bezier path contains
// the center of its bounding rectangle, we shoot a ray in
// +x direction from the center and select a point between
// consecutive intersections of the ray
// consecutive intersections of the ray.
var curves = this._getMonoCurves(),
roots = [],
y = point.y,
@ -1036,16 +1036,15 @@ Path.inject(/** @lends Path# */{
for (var i = 0, l = curves.length; i < l; i++) {
var values = curves[i].values;
if ((curves[i].winding === 1
&& y >= values[1] && y <= values[7]
|| y >= values[7] && y <= values[1])) {
&& y > values[1] && y <= values[7]
|| y >= values[7] && y < values[1])) {
var count = Curve.solveCubic(values, 1, y, roots, 0, 1);
for (var j = count - 1; j >= 0; j--) {
intercepts.push(Curve.getPoint(values, roots[j]).x);
}
}
if (intercepts.length > 1)
break;
}
intercepts.sort();
point.x = (intercepts[0] + intercepts[1]) / 2;
}
return point;