scratchfoundation/paper.js
1
0
Fork 0
mirror of https://github.com/scratchfoundation/paper.js.git synced 2025-01-07 13:22:07 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

Add parameter to Path#_add() that controls wether path is notified of change.

Browse source
This commit is contained in:
Jürg Lehni 2011-05-05 11:40:46 +01:00
parent 61a4464aae
commit 7894a48ace
1 changed files with 11 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
src/path/Path.js
View file

@ -52,7 +52,7 @@ var Path = this.Path = PathItem.extend({
if (this._curves) if (this._curves)
this._curves = null; this._curves = null;
} }
this._add(Segment.readAll(segments)); this._add(Segment.readAll(segments), true);
}, },
getFirstSegment: function() { getFirstSegment: function() {
@ -136,7 +136,7 @@ var Path = this.Path = PathItem.extend({
* If a curves list was requested, it will kept in sync with the segments * If a curves list was requested, it will kept in sync with the segments
* list automatically. * list automatically.
*/ */
_add: function(segs, index) { _add: function(segs, notify, index) {
// Local short-cuts: // Local short-cuts:
var segments = this._segments, var segments = this._segments,
curves = this._curves, curves = this._curves,
@ -175,18 +175,19 @@ var Path = this.Path = PathItem.extend({
if (curve) if (curve)
curve._segment1 = segments[index + amount]; curve._segment1 = segments[index + amount];
} }
this._changed(); if (notify)
this._changed();
return segs; return segs;
}, },
// TODO: Port back support for adding multiple segments at once to Sg // TODO: Port back support for adding multiple segments at once to Sg
add: function(segment1 /*, segment2, ... */) { add: function(segment1 /*, segment2, ... */) {
return this._add(Segment.readAll(arguments)); return this._add(Segment.readAll(arguments), true);
}, },
// TODO: Port back support for adding multiple segments at once to Sg // TODO: Port back support for adding multiple segments at once to Sg
insert: function(index, segment1 /*, segment2, ... */) { insert: function(index, segment1 /*, segment2, ... */) {
return this._add(Segment.readAll(arguments, 1), index); return this._add(Segment.readAll(arguments, 1), true, index);
}, },
// TODO: Port back to Sg // TODO: Port back to Sg
@ -310,6 +311,7 @@ var Path = this.Path = PathItem.extend({
if (last1._point.equals(first1._point)) { if (last1._point.equals(first1._point)) {
first1.setHandleIn(last1._handleIn); first1.setHandleIn(last1._handleIn);
last1.remove(); last1.remove();
// TODO: Don't notify in setClosed... Use internal _setClosed?
this.setClosed(true); this.setClosed(true);
} }
this._changed(); this._changed();
@ -679,12 +681,12 @@ var Path = this.Path = PathItem.extend({
// Let's not be picky about calling moveTo() when not at the // Let's not be picky about calling moveTo() when not at the
// beginning of a path, just bail out: // beginning of a path, just bail out:
if (!this._segments.length) if (!this._segments.length)
this._add([new Segment(Point.read(arguments))]); this._add([ new Segment(Point.read(arguments)) ], true);
}, },
lineTo: function() { lineTo: function() {
// Let's not be picky about calling moveTo() first: // Let's not be picky about calling moveTo() first:
this._add([new Segment(Point.read(arguments))]); this._add([ new Segment(Point.read(arguments)) ], true);
}, },
/** /**
@ -700,7 +702,7 @@ var Path = this.Path = PathItem.extend({
// Convert to relative values: // Convert to relative values:
current.setHandleOut(handle1.subtract(current._point)); current.setHandleOut(handle1.subtract(current._point));
// And add the new segment, with handleIn set to c2 // And add the new segment, with handleIn set to c2
this._add([new Segment(to, handle2.subtract(to), new Point())]); this._add([ new Segment(to, handle2.subtract(to)) ], true);
}, },
/** /**
@ -835,7 +837,7 @@ var Path = this.Path = PathItem.extend({
angle += inc; angle += inc;
} }
// Add all segments at once at the end for higher performance // Add all segments at once at the end for higher performance
this._add(segments); this._add(segments, true);
}, },
lineBy: function(vector) { lineBy: function(vector) {