scratchfoundation/paper.js
1
0
Fork 0
mirror of https://github.com/scratchfoundation/paper.js.git synced 2025-01-05 20:32:00 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

Improve documentation of components code.

Browse source
This commit is contained in:
Jürg Lehni 2014-10-04 19:46:44 +02:00
parent 5f7fd42bcb
commit 6b9a40d987
1 changed files with 10 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
src/ui/Component.js
View file

@ -92,6 +92,8 @@ var Component = Base.extend(Callback, /** @lends Component# */{
this._id = Component._id = (Component._id || 0) + 1; this._id = Component._id = (Component._id || 0) + 1;
this._parent = parent; this._parent = parent;
this._name = name; this._name = name;
// The row within which this component is contained. This can be a
// shared row, e.g. when the parent component has a columns layout.
this._row = row; this._row = row;
var type = this._type = props.type in this._types var type = this._type = props.type in this._types
? props.type ? props.type
@ -108,7 +110,8 @@ var Component = Base.extend(Callback, /** @lends Component# */{
className; className;
if (!type) { if (!type) {
// No type defined, so we're dealing with a layout component that // No type defined, so we're dealing with a layout component that
// contains nested child components. // contains nested child components. See if they are to be aligned
// as columns or rows, and lay things out accordingly.
var columns = props.columns, var columns = props.columns,
// On the root element, we need to create the table and row even // On the root element, we need to create the table and row even
// if it's a columns layout. // if it's a columns layout.
@ -134,6 +137,8 @@ var Component = Base.extend(Callback, /** @lends Component# */{
} }
components[key] = new Component(this, key, component, components[key] = new Component(this, key, component,
values, currentRow); values, currentRow);
// Keep track of the maximum amount of cells per row, so we
// can adjust colspan after.
numCells = Math.max(numCells, this._numCells); numCells = Math.max(numCells, this._numCells);
// Do not reset cell counter if all components go to the // Do not reset cell counter if all components go to the
// same parent row. // same parent row.
@ -146,9 +151,13 @@ var Component = Base.extend(Callback, /** @lends Component# */{
} }
} }
this._numCells = numCells; this._numCells = numCells;
// If aligning things horizontally, we need to tell the parent how
// many cells there are all together.
if (columns && parent) if (columns && parent)
parent._numCells = numCells; parent._numCells = numCells;
Base.each(components, function(component, key) { Base.each(components, function(component, key) {
// NOTE: Components with columns layout won't have their _cell
// set.
if (numCells > 2 && component._cell && !columns) if (numCells > 2 && component._cell && !columns)
DomElement.set(component._cell, 'colspan', numCells - 1); DomElement.set(component._cell, 'colspan', numCells - 1);
// Replace each entry in values with getters/setters so we can // Replace each entry in values with getters/setters so we can