mirror of
https://github.com/scratchfoundation/paper.js.git
synced 2025-01-03 19:45:44 -05:00
Merge branch 'fix-simplify-bug' of https://github.com/calamitas/paper.js into fix-simplify-bug
This commit is contained in:
commit
66fbb9ee2a
1 changed files with 28 additions and 7 deletions
|
@ -80,13 +80,14 @@ var PathFitter = Base.extend({
|
|||
// Parameterize points, and attempt to fit curve
|
||||
var uPrime = this.chordLengthParameterize(first, last),
|
||||
maxError = Math.max(this.error, this.error * this.error),
|
||||
split;
|
||||
split,
|
||||
parametersInOrder = true;
|
||||
// Try 4 iterations
|
||||
for (var i = 0; i <= 4; i++) {
|
||||
var curve = this.generateBezier(first, last, uPrime, tan1, tan2);
|
||||
// Find max deviation of points to fitted curve
|
||||
var max = this.findMaxError(first, last, curve, uPrime);
|
||||
if (max.error < this.error) {
|
||||
if (max.error < this.error && parametersInOrder) {
|
||||
this.addCurve(curve);
|
||||
return;
|
||||
}
|
||||
|
@ -94,7 +95,7 @@ var PathFitter = Base.extend({
|
|||
// If error not too large, try reparameterization and iteration
|
||||
if (max.error >= maxError)
|
||||
break;
|
||||
this.reparameterize(first, last, uPrime, curve);
|
||||
parametersInOrder = this.reparameterize(first, last, uPrime, curve);
|
||||
maxError = max.error;
|
||||
}
|
||||
// Fitting failed -- split at max error point and fit recursively
|
||||
|
@ -178,12 +179,23 @@ var PathFitter = Base.extend({
|
|||
alpha1 = alpha2 = segLength / 3;
|
||||
}
|
||||
|
||||
// Check if the found control points are in the right order when
|
||||
// projected onto the line through pt1 and pt2.
|
||||
var line = pt2.subtract(pt1),
|
||||
// Control points 1 and 2 are positioned an alpha distance out
|
||||
// on the tangent vectors, left and right, respectively
|
||||
cp1Delta = tan1.normalize(alpha1),
|
||||
cp2Delta = tan2.normalize(alpha2);
|
||||
if (cp1Delta.dot(line) - cp2Delta.dot(line) > segLength * segLength) {
|
||||
// Fall back to the Wu/Barsky heuristic above.
|
||||
alpha1 = alpha2 = segLength / 3;
|
||||
cp1Delta = tan1.normalize(alpha1);
|
||||
cp2Delta = tan2.normalize(alpha2);
|
||||
}
|
||||
|
||||
// First and last control points of the Bezier curve are
|
||||
// positioned exactly at the first and last data points
|
||||
// Control points 1 and 2 are positioned an alpha distance out
|
||||
// on the tangent vectors, left and right, respectively
|
||||
return [pt1, pt1.add(tan1.normalize(alpha1)),
|
||||
pt2.add(tan2.normalize(alpha2)), pt2];
|
||||
return [pt1, pt1.add(cp1Delta), pt2.add(cp2Delta), pt2];
|
||||
},
|
||||
|
||||
// Given set of points and their parameterization, try to find
|
||||
|
@ -192,6 +204,15 @@ var PathFitter = Base.extend({
|
|||
for (var i = first; i <= last; i++) {
|
||||
u[i - first] = this.findRoot(curve, this.points[i], u[i - first]);
|
||||
}
|
||||
// Detect if the new parameterization has reordered the points.
|
||||
// In that case, we would fit the points of the path in the
|
||||
// wrong order.
|
||||
for (var j = 1, jLen = u.length; j < jLen; j++) {
|
||||
if (u[j] <= u[j - 1]) {
|
||||
return false;
|
||||
}
|
||||
}
|
||||
return true;
|
||||
},
|
||||
|
||||
// Use Newton-Raphson iteration to find better root.
|
||||
|
|
Loading…
Reference in a new issue