scratchfoundation/paper.js
1
0
Fork 0
mirror of https://github.com/scratchfoundation/paper.js.git synced 2024-12-29 09:22:22 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

Add comment about ideally not relying on parent.children.indexOf for getIndex().

Browse source
This commit is contained in:
Jürg Lehni 2011-02-13 18:51:49 +00:00
parent eeb7d377e6
commit 604ff7824c
1 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/item/Item.js
View file

@ -1,5 +1,6 @@
Item = Base.extend({
beans: true,
initialize: function() {
this.parent = Paper.document.activeLayer;
this.parent.children.push(this);
@ -155,7 +156,7 @@ Item = Base.extend({
getNextSibling: function() {
if (this.parent) {
var index = this.index + 1;
if (index < this.parent.children.length)
if (index < this.parent.children.length)
return this.parent.children[index];
}
},
@ -175,6 +176,9 @@ Item = Base.extend({
* The index of this item within the list of it's parent's children.
*/
getIndex: function() {
// TODO: Relying on indexOf() here is slow, especially since it is
// used for getPrevious/NextSibling().
// We need linked lists instead.
return this.parent.children.indexOf(this);
},