scratchfoundation/paper.js
1
0
Fork 0
mirror of https://github.com/scratchfoundation/paper.js.git synced 2025-01-04 03:45:58 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

Add comment about return undefined rather than null for unclear styles, and fix test.

Browse source
This commit is contained in:
Jürg Lehni 2011-05-05 13:11:40 +01:00
parent 51b2cf287d
commit 478002ea1c
2 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
src/item/PathStyle.js
View file

@ -85,6 +85,7 @@ var PathStyle = this.PathStyle = Base.extend(new function() {
} else if (style != childStyle) { } else if (style != childStyle) {
// If there is another item with a different style, // If there is another item with a different style,
// the style is not defined: // the style is not defined:
// TODO: Port back to Sg (currently returns null)
return undefined; return undefined;
} }
} }

4
test/tests/PathStyle.js
View file

@ -111,8 +111,8 @@ test('setting group styles 2', function() {
compareRGBColors(secondPath.strokeColor, 'red', 'secondPath.strokeColor'); compareRGBColors(secondPath.strokeColor, 'red', 'secondPath.strokeColor');
// By appending a path with a different fillcolor, // By appending a path with a different fillcolor,
// the group's fillColor should return null: // the group's fillColor should return undefined:
equals(group.fillColor, null, 'group.fillColor'); equals(group.fillColor, undefined, 'group.fillColor');
// But, both paths have a red strokeColor, so: // But, both paths have a red strokeColor, so:
compareRGBColors(group.strokeColor, 'red', 'group.strokeColor'); compareRGBColors(group.strokeColor, 'red', 'group.strokeColor');