scratchfoundation/paper.js
1
0
Fork 0
mirror of https://github.com/scratchfoundation/paper.js.git synced 2025-01-04 03:45:58 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

Do not modify children array directly

Browse source 
Use Item#remove() to remove children, to make sure indices are kept in sync.
This commit is contained in:
Jürg Lehni 2016-01-04 11:12:56 +01:00
parent 1543d056a7
commit 34d4115061
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/path/CompoundPath.js
View file

@ -148,7 +148,7 @@ var CompoundPath = PathItem.extend(/** @lends CompoundPath# */{
for (var i = children.length - 1; i >= 0; i--) { for (var i = children.length - 1; i >= 0; i--) {
var path = children[i].reduce(); var path = children[i].reduce();
if (path.isEmpty()) if (path.isEmpty())
children.splice(i, 1); path.remove();
} }
if (children.length === 0) { // Replace with a simple empty Path if (children.length === 0) { // Replace with a simple empty Path
var path = new Path(Item.NO_INSERT); var path = new Path(Item.NO_INSERT);