scratchfoundation/paper.js
1
0
Fork 0
mirror of https://github.com/scratchfoundation/paper.js.git synced 2025-01-06 04:42:15 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

Increase performance of Style getters / setters.

Browse source
This commit is contained in:
Jürg Lehni 2013-04-07 17:36:35 -07:00
parent 218732e320
commit 136c028d29
1 changed files with 9 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

22
src/style/Style.js
View file

@ -32,14 +32,6 @@ var Style = Base.extend({
}, this); }, this);
}, },
/**
* Returns the children to be used to unify style attributes, if any.
*/
_getChildren: function() {
// Only unify styles on children of Group items, excluding CompoundPath.
return this._item instanceof Group && this._item._children;
},
statics: { statics: {
create: function(item) { create: function(item) {
var style = Base.create(this); var style = Base.create(this);
@ -73,10 +65,13 @@ var Style = Base.extend({
// Simply extend src with these getters and setters, to be // Simply extend src with these getters and setters, to be
// injected into this class using this.base() further down. // injected into this class using this.base() further down.
src[set] = function(value) { src[set] = function(value) {
var children = this._getChildren(); var children = this._item && this._item._children;
// Clone color objects since they reference their owner // Clone color objects since they reference their owner
value = isColor ? Color.read(arguments, 0, 0, true) : value; value = isColor ? Color.read(arguments, 0, 0, true) : value;
if (children && children.length > 0) { // Only unify styles on children of Groups, excluding
// CompoundPaths.
if (children && children.length > 0
&& this._item._type !== 'compound-path') {
for (var i = 0, l = children.length; i < l; i++) for (var i = 0, l = children.length; i < l; i++)
children[i][styleKey][set](value); children[i][styleKey][set](value);
} else { } else {
@ -99,11 +94,12 @@ var Style = Base.extend({
} }
}; };
src[get] = function() { src[get] = function() {
var children = this._getChildren(), var style,
style; children = this._item && this._item._children;
// If this item has children, walk through all of them and // If this item has children, walk through all of them and
// see if they all have the same style. // see if they all have the same style.
if (!children || children.length === 0) if (!children || children.length === 0
|| this._item._type === 'compound-path')
return this['_' + key]; return this['_' + key];
for (var i = 0, l = children.length; i < l; i++) { for (var i = 0, l = children.length; i < l; i++) {
var childStyle = children[i][styleKey][get](); var childStyle = children[i][styleKey][get]();