scratchfoundation/paper.js
1
0
Fork 0
mirror of https://github.com/scratchfoundation/paper.js.git synced 2025-01-19 06:00:56 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

Clean up resize handlers when removing resizing views.

Browse source 
Closes #121.
This commit is contained in:
Jürg Lehni 2012-10-08 18:05:44 -07:00
parent 6b08d96c45
commit 08cb7c76ea
1 changed files with 5 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
src/ui/View.js
View file

@ -104,7 +104,7 @@ var View = this.View = Base.extend(Callback, /** @lends View# */{
.getSize().subtract(offset);
element.width = size.width;
element.height = size.height;
DomEvent.add(window, {
this._windowHandlers = {
resize: function(event) {
// Only update element offset if it's not invisible, as
// otherwise the offset would be wrong.
@ -115,7 +115,8 @@ var View = this.View = Base.extend(Callback, /** @lends View# */{
that.setViewSize(DomElement.getViewportBounds(element)
.getSize().subtract(offset));
}
});
};
DomEvent.add(window, this._windowHandlers);
} else {
// If the element is invisible, we cannot directly access
// element.width / height, because they would appear 0. Reading
@ -172,6 +173,8 @@ var View = this.View = Base.extend(Callback, /** @lends View# */{
this._project.view = null;
// Uninstall event handlers again for this view.
DomEvent.remove(this._element, this._handlers);
if (this._windowHandlers)
DomEvent.remove(window, this._windowHandlers);
this._element = this._project = null;
// Removing all onFrame handlers makes the _onFrameCallback handler stop
// automatically through its uninstall method.