Neil Lalonde
90bf3cc3d4
Merge pull request #1760 from dv2/fix_spelling
...
Correct few spelling in the comments
2013-12-27 11:00:02 -08:00
Régis Hanol
b5a59c10d5
let's try another formula for the top tab
2013-12-27 19:12:53 +01:00
Régis Hanol
9c8e50351d
first stab at calculating the score of a topic for the top tab
2013-12-27 18:10:35 +01:00
Régis Hanol
567d2bd23c
add top page
2013-12-24 00:50:36 +01:00
Régis Hanol
0b13b8d7ea
Merge pull request #1737 from chancancode/add_missing_references
...
Added some missing references
2013-12-23 05:51:04 -08:00
DV Suresh
24886c300b
Correct few spelling in the comments
2013-12-21 01:19:22 -06:00
Sam
2cf2ee9d2d
I need to add better testing here
2013-12-20 17:41:12 +11:00
Sam
cc9326c29d
existence in file always overrides
2013-12-20 17:09:51 +11:00
Sam
61a50f1cf6
allow nuking of vars via env
2013-12-20 17:07:08 +11:00
Sam
13e1016d73
oops forgot to commit this
2013-12-20 16:38:51 +11:00
Sam
f5f09933df
Merge branch 'master' of github.com:discourse/discourse
2013-12-20 16:17:52 +11:00
Sam
7b8d2547d0
globals now implemented and documented
2013-12-20 16:17:21 +11:00
Sam
b312b4d563
clean up config to use global settings
2013-12-20 15:12:23 +11:00
Neil Lalonde
33c6997ded
Move password validation into PasswordValidator
2013-12-19 16:15:47 -05:00
Robin Ward
1cac9fa257
New users can only post newuser_max_replies_per_topic
times per topic.
2013-12-19 13:45:55 -05:00
Neil Lalonde
c35af5d755
FIX: When re-opening a topic that auto-closed, make sure it won't auto-close again
2013-12-19 11:25:05 -05:00
Godfrey Chan
e41eecb91b
Added some missing references, see https://github.com/rails/rails/issues/12982
2013-12-18 15:06:19 -08:00
Neil Lalonde
1f0a59584b
Revert "Re-apply with fixes: Stop using user agent to detect mobile devices. Use a media query and yepnope to load the appropriate css and customizations."
2013-12-18 14:47:22 -05:00
Neil Lalonde
c0e1ef75f6
Don't auto-close a topic too soon in PeriodicalUpdates
2013-12-18 14:09:49 -05:00
Neil Lalonde
8057373584
Category featured users: show most recent posters instead of most frequent posters
2013-12-18 11:10:03 -05:00
Régis Hanol
2ef53f89f4
[0] is shorter than [0,1] :)
2013-12-17 16:30:25 +01:00
Sam
ea307931a7
fix spec, categories without position are now always at the end of the list
2013-12-17 14:36:07 +11:00
Neil Lalonde
341adc93a4
Allow categories with null position, which means sort them based on activity. Mix absolutely positioned (position is not null) categories with null position categories.
2013-12-16 15:13:57 -05:00
Régis Hanol
c6fb60e0a0
FIX: S3 upload when using dots in bucket name
2013-12-16 11:44:59 +01:00
Alexander
d93e4fc65d
add more info to rss feeds
2013-12-15 01:17:39 -08:00
Neil Lalonde
1145e4bfd9
Fix topics_year, topics_month, topics_week for uncategorized category
2013-12-13 16:17:06 -05:00
Neil Lalonde
49c3482464
Show topic and post counts by day/week/month/year on categories page
2013-12-13 15:37:45 -05:00
Sam
96fdf72d5e
rails master compatability
2013-12-13 17:04:45 +11:00
Neil Lalonde
50bd05663c
Fix category ordering on categories page. I broke it.
2013-12-12 17:13:35 -05:00
Neil Lalonde
6fa2e68742
Show more than one topic per category on the wide categories page. Disable support for the 2-column categories page. The category_featured_topics site setting controls how many topics to show.
2013-12-12 15:52:30 -05:00
Sam
50c4e3707b
Merge pull request #1731 from chancancode/no_more_scoped_in_rails_4_1
...
✂️ scoped for Rails 4 compat
2013-12-12 12:38:57 -08:00
Régis Hanol
1457a3792d
that fix should have been in the emoji plugin
2013-12-12 16:42:27 +01:00
Régis Hanol
be835785f8
FIX: allow new user to post emojis
2013-12-12 15:05:18 +01:00
Godfrey Chan
3c80ee0b8a
✂️ scoped for Rails 4 compat
2013-12-12 00:37:04 -08:00
Régis Hanol
06dd7ffe3c
better revision history
2013-12-12 03:41:34 +01:00
Neil Lalonde
5171a23a9c
Re-apply with fixes: Stop using user agent to detect mobile devices. Use a media query and yepnope to load the appropriate css and customizations.
2013-12-11 11:19:22 -05:00
Neil Lalonde
2596f7dec2
Revert "Stop using user agent to detect mobile devices. Use a media query and yepnope to load the appropriate css and customizations."
2013-12-09 16:28:11 -05:00
Neil Lalonde
ca5d4d5e54
Stop using user agent to detect mobile devices. Use a media query and yepnope to load the appropriate css and customizations.
2013-12-09 13:28:42 -05:00
Neil Lalonde
9a24d2651d
Allow category to auto-close topics in X hours instead of days. FIX: the system message that says a topic was automatically closed was only counting in days.
2013-12-06 16:39:35 -05:00
Sam
2db3cfb16b
annotate models
2013-12-05 17:40:35 +11:00
Neil Lalonde
abed146cc7
FIX: Category description topics shouldn't auto-close
2013-12-04 10:31:25 -05:00
Sam
7f4697a200
bug: if status changes always attempt to update the feature topics for the category right away
2013-12-02 16:32:24 +11:00
Godfrey Chan
6bbea9de0b
The Rails JSON encoder API requires as_json
to take an optional arg
2013-11-29 21:43:44 -08:00
Robin Ward
769223014c
FIX: Allow link redirects inside oneboxed posts
2013-11-29 14:29:49 -05:00
Neil Lalonde
a9ab98ef9e
Auto-close time can be entered in 3 ways, so a topic can close at any time
2013-11-27 09:52:35 -05:00
Sam
6544f39bcc
fix topic counts not updating automatically in various spots (top menu / categories page / drop down)
2013-11-25 17:37:51 +11:00
Régis Hanol
82b78ec6ba
schemaless avatar urls
2013-11-22 19:18:45 +01:00
Régis Hanol
3cf5a363f7
do not destroy uploads when destroying a user
2013-11-22 18:29:07 +01:00
Régis Hanol
f65cde3cda
do not bump posts when rebaking
2013-11-22 01:52:26 +01:00
Erik Ordway
bf390163aa
Load plugin settings.
...
Along the lines for loading the locale files for a plugin we should also load the settings.yml for a plugin. Updated version 04f3e09 that moves the loading to a function. I do not understand why it was necessary to define the function physically earlier in the file as I thought ruby did two pass but that may only apply to functions and not stray code in the class.
2013-11-19 11:43:01 -08:00
Robin Ward
309904ef8f
Revert "Merge pull request #1673 from aperrault/patch-04"
...
This reverts commit c9ea89bdd3
, reversing
changes made to 9ed49888fc
.
2013-11-19 14:08:45 -05:00
Autumn Perrault
d9c026bec5
Fixing neglect to determine whether a user has the permission to create a topic on a category (besides being able to create a post) in ListController, TopicList, and TopicListSerializer causing the "Create Topic" button to appear even if a user cannot actually create a topic in that category but can reply to a topic therein.
2013-11-19 05:09:58 -07:00
Neil Lalonde
ae58a7db95
Add a warning on dashboard if enforce_global_nicknames is checked, but access key is blank.
2013-11-18 13:45:10 -05:00
Robin Ward
4ce81e1b01
Rename "Best Of" to "Summary"
2013-11-18 12:48:26 -05:00
Robin Ward
ad3e276b4b
Rename TopicSummary -> TopicMap
2013-11-18 12:08:21 -05:00
Régis Hanol
dabdcf59c4
allow for arbitrary HTML at the top/bottom of every pages
2013-11-18 17:13:24 +01:00
Sam
6e1198334c
automatic groups should be bootstrapped
2013-11-18 12:53:14 +11:00
Sam
1b19444b44
URGENT FIX: code would fail in Ruby 1.9.3 exception does not exist
2013-11-18 09:32:02 +11:00
Neil Lalonde
dfdc618e9a
Use File.join instead of hard-coding slashes
2013-11-15 14:34:03 -05:00
Neil Lalonde
fc180ccd71
Site settings: move category into the opts hash so that it's compatibale with existing plugins
2013-11-15 14:32:33 -05:00
railsaholic
34bba737ff
Refactor SessionController#create, reduce complexity.
...
Don't compromise readablity
2013-11-15 22:09:03 +05:30
Régis Hanol
8a83f1a88f
add disk space usage failsafe
2013-11-15 16:48:38 +01:00
Neil Lalonde
1e37abc310
Add site setting category support
2013-11-14 16:02:13 -05:00
Neil Lalonde
791f5ac94e
Load site settings from config/site_settings.yml
2013-11-14 16:02:13 -05:00
Robin Ward
67041d1c6d
Support for tracking the count of unique participants in a topic
2013-11-14 14:32:41 -05:00
Régis Hanol
07cbf8f4e3
do not customize the admin section
2013-11-14 16:41:16 +01:00
Robin Ward
7207cef7aa
TopicQuery cleanup in advance of custom sorting:
...
- Move SQL method constants into a module
- Removed unused count methods
- Moved methods that don't return a TopicList into Topic
- Replaced some confusing method signatures
2013-11-13 12:26:32 -05:00
Régis Hanol
7e7d951152
do not pull hotlinked images when max_image_size_kb == 0
2013-11-13 17:30:48 +01:00
Régis Hanol
e9f9d22482
add query parameter to temporarily disable customization
2013-11-12 18:14:22 +01:00
Scott Albertson
77b59b54ce
Refactor UsersController#invited
...
* Add test coverage
* Simplify controller action
* Move finder code to Invite class
2013-11-11 13:23:49 -08:00
Sam
0ceeeedf80
correct logic for tracking incoming links
2013-11-11 10:53:01 +11:00
Sam
d1d661f6e1
add logic that auto closes any topics that missed the queued job (due to redis flush or whatever)
2013-11-11 10:52:44 +11:00
sirMackk
af67284995
User ctrl refactor - breaks up large methods, moves some logic into model
...
Includes missing methods from backup for travis to pass
fix missing code, failing specs
keep params handling in the controller.
2013-11-09 18:44:13 +05:30
Robin Ward
c753a3c784
We shouldn't be matching on the created_at
field. Causes tests to randomly fail.
2013-11-07 16:35:40 -05:00
Neil Lalonde
0c6f794eb0
Used the term suspended instead of banned.
2013-11-07 13:53:49 -05:00
Robin Ward
01b768392a
Remove default_scope
2013-11-06 16:56:49 -05:00
Robin Ward
914b723b97
Category dropdown should be in the position
order
2013-11-06 15:50:47 -05:00
Robin Ward
948a545cb1
Category descriptions should not appear in digests
2013-11-06 15:05:06 -05:00
Robin Ward
de30af9302
Support for inviting to a forum from a user's invite page.
2013-11-06 12:56:50 -05:00
Robin Ward
25ef66c60b
User invites page now has search, displays first invites_shown
records
2013-11-05 17:53:26 -05:00
Régis Hanol
37fd7ab574
pull hotlinked images
2013-11-05 19:07:29 +01:00
Neil Lalonde
8724b2e2b6
Add comments about the IPAddr hack
2013-11-05 11:24:13 -05:00
Sam
1e21fc8c9a
fix regression in Rails 4
2013-11-05 10:32:35 +11:00
Neil Lalonde
bd9b85f076
Screened Urls page shows results for each domain instead of each url
2013-11-04 16:24:48 -05:00
Neil Lalonde
ede59a4386
FIX: issue 1538. After upgrading and before a new version check request has been made, dashboard might still say that an update is available.
2013-11-04 12:51:09 -05:00
Robin Ward
52c3457133
Site setting to support showing real names in posts. Also put back in type to search on site settings
2013-11-01 16:32:12 -04:00
Neil Lalonde
92a0729937
When banning a user, a reason can be provided. The user will see this reason when trying to log in. Also log bans and unbans in the staff action logs.
2013-11-01 10:47:26 -04:00
Robin Ward
b93ca1089e
List subcategories on categories page
2013-10-31 18:02:24 -04:00
Robin Ward
3d6d7c8abe
SiteSetting to hide regular names from users
2013-10-30 15:45:34 -04:00
Robin Ward
6063b52d6a
Support for choosing a destination category when splitting topics.
2013-10-29 15:30:06 -04:00
Robin Ward
f7d6ab579c
Merge pull request #1571 from novemberkilo/master
...
Refactor User#update_last_seen! and User#update_tracked_topics
2013-10-29 08:28:08 -07:00
Manoj
9650dbb97c
Refactor topics controller
...
Refactor: 1) TopicsController to reduce code climate complexity.
2) Topic model, addressed comments
fix typo
2013-10-28 11:42:07 +05:30
Sam
95e936c299
cleanup API for looking up a user by email or username, add specs, fix invalid auto association in open id provider
2013-10-28 16:29:07 +11:00
Robin Ward
f4d9bf9181
Merge pull request #1573 from railsaholic/use_existing_find_by_username_or_email
...
Utilize already existing method 'find_by_username_or_email'
2013-10-25 12:57:18 -07:00
Sam
4929c5db71
FIX: when allow_uncategorized_topics was false, PMs can not be created
2013-10-25 09:33:39 +11:00
Neil Lalonde
d149066ac6
Show a warning on admin dashboard if running on an older patch level of ruby 2.0
2013-10-24 18:22:47 -04:00
Robin Ward
61468f6f27
Can assign a parent category to a category.
2013-10-24 17:03:28 -04:00
Manoj
96ae3cdacc
Utilize already existing method 'find_by_username_or_email'
...
check presence of email using include, dont use =~
2013-10-24 19:26:06 +05:30
Sam
24d732b12a
regressions post merge
2013-10-24 12:25:20 +11:00
Sam
adeb987c70
oops messed up merge
2013-10-24 12:09:49 +11:00
Sam
666264879c
change it so all topics MUST include a category, we store a special uncategorized category to compensate
...
this cleans up a bunch of internals and removes some settings
2013-10-24 12:08:02 +11:00
Navin Keswani
6ce80fd148
Refactor User#update_last_seen! and User#update_tracked_topics
2013-10-23 23:27:30 +02:00
Neil Lalonde
8aab2253d0
Whitelisted ip addresses will not be flagged as spam by flag_sockpuppets
2013-10-23 17:11:35 -04:00
Robin Ward
c814fc16a3
Database structure to support sub categories
2013-10-23 15:22:49 -04:00
Neil Lalonde
c1008f4359
Fixes for postgresql inet columns in Rails 4. They're backed by an IPAddr class now, which breaks sql parameter marker support, and automatically sets the attribute to nil when trying to assign an invalid ip address.
2013-10-22 19:19:32 -04:00
Robin Ward
6394d924c8
Change migration to prevent down
2013-10-22 17:51:04 -04:00
Robin Ward
348e2e3ef2
Support for per-user API keys
2013-10-22 17:34:39 -04:00
Neil Lalonde
7d582fbee3
Screened ip address can be edited, deleted, and changed to allow or block.
2013-10-22 16:30:46 -04:00
Robin Ward
2308784713
Merge pull request #1543 from railsaholic/small_users_controller_refactoring
...
refactor UsersController to reduce complexity
2013-10-21 12:21:03 -07:00
Neil Lalonde
648b11a0eb
Add screening by IP address. When deleting a user as a spammer, block all signups from the same IP address.
2013-10-21 14:50:18 -04:00
Sam
6067795780
categories can now be re-ordered
2013-10-21 15:25:20 +11:00
Sam
614f45d003
correct topic and category counting query
...
revive old styling that was stripped
2013-10-21 10:20:16 +11:00
Manoj
868e4ffe6d
refactor UsersController to reduce complexity
...
Refactored: UsersController#create
2013-10-19 15:18:11 +05:30
Sam
5f74cb6bf9
category is not "positionable"
2013-10-18 18:09:30 +11:00
Sam
6f32cb52d6
minor styling changes, kill n+1 query
2013-10-18 11:23:08 +11:00
Sam
1ee49798b2
work in progress wide category list
2013-10-18 11:10:10 +11:00
Sam
7bf96ee690
naive implementation of post_count on categories
2013-10-18 11:10:10 +11:00
Sam
8f0e3de675
work in progress, wide categories page
2013-10-18 11:10:10 +11:00
Robin Ward
3df42f5c45
Disable caching of site settings temporarily
2013-10-17 15:49:33 -04:00
Neil Lalonde
0eaf32db45
Add a message to flags created because of the newuser_spam_host_threshold site setting
2013-10-17 15:08:11 -04:00
Régis Hanol
82dd9009e3
4% speedup on our test suite
2013-10-17 18:47:08 +02:00
Robin Ward
f8625b5510
Merge pull request #1495 from cored/refactor-topic-invite-by-email
...
Refactor: Topic model
2013-10-17 07:04:12 -07:00
Robin Ward
0a4f5af4a8
Merge pull request #1531 from railsaholic/topics_model_refactoring
...
Refactored Topic#limit_topics_per_day to improve Code Climate Complexity
2013-10-17 06:56:41 -07:00
Jeff Atwood
a580078ca7
increase default max_post_size to 32k chars
2013-10-16 14:59:33 -07:00
Neil Lalonde
cabe8f0d2d
Clean up ScreenUrl normalization and matching
2013-10-16 16:39:29 -04:00
Robin Ward
15cad17810
FIX: Nokogiri bugs in certain environments
2013-10-16 12:19:59 -04:00
Régis Hanol
debd9bfb25
add a sitesetting to enable the CleanUpUploads job
2013-10-16 17:09:36 +02:00
Manoj
7c03076c2a
Refactored Topic#limit_topics_per_day to reduce code climate complexity
...
Extracted 1) #apply_per_day_rate_limit_for, method as generic
RateLimiter , 2) #limit_first_day_topics_per_day as a separate method,
3) Added User#added_a_day_ago?, 4) Fixed private methods indentation.
2013-10-16 14:58:18 +05:30
James Edward Gray II
1aa9fc982d
Adding post details in preparation for the API importer code.
2013-10-15 09:21:30 -05:00
Régis Hanol
4536b5fe04
added a job to clean up orphan uploads
2013-10-15 11:15:48 +02:00
Sam
cf08d2c751
security: when login is required don't return the site node in the preload store
2013-10-15 09:50:49 +11:00
Sam
7df4e4afb9
security fix, anon should not be treated as though they can create anything
2013-10-13 09:54:48 +11:00
Sam
e5fbdde56f
filter params correctly from error log
2013-10-13 08:07:45 +11:00
Neil Lalonde
3c2c6ab24b
Add sockpuppet spammer detection. Automatically flag posts if they are from new users (registered less than 24 hours ago) at the same IP address and one of them started the topic.
2013-10-11 13:34:05 -04:00
Robin Ward
fee2734aaa
Check for custom avatars by default now.
2013-10-11 11:09:53 -04:00
Sam
b0465c517e
(experimental) added framework for filtering all sorts of internals in discourse and consuming by plugins
2013-10-10 18:45:40 +11:00
Sam
2a948c52a9
this setting needs to be pushed up to 15 so we will be able to nuke new spammer accounts
...
it is set to max_topics_in_first_day + max_replies_in_first_day
2013-10-10 10:45:27 +11:00
Sam
ad2ed5fe51
rate limits for topics and posts on first day
...
max_topics_in_first_day and max_replies_in_first_day
2013-10-10 10:32:03 +11:00
Rafael George
3a1e1e046b
Refactor: Topic#invite_by_email
...
Extract Topic#email_already_existas_for? and Topic#grant_permission_to_user
Fix failing spec due to missing variable in extracted method
2013-10-09 13:55:02 -04:00
Neil Lalonde
bccb37b6f3
When creating a topic, don't select a category by default when allow_uncategorized_topics is false. Also, added category validation on the server to enforce allow_uncategorized_topics.
2013-10-08 14:41:20 -04:00
Sam
094b5eccca
bug fixes for user_stat extraction, decrease querying
2013-10-07 15:05:00 +11:00
Sam
e18b93026a
defer view creation on so updates are not performed when people navigate to topics
2013-10-07 15:04:59 +11:00
Sam
5bf26ec34e
large refactor, ship a few columns from the user table into user_stats
2013-10-07 15:04:59 +11:00
Sam Saffron
ad93fc959c
security issue, anon and logged in users could see the fact that a user sent another user a pm (but could not see the pm itself or title)
2013-10-03 16:48:03 -07:00
Robin Ward
578ef2098b
Merge pull request #1488 from cfstras/removeAllowedUser
...
Allow removing users from private conversations
2013-10-03 08:02:41 -07:00
Claus Strasburger
15a973fd45
Improved private message user removal, locale edit
...
replaced array iteration with findProperty (will be renamed and aliased to findBy with Ember 1.1)
added modal dialog to verify
catched nil-error on topic.rb
2013-10-02 19:16:43 +02:00
Sam
441010ac65
optimise view count calculation query
2013-10-02 17:08:53 +10:00
Sam
5f8851cb44
Avoid superfluous transaction when saving drafts
2013-10-02 12:17:27 +10:00
Sam
f0a122a66c
move job files so they live underneath app/ and not in lib/
...
introduce new setting email_always, that will force emails to send to users regardless of presence on site
2013-10-01 17:04:02 +10:00
Robin Ward
3f0c03a20c
FIX: Prevent unauthorized list of private message titles. Also remove some unused code.
2013-09-30 14:35:11 -04:00
Sam
5caa7a0e4d
improve performance of periodical update job, decrease frequency and shift it by a few minutes
2013-09-30 16:59:16 +10:00
Sam
6fbc5af284
notify_user is not a flag
2013-09-30 15:26:19 +10:00
Régis Hanol
cd4cda5b4c
allow users to specify thumbnail size
2013-09-27 10:57:31 +02:00
Sam Saffron
085493e35d
optimise regular job to avoid touching posts that have not changed
2013-09-19 23:00:42 -07:00
Robin Ward
99b6a62fcb
New composer message for people dominating a topic
2013-09-17 14:38:39 -04:00
Neil Lalonde
0fafe124db
Add enable_mobile_theme site setting. Uncheck it to disable the mobile theme.
2013-09-17 11:25:37 -04:00
Neil Lalonde
b15e629f46
Strip trailing slashes from ScreeningUrl records
2013-09-17 10:26:05 -04:00
Neil Lalonde
c845071066
Fix an error with mobile custom header
2013-09-16 12:55:44 -04:00
Neil Lalonde
13f17b2a5c
Add ability to customize css and header for mobile
2013-09-16 12:28:02 -04:00
Matthieu Guillemot
3ba1f20674
New site settings to enable/disable the possibility of editing user's nickname or email address
2013-09-14 21:34:21 +09:00
Robin Ward
c365bd0070
Notify users posting sequential replies that there's a better way to do it.
2013-09-13 13:49:34 -04:00
Robin Ward
7d9a84b496
New User Education goes through a server side ComposerMessages check. Composer message for users
...
who don't have avatars.
2013-09-13 12:23:53 -04:00
Robin Ward
3fcd331d43
Add records that indicate a user's avatar has been checked
2013-09-12 14:58:20 -04:00
Sam
aa26f9b2ad
I need to figure out how to make a .try variant that does not call respond_to.
2013-09-12 11:29:44 +10:00
Neil Lalonde
bded4b26fa
Ask admins to fill in site_description on the dashboard, and send it to the hub
2013-09-11 16:32:49 -04:00
Neil Lalonde
4fa11f159f
Add site setting site_description. If filled, it will be used in meta description tag for teh white hat SEO
2013-09-11 15:33:27 -04:00
Robin Ward
06ea8140aa
New job (default off) to detect whether users have uploaded custom avatars by contacting Gravatar.
2013-09-11 15:14:18 -04:00
Robin Ward
fcff4e80d1
New user_stats
table to keep track of queried information on a user.
...
This is information that is not usually needed when representing a user
and is in a separate table with a has one relationship to avoid querying
it all the time.
2013-09-11 14:50:26 -04:00
Neil Lalonde
e8ef55c446
Rename StaffActionLog to UserHistory
2013-09-10 22:01:20 -04:00
Robin Ward
2319924206
Adds a class that can detect whether a user has uploaded a custom avatar
2013-09-10 15:39:11 -04:00
Sam
162d94aa02
improve secure_category_id query
2013-09-10 14:29:02 +10:00
Neil Lalonde
78c15d5810
Move the unique post key storage code into the Post model
2013-09-09 16:17:31 -04:00
Neil Lalonde
eae7e75611
FIX: recover post by a non-staff user fails because the post is not unique. Uniqueness check shouldn't happen when recovering a deleted post.
2013-09-06 11:50:15 -04:00
Sam
641c51367a
fix broken build
...
hack to allow for PMs with no users for flagging needs
2013-09-06 18:03:30 +10:00
Sam
32e3e3f382
update annotations
2013-09-06 17:38:50 +10:00
Sam
2ce4468aa5
rename system_username to site_contact_username , system_user is a special user with -1 id that is only used for certain admin tasks
...
for example system_user will autoclose stuff if needed, it will delete stubs and be the target for flag pms
2013-09-06 17:28:37 +10:00
Sam
41a1b6942d
notify moderators now goes to the "community" user, that saves our poor mods from a flood of pms
...
if any staff respond to a pm they are automatically added to the list of recipients and will start
getting email notifications
2013-09-06 14:07:23 +10:00
Neil Lalonde
cde631cbd1
Change default of notify_mods_when_user_blocked to false
2013-09-05 11:27:24 -04:00
Neil Lalonde
d76486a48b
Topic can have null user_id when user was nuked
2013-09-04 15:42:24 -04:00
Neil Lalonde
117fc8db58
Change the way nuked users' posts are handled. Allow null in the user_id column of posts. Show these posts in the posts stream.
2013-09-04 15:42:21 -04:00
Robin Ward
1a6170a47c
Merge pull request #1407 from einarj/extract_fake_admin_method
...
Extracted a fake_admin method
2013-09-04 07:59:03 -07:00
Neil Lalonde
b47eedba00
Add min_trust_to_create_topic setting to require a certain trust level before users can start new topics
2013-09-03 19:12:22 -04:00
Einar Jonsson
e06356ebbe
Extracted a fake_admin method
2013-08-30 17:39:31 +00:00
Einar Jonsson
23d8f5fec7
Replaced delegator methods with Forwardable def_delegator in Topic
2013-08-30 09:29:34 +00:00
Robin Ward
bbd79aafd1
Revert "Replaced delegator methods with Forwardable def_delegator in Topic"
...
This reverts commit 3ed037940f
.
2013-08-29 11:45:27 -04:00
Einar Jonsson
3ed037940f
Replaced delegator methods with Forwardable def_delegator in Topic
2013-08-28 11:25:57 +00:00
Sam
61281a3c81
invite only forums had very wonky logic, invited users were not being activated, invite_only forums were still registering users
2013-08-28 17:18:31 +10:00
Sam
dfa5a8a83f
annotate models
2013-08-28 10:52:06 +10:00
Einar Jonsson
b385cdcc34
Extracted featured_users functionality out of Topic.
...
* Created a TopicFeatureUsers model
* Topic#featured_user_ids and Topic#feature_topic_users now delegate to
* a TopicFeatureUsers instance to keep demeter happy.
2013-08-27 09:10:50 +00:00
Sam
83d8bcdc27
revert non queuing of emails
2013-08-27 11:52:28 +10:00
Sam
f4bda8f1ba
revert change of defaults for twitter and facebook enabled
2013-08-26 17:36:08 +10:00
Sam
322b5c236c
queue emails right away if a user is not online, no point waiting.
2013-08-26 14:55:35 +10:00
Sam
818bf1355d
PluginStore for plugin specific bits of storage
...
Amended plugin interfaces so they work with the vk sample
2013-08-26 12:59:17 +10:00
Sam
2eb55b74e4
twitter and facebook are broken unless configure, so default off please
2013-08-26 12:59:17 +10:00
Sam
e0c99196a8
Merge pull request #1383 from ZogStriP/add-max-image-height-site-setting
...
add max_image_height site setting
2013-08-25 17:11:48 -07:00
Régis Hanol
32f717420d
add max_image_height site setting
2013-08-26 00:24:24 +02:00
Navin Keswani
d87389b38e
No more rails 4 deprecation warnings
2013-08-25 23:18:11 +02:00
Robin Ward
e9663e5338
Merge pull request #1332 from locks/user_email_observer
...
User email observer (Code Climate improvements)
2013-08-24 08:34:11 -07:00
Ricardo Mendes
37f4022f73
Refactors UserEmailObserver to improve Code Climate score
...
- Extracts certain logic to private methods and remove unnecessary
comments
- Extracts email enqueueing methods into a separate class
- Fix specs involving UserEmailObserver to call #after_commit instead
of the specific methods
2013-08-24 12:21:39 +01:00
Jeff Atwood
edbaafdd7b
default relative dates to 30 days vs 14
2013-08-23 23:28:51 -07:00
Neil Lalonde
6e79197519
Enum site settings can have translatable names in dropdown. Add setting for how often users get digest emails by default: default_digest_email_frequency.
2013-08-23 17:36:25 -04:00
Régis Hanol
43a8bff652
add a site setting for allowing animated avatars
2013-08-23 18:55:02 +02:00
Sam
472f0684c3
Merge pull request #1345 from salbertson/refactor-find_by_username_or_email
...
Improve test coverage and refactor User.find_by_username_or_email
2013-08-22 17:14:06 -07:00
Neil Lalonde
3b15e2e58e
Banned users are not returned as pending review users
2013-08-22 19:23:49 -04:00
Neil Lalonde
25e0c3eac1
Log IP addresses with screened emails and urls
2013-08-22 19:04:35 -04:00
Scott Albertson
1dbe1fb1bc
Refactor User.find_by_username_or_email
...
* Improve test coverage
2013-08-22 09:40:07 -07:00
Neil Lalonde
24617dd776
Show empty categories with descriptions to everyone
2013-08-22 11:55:20 -04:00
Sam
d7596840e5
only staff should be able to see bookmarks and favs of other users
...
ensure that when they click on them they see the correct topics (topics for user they are looking at, not current user)
2013-08-22 09:18:54 +10:00
Neil Lalonde
47add6da70
Log when a site customization is deleted
2013-08-21 12:33:24 -04:00
Neil Lalonde
a95303fcd8
Log site customization changes. Use a modal to show staff action log details for site customizations.
2013-08-21 12:33:24 -04:00
Robin Ward
7f69a58439
Replace Markdown parser.
2013-08-21 10:10:57 -04:00
Neil Lalonde
3abeb5f793
Staff action logs can be filtered to changes of one site setting
2013-08-20 13:50:51 -04:00
Sam
c0c929be5a
optimise query that runs every 10 minutes and takes out the user table
2013-08-20 17:40:22 +10:00
Sam
f4d833da27
fix onebox exception, if oneboxes fail on save we log a warning to the log
2013-08-20 11:38:10 +10:00
Neil Lalonde
1d030666d8
Log site setting changes and show in admin
2013-08-19 16:58:38 -04:00
Neil Lalonde
7eaedb84e1
Add notify_mods_when_user_blocked site setting to control whether moderators get a message when someone is automatically blocked
2013-08-19 12:00:48 -04:00
Sam
a9393e4a7a
paging for flag list
...
corrected reload behavior on flag list
refactored post actions ... extracted flag queries
2013-08-19 21:14:26 +10:00
Sam
3b34ab8cab
Merge branch 'master' of github.com:discourse/discourse
2013-08-18 21:35:29 +10:00
Sam
82ca61f150
Merge pull request #1350 from michaelkirk/feature/oauth2
...
Feature/oauth2
2013-08-18 17:01:01 -07:00
Sam
1cab98bf78
Merge pull request #1336 from novemberkilo/master
...
First pass at fixing rails4 deprecation warnings
2013-08-18 16:59:07 -07:00
Sam
3f5b5f1581
Merge branch 'master' of github.com:discourse/discourse
2013-08-18 21:30:14 +10:00
Michael Kirk
4af8a9102e
Authenticate with Discourse via OAuth2
...
See https://github.com/michaelkirk/discourse_oauth2_example for an
example of how you might integrate your existing oauth2 provider's
authentication via a Discourse plugin.
2013-08-17 21:45:20 -07:00
Neil Lalonde
baff59d752
Send email to contact_email when a new version of Discourse is found. Disable with the new_version_emails setting.
2013-08-16 17:28:36 -04:00
Régis Hanol
2119774fb6
FIX: custom avatars in email
2013-08-16 09:58:20 +02:00
Sam
c314a1862f
add todo
2013-08-16 17:04:30 +10:00
Régis Hanol
c9969738bf
FIX: N+1 query for avatars when searching for users
2013-08-16 00:26:49 +02:00
Neil Lalonde
8a96c4c0f6
Fix uncategorized topics not being shown on categories page
2013-08-15 15:18:04 -04:00
Navin
9ab2471a92
Fix rails4 deprecation warnings
...
That appear when running topic_spec.rb
2013-08-15 17:52:18 +02:00
Sam
ee95d7df9c
trigger observers, wow this is all very complicated and full of duct tape
2013-08-15 13:54:48 +10:00
Sam
fda6cce0de
minor refactor
2013-08-15 13:44:30 +10:00
Sam
79c109a819
Merge pull request #1322 from bhicks/refactor-feature-topic-users
...
Refactoring the feature_topic_users method
2013-08-14 20:04:54 -07:00
Sam
b55c9e391d
Merge pull request #1333 from fabianoleittes/fix_type_url
...
Fix url not to be nil
2013-08-14 20:04:00 -07:00
Ben Hicks
b13796c35e
Refactoring the feature_topic_users method to improve
...
the code climate score.
2013-08-14 20:42:16 -05:00
Fabiano Leite
4df8babb9a
Fix url not to be nil
2013-08-14 21:55:25 -03:00
Sam
1965cbcad6
Merge pull request #1331 from ZogStriP/fix-avatars-on-activity-stream
...
FIX: performance regression on activity streams
2013-08-14 16:52:13 -07:00
Sam
c2653b2915
Merge pull request #1309 from stephankaag/sidetiq
...
Replace Clockwork with Sidetiq
2013-08-14 16:51:04 -07:00
Régis Hanol
8af51883bf
FIX: performance regression on activity streams
2013-08-15 01:32:27 +02:00
Robin Ward
3e7441177a
Merge pull request #1330 from ZogStriP/emails-can-be-mixed-case
...
only the host part of an email address is case insensitive
2013-08-14 13:26:49 -07:00
Neil Lalonde
86647f0a54
Add ScreenedUrl. Rename BlockedEmail to ScreenedEmail.
2013-08-14 16:08:23 -04:00
Stephan Kaag
a6b4b5dbf2
Replace Clockwork with Sidetiq
2013-08-14 21:39:40 +02:00
Régis Hanol
5ca187ba57
only the host part of an email address is case insensitive
2013-08-14 19:31:35 +02:00
Robin Ward
8fa9c51bf4
FIX: New avatar regression with mixed case email addresses.
2013-08-14 13:05:57 -04:00
Régis Hanol
4866f4d8f5
FIX: N+1 query for avatars
2013-08-14 15:25:05 +02:00
Sam
6e97ddc8ef
allow uploaded avatars by default
2013-08-05 14:08:08 +10:00
Régis Hanol
9a7df140b7
updated model annotations
2013-08-13 22:09:27 +02:00
Régis Hanol
c867b67a0b
custom avatar support
2013-08-13 22:08:29 +02:00
Régis Hanol
e5e3164ea1
added the "allow uploaded avatars" site setting
2013-08-13 22:06:22 +02:00
Jeff Atwood
6722a1fe22
some minor user deletion tweaks
2013-08-13 00:41:23 -07:00
Neil Lalonde
b36c6d7b78
Users cannot change their own username after 3 days since registering. Site setting username_change_period allows you to change the number of days.
2013-08-12 14:55:09 -04:00
Neil Lalonde
879652f055
Add setting edit_history_visible_to_public to control whether post edits can be viewed by everyone. Uncheck it so only staff users can see edits.
2013-08-12 11:12:20 -04:00
Neil Lalonde
bb492eb8bf
Add filtering to staff logs page
2013-08-09 16:59:05 -04:00
Robin Ward
652169daf6
Include a list of more new topics in the digest emails at the bottom
2013-08-09 14:43:02 -04:00
Robin Ward
6452962f36
FIX: Notification counters were being updated incorrectly.
2013-08-09 12:12:56 -04:00
Neil Lalonde
90a3bcf6ff
Add filter by action to staff logs page
2013-08-09 10:06:59 -04:00
Neil Lalonde
ce05b43c1d
Fix delete user button on admin/user page so it's enabled at the right times, and update its title attribute to be more helpful
2013-08-08 12:54:38 -04:00
Neil Lalonde
d2fb6ec53f
Blocked Emails list in admin
2013-08-07 16:27:34 -04:00
Régis Hanol
bbd05f37d2
create thumbnails by defaults
...
changed "create_thumbnails" default value to `true`
2013-08-07 22:18:50 +02:00
Robin Ward
fe3a69c271
Private message emails now include the history
2013-08-07 13:03:45 -04:00
Robin Ward
1c3804934e
Show the entire history of replies above a post when you expend "in reply to"
2013-08-06 17:43:10 -04:00
Neil Lalonde
98b58150bb
Dashboard calculations are done with an async job now
2013-08-02 18:32:33 -04:00
Neil Lalonde
1552c4b69e
Remove users column from Top Traffic Sources table on dashboard. It's not useful and very expensive to calculate.
2013-08-02 18:32:33 -04:00
Neil Lalonde
9db0ac16a9
Add site setting delete_removed_posts_after to configure after how many hour posts that were deleted by their authors will be deleted
2013-08-02 13:35:52 -04:00
Sam
d343d512b9
favorite user action consistency
2013-08-02 11:07:18 +10:00
Sam
5e23a0681d
work in progress, will finalize soon
2013-08-02 09:59:25 +10:00
Régis Hanol
faeb4a9ebd
enhance upload selector
...
- Change the icon on the button to a file when attachments are enabled
- Display the list of allowed extensions in the upload selector
- FIX : regexps for validating uploads weren't escaping the dots
2013-08-02 01:30:18 +02:00
Robin Ward
4f0713b9da
Merge pull request #1275 from ZogStriP/enable-thumbnailing-on-s3
...
Enable thumbnailing on s3
2013-08-01 07:35:35 -07:00
Régis Hanol
ed9417fa3b
enable thumbnailing on S3
...
- added url to optimized image model
- refactored s3_store & local_store
2013-07-31 23:26:34 +02:00
Neil Lalonde
27498a912b
Add indexes to help IncomingLinksReport, but not much. Refactor to limit result set size, but it doesn't help perf much either. SELECT COUNT(DISTINCT ...) is still slow.
2013-07-31 15:17:53 -04:00
Ryan Boland
553a671fdb
fix mentions in code blocks
2013-07-30 18:01:42 -04:00
Neil Lalonde
882c1524f7
Strip trailing and leading spaces from category names
2013-07-30 16:48:45 -04:00
Neil Lalonde
06140740d0
Version checks: tolerate old version check data that can happen immediately after upgrading but forgetting to restart sidekiq/clockwork. Don't cache version check data along with other dashboard data.
2013-07-30 12:12:04 -04:00
Neil Lalonde
4fd5087f91
Add button to delete a spammer in the flag modal
...
Add SiteSettings: delete_user_max_age, delete_all_posts_max. Add delete spammer button to admin flags UI
Moderators can delete users too
2013-07-29 15:29:44 -04:00
Neil Lalonde
8cee3a9fcd
Add a way to add email to block list when nuking a user
2013-07-29 15:29:43 -04:00
Neil Lalonde
5f8a130277
Add BlockedEmail, to block signups based on email. Track stats of how many times each email address is blocked, and last time it was blocked. Move email validation out of User model and into EmailValidator. Signup form remembers which email addresses have failed and shows validation error on email field.
2013-07-29 15:29:43 -04:00
Neil Lalonde
a8df9778b5
Rename AdminLog to StaffActionLog
2013-07-29 15:29:43 -04:00
Robin Ward
3a861c0823
FIX: Allow clicks on @names
2013-07-27 13:18:37 -04:00
Robin Ward
01a6b45231
FIX: Can click on your own links again
2013-07-26 17:29:43 -04:00
Stephan Kaag
f99acebdaa
Rails 4 updates
2013-07-24 21:09:18 +02:00
Régis Hanol
be9217d4c8
add server-side filesize check on uploads
2013-07-24 00:54:41 +02:00
Robin Ward
adf7c9ad06
Merge pull request #1237 from stephankaag/improve_post_analyzing
...
Improve post analyzing
2013-07-23 07:07:49 -07:00
Sam
7e92109ac8
Merge pull request #1240 from abbat/master
...
Fix locale dependend stemmer for FTS
2013-07-23 00:40:54 -07:00
Sam
060c79ecc0
remove dupes before correcting topic_ids in user action consistency check job
2013-07-23 12:44:20 +10:00
Doug Alcorn
35a2bb7919
Parameterize the PBKDF2 algorithm in application config
...
http://meta.discourse.org/t/sso-between-discourse-and-xmpp/8567/5
2013-07-22 21:36:01 -04:00
Sam
4b269de724
correct: http://meta.discourse.org/t/cant-save-adding-a-group-permission-to-a-category/8537
...
can not save category after adding a new custom group
2013-07-23 10:10:36 +10:00
Sam
0acc96c94e
work around for http://meta.discourse.org/t/activerecord-statementinvalid-exception-raised-in-models-user-action-rb/7275/4
2013-07-23 09:48:18 +10:00
Anton Batenev
aa7d1c2fbe
Fix locale dependend stemmer for FTS
...
Fix locale dependend stemmer for FTS to improve search relevance on non English languages.
2013-07-23 03:07:59 +04:00
Sam
ea7684fb32
Merge pull request #1226 from stephankaag/rails4_updates
...
Some Rails4 updates
2013-07-22 15:03:37 -07:00
Stephan Kaag
b58da2fcf9
Add some TODO's
2013-07-22 22:39:20 +02:00
Stephan Kaag
ebd5fa76c5
Reuse post-analyzer and cooked-document when requesting multiple post stats
2013-07-22 22:24:47 +02:00
Stephan Kaag
ad2b667504
Remove dead code
2013-07-22 22:16:46 +02:00
Robin Ward
fd1d376975
Merge pull request #1235 from stephankaag/remove_all
...
Remove some calls to `all`
2013-07-22 12:26:00 -07:00
Robin Ward
3e7b418ea8
First Try: Include Post History (context) in Notification Emails
2013-07-22 15:06:37 -04:00
Stephan Kaag
0e3b8fbb24
Remove some calls to all
. They are not required, and Rails4 raises warnings about them.
2013-07-22 20:44:11 +02:00
Stephan Kaag
b19f631b3a
Some Rails4 updates
2013-07-22 19:01:22 +02:00
Robin Ward
ed745c3fdd
Merge pull request #1222 from ZogStriP/fix-s3-related-issues
...
Fix s3 related issues
2013-07-22 07:30:41 -07:00
Robin Ward
80a0943f54
Merge pull request #1228 from ZogStriP/fix-thumbnailing-with-cdn-enabled
...
FIX: thumbnailing isn't working with CDN enabled
2013-07-22 07:22:59 -07:00
Robin Ward
8b181e0803
Merge pull request #1230 from ZogStriP/add-newuser-max-attachments-setting
...
add newuser-max-attachments setting
2013-07-22 07:22:23 -07:00
Sam
1f3c5cb656
allow end user to recover a post they delete
...
automatically delete stubs after 1 day
2013-07-22 17:48:47 +10:00
Sam
58e7c3e1f3
push some work out of AR callbacks into PostCreator, add a couple of helpers for post and topic creation in test
...
fix it so the auto_track false marks topics as new
2013-07-22 15:07:20 +10:00
Sam
31bb08bcdd
added an option to bypass auto tracking of topics on post creation
2013-07-22 15:07:20 +10:00
Sam
9e4b0df7ff
69 specs fail in rails 4 now ...not too bad
2013-07-22 15:07:20 +10:00
Régis Hanol
2986798ba7
add newuser-max-attachments setting
2013-07-22 02:39:17 +02:00
Régis Hanol
649ab85740
FIX: thumbnailing wasn't working with CDN enabled
2013-07-22 00:37:23 +02:00
Régis Hanol
33977252c9
rollback to previous s3 syntax (ie. subdomains)
2013-07-20 11:30:36 +02:00
Régis Hanol
8406a4230c
FIX: click tracking on attachments wasn't working
2013-07-19 01:27:09 +02:00
Robin Ward
7a6f1b5aff
Color moderator actions on user stream
2013-07-18 17:24:51 -04:00
Sam
81616a46ba
db consistency check for mismatching topic_ids in user_actions
...
fix up post mover so it remaps user actions as well
move specs for post mover into post_mover_spec
2013-07-17 16:40:56 +10:00
Sam
c2be81a76e
Merge pull request #1199 from ZogStriP/uploads
...
adds the `max_attachment_size_kb` setting
2013-07-16 23:03:42 -07:00
Régis Hanol
5c27dd175a
make sure we handle both s3 url formats
2013-07-17 00:32:09 +02:00
Régis Hanol
7ae2fe304d
renamed s3 to s3_store
2013-07-17 00:27:52 +02:00
Robin Ward
75282576b9
Merge pull request #1195 from initforthe/post-analyser-backtrace-fix
...
Post analyser backtrace fix
2013-07-16 07:34:54 -07:00
Sam
e9d37f395f
hmm I totally missed that it was already there
2013-07-16 21:06:04 +10:00
Sam
06bd9e3234
allow login required screen to be customized
2013-07-16 20:49:04 +10:00
Sam
352ac9e60c
Finalize read only and post only categories, finished off UI work
2013-07-16 15:46:11 +10:00
Sam
ecf17cfebb
work in progress, add fidelity to category group permissions (full, create posts, readonly)
2013-07-16 15:46:11 +10:00
Régis Hanol
5ce05ff5cb
adds the max_attachment_size_kb
setting
...
so that we can specify a different max upload size for attachments and images.
2013-07-16 02:01:36 +02:00
Tom Russell
96065a1499
Prevent backtrace in PostAnalyser
2013-07-15 11:15:04 +01:00
Régis Hanol
6f2ce93ab2
FIX: create an upload when FastImage throws an exception
...
FastImage might throw an exception when it isn't able to recognize a
file as being an image (ie. happens when users changes the extension
manually)
Also improved upload specs a lot
2013-07-13 23:42:19 +02:00
Robin Ward
7fd8bb75d9
Merge pull request #1177 from ZogStriP/attachments
...
Attachments
2013-07-11 06:49:20 -07:00
Sam
1aef6de4b0
automatically approve invited users on forum where moderators must approve (keep in mind only moderators can invite)
...
speed up specs a touch
allow invite controller to accept an email in absence of user (cleans up API)
2013-07-11 11:22:00 +10:00
Régis Hanol
ac41e94619
refactor optimized_image a bit
2013-07-10 22:59:54 +02:00
Régis Hanol
27ab5f471c
support arbitrary attachments
2013-07-10 22:59:53 +02:00
Neil Lalonde
8814f9ed05
Fix a case when a staff user views a topic with a deleted post by a nuked user; might be a temporary solution until we decide what to do with nuked records
2013-07-10 16:52:47 -04:00
Neil Lalonde
0e3e5bf533
Add relative_date_duration site setting
2013-07-10 12:38:43 -04:00
Robin Ward
cc47616cdb
Merge pull request #1157 from abbat/email-custom-headers
...
Add custom headers for email messages
2013-07-10 07:12:51 -07:00
Robin Ward
b7327942af
Add deleted_by
to Trashable
tables
2013-07-09 15:46:36 -04:00
Neil Lalonde
ba7a4e9845
Merge pull request #1165 from novemberkilo/feature/log-trust-level-boosts
...
Log all changes of user trust level by an admin
2013-07-09 12:16:08 -07:00
Neil Lalonde
3c38062802
Check for updates: edge cases when the message on the dashboard doesn't make sense.
2013-07-09 14:01:08 -04:00
Anton Batenev
b0dbb0ea13
And add tests for empty string & null
2013-07-09 20:19:10 +04:00
Robin Ward
5cda0e556c
Merge pull request #1111 from jamesaanderson/flash-video-onebox
...
Add flash video onebox support
2013-07-09 06:55:56 -07:00
Robin Ward
f9d1fcb169
Merge pull request #1140 from stephankaag/code_refactoring
...
Refactor code that raises deprecating warnings in Rails 4
2013-07-09 06:48:48 -07:00
Sam
8f892da890
move bookmark to end
2013-07-09 18:16:17 +10:00
Neil Lalonde
806bd98f99
Update category's topic_count immediately when trashing or recovering a topic; this ensures that a category can be deleted without waiting for the category_stats job to run.
2013-07-08 15:23:20 -04:00
Neil Lalonde
9b0f63627b
Add blocked users count to dashboard
2013-07-08 12:44:13 -04:00
Stephan Kaag
2abfd38aee
Refactor code that raises deprecating warnings in Rails 4
2013-07-08 18:35:11 +02:00
James A. Anderson & Jalil Mohammed
d51a3cf50f
Add flash video onebox as disabled setting by default
2013-07-08 06:37:44 -07:00
Navin
d77ce23de2
Log all changes of user trust level by an admin
2013-07-08 11:53:22 +02:00
Sam
807b9d438a
Merge pull request #1159 from jd-erreape/user_refactors
...
Refactors in user model
2013-07-07 23:38:16 -07:00
Sam
f1a31cd9e6
Merge pull request #1163 from ZogStriP/refactor-cooked-post-processor
...
refactored CookedPostProcessor
2013-07-07 22:01:48 -07:00
Sam
d79aa917f1
add option suppress_reply_directly_above to stop suppressing the reply directly above
...
added a bunch of debugging information to help diagnose weird positioning issues
2013-07-08 11:13:45 +10:00
Régis Hanol
ac7253a938
refactor CookedPostProcessor & specs
2013-07-08 01:39:08 +02:00
Juan de Dios Herrero
27b038cd40
Refactored username validations to avoid repeated code
2013-07-07 13:05:18 +02:00
Juan de Dios Herrero
e4fc6e02ed
Added discourse hub nickname operations simplify and avoid repeated code
2013-07-07 12:40:35 +02:00
Anton Batenev
4e04c4dddd
Add custom headers for email messages
...
See http://meta.discourse.org/t/custom-headers-in-emails-site-settings/7480
2013-07-07 04:37:44 +04:00
Régis Hanol
6251935b1e
removed auto_link_images_wider_than setting
2013-07-06 22:19:16 +02:00
Robin Ward
1c18490141
Revert "cheat to fix duplicate key on thumbnails"
...
This reverts commit 0c702522c4
.
2013-07-05 16:09:43 -04:00
Robin Ward
7335f5fb7f
Merge pull request #1145 from abbat/yandex-workaround
...
Workaround solution to help Yandex crawler index discourse.
2013-07-05 10:04:40 -07:00
Anton Batenev
694a6f4970
Fix recommendations from #1145
2013-07-05 15:59:39 +04:00
Sam
0c702522c4
cheat to fix duplicate key on thumbnails
2013-07-05 15:01:31 +10:00
Sam
9afea0ed07
spec for change
2013-07-05 14:23:29 +10:00
Sam
f3ac84d41f
our referer is bust if there is no domain
2013-07-05 14:07:08 +10:00
Régis Hanol
7c82d6d4d0
FIX: new users are allowed to upload images to your servers
2013-07-05 00:44:18 +02:00
Anton Batenev
af36d32f7f
Workaround solution to help Yandex crawler index discource.
...
Yandex search engine doesn't index noscript tag content. See also
http://meta.discourse.org/t/noscript-tag-and-some-search-engines/8078
2013-07-04 22:08:23 +04:00
Sam
ca7c10df9a
Merge pull request #1139 from stephankaag/correct_image_url_rails4
...
No need to include all ActionView::Helpers in Topic
2013-07-03 23:29:43 -07:00
Sam
b662cb6c02
If a user read to the end of an auto closing topic, when it is closes just pretend they read the close message.
2013-07-04 11:47:12 +10:00
Neil Lalonde
2c8ed8414c
If an auto-closing topic is manually closed, remove the auto-close countdown
2013-07-03 16:54:41 -04:00
Stephan Kaag
7cc7116680
No need to include all ActionView::Helpers in Topic, we only need the sanitize helper.
...
This also fixes a bug in Rails 4 where image_url gets accidentally overridden.
2013-07-03 21:43:29 +02:00
Robin Ward
f328804488
Merge branch 'add-list-of-authorized-extensions' of git://github.com/ZogStriP/discourse into ZogStriP-add-list-of-authorized-extensions
...
Conflicts:
app/models/site_setting.rb
2013-07-03 11:18:42 -04:00
Robin Ward
6364fc74ef
Merge branch 'rewrite_update_alls' of git://github.com/stephankaag/discourse-1 into stephankaag-rewrite_update_alls
...
Conflicts:
app/services/spam_rules_enforcer.rb
2013-07-03 11:13:56 -04:00
Robin Ward
05fe33111e
FIX: Moving a post should also update its TopicLink records
2013-07-02 16:42:25 -04:00
Robin Ward
22e6b3f466
FIX: When moving topics to an existing topic, say it's an existing topic in the moderator message.
2013-07-02 15:47:15 -04:00
Stephan Kaag
89b621d31a
Refactor update_all statements in order to prevent deprecation warnings in Rails 4
2013-07-02 18:36:47 +02:00
Robin Ward
5770879472
Refactor: Move Topic Details into better objects, identity map, tests, query string filters
2013-07-02 10:36:46 -04:00
Sam
f6b850e7a4
allow skipping the validations on creation if its an api call AND skip_validations is specified
...
this allows wordpress plugin to post very very short titles or titles that would otherwise be disallowed
2013-07-02 12:23:19 +10:00
Sam
5d4760f91d
ruby 1.9.3 compat ... to_h does not exist there
2013-07-01 12:44:46 +10:00
Régis Hanol
6723ba6014
Add a list of for file uploads
2013-07-01 02:19:03 +02:00
Régis Hanol
4de88814d2
bumped default max upload size to 2048Kb
2013-06-30 11:35:33 +02:00
Sam
7681ba0c32
don't fail this query cause avg_time is 0
2013-06-30 01:30:47 +10:00
Neil Lalonde
a352b70bfc
Permit changing my own username's case without an error saying it is already taken
2013-06-28 16:21:46 -04:00
Sam
6b82f1047a
that date there is on purpose for date boundries
2013-06-28 16:08:48 +10:00
Sam
1ec12fc808
this spec is just refusing to work on jenkins
2013-06-28 16:07:36 +10:00
Sam
3c67cf8acd
remove timecop, specs were failing and we can avoid it here anyway
2013-06-28 15:14:44 +10:00
Sam
966513a66d
my spec suite has been playing up attempting to clean some stuff by avoiding type checks
2013-06-28 12:18:04 +10:00
Sam
4512956c68
don't run the wrong sentinel on message, message is validated in the post, in effect some flags were being rejected incorrectly
2013-06-28 12:14:40 +10:00
Neil Lalonde
8e50b49cf1
Try to fix specs that are failing in jenkins
2013-06-27 17:23:06 -04:00
Neil Lalonde
948fc62b4a
Handle configurable routes for statics in static_controller.js. Make it better when we can use ember's new async routing.
2013-06-27 13:01:12 -04:00
Robin Ward
bf96c8ad01
Support for Custom FAQ content
2013-06-27 12:50:24 -04:00
Sam
9fd00cac65
work in progress, add custom faq link, ember router needs to know about this or the redirect trick will not work
2013-06-27 17:15:59 +10:00
Sam
6145e99baa
navigate to message fixed, changed to button
...
added spec to catch this regression in future
2013-06-27 16:59:07 +10:00
Neil Lalonde
b1d0f30379
Fix AdminUser bulkApprove; add a way to approve a user without sending them the welcome email for cases when must_approve_users is enabled and there are existing users
2013-06-26 13:24:30 -04:00
Robin Ward
89f182899f
Support for custom Privacy Policies
2013-06-26 10:59:36 -04:00
Neil Lalonde
196a8f4ba5
Add dashboard warnings for system_username and notification_email site settings
2013-06-26 10:57:04 -04:00
Sam
039b4758ac
fix 1.9.3 regression, [] does not work on OpenStruct there.
2013-06-26 21:49:29 +10:00
Sam
48d7a33157
Flag UI now displays deleted status for post/topic correctly on old flags
...
Commented out a spec that was failing in order random, with a TODO
2013-06-26 16:18:50 +10:00
Sam
65dc04c00e
simplify flag reporting and correct it so it properly displays old flags
2013-06-26 15:57:55 +10:00
Sam
3af12ba7d3
Merge pull request #1088 from ComputerDruid/fix-ipv6
...
Fix ipv6 addresses in the database
2013-06-25 17:25:48 -07:00
Dan Johnson
9f6b7889a8
views: convert 'ip' (bigint) -> 'ip_address' (inet)
...
This fixes all known issues when connecting to discourse over IPv6.
This table has no primary key, so the migration is done with update_all,
for each ip address in the views table. Since this table can potentially
grow quite large, this process might take a long time. I don't know any
way around this, though.
This migration uses a SQL command to populate the new field from the old
one, so as not to rely on the View model class, which should keep the
migration from failing if that class is modified in the future.
2013-06-25 19:47:25 -04:00
Dan Johnson
2e478d8537
TopicLinkClick: convert 'ip' (bigint) -> 'ip_address' (inet)
...
When accessed over IPv6, the ip address of the user is a 128-bit number,
too big for PostgreSQL's bigint data type. Since PostgresSQL has the
built-in inet type, which handles both IPv4 and IPv6 addresses, we
should use that instead. Where this is done elsewhere in the codebase,
the column is called ip_address, so we should follow that convention as
well.
This migration uses a SQL command to populate the new field from the old
one, so as not to rely on the TopicLinkClick model class, which should
keep the migration from failing if that class is modified in the future.
2013-06-25 19:41:19 -04:00
Neil Lalonde
a86b35c873
Remove the access_password site setting
2013-06-25 15:05:25 -04:00
Jesse House
06be760257
adds TopMenuItem model which encapsulates top_menu parsing logic
2013-06-24 10:04:18 -07:00
Dmitriy Budnik
d12288de49
adding a missing User association
2013-06-24 17:08:49 +03:00
Sam
25bb8cf382
remove dead uncalled code
2013-06-23 15:28:38 +10:00
Sam
ea932b74e7
values is a much more consistent name than all_values ... we use {}.values not {}.all_values
...
also fixes random ordering of tests failure in site settings
2013-06-23 15:07:49 +10:00
Sam
22d6f6784c
Merge pull request #1075 from ZogStriP/fix-lightboxing-when-using-s3
...
FIX: lightbox wasn't working when using s3 upload
2013-06-23 22:11:45 -07:00
Sam
287d0dbd75
bad locale files could lead to broken automatic groups
2013-06-23 14:44:16 +10:00
Sam
298949a343
missing dependency
2013-06-23 14:32:46 +10:00
Sam
fc6983d238
basic requires that 20 topics are entered thanks @novemberkilo
2013-06-23 14:32:37 +10:00
Régis Hanol
08aa23f0ca
FIX: lightbox wasn't working when using s3 upload
2013-06-22 13:38:42 +02:00
Robin Ward
bb908d5913
Email parsing uses Traditional Markdown Linebreaks by default. Added JS tests for line breaks.
2013-06-21 11:37:26 -04:00
Neil Lalonde
bfdbf373f3
Don't show invisible topics in uncategorized on categories page
2013-06-21 11:36:00 -04:00
Robin Ward
455742d3ee
Merge pull request #1062 from ComputerDruid/fix-which-s
...
Use "command -v" to test for convert instead of "which -s"
2013-06-21 07:12:42 -07:00
Robin Ward
8dceb655db
Merge pull request #1058 from ZogStriP/delete-optimized-images-when-cleaning-up-orphans
...
make sure we also delete optimized images
2013-06-21 07:10:28 -07:00
Régis Hanol
8a751e6e44
make sure we also delete optimized images
2013-06-21 09:34:02 +02:00
Amos L King
777e8c2012
Correct spelling of suppress
...
supress => suppress
Amos King @adkron <amos.l.king@gmail.com>
2013-06-20 23:44:27 -05:00
Dan Johnson
8009b3f036
Use "command -v" to test for convert instead of "which -s"
2013-06-20 21:42:18 -04:00
Neil Lalonde
f39f44ddbf
Categories page should not show invisible topics
2013-06-20 16:07:53 -04:00
Robin Ward
4aa20cf23c
Merge pull request #1053 from vipulnsward/remove_var
...
Remove unused var.
2013-06-20 09:54:34 -07:00
Vipul A M
5e5ef9cafd
Remove unused var.
2013-06-20 20:58:05 +05:30
Robin Ward
9f3d5b9f1e
Merge pull request #1044 from ZogStriP/clean-orphan-uploaded-files
...
added a rake task to clean orphan uploaded files
2013-06-20 07:53:50 -07:00
Robin Ward
2e7c5a674c
Merge pull request #1049 from ZogStriP/admin-alerts
...
Admin alerts
2013-06-20 07:51:40 -07:00
Sam
70683c1f09
Merge pull request #1034 from chrishunt/rebake-oneboxes
...
Optionally rebake oneboxes with posts:rebake task
2013-06-20 01:18:57 -07:00
Sam
08df4c41cc
Merge branch 'master' of github.com:discourse/discourse
2013-06-20 17:42:29 +10:00
Sam
4a8a663a67
flagging workflow changes per http://meta.discourse.org/t/we-need-an-archive-flag-notification-button/7450
2013-06-20 17:42:15 +10:00
Régis Hanol
8a26b86739
added image magick alert
2013-06-19 22:36:56 +02:00
Régis Hanol
9036738ba2
added s3 file uploads alert
2013-06-19 22:11:11 +02:00
Régis Hanol
4a17d6dca6
added a rake task to clean orphan uploaded files
2013-06-19 21:51:41 +02:00
Robin Ward
5ef6714d48
New site setting: minimum_topics_similar
, allows you to specify a minimum amount
...
of topics that need to be in the database before it will suggest similar topics as
a user creates a post.
2013-06-19 13:14:24 -04:00
Chris Hunt
ef76e18215
Optionally invalidate onebox in PostAnalyzer#cook
2013-06-19 00:19:42 -07:00
Sam
799b402778
fix horribly broken invite code, could lead to inviting the wrong person to a conversation
2013-06-19 10:31:19 +10:00
Sam
6989851cd4
Merge pull request #1038 from ZogStriP/keep-uploads-reverse-index-up-to-date
...
Keep uploads reverse index up to date
2013-06-18 00:43:31 -07:00
Sam
80c42753e1
fix up find as you type for the invite into PM function
...
allow mods to remove users from a PM
2013-06-18 17:17:01 +10:00
Sam
7abb20928b
Merge pull request #1033 from chrishunt/move-dynamic-favicon-to-user
...
Move 'dynamic favicon' setting to User preference
2013-06-17 17:31:02 -07:00
Robin Ward
8acdc18bc8
First stab at polling support for POP3S / reply by email
2013-06-17 16:49:02 -04:00
Régis Hanol
ae3543872c
renamed the sha
column to the proper sha1
2013-06-17 22:16:14 +02:00
Neil Lalonde
281a08a99f
Allow people to capitalize a word when ninja-editing a post
2013-06-17 15:57:13 -04:00
Robin Ward
3c7eb3a4e8
FIX: null dates crashed the client app. last_posted_at
was not updating properly on split topic.
2013-06-17 13:02:50 -04:00
Régis Hanol
af45b5a11e
proper column naming
...
silly schemaless database habits are hard to kill
2013-06-17 04:02:17 +02:00
Régis Hanol
454636abf1
annotate models
2013-06-17 02:49:34 +02:00
Régis Hanol
510bac4b27
refactored a bit & tested thumbnails creation
2013-06-17 02:49:34 +02:00
Régis Hanol
cc9e0ec80a
create thumbnails when needed
2013-06-17 02:49:34 +02:00
Régis Hanol
d4c3fe4e6a
added create_thumbnails?
site setting
...
defaults to `false`
2013-06-17 02:49:34 +02:00
Régis Hanol
5de03814fb
created optimized_image
model
2013-06-17 02:49:34 +02:00
Régis Hanol
2c3f757951
moved has_been_uploaded
and uploaded_regex
to the Upload
model
2013-06-17 02:49:34 +02:00
Régis Hanol
8a98310cf9
make sure we only do the work once
2013-06-17 02:49:34 +02:00
Régis Hanol
6c4554b941
identifies all uploads with the SHA1 hash of the file content
2013-06-17 02:49:33 +02:00
Régis Hanol
6ea91b4416
remove useless upload topic direct association
2013-06-17 02:49:33 +02:00
Sam
b545a49d32
Merge pull request #1025 from ZogStriP/reverse-index-take-2
...
Reverse index take 2
2013-06-16 16:49:57 -07:00
Chris Hunt
09d3800701
Move 'dynamic favicon' from Server to User pref
2013-06-14 23:58:24 -07:00
Neil Lalonde
f62c421c91
Render category descriptions differently on the categories page
2013-06-14 11:18:44 -04:00
Régis Hanol
037f62928b
add proper post_uploads reverse index
2013-06-13 23:44:24 +02:00
Neil Lalonde
4db8204a15
Remove topic links when a post is deleted
2013-06-13 13:41:54 -04:00
Robin Ward
49c09898e2
The EmailBuilder now creates the Reply by Email Key if necessary.
2013-06-13 12:40:06 -04:00
Robin Ward
e29f4a3496
Work in Progress: Reply By Email:
...
- Add support classes and settings to enable reply by email
- Split out Email builder to be more OO, add many specs
2013-06-13 12:39:56 -04:00
Neil Lalonde
ef18a3ad5c
Locales should be sorted in dropdown
2013-06-13 12:18:11 -04:00
Robin Ward
cb40ceb9e8
Merge pull request #1019 from ZogStriP/reverse-index-of-user-uploads
...
added a reverse index of user uploads + rake task
2013-06-13 07:20:55 -07:00
Sam
f7de9f17d5
refactor validators
...
add a new setting for min pm body length
use that setting for flags
scale entropy check down for pms
2013-06-13 18:18:43 +10:00
Sam
e6e81efe85
correct information leak in page not found
2013-06-13 10:27:17 +10:00
Régis Hanol
770c1faeb1
added a reverse index of user uploads + rake task
2013-06-13 01:43:50 +02:00
Robin Ward
77b218a142
FIX: Do not suggest similar topics from secure categories you can't see.
2013-06-12 13:45:11 -04:00
Neil Lalonde
28ac110a3c
Add eu-west-1 to s3 regions
2013-06-12 12:02:47 -04:00
Sam
c1f6169b48
hidden and deleted state in user stream
2013-06-12 11:14:08 +10:00
Régis Hanol
8a2d635e62
removed imgur support
2013-06-11 21:51:41 +02:00
Neil Lalonde
811a0df68b
Make s3 region site setting a drop down
2013-06-11 14:24:04 -04:00
Neil Lalonde
5ff7e570ac
Add support for enum site settings that render as a dropdown; use a dropdown for default_locale
2013-06-11 11:40:14 -04:00
Jeff Atwood
b4a4774165
extend consumer email warning to yahoo & outlook
2013-06-10 00:08:06 -07:00
Vipul A M
4f606ffd8e
Some minor cleanups
...
1. Change map to keys
2. Remove overshadow
3. Remove var
2013-06-10 10:38:10 +05:30
Sam
6a6496eedf
Merge pull request #995 from novemberkilo/master
...
Refactoring Post model
2013-06-09 16:19:06 -07:00
Sam
2d14b54096
Merge pull request #988 from chrishunt/add-dynamic-favicon
...
Add 'dynamic favicon' setting
2013-06-09 16:13:54 -07:00
Navin
3fdba0019b
Extract callbacks and validations for Post
...
Move Post create callbacks to PostCreate
Extract Post validations
Move stripped_length_validator to lib/validators
2013-06-09 20:47:04 +02:00
Sam
1756f713d6
SECURITY HOLE, upgrade right away if you are using Secure Groups.
2013-06-08 23:52:06 +10:00
Chris Hunt
af1c14939e
Add 'dynamic favicon' setting
2013-06-07 17:15:49 -07:00
Robin Ward
463be6fadf
Merge pull request #982 from jd-erreape/add_scopes_to_roleable
...
Added role scopes to roleable
2013-06-07 12:08:26 -07:00
Neil Lalonde
169125e96d
Fix a case where a random topic with null slug will be rendered instead of 404
2013-06-07 14:30:26 -04:00
Juan de Dios Herrero
36fe8fbc6d
Added role scopes to roleable
2013-06-07 18:26:06 +02:00
Juan de Dios Herrero
1b92d9d7f8
Added roleable module for User model
2013-06-07 12:33:48 +02:00
Chris Hunt
f6ce985121
Send activation email after user approved
2013-06-06 18:37:25 -07:00
Sam
1eed1e240b
Merge pull request #977 from chrishunt/add-apple-touch-icon
...
Add 'apple touch icon url' site setting
2013-06-06 17:40:12 -07:00
Chris Hunt
268a5debbf
Add 'apple touch icon url' site setting
2013-06-06 14:43:05 -07:00
Neil Lalonde
a151bfc7ec
Store when a topic was first set to auto-close and report that amount of time when it closes. And do some refactoring.
2013-06-06 17:04:21 -04:00
Robin Ward
f268b882fd
The posts rebake task should regenerate links too.
2013-06-06 13:52:30 -04:00
Robin Ward
bac03a3369
Merge pull request #975 from jd-erreape/username_refactor
...
[WIP] Refactored user_name suggestion methods into a module
2013-06-06 08:12:29 -07:00
Juan de Dios Herrero
96d23ddd8d
Refactored user_name suggestion methods into a module to reduce the complexity of User model
2013-06-06 16:40:10 +02:00
Ian Christian Myers
0d01c33482
Enabled strong_parameters across all models/controllers.
...
All models are now using ActiveModel::ForbiddenAttributesProtection, which shifts the responsibility for parameter whitelisting for mass-assignments from the model to the controller. attr_accessible has been disabled and removed as this functionality replaces that.
The require_parameters method in the ApplicationController has been removed in favor of strong_parameters' #require method.
It is important to note that there is still some refactoring required to get all parameters to pass through #require and #permit so that we can guarantee that parameter values are scalar. Currently strong_parameters, in most cases, is only being utilized to require parameters and to whitelist the few places that do mass-assignments.
2013-06-06 00:30:59 -07:00
Sam
2ca734c118
Merge pull request #964 from chrishunt/exclusive-club
...
Add 'invite only' site setting
2013-06-05 16:38:47 -07:00
Robin Ward
0b97ea6345
Better HTML emails, smarter email digests, new email section in admin with digest preview
2013-06-05 17:47:25 -04:00
Neil Lalonde
f030d9b420
Make default_logo_check more smarter
2013-06-05 16:59:19 -04:00
Neil Lalonde
4e8ff74b99
Show dashboard warning when favicon and/or logo urls contain the same filename as the shipped defaults
2013-06-05 16:43:39 -04:00
Neil Lalonde
b55182b983
Use PostDestroyer when deleting all of a user's posts; deleting a post removes its flags and resets its flag counts
2013-06-05 16:05:13 -04:00
Robin Ward
dfba2b6e0a
FIX: Strip links from google indexed bios when the users are new.
2013-06-05 15:28:10 -04:00
Chris Hunt
24da1ab07e
Add 'invite only' site setting
2013-06-05 11:06:05 -07:00
Ian Christian Myers
41528f5d11
Implemented strong_parameters for Upload/UploadsController.
...
The topic_id param is now required using strong_parameters' #require method. If the parameter is missing ActionController::ParameterMissing will be raised instead of Discourse::InvalidParameters.
2013-06-05 00:55:55 -07:00
Ian Christian Myers
f50b648844
Implemented strong_parameters for PostAction/PostActionsController.
...
PostActionsController now uses strong_parameters' #require to require certain parameters. ActionController::ParameterMissing is now thrown when a reqired parameter is missing, rather than Discourse::InvalidParameters.
2013-06-05 00:23:51 -07:00
Ian Christian Myers
3b245031a4
Implemented strong_parameters for Invite/InvitesController.
...
The email parameter is now required using strong parameters and will throw ActionController::ParameterMissing if it is missing. If the email address is incorrect or invalid, Discourse::InvalidParameters will still be thrown.
2013-06-05 00:04:03 -07:00
Ian Christian Myers
130d837952
Implemented strong_parameters for Category/CategoriesController.
...
Category now requires parameters to be permitted by strong_parameters using #require or #permit for mass-assignment. Missing required parameters now throw a ActionController::ParameterMissing execption instead of the Discourse::InvalidParameters execption.
2013-06-04 23:45:25 -07:00
Sam
870e59883b
secure the links on the topic pages, eliminated deleted topics as well.
2013-06-05 16:10:26 +10:00
Sam
2509d0f4fa
Merge pull request #959 from chrishunt/chrishunt/login-required-fixes
...
'login required' site setting improvements
2013-06-04 19:09:40 -07:00
Chris Hunt
3074300f76
Allow customization of 'login required' message
2013-06-04 18:53:36 -07:00
Sam
9a57aaaaa9
fix encoding for category excerpt
...
fix missing secure category topics in categories page
2013-06-05 11:22:47 +10:00
Sam
21b3359ea4
Merge pull request #957 from chrishunt/chrishunt/lock-down-the-base
...
Add 'login required' site setting
2013-06-04 17:22:08 -07:00
Chris Hunt
85ceb5efa7
Add 'login required' site setting
2013-06-04 16:10:10 -07:00
Régis Hanol
e3e55d4dad
fix image uploads on s3/imgur
2013-06-05 00:35:42 +02:00
Neil Lalonde
2465c9c724
Add min_private_message_title_length site setting so private messages can have short titles
2013-06-04 17:59:23 -04:00
Robin Ward
4392a17b54
Strip out links when displaying a new user's bio
2013-06-04 12:06:25 -04:00
Neil Lalonde
2259e97d42
Add a count of blocked users on the dashboard
2013-06-04 11:53:19 -04:00
Neil Lalonde
c4904aacc0
Automatically flag someone as a spammer if their posts get at least X spam flags from N users while their trust level is 'new user'. Staff can clear and set this status from the user record in admin.
2013-06-03 16:37:40 -04:00
Robin Ward
33d0a6a876
FIX: Safety checks for categories index
2013-06-02 11:20:08 -04:00
Navin
cab3502c15
Replace PostAnalyser module with a class
...
Encapsulate Post#cooked_document as well
Include specs for PostAnalyzer class
2013-06-01 14:59:27 +02:00
Robin Ward
545dbfc07e
New Feature: Staff can choose to "Take Action" when flagging to immediately reach hiding
...
thresholds.
2013-05-31 17:39:32 -04:00
Robin Ward
d23ef1d090
FIX: You could update a topic to have a title that's too short if the TextCleaner
...
removed extra characters. Additionally, updating the title will not return an error
message to the client app if the operation fails (rather than failing silently.)
2013-05-31 15:24:13 -04:00
Robin Ward
0af0a214b2
Refactor: Back all modals by controllers
2013-05-31 12:29:38 -04:00
Robin Ward
830b7805e9
Merge pull request #927 from bplexico/extract_invite_redeemer
...
Extract InviteRedeemer from Invite
2013-05-31 08:30:42 -07:00
Sam
d2c1eb090e
Merge pull request #921 from nirnanaaa/postgres-truefalse
...
removed t's and f's from models
2013-05-30 21:38:26 -07:00
Sam
41187a5de1
Merge pull request #931 from ZogStriP/more-file-upload-test-coverage
...
added more file uploads test for better coverage
2013-05-30 21:36:33 -07:00
Régis Hanol
6cc0f8f2d4
added more file uploads test for better coverage
2013-05-31 03:13:37 +02:00
Juan de Dios Herrero
807f763fb0
Merge remote-tracking branch 'upstream/master'
2013-05-30 21:42:26 +02:00
DI2uNk
24e32092e7
Refactored two class methods into scopes (to achieve a better 'rails way')
...
Also added some tests to the methods
2013-05-30 21:21:31 +02:00
Neil Lalonde
b82a5dfd56
Move logic to reject slugs that are just numbers into the slug module
2013-05-30 11:54:02 -04:00
Brian Plexico
0591d5be11
Extract InviteRedeemer from Invite
2013-05-30 11:49:11 -04:00
Neil Lalonde
7d5c313456
Don't allow category slugs that are numbers
2013-05-30 11:09:09 -04:00
Sam
6ad86aa305
read state is now published
2013-05-30 16:49:58 +10:00
Sam
e93b7a3b20
more progress towards live unread and new counts, unread message implemented, still to implement delete messages
2013-05-30 16:49:57 +10:00
Sam
73834370a5
work in progress, live unread and new counts
2013-05-30 16:49:57 +10:00
Sam
33ff87bf44
work in progress, live unread / new counters
2013-05-30 16:49:57 +10:00
Robin Ward
830b93a16b
Reduced complexity of admin flags controller, split up into methods, moved reports into model.
2013-05-29 16:49:34 -04:00
nirnanaaa
364113a4d5
removed t and f 's from group model
...
removed t and f 's from user model as mentioned in #919
removed t's and f's from category model
2013-05-29 22:10:43 +02:00
Neil Lalonde
6abd9ddd2d
Add warning on admin dashboard if production env is configured to send email through gmail
2013-05-29 14:00:35 -04:00
Robin Ward
92dc59fba9
Properly assign draft keys to Categories List view.
2013-05-28 21:16:24 -04:00
Sam
46389754d6
Merge pull request #892 from eriko/cas_support
...
Cas support
2013-05-28 16:13:29 -07:00
Robin Ward
ee319ea7f7
FIX: Issues that didn't show up originally
2013-05-28 15:57:11 -04:00
Robin Ward
560fb15d8a
Include pinned topics in category list.
...
- removes an (n+1) query for user data
- supports the preload store for the data to avoid a second request
- fix a bug where uncategorizes was reporting (0, 0, 0) for topics by week, month, year
2013-05-28 15:36:16 -04:00
Robin Ward
320b35bf90
Merge pull request #910 from novemberkilo/master
...
WIP - Reduce complexity of Post#raw_links
2013-05-28 10:07:41 -07:00
Chris Hunt
21a54567ff
Extract TopicStatusUpdate from Topic
2013-05-28 09:01:04 -07:00
Erik Ordway
9a409d9440
fix comment and remove url setting as it is not used.
2013-05-28 08:06:18 -07:00
Navin
1d5952a92f
Extract analysis type methods to a module and refactor Post#raw_links
2013-05-28 16:41:18 +02:00
Chris Hunt
54a798eb12
Add Topic#age_in_days for determining age of topic
2013-05-27 18:02:15 -07:00
Sam
d2f2a8e218
refactoring
2013-05-28 09:13:53 +10:00
Robin Ward
62a20f5655
FIX: Couldn't access "Uncategorized" category from category list.
2013-05-27 14:15:52 -04:00
Neil Lalonde
b1ef2ea1e1
Fix TopicPostersSummary when a suggested topic includes a user who has been deleted
2013-05-27 14:12:15 -04:00
Robin Ward
197909246c
Weigh staff likes higher when calculating scores. New site setting: staff_like_weight
...
can set the factor (default is 3)
2013-05-27 12:46:08 -04:00
Robin Ward
e1781240a6
Merge branch 'refactoring' of git://github.com/mattvanhorn/discourse
...
Conflicts:
lib/text_sentinel.rb
2013-05-27 10:42:20 -04:00
Robin Ward
a15910ad1e
Merge pull request #899 from chrishunt/chrishunt/extract-topic-posters-summary
...
Extract topic posters summary
2013-05-27 06:30:58 -07:00
Sam
bf16b4f381
Merge pull request #903 from chrishunt/chrishunt/extract-post-move
...
Extract post move
2013-05-26 19:10:50 -07:00
Chris Hunt
6024529f81
Extract PostMover from Topic into its own class
2013-05-26 18:42:04 -07:00
Sam
d84ae80074
Simplify user action make it more idiomatic
2013-05-27 10:22:37 +10:00
Janis Miezitis
f58bcf7fe3
Refactored duplication in user action
2013-05-26 16:07:20 +03:00
Chris Hunt
b8fbac582e
Add Topic#url for determining url for a Topic
2013-05-25 17:44:32 -07:00
Chris Hunt
f2b5e20840
Add Topic#max_post_number to find max post number
2013-05-25 17:44:32 -07:00
Chris Hunt
c4cce68613
Add Post#is_first_post?
...
We should be able to ask a post if it's the first in a topic
2013-05-25 17:44:32 -07:00
Chris Hunt
63c63c2939
Remove unused parameters from posters_summary
2013-05-24 15:33:50 -07:00
Chris Hunt
c1841a6c89
Extract Topic#posters_summary
2013-05-24 15:33:45 -07:00
Robin Ward
e2774cc2df
Merge pull request #896 from xtream/master
...
Removed unnecesary method
2013-05-24 14:09:44 -07:00
Neil Lalonde
d26b87bd3c
Add Site Setting allow_uncategorized_topics. Uncheck it to force people to choose a category for all new topics.
2013-05-24 16:56:43 -04:00
Matt Van Horn
e5e904aa4e
minor refactorings
2013-05-24 13:36:33 -07:00
Matt Van Horn
d7817cf314
extract TopicNotifier class from topic
2013-05-24 13:36:33 -07:00
Robin Ward
d1fdc66ca4
FIX: For spam detection, don't count total occurances of links of the same host, but
...
post count including that host.
2013-05-24 15:20:58 -04:00
Victor Cruz Dueñas
bca006feca
removed unnecesary method
2013-05-24 18:03:02 +02:00
Robin Ward
c0c97487d8
Merge pull request #888 from novemberkilo/master
...
Refactor to reduce complexity of Post#save_reply_relationships
2013-05-24 07:04:28 -07:00
Sam
ca2dee52db
moved comments to the bottom, they are way less intrusive there
2013-05-24 12:48:32 +10:00
Sam
2cd95bc649
lets try out annotations
2013-05-24 12:35:14 +10:00
Sam
fc3c93d237
almost fixed the regression of not allowing top level filters
2013-05-24 09:54:39 +10:00
Erik Ordway
0bdee973a0
allow disabling of local logins. In the instance where an .edu is using cas they may not want a user to be able to log in once the users credentials have been revoked in the system that feeds the CAS authentication server. This is very optional
2013-05-23 13:44:14 -07:00
Erik Ordway
1575ce7b10
add cas support with a few tests
2013-05-23 13:40:50 -07:00
Navin
9aacde2f2d
Refactor Post#save_reply_relationships
2013-05-23 18:09:06 +02:00
Navin
ba4eaa0297
Helper to create reply relationship with post
2013-05-23 18:08:24 +02:00
Navin
d7219a6fbc
Helper to add a number to quoted_post_numbers
2013-05-23 18:07:45 +02:00
Neil Lalonde
4492d06a9f
Don't send notifications for moderator action posts
2013-05-23 11:42:52 -04:00
Robin Ward
0bd61df34c
Merge pull request #884 from mattvanhorn/refactor_topic
...
Refactor topic
2013-05-23 07:26:22 -07:00
Matt Van Horn
c4b5821ef8
Revert annotation and non-English I18n changes
2013-05-23 06:44:47 -07:00
Sam
3dfc034e8d
Merge pull request #881 from novemberkilo/master
...
Improve flog metric for Post#extract_quoted_post_numbers
2013-05-23 00:21:27 -07:00
Matt Van Horn
7271b90655
annotate topic model
2013-05-22 22:36:01 -07:00
Matt Van Horn
806255b3c4
refactor Topic validation
...
introduce a couple of custom validators
fix minor discrepancies in tests
copy I18n error message keys to default location
clean up validation invocation
move some responsibilities out of validator into class
2013-05-22 22:31:52 -07:00
Sam
fcc7192fd2
User tracking state implementation progress for live unread / new counts
2013-05-23 15:22:06 +10:00
Robin Ward
7a31630837
Search Refactor: Remove some manual SQL, make search data tables more idomatic Rails/AR
2013-05-22 16:31:13 -04:00
Navin
4754216369
Simplify branching
2013-05-22 21:45:31 +02:00
Navin
ef93512de8
Extract quote parsing into a method
2013-05-22 21:38:45 +02:00
Matt Van Horn
872995db57
refactor guardian class for clarity & correctness
...
introduce NullUser to avoid type-checking
DRY up code
reduce number of multiple returns
remove some redundant/impossible logic branches
add pending test for possible bug
add test & fix for ability to flag archived posts
add #secure_category? method to topic class
Fix bug that prevented flagging of archived topics
Rename NullUser to AnonymousUser
DRY up can_<action>? methods
Fix some ownership logic, and a test, for Guardian
2013-05-22 01:09:34 -07:00
Chris Hunt
d0bc8c95d3
Trigger UserActionObserver when tracking visit
2013-05-21 20:45:03 -07:00
Chris Hunt
685f4960f1
Trigger UserActionObserver when updating TopicUser
2013-05-21 20:43:43 -07:00
Robin Ward
27828c5ec2
Merge pull request #871 from avdi/refactoring-with-josh-and-avdi
...
Various refactorings towards Ruby/Rails idiom from Josh Susser and Avdi Grimm
2013-05-21 07:18:50 -07:00
Sam
b5eff93a9d
update message bus to support per client filtering
...
start work on user_tracking_state
fix can_ban? in guardian
expose protected scopes on topic_query we need
move guardian spec to use build as opposed to creating topics / posts / users
start work on user tracking spec
2013-05-21 16:39:51 +10:00
Sam
e91ed83586
the private message stream is different to normal streams, improving the ui a bit and collapsing conversations
2013-05-20 16:44:06 +10:00
Sam
18b00d01d0
Merge pull request #859 from lengarvey/user_refactoring
...
Light refactoring of the User model
2013-05-19 16:41:20 -07:00
Neil Lalonde
5f7f87437c
Fix for topic excerpt being from the wrong post
2013-05-18 13:35:21 -04:00
Leonard Garvey
b16705be0d
Clean up update_visit_record!
...
update_visit_record! appears to add user_visit record if one
doesn't exist and days_visited is simply a counter for the number
of visit records.
2013-05-18 16:02:06 +10:00
Leonard Garvey
32f4dfd2fb
DRY up the user model slightly
...
regular? is just the inverse of staff?
2013-05-18 16:00:35 +10:00
Sam
25105082d5
Merge pull request #850 from bplexico/refactor_post_rb
...
Refactored post model to reduce duplication in validator methods
2013-05-17 15:56:53 -07:00
Josh Susser and Avdi Grimm
2acc80d192
Various idiomatic User refactorings.
2013-05-17 15:44:35 -04:00
Josh Susser and Avdi Grimm
5659b66729
Refactor select().map() to use pluck.
...
Remove a method already provided by ActiveRecord.
2013-05-17 15:11:37 -04:00
Neil Lalonde
191d454589
Show Inbox before Sent Items
2013-05-17 14:11:33 -04:00
Josh Susser and Avdi Grimm
d30330441a
Refactored conditional to an || to be more idiomatic.
2013-05-17 14:06:58 -04:00
Brian Plexico
a86646312b
Refactored post model to reduce duplication in validator methods
2013-05-17 12:15:21 -04:00
Neil Lalonde
f3282e33a3
Add tabs to category create/edit modal. Categories can have a default auto-close setting that applies to all new topics created in the category. Add rspec-given and write some integration tests. Tests for topic auto-close with category default
2013-05-17 11:05:35 -04:00
Sam
8f46653345
refactor
2013-05-17 09:03:52 +10:00
Robin Ward
d554a59102
Support for a new site setting: newuser_spam_host_threshold
. If a new user posts a link
...
to the same host enough tiles, they will not be able to post the same link again.
Additionally, the site will flag all their previous posts with links as spam and they will
be instantly hidden via the auto hide workflow.
2013-05-16 12:19:50 -04:00
Sam
04b8cd5c95
consistency check, need to also ensure delete cleans stuff up, maybe make notifications trashable
2013-05-16 17:50:14 +10:00
Sam
eb71e9de24
opening move, don't get rid of green notification till the pm is read
...
TODO a way to list all unread PMs
2013-05-16 16:37:47 +10:00
Sam
e9ebadb414
Nuke message_bus_observer move to service class and classes
...
Secure all messages triggered by post creation and all user actions so they don't leak
(meaning, if you have a browser open and secure topics are created you will only get them if you are allowed to see them)
2013-05-16 15:03:16 +10:00
Lee Machin
dadb7eaa23
fix crash caused by incorrect query in scope
...
setting all categories to be secured led to a blank screen on all pages
use stabby lambda for consistency in class
make the test a little more concise
- move the local assignments into let blocks for
reusability
- remove calls to `to_a`, which aren't needed
- use 'be_empty' instead of '[]' to be consistent
with the other matchers in the test
add a test for the `secured` scope with multiple
secured categories
2013-05-15 22:26:52 +01:00
Neil Lalonde
18634ad00d
Don't cache the problems list with the rest of the dashboard data
2013-05-15 11:09:12 -04:00
Neil Lalonde
21b4b8d5d5
Expire dashboard data when you upgrade to a new discourse version. Version check data was being cached and causing confusion to people who upgraded.
2013-05-14 16:17:25 -04:00
Robin Ward
be234ce9b9
You can now 'move' the first post of a topic to another topic as a merge. In that
...
case, the first post is cloned instead of being deleted from the original topic.
2013-05-13 14:07:31 -04:00
Neil Lalonde
9828c87525
Topic Auto-Close: admins and mods can set a topic to automatically close after a number of days
2013-05-13 12:53:52 -04:00
Sam
670b66ade3
better add some tests here tomorrow
2013-05-13 18:47:32 +10:00
Sam
b6bf95e741
speed up startup (avoid loading some gems on startup)
...
correct group permission leaks
add Discourse.cache for richer caching support
2013-05-13 18:04:03 +10:00
Sam
9b33e826f2
clear flags on reply to notify moderators
2013-05-13 11:48:01 +10:00
Robin Ward
cf01c98d81
Experimental: Interface to Move Posts to an Existing Topic
2013-05-10 14:55:51 -04:00
Sam
942f168ab6
UI still a tad rough, but we have a first pass of secure categories
2013-05-10 16:47:47 +10:00
Sam
5280b3a01b
more group progress, UI getting there, controller mostly done
...
changed it so notify moderators goes to the moderators group
allow admins to grant self moderation and revoke self moderation
2013-05-09 17:37:34 +10:00
Sam
4f328e3e45
+x on files makes no sense unless they really are executable
...
rails in the script dir makes no sense, use binstubs or bundler instead
2013-05-09 17:35:15 +10:00
Sam
0f0fd281a8
group progress, never email banned users
2013-05-09 11:34:58 +10:00
Neil Lalonde
f35a44aeae
Add ability for admins and mods to send another activation email to a user, to activate an account, and deactivate an account
2013-05-08 10:10:47 -04:00
Sam
6b536dcde5
work in progress ... groups
2013-05-08 15:20:38 +10:00
Sam
7571152d1d
fix issue adding users to groups
2013-05-08 10:32:29 +10:00
Neil Lalonde
52ee1928cc
Oops, I made a spec fail by refactoring after I made the test pass and didn't check the tests
2013-05-07 15:40:18 -04:00
Neil Lalonde
8e24a608b0
Show empty categories on categories page to people people who can edit and delete categories
2013-05-07 15:31:56 -04:00
Sam
e9fc272db7
remove acts_as_paranoid, use .trash! , .recover! and .with_deleted as needed
...
makes upgrading to rails 4 possible
2013-05-07 14:39:01 +10:00
Neil Lalonde
69be7d0ad1
Change the title Visits to Clicks in referral tables on admin dashboard
2013-05-06 11:56:35 -04:00
Neil Lalonde
b944157d88
Fix edit uncategorized when on the /category/uncategorized page
2013-05-06 11:22:58 -04:00
Sam
be1ab8b275
automatic group infrustructure
2013-05-06 14:49:56 +10:00
Régis Hanol
392b9696f4
prevent duplicate actions on a post
2013-05-04 02:52:45 +02:00
Neil Lalonde
52942d2de6
Merge pull request #813 from slainer68/ga_domain_name
...
Google Analytics Domain name site setting
2013-05-03 14:57:01 -07:00
Neil Lalonde
c6370a3479
Add ability to edit the uncategorized category name, color, and text_color in a modal
2013-05-03 17:55:04 -04:00
slainer68
ac66f25043
Google Analytics Domain name site setting
2013-05-03 21:58:10 +02:00
Sam
5ec52bd2e9
:s/moderator?/staff/g ... our naming was kind of crazy, renamed moderator? to staff
2013-05-02 17:22:27 +10:00
Sam
65cd00cf25
moderators now have teeth, more at http://meta.discourse.org/t/moderator-permission-set/6307/5
...
allow pms to be targetted at groups
2013-05-02 15:15:53 +10:00
Sam
e59ab32210
Merge pull request #800 from goodbrews/imgur-api-v3
...
Update to Imgur API v3
2013-05-01 21:52:00 -07:00
David Celis
6be26f5316
Update to Imgur API v3
...
Version 2 of Imgur's API is deprecated. Their documentation for v2 is no
longer online, and applications can only be registered under version 3.
Version 3 of their API has a slightly different endpoint but, more
importantly, uses a Client ID/Secret pair instead of an API Key.
This PR updates Discourse to use the new version of Imgur's API.
Signed-off-by: David Celis <me@davidcel.is>
2013-05-01 21:39:10 -07:00
Neil Lalonde
3c7afeb233
Fix incoming links dashboard data when topic record can't be found
2013-05-01 19:10:31 -04:00
Neil Lalonde
38ed86d0c5
Add reports for IncomingLinks on admin dashboard
2013-05-01 18:12:02 -04:00
Sam
e4a76812a6
this is a slightly round about way of making our self oneboxes sane
...
shrunk avatar to 60px, added global whitelisting
2013-05-01 16:38:13 +10:00
Sam
08ce46e7ed
:s/POST/REPLY/g
2013-05-01 10:52:31 +10:00
Jeff Atwood
51f16333be
increase default max_likes to 50
...
WE LIKE LIKES MAN
2013-04-30 12:45:27 -07:00
Neil Lalonde
20d73a4151
Fix bookmarks admin dashboard counts to include bookmarks that were deleted
2013-04-30 12:52:12 -04:00
Sam
b25a5a20bb
option to strip links from excerpts
2013-04-30 13:25:55 +10:00
Neil Lalonde
dc07563c0d
Add unstarred_at column to topic_users so we can permanently track when topics are starred
2013-04-29 11:39:05 -04:00
Sam
5cfcdc7ef0
backend for secure categories mostly done (todo pm groups)
2013-04-29 16:33:43 +10:00
Régis Hanol
dca2fbcefc
add meaningful error message on upload [ fixes #773 ]
2013-04-27 20:26:17 +02:00
Neil Lalonde
bbf982984d
Add TOS and Privacy Policy site settings that can link to external sites.
2013-04-26 18:46:36 -04:00
Sam
f9e33ec6b8
store ip address and current user with incoming links
...
make links long an readable in share dialog
2013-04-26 16:18:55 +10:00
Sam
f0d3500ada
Merge pull request #735 from kubabrecka/i18n_user_actions4
...
move i18n of UserActions to JS-side and make sentences translatable (take 3)
2013-04-25 15:53:17 -07:00
Neil Lalonde
159c9b10d5
Add a nag to admin dashboard if you haven't changed the title site setting from the default 'Discourse'
2013-04-25 17:53:31 -04:00
Neil Lalonde
db2de1eff0
Add contact_email to site settings
2013-04-24 11:15:47 -04:00
Sam
37867af1bb
track incoming links, amend share link to include user
...
fix pm styling
2013-04-24 18:05:35 +10:00
Sam
4d9dc82be0
bug fix
2013-04-24 14:39:31 +10:00
Sam
81673dcde8
slug memoization in the table
2013-04-24 12:46:43 +10:00
Neil Lalonde
72508d459b
Use heat map on views column in topic lists
2013-04-23 15:06:13 -04:00
Neil Lalonde
7257d65082
Add warning to dashboard if using default logo or favicon
2013-04-22 15:38:48 -04:00
Neil Lalonde
439877bdb9
Show a warning if there are email jobs in the retry queue
2013-04-22 13:37:16 -04:00
Neil Lalonde
ae487e740c
Add a dashboard warning when sidekiq queue has more than 100 jobs
2013-04-22 13:02:24 -04:00
Sam
cfc62dadff
speed up tests
...
add the ability to find the first notify private message
2013-04-22 17:45:03 +10:00
Sam
8827dd3e42
speed up tests
2013-04-22 13:48:41 +10:00
Shane Liesegang
42fdbe2fb6
Fixing Amazon uploads to not be hardcoded to https
...
Amazon S3 uploads are currently hardcoded to use https, where they should probably use whatever protocol the rest of the site is using. Removing the protocol and just using "//" links should accomplish that.
2013-04-19 22:05:51 -03:00
Jeff Atwood
b644509c28
reduce auto track default from 5m to 4m
2013-04-19 15:11:38 -07:00
Jeff Atwood
6948d2cbf3
increase email notify delay to 10 mins
2013-04-19 14:59:11 -07:00
Sam
4cea92c4e9
work in progress add support for groups
2013-04-19 10:34:39 +10:00
Neil Lalonde
5cd6c85e8b
Add bookmarks and favorites to dashboard stats
2013-04-18 14:27:22 -04:00
Neil Lalonde
75cfcbfa4f
Need to require email in user.rb because specs can start failing when running guard
2013-04-18 14:27:04 -04:00
Kuba Brecka
d355e42d73
move i18n of UserActions to JS-side and make sentences translatable (take 3)
2013-04-18 12:08:13 +02:00
Jeff Atwood
b64a4100fa
change "visitor" trust level to "new user"
...
I blame me for this mistake.. visitor means other stuff in practice. New
User is correct meaning.
2013-04-17 16:11:24 -07:00
Sam
437142424c
speed up tests, fix notification of mentioned users in pms
2013-04-17 17:39:18 +10:00
Neil Lalonde
3b6aeb14c7
Add subtype to topics to classify private messages
2013-04-16 16:56:18 -04:00
Régis Hanol
b24c1a1ad9
better consistency around email case sensitivity
2013-04-15 02:20:33 +02:00
Sam
2bdb53261b
don't treat notify user as a flag
2013-04-15 13:09:52 +10:00
Sam
5b4fa68e8c
Merge pull request #705 from wpp/refactor_users_controller
...
Refactor user controller, create action, mostly.
2013-04-14 18:40:19 -07:00
Philipp Weissensteiner
3dcb1905e3
Refactor user controller, create action, mostly.
...
The gist of the commit are a few improvements in the
create action, where:
* long boolean statemenst have been wrapped in smaller more readable
methods.
* the 3rd party user info creation has been extracted (still in controller)
* a small helper method for creating a new user from params (to reduce
visual clutter)
* specs have been added where I came across untested methods/branches
Other changes are more trivial like formatting and whitespace fixes.
Hope this helps. Regards.
2013-04-13 00:53:59 +02:00
Neil Lalonde
48d5cb02c2
Add email as a sharing option
2013-04-12 18:06:36 -04:00
Neil Lalonde
651cfba93f
Add ability to destroy a user with 0 posts
2013-04-12 16:53:00 -04:00
Sam
86b317ea73
oops
2013-04-12 18:14:36 +10:00
Sam
e969eb14e8
added 2 new flag types: notify user and notify moderators
...
fixed up messed up user navigation
refactored
2013-04-12 17:55:45 +10:00
Neil Lalonde
36dc5874e5
Post image_count doesn't count favicons and thumbnails in oneboxes, so visitors can post links that get oneboxed
2013-04-11 12:36:45 -04:00
Sam
5f30ea7463
Merge pull request #684 from ZogStriP/auto-replace-rules-in-titles
...
auto replace rules in titles
2013-04-10 21:12:20 -07:00
Neil Lalonde
c0f3c47196
Use message bus to broadcast addition and removal of categories
2013-04-10 15:53:36 -04:00
Régis Hanol
d120a5d139
FIX: setting min_topic_title_length is ignored
2013-04-10 14:54:10 +02:00
Régis Hanol
c5cf8be864
auto replace rules in titles
2013-04-10 11:00:50 +02:00
Sam
33e3ad1603
clean up onebox application so it uses a single code path
...
use fragments for oneboxes
strip parent <p> if <div> is in it
clean some tests
2013-04-10 17:52:38 +10:00
Sam
9b487953c4
collapse some db tests
...
ensure deleted topics do not show up in user stream
2013-04-10 12:50:00 +10:00
Robin Ward
1ce7a40084
Revert "Merge pull request #677 from kubabrecka/localization_user_actions2"
...
This reverts commit c3a426930b
, reversing
changes made to 9f9072bd9d
.
2013-04-09 12:33:32 -04:00
Kuba Brecka
8d927418e8
move i18n of UserActions to JS-side and make sentences translatable
2013-04-08 22:54:08 +02:00
Neil Lalonde
467d59ec5a
Merge some work: topic counts in category select; fix All count on dashboard
2013-04-08 10:23:29 -04:00
Sam
73c508115a
better consistency check
2013-04-08 13:02:20 +10:00
Sam
11ff0ccd03
correct logic for tracking the highest seen post number so its always consistent
2013-04-08 11:12:52 +10:00
Régis Hanol
1692350336
added some tests for uploads
2013-04-07 17:52:46 +02:00
Robin Ward
a14f62766e
Replace MultisiteI18n hack with SiteContent and admin editing.
2013-04-05 16:48:15 -04:00
Robin Ward
c6bd6371f2
Exclude recently made invisible topics from the categories list. Also remove a couple n+1 queries.
2013-04-05 16:09:27 -04:00
Robin Ward
fe8d2377e8
admins/moderators should not receive "body is too similar" when editing
...
a regular user's post.
2013-04-05 15:38:03 -04:00
Robin Ward
72b4f41254
Can change TOS content via site content editor
2013-04-05 15:21:55 -04:00
Neil Lalonde
eb212aec9b
Fix dashboard totals for topics, posts, and private messages
2013-04-05 14:09:16 -04:00
Robin Ward
af9b27358c
If an admin or moderator edits a visitor's post, the restrictions should be based
...
on the *editors* access rights, not the original poster.
2013-04-05 13:59:00 -04:00
Wojciech Kocjan
0481fbae8c
Fix for reply to user avatar and picture uploading not working when editing post with discourse running in a prefix
2013-04-05 12:46:14 +02:00
Sam
5273657537
a method called "adding_user_record" is annoying me. 5 lines of code replaced with 2
2013-04-05 17:53:39 +11:00
Sam
ea8d69fbd6
fix my broken test
2013-04-05 17:47:54 +11:00
Sam
a2cca2540e
some minimal site settings diags
...
fix issue where days_visited was totally out of sync
2013-04-05 17:47:54 +11:00
Sam
a7f92ec0c1
topic reply count resync for each new post
2013-04-05 17:47:54 +11:00
Sam
4fbf017272
get regular trust level going, self heal inconsistent topic timings
2013-04-05 15:30:28 +11:00
Robin Ward
fa1ba6791b
Work in Progress: Content Editing in Admin Section
2013-04-04 17:26:22 -04:00
Sam
e61a28f3e1
utc vs non utc is a subtle issue, tests were failing for a few hours every day cause of this
2013-04-04 13:29:54 +11:00
Sam
86cf7b1524
trust level 0 is highlighted in light gray as opposed to having special semantics around account age.
2013-04-04 12:24:23 +11:00
Robin Ward
33f349a1e6
Show all Hot rankings at once with a toggle button
2013-04-03 15:25:18 -04:00
Neil Lalonde
bb18b6cb9b
Dashboard: split out private messages from topic and post counts; re-enable report_spec because I think I fixed it...
2013-04-03 13:26:09 -04:00
Robin Ward
459c7e3d59
Include pinned on Categories page
2013-04-03 11:45:53 -04:00
Robin Ward
ac0bc1bb30
Including your avatar if you've posted is confusing. Let's remove it for now.
2013-04-03 11:29:50 -04:00
Robin Ward
ee76f1926d
Debugging Tool for Hot Topics
2013-04-02 18:00:53 -04:00
Neil Lalonde
202addb693
User Visits count for 30 days ago was always 0
2013-04-02 15:03:23 -04:00
Robin Ward
e8d66beea5
Fix @notification text for non visitors
2013-04-02 11:58:12 -04:00
Robin Ward
422dbbd25a
Exclude older topics from the first x rows in "Hot"
2013-04-02 11:15:04 -04:00
Jeff Atwood
533936f3a2
increase max_mentions to 10
2013-04-01 14:31:07 -07:00
Robin Ward
1e6f8dc93a
Include uncategorized pinned topics on 'Hot'
2013-04-01 13:49:35 -04:00
Robin Ward
79c986dd92
Fix issue with duplicate slugs
2013-04-01 12:26:51 -04:00
Neil Lalonde
68710be564
Merge pull request #610 from PragTob/ReportsRemoveDuplication
...
Battling code duplication in the Report class
2013-04-01 07:39:44 -07:00
Robin Ward
f9ea1a448d
Merge pull request #600 from kubabrecka/consistent_topic_count
...
make sure Category.topic_count is consistent with week/year stats
2013-04-01 07:37:07 -07:00
Robin Ward
8f518a2496
Merge pull request #604 from wpp/refactor_suggest_username
...
Improve suggest_username method in user class
2013-04-01 07:25:27 -07:00
Tobias Pfeiffer
3324f0f2d2
Battling code duplication in the Report class
...
* the reports mainly followed the same structure but with
different classes, so I took the code and a class as its
parameter
* the method on which reports.data is generated may change
but mostly is count_per_day so made that optional
* grouped the refactored methods to the top, some unrefactored
methods remain but those are a bit harder to refactor, and not
as reusable so I'd like to get this through first
* Overall I believe this patch enhances maintainability :-)
2013-04-01 15:26:58 +02:00
Sam
dce2847b4f
Merge pull request #597 from ZogStriP/fix-s3-image-upload
...
FIX: S3 image upload
2013-04-01 03:12:58 -07:00
Philipp Weissensteiner
c34f476b31
Improve suggest_username method in user.rb
...
The suggest_username method showed up on codeclimate
so I thought I'd give it some love and make it more readable.
In the process removed trailing whitespaces and had to fix a
terrible spelling error :)
2013-03-31 19:01:11 +02:00
Kuba Brecka
d50b5e1fd8
make sure Category.topic_count is consistent with week/year stats
2013-03-31 13:22:05 +02:00
Neil Lalonde
92aa0f45d2
Show trends on some dashboard numbers
2013-03-30 14:07:35 -04:00
Régis Hanol
0aff5042e5
FIX: S3 image upload
2013-03-30 17:56:25 +01:00
Neil Lalonde
25073e873f
Fetch the list of problems more frequently on the admin dashboard
2013-03-29 15:48:26 -04:00
Robin Ward
df85201298
Adjust hot to include more recent topics
2013-03-29 13:33:31 -04:00
Neil Lalonde
436515ec6c
Dashboard checks for facebook, twitter, and github configs
2013-03-29 13:32:40 -04:00
Gosha Arinich
bdfa9b0508
create the User.admins and User.moderators scopes
2013-03-29 09:52:09 +03:00
Robin Ward
a819a26f34
BUGFIX: New status posts weren't using PostCreator
2013-03-28 16:40:54 -04:00
Robin Ward
473a64d39d
Add score, percent_rank to topics. Adds HotTopic
model and consolidated job to calculate
...
hotness. Note: People on Heroku will have to update their jobs to the new structure
in Heroku.md
2013-03-28 15:39:54 -04:00
Régis Hanol
1668b5eab2
FIX: allows the selection of the default landing tab
2013-03-28 14:01:13 +01:00
Robin Ward
36269cfbaa
Rename 'popular' to 'latest'. First stab at 'Hot' tab.
2013-03-27 16:21:23 -04:00
Neil Lalonde
5961ffc0e4
Add site setting to choose which share links to show and in what order
2013-03-26 17:17:37 -04:00
Sam
c57ec611e1
basic api support
2013-03-25 18:04:46 -07:00
Robin Ward
c372e36cb6
Don't count @mentions as links in a post
2013-03-25 13:12:15 -04:00
Robin Ward
6568b4aaa9
Better error messages when hitting max mentions/images/links
2013-03-25 12:27:09 -04:00
Sam
deb603f41c
Merge pull request #547 from kid0m4n/convert-ruby-1-9-syntax
...
Convert a lot of :a => b to a: b and bring peace to the world
2013-03-24 16:43:17 -07:00
Karan Misra
5dfb04e4b3
Convert a lot of :a => b to a: b and bring peace to the world
2013-03-25 05:07:36 +05:30
Sam
36a069488e
Merge pull request #492 from sbauch/email-whitelist
...
added email whitelist SiteSetting feature to replicate email blacklist S...
2013-03-24 16:35:24 -07:00
Jeff Atwood
f14cf4c97e
reduce read time required for basic user to 15m
2013-03-23 23:52:34 -07:00
Robin Ward
842760e50e
Bump up best of to top 20%
2013-03-23 11:14:07 -04:00
Karan Misra
3f27ffca9f
topic_poster.rb: Fix formatting of the attributes return value
2013-03-23 19:09:01 +05:30
Kuba Brecka
4424328bff
remove unnecessary .gitkeep files
2013-03-23 10:45:40 +01:00
Jeff Atwood
f0b57d5e4a
reduce basic user time required from 25m to 20m
2013-03-22 15:33:40 -07:00
Neil Lalonde
158cda7628
Add moderator and admin count to dashboard
2013-03-22 17:50:34 -04:00
Neil Lalonde
aa6e87c5c1
Dashboard memory warning
2013-03-22 15:47:35 -04:00
Robin Ward
9c38c13ac5
The "Best Of" mode uses a percentage ranking of posts.
2013-03-22 15:44:39 -04:00
Sam Bauch
77e3434d81
added email whitelist SiteSetting feature to replicate email blacklist. email_validator method now also uses the regex method for both the whitelist and blacklist.
2013-03-22 14:49:42 -04:00
Neil Lalonde
6f8d13d47e
Dashboard warning when sidekiq is not running
2013-03-22 11:35:51 -04:00
Dan Berman
9ad5720090
someone's been playing too much
2013-03-22 06:18:48 -04:00
Neil Lalonde
8cc7f3c20b
Dashboard warning when clockwork doesn't seem to be running
2013-03-21 16:51:50 -04:00
Neil Lalonde
40962c84ca
Add 'all' column to admin dashboard counts
2013-03-21 16:51:50 -04:00
Neil Lalonde
38415f28da
Remove old caching code from report model
2013-03-21 16:51:49 -04:00
Robin Ward
babcfe6234
Cache oneboxes in Redis now instead of postgres.
2013-03-21 13:11:54 -04:00
Jeff Atwood
002fab358b
slightly reduce read time req for trust level 1
2013-03-20 16:49:32 -07:00
Neil Lalonde
d28d81a590
Dashboard warning when GC params are default
2013-03-20 16:16:23 -04:00
Neil Lalonde
c8508d3f26
Dashboard warning when host_names is localhost
2013-03-20 15:38:28 -04:00
Neil Lalonde
c3c25b894a
Cache dashboard data in the controller, not the report model
2013-03-20 13:54:32 -04:00
Neil Lalonde
1e4dd3ea0c
Start detecting install problems and report them on the admin dashboard. This commit adds check for Rails.env
2013-03-20 12:00:52 -04:00
Sam
62c60540be
pull moderator into own column, rename trust levels
2013-03-19 21:06:11 -07:00
Sam
2a047df4f1
cache reply_to_user_id in post to eliminate a very nasty n+1 query
2013-03-19 16:54:23 -07:00
Robin Ward
96ac0c5569
A site setting for how many similar topics are returned
2013-03-19 13:51:25 -04:00
Sam
9805f7d2f5
max upload size message when images are too big.
2013-03-19 00:19:05 -07:00
Sam
1cd26a7dcf
oops
2013-03-18 23:44:21 -07:00
Sam
dd03f44968
optimise
2013-03-18 23:18:15 -07:00
Robin Ward
59fc3bfac4
PostDestroyer to replace callbacks for destroying
2013-03-18 17:55:11 -04:00
Robin Ward
c1e40f5d19
Convert Post type constants to Enum
2013-03-18 17:55:05 -04:00
Robin Ward
897d48b145
Moved more Post
callbacks into service classes
2013-03-18 17:54:55 -04:00
Robin Ward
d5e4243f02
Move draft sequence incrementing out of after_save
2013-03-18 17:54:50 -04:00
Robin Ward
5aec5261a7
Converted flag threshold constants to enums
2013-03-18 17:54:43 -04:00
Robin Ward
aea848f164
Move MessageBus observer into PostCreator
2013-03-18 17:54:39 -04:00
Robin Ward
b6224b014c
Move a bunch of callbacks into PostCreator
2013-03-18 13:56:26 -04:00
Neil Lalonde
50b04b2209
Add email counts to admin dashboard
2013-03-18 10:08:09 -04:00
Neil Lalonde
6a99d12784
Add likes to admin dashboard
2013-03-18 10:08:08 -04:00
Robin Ward
42c234e927
Merge pull request #483 from ZogStriP/site-setting-for-category-color
...
site setting for category colors
2013-03-17 04:48:01 -07:00
Robin Ward
4e057335d5
Merge pull request #464 from ZogStriP/fix-issues-when-a-failure-happen-while-creating-a-new-category
...
displays a message when a failure happen while creating a new category
2013-03-17 04:47:44 -07:00
Régis Hanol
bc9e931304
site setting for category colors
2013-03-17 01:24:52 +01:00
Neil Lalonde
d9cdde9aa7
Add user counts for each trust level to admin dashboard
2013-03-15 18:09:02 -04:00
Neil Lalonde
8983df9856
Show current user count for now, not at different points in time
2013-03-15 18:09:01 -04:00
Robin Ward
ad082cea70
Big commit:
...
- Support for a popup that shows similar topics
- Cleaned up a lot of Javascript
- Cleaned up use of Promises
2013-03-15 14:35:33 -04:00
Régis Hanol
3bf6625aa4
displays a message when a failure happen while creating a new category
2013-03-14 22:25:55 +01:00
Robin Ward
ea20993bed
FIX: Don't create a new version when a post is recovered. Also display username instead of full name for consistency.
2013-03-13 12:35:55 -04:00
Sam
38f185355d
added options to disable quoting and open links in new tabs
...
fixed a some regressions
removed some dead code
fixed messages about constants being re-defined
2013-03-12 20:06:58 -07:00
Neil Lalonde
40c27ff3cf
Add flag counts to admin dashboard
2013-03-12 14:40:59 -04:00
Neil Lalonde
4eda422cdf
Add total users report; restructure dashboard reports js
2013-03-12 14:40:59 -04:00
Robin Ward
1103dde5cd
Fix: When you split topics, featured users and like counts were incorrect.
2013-03-12 12:33:42 -04:00
Jeff Atwood
3414e2bb92
increase default minimum topic title length to 15
2013-03-10 22:45:55 -07:00
Sam
e62bb9922e
exceptions are BAD
...
the old code wacked on 10ms to every home page request, for no real reason.
2013-03-10 19:11:33 -07:00
Sam
22a4580df5
added profile environment for perftools profiling (1.9.3 only)
2013-03-10 17:21:56 -07:00
Sam
22f8100919
requiring is mega expensive, lets not do it every request.
2013-03-10 07:14:52 -07:00
Neil Lalonde
8927432a93
Add stats to the admin dashboard
2013-03-09 15:34:27 -05:00
Sam
325e28c3c8
wrong conditional
2013-03-08 17:24:54 -08:00
Robin Ward
8c02d2f48d
Robin sucks at merging! This fixes a n+1 query.
2013-03-08 16:48:56 -05:00
Robin Ward
4c7b0a42b5
Oops escape everything but image urls
2013-03-08 16:17:56 -05:00
Robin Ward
908bba8c13
First stab at oneboxing of meta.discourse.org
2013-03-08 15:59:12 -05:00
Robin Ward
d1d4530efd
User Profile enhancements:
...
- Added PreloadStore support to avoid duplicate requests
- preliminary SEO
- Support for opengraph/twitter cards
2013-03-08 15:04:37 -05:00
Robin Ward
b8fd734d0e
Merge branch 'refactor-category' of git://github.com/goshakkk/discourse
...
Conflicts:
app/models/category.rb
2013-03-08 10:49:25 -05:00
Robin Ward
fb573b917f
Merge pull request #390 from ZogStriP/min-search-term-length-site-setting
...
added the min-search-term-length site setting
2013-03-08 06:58:45 -08:00
Sam
d6ca23a75b
remove N+1 queries
2013-03-08 05:34:19 -08:00
Robin Ward
052887c296
Category Topics are no longer invisible, they are pinned.
2013-03-07 12:46:23 -05:00
Robin Ward
f8d8272406
Cleaned up TopicUserSpec, introduces clearing of pinned topics
2013-03-07 12:19:25 -05:00
Regis Hanol
5703d6c730
added the min-search-term-length site setting
2013-03-07 16:52:01 +01:00
Robin Ward
6a63178411
Merge pull request #377 from kubabrecka/typos5
...
various typos in comments
2013-03-06 09:14:16 -08:00
Robin Ward
30aae8e793
Topic was not sanitizing <b> and <img> tags from titles
2013-03-06 11:36:42 -05:00
Sam Saffron
8f56a09e82
PBKDF2 gem is trouble, removing and hand coding for now
2013-03-06 23:12:16 +11:00
Kuba Brecka
dc62136642
various typos in comments
2013-03-06 08:52:24 +01:00
Neil Lalonde
f8e04a5c48
Version check gets how many versions behind you are, and shows judgemental faces on the dashboard
2013-03-05 18:15:33 -05:00
Robin Ward
3c1388bbd7
Don't include closed or archived topics in the "new topics" section of the daily digest
2013-03-05 17:22:02 -05:00
Gosha Arinich
a1825fece9
refactor Category
...
* move callback bodies to separate methods (easier to test)
2013-03-05 21:09:13 +03:00
Régis Hanol
239cbd2d58
enforce coding convention
...
replaced every `and` by `&&` and every `or` by `||`
2013-03-05 01:42:44 +01:00
Robin Ward
ccbd3b2841
Let's default Persona to off right now, change button text
2013-03-04 12:01:20 -05:00
Robin Ward
f7c9efb101
Merge branch 'persona-integration' of git://github.com/callahad/discourse
2013-03-04 11:51:26 -05:00
Gosha Arinich
5066682e7a
move IncomingLink callbacks into their own methods
2013-03-02 12:33:29 +03:00
Robin Ward
d410f043a9
Merge pull request #290 from alxndr/category-rss
...
RSS for topics in a category
2013-03-01 12:01:26 -08:00
Dan Callahan
7c87359e02
Make Persona configurable
2013-03-01 14:00:56 -06:00
Robin Ward
7c68224763
Merge pull request #309 from goshakkk/enums
...
Introduce Enum
2013-03-01 11:34:48 -08:00
Robin Ward
d2596c3c4c
Remove unusued site_settings, show checkbox in UI for boolean values, remove restrict_access
...
boolean to avoid locking yourself out by setting access_password to empty string. Minor
UI tweaks.
2013-03-01 14:27:41 -05:00