Nick Winter
09c8a99a9b
Merge branch 'patch-5' of git://github.com/gosnat/codecombat into gosnat-patch-5
2014-05-06 07:23:51 -07:00
Nick Winter
acccee33a3
Cleaner conditional init syntax.
2014-05-06 07:22:09 -07:00
gosnat
939509849c
Update GoalManager.coffee
...
Justification:
For a negative goal like saveThangs, let's say you have 5 thangs on the save list. As things stand, if you don't have a HowMany defined, then the number of needed deaths to fail is
numNeeded = _.size(stateThangs) - Math.min((goal.howMany ? 1), _.size stateThangs) + 1
numNeeded = 5 - Math.min(1, 5) + 1
numNeeded = 5
So you would only fail the goal if all 5 thangs you were supposed to save died. This is contrary to the comment right above this line:
# saveThangs: by default we would want to save all the Thangs, which means that we would want none of them to be "done"
Therefore, I think it should be Math.max rather than Math.min.
numNeeded = _.size(stateThangs) - Math.max((goal.howMany ? 1), _.size stateThangs) + 1
numNeeded = 5 - Math.max(1, 5) + 1
numNeeded = 1
So any of the Thangs on the save list dying is enough to fail the goal.
As a double check, what if the level designer designated a HowMany of 5?
numNeeded = _.size(stateThangs) - Math.max((goal.howMany ? 1), _.size stateThangs) + 1
numNeeded = 5 - Math.max(5, 5) + 1
numNeeded = 1
So this is consistent.
2014-05-05 14:08:41 -05:00
gosnat
93d117100a
Update GoalManager.coffee
...
For compound goals like GetAllToLocation, you should continue adding to the existing list of thang states.
2014-05-05 13:22:57 -05:00
gosnat
39b21da035
Update GoalManager.coffee
...
I'd like to temporarily turn on console logging (lines 240 and 245) to take a peek at why numNeeded doesn't seem to be correct if howMany isn't defined.
2014-05-03 21:36:24 -05:00
Nick Winter
5376a42f94
Fixed serialization of tracked property arrays.
2014-05-01 13:23:14 -07:00
Nick Winter
f7bdb7e840
Upgrades for teleportation imnterpolation performance, ACE search box styling.
2014-05-01 10:44:17 -07:00
Nick Winter
d4cf31c8fe
Improved admin view of pending candidates.
2014-04-23 10:21:58 -07:00
Nick Winter
10bb17c38a
Added getThangByID method to Thang. Handled a few error corner cases with the time popup.
2014-04-11 14:03:13 -07:00
Nick Winter
3325c55c3f
Fixed #759 .
2014-04-08 14:58:34 -07:00
Nick Winter
255cef83fb
Fixed #738 .
2014-04-03 16:16:53 -07:00
Nick Winter
bfa71d01ff
Merged.
2014-04-01 10:31:22 -07:00
swapnesh
497563bc0a
Added more names for #53
2014-04-01 17:50:33 +05:30
Nick Winter
cb27124285
Fixed #135 .
2014-03-30 17:24:07 -07:00
Nick Winter
b0a4a97ff1
Merged
2014-03-30 12:54:48 -07:00
Bia
53c20d3b9d
Added Thang names
2014-03-30 20:43:48 +01:00
Nick Winter
e08265a725
Merge pull request #730 from Darredevil/master
...
Added setGoalState
2014-03-29 14:04:33 -07:00
Darredevil
c4de6ef996
Added setGoalState
2014-03-29 03:54:16 +02:00
Darredevil
0a969bb103
Added setGoalState
2014-03-29 03:53:19 +02:00
Darredevil
e060d4b73d
Added setGoalState
2014-03-29 03:52:02 +02:00
therealbond
7d03c2e520
Merge branch 'master' of https://github.com/therealbond/codecombat
2014-03-22 02:05:19 -04:00
therealbond
b2c500369b
Added more names for #53
2014-03-22 01:56:32 -04:00
Scott Erickson
37a9b7f319
Switching from the slow _.cloneDeep to the fast $.extend
2014-03-18 13:08:26 -07:00
Nick Winter
795bd8f63b
Moved Glen from Archmages to About.
2014-03-13 18:27:08 -07:00
Nick Winter
8b572f0647
Using isThang instead of instanceof Thang.
2014-03-13 17:59:17 -07:00
Nick Winter
4f9db0a7f7
Merged in all names.
2014-03-11 18:11:48 -07:00
Darredevil
012c25a817
Added GetALLToLocations and KeepALLFromLocations
2014-03-12 01:57:30 +02:00
Alexandru
5f2587da18
Merge remote-tracking branch 'upstream/master'
2014-03-12 01:38:54 +02:00
Alexandru
4552455284
Merge branch 'master' of https://github.com/Darredevil/codecombat
2014-03-12 01:23:55 +02:00
Sam Epps
11ca60765d
Added some additional names to names.coffee
2014-03-11 17:16:09 +01:00
Darredevil
c9a56048ca
Update GoalManager.coffee
2014-03-09 20:35:33 +02:00
Nick Winter
b6335a30ae
More fixes for empty string array serialization.
2014-03-06 16:32:13 -08:00
Nick Winter
40a32d7b43
Fixed array / string ThangState key serialization conflicts. Fixed #333 .
2014-03-06 14:53:37 -08:00
Nick Winter
a03403de94
Started some more name categories.
2014-03-06 09:35:58 -08:00
Nick Winter
fddd210d34
Fixed Archer M names conflict.
2014-03-06 09:27:06 -08:00
iraladson
8d046c31b9
Update names.coffee
...
"Added more names for #53
2014-03-05 14:06:29 -06:00
iraladson
7885b21b4b
Update names.coffee
2014-03-05 14:03:57 -06:00
Yos Riady
195b1941ea
Added even more names for #53
2014-03-05 02:53:54 +08:00
Finn
5b5af5a55a
Update names.coffee
...
Added the name "Cid" under "Soldier M".
2014-02-28 12:06:26 +01:00
Darredevil
55ab142d75
Added more names for #53
2014-02-26 23:21:03 +02:00
Aidan Matzko
b69fe85134
Silly error names
2014-02-23 15:30:33 -05:00
Nick Winter
81d3702b49
Merge pull request #388 from jcvno/patch-1
...
Update names.coffee
2014-02-20 14:38:43 -08:00
Scott Erickson
6b2e0bc364
Changed how the goal manager handles arriving at goals and figuring out the how many requirement.
2014-02-20 11:43:35 -08:00
Justin Cano
059c50e47d
Update names.coffee
2014-02-19 03:03:43 -08:00
Nick Winter
af510c7cc7
60 FPS and support for independent world/surface frame rates.
2014-02-17 11:53:52 -08:00
Nick Winter
e3824d7698
Many improvements to the spell palette.
2014-02-16 15:30:00 -08:00
Scott Erickson
b8051689b3
Fixed the goal manager from polluting the goals in the level with the isPositive property.
2014-02-13 15:50:53 -08:00
Scott Erickson
23964abee9
Set up the goal manager to only use goals from the level.goals property, rather than from scripts.
2014-02-13 09:26:42 -08:00
Nick Winter
8a80b9770d
More work on docs. Got rid of Docs.coffee.
2014-02-12 18:54:45 -08:00
Nick Winter
d2345432ff
Merge branch 'master' of https://github.com/codecombat/codecombat
2014-02-12 16:42:31 -08:00
