7cc5c4f330d47060/geode
1
0
Fork 0
mirror of https://github.com/geode-sdk/geode.git synced 2025-03-22 02:45:49 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions1

Merge pull request from dankmeme01/main

Browse source 
better error messages on dll load fail
This commit is contained in:
mat 2024-01-23 15:14:16 -03:00 committed by GitHub
commit e4f957856f
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 21 additions and 5 deletions

26
loader/src/platform/windows/ModImpl.cpp
View file

@ -49,12 +49,28 @@ std::string getLastWinError() {
if (!err) return "None (0)";
auto useful = getUsefulError(err);
if (useful) return useful;
auto len = FormatMessageA(
char* errorBuf = nullptr;
auto result = FormatMessageA(
FORMAT_MESSAGE_FROM_SYSTEM | FORMAT_MESSAGE_ALLOCATE_BUFFER | FORMAT_MESSAGE_IGNORE_INSERTS,
nullptr, err, MAKELANGID(LANG_NEUTRAL, SUBLANG_DEFAULT), nullptr, 0, nullptr
);
std::string msg = len == 0 ? "Unknown" : "Very Unknown";
return msg + " (" + std::to_string(err) + ")";
nullptr, err, MAKELANGID(LANG_NEUTRAL, SUBLANG_DEFAULT), (LPSTR)&errorBuf, 0, nullptr);
std::string msg;
if (result == 0 || !errorBuf) {
msg = fmt::format("Unknown ({})", err);
} else {
msg = std::string(errorBuf, errorBuf + result);
// the string sometimes includes a crlf, strip it
msg.erase(std::find_if(msg.rbegin(), msg.rend(), [](unsigned char ch) {
return ch != '\r' && ch != '\n';
}).base(), msg.end());
}
if (errorBuf) {
LocalFree(errorBuf);
}
return msg;
}
Result<> Mod::Impl::loadPlatformBinary() {