remove advanced settings as early load is handled through mod.json now

loader/src/ui/internal/info/ModInfoPopup.cpp

@@ -3,7 +3,6 @@
 #include "../dev/HookListLayer.hpp"
 #include "../list/ModListLayer.hpp"
 #include "../settings/ModSettingsPopup.hpp"
-#include "../settings/AdvancedSettingsPopup.hpp"
 #include <InternalLoader.hpp>
 #include <Geode/loader/Dirs.hpp>
 
@@ -355,19 +354,6 @@ bool LocalModInfoPopup::init(Mod* mod, ModListLayer* list) {
     }
 
     if (mod != Loader::get()->getInternalMod()) {
-        // advanced settings
-        auto advSettSpr = CCSprite::createWithSpriteFrameName("GJ_optionsBtn02_001.png");
-        advSettSpr->setScale(.65f);
-
-        auto advSettBtn = CCMenuItemSpriteExtra::create(
-            advSettSpr, this, menu_selector(LocalModInfoPopup::onAdvancedSettings)
-        );
-        advSettBtn->setPosition(
-            m_infoBtn->getPositionX() - 30.f,
-            m_infoBtn->getPositionY()
-        );
-        m_buttonMenu->addChild(advSettBtn);
-
         auto uninstallBtnSpr = ButtonSprite::create(
             "Uninstall", "bigFont.fnt", "GJ_button_05.png", .6f
         );
@@ -516,10 +502,6 @@ void LocalModInfoPopup::onNoSettings(CCObject*) {
         ->show();
 }
 
-void LocalModInfoPopup::onAdvancedSettings(CCObject*) {
-    AdvancedSettingsPopup::create(m_mod)->show();
-}
-
 void LocalModInfoPopup::FLAlert_Clicked(FLAlertLayer* layer, bool btn2) {
     switch (layer->getTag()) {
         case TAG_CONFIRM_UNINSTALL: {
@@ -581,9 +563,9 @@ LocalModInfoPopup* LocalModInfoPopup::create(Mod* mod, ModListLayer* list) {
 
 IndexItemInfoPopup::IndexItemInfoPopup()
   : m_installListener(
-    this, &IndexItemInfoPopup::onInstallProgress,
-    ModInstallFilter("")
-  ) {}
+        this, &IndexItemInfoPopup::onInstallProgress,
+        ModInstallFilter("")
+    ) {}
 
 bool IndexItemInfoPopup::init(IndexItemHandle item, ModListLayer* list) {
     m_item = item;

loader/src/ui/internal/info/ModInfoPopup.hpp

@@ -67,7 +67,6 @@ protected:
     void onEnableMod(CCObject*);
     void onUninstall(CCObject*);
     void onOpenConfigDir(CCObject*);
-    void onAdvancedSettings(CCObject*);
     void doUninstall();
 
     void FLAlert_Clicked(FLAlertLayer*, bool) override;

loader/src/ui/internal/settings/AdvancedSettingsPopup.cpp

@@ -1,22 +0,0 @@
-#include "AdvancedSettingsPopup.hpp"
-#include <Geode/loader/Loader.hpp>
-#include <Geode/binding/CCMenuItemToggler.hpp>
-#include <Geode/binding/GameToolbox.hpp>
-
-bool AdvancedSettingsPopup::setup(Mod* mod) {
-    m_mod = mod;
-
-    this->setTitle("Advanced Settings for " + mod->getName());
-
-    return true;
-}
-
-AdvancedSettingsPopup* AdvancedSettingsPopup::create(Mod* mod) {
-    auto ret = new AdvancedSettingsPopup;
-    if (ret && ret->init(356.f, 220.f, mod)) {
-        ret->autorelease();
-        return ret;
-    }
-    CC_SAFE_DELETE(ret);
-    return nullptr;
-}

loader/src/ui/internal/settings/AdvancedSettingsPopup.hpp

@@ -1,16 +0,0 @@
-#pragma once
-
-#include <Geode/ui/Popup.hpp>
-#include <Geode/loader/Mod.hpp>
-
-USE_GEODE_NAMESPACE();
-
-class AdvancedSettingsPopup : public Popup<Mod*> {
-protected:
-    Mod* m_mod;
-
-    bool setup(Mod* mod) override;
-
-public:
-    static AdvancedSettingsPopup* create(Mod* mod);
-};